{"id":10153,"url":"https://patchwork.libcamera.org/api/patches/10153/?format=json","web_url":"https://patchwork.libcamera.org/patch/10153/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20201021013955.301790-3-hiroh@chromium.org>","date":"2020-10-21T01:39:54","name":"[libcamera-devel,v3,3/4] android: post_processor_jpeg: Make |cameraDevice_| constant","commit_ref":"79bca4300b6582fe018967e8483eb584583d2a96","pull_url":null,"state":"accepted","archived":false,"hash":"b4f01d99077c0f42849e7fe1a414180db5aca97f","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/people/63/?format=json","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/10153/mbox/","series":[{"id":1395,"url":"https://patchwork.libcamera.org/api/series/1395/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1395","date":"2020-10-21T01:39:52","name":"[libcamera-devel,v3,1/4] android: Modify PostProcessor interface","version":3,"mbox":"https://patchwork.libcamera.org/series/1395/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/10153/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/10153/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 48854BDB13\n\tfor ;\n\tWed, 21 Oct 2020 01:40:10 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1618361DAB;\n\tWed, 21 Oct 2020 03:40:10 +0200 (CEST)","from mail-pf1-x42b.google.com (mail-pf1-x42b.google.com\n\t[IPv6:2607:f8b0:4864:20::42b])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 406A761D98\n\tfor ;\n\tWed, 21 Oct 2020 03:40:08 +0200 (CEST)","by mail-pf1-x42b.google.com with SMTP id c20so502182pfr.8\n\tfor ;\n\tTue, 20 Oct 2020 18:40:08 -0700 (PDT)","from hiroh.tok.corp.google.com\n\t([2401:fa00:8f:2:de4a:3eff:fe7d:f78f])\n\tby smtp.gmail.com with ESMTPSA id\n\tw2sm368066pgi.56.2020.10.20.18.40.04\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 20 Oct 2020 18:40:06 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"eD962NbE\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=B3yYJQA+QTIkRSTx3E4WlxnV44ortnpTrmlhQYrPOwM=;\n\tb=eD962NbETmX5QZT0TjOTjbVUm6XoCndAwD6RRc9cXypYYUu2CXRvqynrdLIjbw+0Pg\n\tgEkT88JsfZ1sI+fbdseDF/ie/KZ7Y2HtJ7ebfq1NnPyUyG5KV96lwngoKUeCrvXFUf5m\n\tRVO5ZbUtG5NCSwa1lZdixRR53sUZdJslCodSE=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=B3yYJQA+QTIkRSTx3E4WlxnV44ortnpTrmlhQYrPOwM=;\n\tb=ggnwqxkOMI+PSMH3v0HzI9vhsBWBIxlQPNo6lAOI4/IkaYrJ9dNsOApZmB6p9GuVjg\n\tswgOV5FWNSYuoVhGAoKgUULaMOp5+1FqRREhhf1+idER694JrAXE2Mdds7Zx/zVs1xBS\n\tJgkkWkm55X531YKy9rxRe5nju+OKp013QEcaoIY4EXbda1nJF/zfqbvxPjYjmhCJbaqL\n\tmyPfVWY8jyaQGPPpeN/8halcyXbOZfcCw1BQ/H0QfrLPLEFKJPqW0z7AUHY7Pxvq34CS\n\t5V+gP+XA8BGwIBOgR4zjqInEMqEyZygx/2r/d85wfVqEuWYH4lZX2xT6aGOCvcLy300+\n\tXf6A==","X-Gm-Message-State":"AOAM532P4IZ98L2/8E2ftoydqfyvn8fl+S48njZH61666l40oRvJz6RV\n\t7qf0cWkiEem2dooWuE5kKrdfgZQ5cSqolw==","X-Google-Smtp-Source":"ABdhPJxnBU0B5iINwaWlVqSbcECYmLG3t+5XYeJxaGx+6i/xjt73l/IkBrefcGK5X8rAWR+nomKG3A==","X-Received":"by 2002:a65:63c5:: with SMTP id n5mr968439pgv.437.1603244406728; \n\tTue, 20 Oct 2020 18:40:06 -0700 (PDT)","From":"Hirokazu Honda ","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 21 Oct 2020 10:39:54 +0900","Message-Id":"<20201021013955.301790-3-hiroh@chromium.org>","X-Mailer":"git-send-email 2.29.0.rc1.297.gfa9743e501-goog","In-Reply-To":"<20201021013955.301790-1-hiroh@chromium.org>","References":"<20201021013955.301790-1-hiroh@chromium.org>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v3 3/4] android: post_processor_jpeg: Make\n\t|cameraDevice_| constant","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"PostProcessorJpeg doesn't have the ownership of CameraDevice given\nin the constructor. To clarify it, this makes the member variable\nconstant.\n\nSigned-off-by: Hirokazu Honda \nReviewed-by: Umang Jain \nReviewed-by: Kieran Bingham \nReviewed-by: Laurent Pinchart \n---\n src/android/jpeg/post_processor_jpeg.cpp | 2 +-\n src/android/jpeg/post_processor_jpeg.h | 4 ++--\n 2 files changed, 3 insertions(+), 3 deletions(-)","diff":"diff --git a/src/android/jpeg/post_processor_jpeg.cpp b/src/android/jpeg/post_processor_jpeg.cpp\nindex 8b01bd6..fd1c7be 100644\n--- a/src/android/jpeg/post_processor_jpeg.cpp\n+++ b/src/android/jpeg/post_processor_jpeg.cpp\n@@ -20,7 +20,7 @@ using namespace libcamera;\n \n LOG_DEFINE_CATEGORY(JPEG)\n \n-PostProcessorJpeg::PostProcessorJpeg(CameraDevice *device)\n+PostProcessorJpeg::PostProcessorJpeg(CameraDevice *const device)\n \t: cameraDevice_(device)\n {\n }\ndiff --git a/src/android/jpeg/post_processor_jpeg.h b/src/android/jpeg/post_processor_jpeg.h\nindex ae636ff..3706cec 100644\n--- a/src/android/jpeg/post_processor_jpeg.h\n+++ b/src/android/jpeg/post_processor_jpeg.h\n@@ -19,7 +19,7 @@ class CameraDevice;\n class PostProcessorJpeg : public PostProcessor\n {\n public:\n-\tPostProcessorJpeg(CameraDevice *device);\n+\tPostProcessorJpeg(CameraDevice *const device);\n \n \tint configure(const libcamera::StreamConfiguration &incfg,\n \t\t const libcamera::StreamConfiguration &outcfg) override;\n@@ -28,7 +28,7 @@ public:\n \t\t CameraMetadata *metadata) override;\n \n private:\n-\tCameraDevice *cameraDevice_;\n+\tCameraDevice *const cameraDevice_;\n \tstd::unique_ptr encoder_;\n \tlibcamera::Size streamSize_;\n };\n","prefixes":["libcamera-devel","v3","3/4"]}