[{"id":13322,"web_url":"https://patchwork.libcamera.org/comment/13322/","msgid":"<20201021103450.4pnxm7rwmlaujyol@uno.localdomain>","date":"2020-10-21T10:34:50","subject":"Re: [libcamera-devel] [PATCH 1/2] libcamera: pipeline: simple: Set\n\tcamera properties","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent,\n\nOn Wed, Oct 21, 2020 at 03:24:17AM +0300, Laurent Pinchart wrote:\n> Initialize the CameraData properties with the properties exposed by the\n> sensor.\n>\n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> src/libcamera/pipeline/simple/simple.cpp | 2 ++\n> 1 file changed, 2 insertions(+)\n>\n> diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\n> index 8868a43beeb4..4b6f708e8fee 100644\n> --- a/src/libcamera/pipeline/simple/simple.cpp\n> +++ b/src/libcamera/pipeline/simple/simple.cpp\n> @@ -324,6 +324,8 @@ int SimpleCameraData::init()\n> \t\treturn -EINVAL;\n> \t}\n>\n> +\tproperties_ = sensor_->properties();\n> +\n> \treturn 0;\n> }\n>\n> --\n> Regards,\n>\n> Laurent Pinchart\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A7637C3D3C\n\tfor ;\n\tWed, 21 Oct 2020 10:34:54 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 856DB61D98;\n\tWed, 21 Oct 2020 12:34:54 +0200 (CEST)","from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net\n\t[217.70.183.200])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1EE8360353\n\tfor ;\n\tWed, 21 Oct 2020 12:34:53 +0200 (CEST)","from uno.localdomain (93-34-118-233.ip49.fastwebnet.it\n\t[93.34.118.233]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay7-d.mail.gandi.net (Postfix) with ESMTPSA id 984AF20007;\n\tWed, 21 Oct 2020 10:34:52 +0000 (UTC)"],"X-Originating-IP":"93.34.118.233","Date":"Wed, 21 Oct 2020 12:34:50 +0200","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Message-ID":"<20201021103450.4pnxm7rwmlaujyol@uno.localdomain>","References":"<20201021002418.21764-1-laurent.pinchart@ideasonboard.com>\n\t<20201021002418.21764-2-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201021002418.21764-2-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 1/2] libcamera: pipeline: simple: Set\n\tcamera properties","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13332,"web_url":"https://patchwork.libcamera.org/comment/13332/","msgid":"<20201021113851.GE2092600@oden.dyn.berto.se>","date":"2020-10-21T11:38:51","subject":"Re: [libcamera-devel] [PATCH 1/2] libcamera: pipeline: simple: Set\n\tcamera properties","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your work.\n\nOn 2020-10-21 03:24:17 +0300, Laurent Pinchart wrote:\n> Initialize the CameraData properties with the properties exposed by the\n> sensor.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/libcamera/pipeline/simple/simple.cpp | 2 ++\n> 1 file changed, 2 insertions(+)\n> \n> diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\n> index 8868a43beeb4..4b6f708e8fee 100644\n> --- a/src/libcamera/pipeline/simple/simple.cpp\n> +++ b/src/libcamera/pipeline/simple/simple.cpp\n> @@ -324,6 +324,8 @@ int SimpleCameraData::init()\n> \t\treturn -EINVAL;\n> \t}\n> \n> +\tproperties_ = sensor_->properties();\n> +\n> \treturn 0;\n> }\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0F86CBDB13\n\tfor ;\n\tWed, 21 Oct 2020 11:38:56 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 98E6860CE0;\n\tWed, 21 Oct 2020 13:38:55 +0200 (CEST)","from mail-lf1-x143.google.com (mail-lf1-x143.google.com\n\t[IPv6:2a00:1450:4864:20::143])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 95BC960CDD\n\tfor ;\n\tWed, 21 Oct 2020 13:38:53 +0200 (CEST)","by mail-lf1-x143.google.com with SMTP id r127so2612716lff.12\n\tfor ;\n\tWed, 21 Oct 2020 04:38:53 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\tc184sm347900lfg.274.2020.10.21.04.38.52\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 21 Oct 2020 04:38:52 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"EIv7OtYG\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=dkLNmQ+hsDPRVzPAS5HC8/u0V9csAkfohpwswf6QLfM=;\n\tb=EIv7OtYG1lgq1lw9tB+15QF9EKkkV9rTZYmTzr9DYSaShEKihRIkWNRvYkj4KJKN+t\n\tRxZcGKI2IFaye9CNBpTvBOuG6tCghnfl+0Kh7Fj9hERPWJ0wlam7us6Zdgak+HQIEPyx\n\tlKq/HlRlx9fzuV7fopQ4NHDSK4ga/WYJtZpmtSK4vJsZU9nto5dZ7thnkmIggDoTe7S4\n\tejwAsDxpM9Fkgwfz2ASxFzuO7xUHoOFtf9OTv4J7GCE90L8I6kJe5lvONB9FkehfT7Zm\n\tKlbw3Sdc2Uk8Wx1dbIcMGyCDc5Rrc3PPYOmT5VwspRSdCsDOhxcqb86+NLp2PeQ4tE9E\n\tLi9A==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=dkLNmQ+hsDPRVzPAS5HC8/u0V9csAkfohpwswf6QLfM=;\n\tb=k5CCwaNPhqHpjnWUZqtCK8oDvzBkZHkgjrU5wAOjwEbL3udrH7YFdlc9eRQV+OpOjD\n\t5x5loISTB7DD16C8CiDQ4GUUB16xitTckW+QfY3FTmK7PPEObGUVJ5/B97KK9pMM1GeQ\n\tXGQIEeP8cH22LdJVt9b/bCA20FPC+DYUCXOQIVbMzJ1Y1njX9moMr5jpnPMJk2RmiTDZ\n\tGxMpmmlxAZeobPeu/HlXNtiZSD4j7Yf4eFZtytTe3AWo2mDUZGpY3AdJqTLhh9vGzmqY\n\tiu8Mcn2W9FXKm98n1Mm1hq3m46U4cS9ZXjD/qRXSIpPyfdanxapZo9878lGqYKlmrKv4\n\tOyvA==","X-Gm-Message-State":"AOAM5300owQnEHjc4VmUY9VLoxWHdANo8iMeCpox6lewfpp+o147jZH2\n\t8YuyR9EK8zW2yjOzZ2X43nBBrA==","X-Google-Smtp-Source":"ABdhPJxK5vRpqQpNKg4EJRT80tPq+B6k/TBYIhHngvUNwb/iAsB/WwVBPAWMxahYkvJ+QO5wXT8a+Q==","X-Received":"by 2002:a19:7f4d:: with SMTP id\n\ta74mr1143502lfd.533.1603280333087; \n\tWed, 21 Oct 2020 04:38:53 -0700 (PDT)","Date":"Wed, 21 Oct 2020 13:38:51 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Message-ID":"<20201021113851.GE2092600@oden.dyn.berto.se>","References":"<20201021002418.21764-1-laurent.pinchart@ideasonboard.com>\n\t<20201021002418.21764-2-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201021002418.21764-2-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 1/2] libcamera: pipeline: simple: Set\n\tcamera properties","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13344,"web_url":"https://patchwork.libcamera.org/comment/13344/","msgid":"","date":"2020-10-21T13:16:52","subject":"Re: [libcamera-devel] [PATCH 1/2] libcamera: pipeline: simple: Set\n\tcamera properties","submitter":{"id":25,"url":"https://patchwork.libcamera.org/api/people/25/","name":"Andrey Konovalov","email":"andrey.konovalov@linaro.org"},"content":"Hi Laurent,\n\nThank you for the patch!\nNow I can see (on my setup using simple pipeline):\n-----8<-----\nProperty: Rotation = 0\nProperty: Location = 0\nProperty: Model = imx290\n-----8<-----\nadded to the 'cam -c 1 -p' output.\n\nTested-by: Andrey Konovalov \n\nThanks,\nAndrey\n\nOn 21.10.2020 03:24, Laurent Pinchart wrote:\n> Initialize the CameraData properties with the properties exposed by the\n> sensor.\n> \n> Signed-off-by: Laurent Pinchart \n> ---\n> src/libcamera/pipeline/simple/simple.cpp | 2 ++\n> 1 file changed, 2 insertions(+)\n> \n> diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\n> index 8868a43beeb4..4b6f708e8fee 100644\n> --- a/src/libcamera/pipeline/simple/simple.cpp\n> +++ b/src/libcamera/pipeline/simple/simple.cpp\n> @@ -324,6 +324,8 @@ int SimpleCameraData::init()\n> \t\treturn -EINVAL;\n> \t}\n> \n> +\tproperties_ = sensor_->properties();\n> +\n> \treturn 0;\n> }\n> \n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 05C29BDB13\n\tfor ;\n\tWed, 21 Oct 2020 13:16:58 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7279961DAB;\n\tWed, 21 Oct 2020 15:16:57 +0200 (CEST)","from mail-lf1-x142.google.com (mail-lf1-x142.google.com\n\t[IPv6:2a00:1450:4864:20::142])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 61A6460CE0\n\tfor ;\n\tWed, 21 Oct 2020 15:16:56 +0200 (CEST)","by mail-lf1-x142.google.com with SMTP id j30so3087534lfp.4\n\tfor ;\n\tWed, 21 Oct 2020 06:16:56 -0700 (PDT)","from [192.168.118.216] ([85.249.41.73])\n\tby smtp.gmail.com with ESMTPSA id\n\tb21sm397616lfg.309.2020.10.21.06.16.54\n\t(version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n\tWed, 21 Oct 2020 06:16:54 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"T4sDUoKm\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=subject:to:references:from:message-id:date:user-agent:mime-version\n\t:in-reply-to:content-language:content-transfer-encoding;\n\tbh=zNDRcYB9fjK/Xb9DJuBo5rwhUrNv4W04YpvNIj1Xoc0=;\n\tb=T4sDUoKm6Kb6kXvMKyv575OqqT4B4aQvj3X3OlirgHtfcmTqVRdL3tLKEaI4crYrFa\n\tZl3d1y/OjOlpTs/Sm/phImcNKL79tqmPgovU8p96oAd/4jAc8WoA2aBe7gpGSpUr5tJE\n\tTYgOUnBM/3yZTDXOZjgHs4g8Edn84qBQDA3KQj4O4Mc3dLuUqxR7pTQRjhrcLm6m9vs9\n\t4HHz+aFJy2b2gGAFicPTZLg/OKiXQB5mfUg43ro+QY1vDfbXjEr7Lwj1Bo7mwZAqqe2Y\n\tMSz4eyYLM32sE854iZT4yqjZjsa2a4UV0e8LgMg72rvXupkXSIuMmzXwvFO6+vbc/AWN\n\tcAAA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=zNDRcYB9fjK/Xb9DJuBo5rwhUrNv4W04YpvNIj1Xoc0=;\n\tb=E883vmhdcaLIMeuuttEXVoWbC8H/B2IdcQYzvt0suEXaz5FKuuIGtK0VQfX6RtBglA\n\tG92ok+Ysetgy6Uv+trhxRWsCkIz/Q/qk+WCyvkob9nCPuxccixGHHwrNAIzylK4FonjL\n\tOjg5X8mGoCZkUARrfgIC/30dhTz/xT7sNTQDIhBUcA0ksYxLXFvErfDwk/hu9CKLhMCb\n\t+vNnlYD84EjtwJiI65Yjff7jquh0FUGEvdFl5VeqvCrFUFzM8sxihLK/2YajO2e6CGGY\n\tzv0U435D5Y0pMeQTNvzG//a1Kg3rUgOowTxSCbZbzxLnGCQRKVWzTgiOG/gS+z7ZnGsJ\n\tGGCg==","X-Gm-Message-State":"AOAM533ETKfKQij5vydtjF5hTC5ieiWWUdLvHM4gx3hgcyyAKKADSXvD\n\tB0tQcHIjUoQBMLF/Rin2ontjWo+k7Dzssg==","X-Google-Smtp-Source":"ABdhPJz3J9YMOJyQuASKoeW2KGeVMGbZmnm40ZkK/ClwP5XI1s7CLN8G8+5Cvx/t8VDUu/nOUBea4g==","X-Received":"by 2002:ac2:5230:: with SMTP id i16mr1168005lfl.33.1603286215801;\n\tWed, 21 Oct 2020 06:16:55 -0700 (PDT)","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20201021002418.21764-1-laurent.pinchart@ideasonboard.com>\n\t<20201021002418.21764-2-laurent.pinchart@ideasonboard.com>","From":"Andrey Konovalov ","Message-ID":"","Date":"Wed, 21 Oct 2020 16:16:52 +0300","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20201021002418.21764-2-laurent.pinchart@ideasonboard.com>","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH 1/2] libcamera: pipeline: simple: Set\n\tcamera properties","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Transfer-Encoding":"7bit","Content-Type":"text/plain; charset=\"us-ascii\"; Format=\"flowed\"","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13358,"web_url":"https://patchwork.libcamera.org/comment/13358/","msgid":"<0a4f3674-c1e9-5072-3e91-d279a5cf1a82@linaro.org>","date":"2020-10-21T13:59:38","subject":"Re: [libcamera-devel] [PATCH 1/2] libcamera: pipeline: simple: Set\n\tcamera properties","submitter":{"id":25,"url":"https://patchwork.libcamera.org/api/people/25/","name":"Andrey Konovalov","email":"andrey.konovalov@linaro.org"},"content":"On 21.10.2020 16:16, Andrey Konovalov wrote:\n> Hi Laurent,\n> \n> Thank you for the patch!\n> Now I can see (on my setup using simple pipeline):\n> -----8<-----\n> Property: Rotation = 0\n> Property: Location = 0\n> Property: Model = imx290\n> -----8<-----\n> added to the 'cam -c 1 -p' output.\n\nAlso 'cam -l' gives now:\n-----8<-----\nAvailable cameras:\n1: Internal front camera (/base/soc/cci@1b0c000/i2c-bus@0/imx290@1a)\n-----8<-----\ninstead of:\n-----8<-----\n1: [0:12:22.274562882] [877] ERROR Controls controls.cpp:957 Control 0x00000001 not found\nInternal front camera (/base/soc/cci@1b0c000/i2c-bus@0/imx290@1a)\n-----8<-----\nbefore the patch.\n\nThe ERROR was due to:\nCamApp::cameraName() -> ControlList::get(properties::Location) -> ControlList::find() with the\nlist of properties supported by the camera not initialized.\n\nAnd the old behavior seems to reveal a bug in ControlList::get() - if int32 control is not found,\nControlList::get() returns 0 which can be a valid control value like \"internal front camera\" in the\nproperties::Location case).\n\n\nThanks,\nAndrey\n\n> Tested-by: Andrey Konovalov \n> \n> Thanks,\n> Andrey\n> \n> On 21.10.2020 03:24, Laurent Pinchart wrote:\n>> Initialize the CameraData properties with the properties exposed by the\n>> sensor.\n>>\n>> Signed-off-by: Laurent Pinchart \n>> ---\n>>   src/libcamera/pipeline/simple/simple.cpp | 2 ++\n>>   1 file changed, 2 insertions(+)\n>>\n>> diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\n>> index 8868a43beeb4..4b6f708e8fee 100644\n>> --- a/src/libcamera/pipeline/simple/simple.cpp\n>> +++ b/src/libcamera/pipeline/simple/simple.cpp\n>> @@ -324,6 +324,8 @@ int SimpleCameraData::init()\n>>           return -EINVAL;\n>>       }\n>> +    properties_ = sensor_->properties();\n>> +\n>>       return 0;\n>>   }\n>>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8EC2BBDB13\n\tfor ;\n\tWed, 21 Oct 2020 13:59:43 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0615661E0D;\n\tWed, 21 Oct 2020 15:59:43 +0200 (CEST)","from mail-lj1-x242.google.com (mail-lj1-x242.google.com\n\t[IPv6:2a00:1450:4864:20::242])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2A72061DDB\n\tfor ;\n\tWed, 21 Oct 2020 15:59:41 +0200 (CEST)","by mail-lj1-x242.google.com with SMTP id h20so2727346lji.9\n\tfor ;\n\tWed, 21 Oct 2020 06:59:41 -0700 (PDT)","from [192.168.118.216] ([85.249.41.73])\n\tby smtp.gmail.com with ESMTPSA id\n\tc184sm400229lfg.274.2020.10.21.06.59.39\n\t(version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n\tWed, 21 Oct 2020 06:59:39 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"dGB0cmiI\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=subject:from:to:references:message-id:date:user-agent:mime-version\n\t:in-reply-to:content-language:content-transfer-encoding;\n\tbh=J2Z+8bJ4KDKcBLvo68PWN8QLuoACta1Ar8IVHE3hU2Y=;\n\tb=dGB0cmiIFiNQQMUHmYt6FnT5P/105N3YutSI6fd+cYvy5/nGXu0y7z3laRF4XZRgh1\n\tnnuaTV++al8vVXcxxsv4uRhIpOOwnVVsQ+9BwshPp3tw1PW4enhE6ziSJyP+W3toaozS\n\tSupmjX4ujwjiEQ/fBKDphTeupybmnWGlII6cdKazINcoI7bhF/hf57v+c5tLViBVWbZ1\n\tAFA+2XK8ly9U12/OIEVgfMIVx8Od9wFL6BaDEyfRrsBGH5kfbWKy6dSW8gTA+0rUT6Ox\n\tDckq8OizQBDGndfG7K6PKjpZ/GZDPlWWbZo/Yv9eEii/vtTKrmEeo9ZBGvep8bJwwB9s\n\td/FQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:from:to:references:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=J2Z+8bJ4KDKcBLvo68PWN8QLuoACta1Ar8IVHE3hU2Y=;\n\tb=OrNCZWwVJvycQyFRzJCHpOrm1KInbdxwuy4sEHyvGXH/OfNfyHVuT38WBMG55X/7L4\n\tGUSvuDgmJsusaxuWgbuElgGfgKvq8tmSegh4zBc/DIyrO+amFKxqEpn7MC/xXlbgoIcG\n\tgkQ4oGxDq81Jb0pxeWzHSFoje1hlL6gN3MKzpveNG4QT0hpWjrkJqf8BeFtU0UXPn5u0\n\tZ+N7niMQVwJ9LqWrnUOJTqQirZAHBgpp5lV1glpHY7UEG6xGJb/lbAGUqi5M+Sw7GubS\n\tXh58w1pzz/GXAHXXlj6JpZQ0oCTYE2q7HpafeVAw8GJXLeTW5X/sBxzPp8V0aGZNS541\n\tPaCA==","X-Gm-Message-State":"AOAM530dFqnkl4yLk/EHFckzjLmMKss7xkgH9wcAoqOF9K7wEhwSyuae\n\tnnU5HqywWWRzaJU3CZFEtMR/bahMuliMog==","X-Google-Smtp-Source":"ABdhPJx2+yt9Xv9H4GQeB8R5NAqDqdFolp5u50HpojZRs5xZCsjMyCW9aHodiwEPauKfUvbWQWFlyw==","X-Received":"by 2002:a2e:8596:: with SMTP id\n\tb22mr1415624lji.455.1603288780580; \n\tWed, 21 Oct 2020 06:59:40 -0700 (PDT)","From":"Andrey Konovalov ","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20201021002418.21764-1-laurent.pinchart@ideasonboard.com>\n\t<20201021002418.21764-2-laurent.pinchart@ideasonboard.com>\n\t","Message-ID":"<0a4f3674-c1e9-5072-3e91-d279a5cf1a82@linaro.org>","Date":"Wed, 21 Oct 2020 16:59:38 +0300","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH 1/2] libcamera: pipeline: simple: Set\n\tcamera properties","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Transfer-Encoding":"base64","Content-Type":"text/plain; charset=\"utf-8\"; Format=\"flowed\"","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13359,"web_url":"https://patchwork.libcamera.org/comment/13359/","msgid":"<02d913f4-e822-8ccd-fb05-f3fc783b4c59@linaro.org>","date":"2020-10-21T14:05:01","subject":"Re: [libcamera-devel] [PATCH 1/2] libcamera: pipeline: simple: Set\n\tcamera properties","submitter":{"id":25,"url":"https://patchwork.libcamera.org/api/people/25/","name":"Andrey Konovalov","email":"andrey.konovalov@linaro.org"},"content":"On 21.10.2020 16:59, Andrey Konovalov wrote:\n> On 21.10.2020 16:16, Andrey Konovalov wrote:\n>> Hi Laurent,\n>>\n>> Thank you for the patch!\n>> Now I can see (on my setup using simple pipeline):\n>> -----8<-----\n>> Property: Rotation = 0\n>> Property: Location = 0\n>> Property: Model = imx290\n>> -----8<-----\n>> added to the 'cam -c 1 -p' output.\n> \n> Also 'cam -l' gives now:\n> -----8<-----\n> Available cameras:\n> 1: Internal front camera (/base/soc/cci@1b0c000/i2c-bus@0/imx290@1a)\n> -----8<-----\n> instead of:\n> -----8<-----\n> 1: [0:12:22.274562882] [877] ERROR Controls controls.cpp:957 Control 0x00000001 not found\n> Internal front camera (/base/soc/cci@1b0c000/i2c-bus@0/imx290@1a)\n> -----8<-----\n> before the patch.\n> \n> The ERROR was due to:\n> CamApp::cameraName() -> ControlList::get(properties::Location) -> ControlList::find() with the\n> list of properties supported by the camera not initialized.\n> \n> And the old behavior seems to reveal a bug in ControlList::get() - if int32 control is not found,\n> ControlList::get() returns 0 which can be a valid control value like \"internal front camera\" in the\n> properties::Location case).\n\nAfter reading the ControlList::get() documentation, I see that undefined behaviour is documented for that\ncase. This is CamApp which should check that the control is present in the list before calling get().\n\nSorry,\nAndrey\n\n> Thanks,\n> Andrey\n> \n>> Tested-by: Andrey Konovalov \n>>\n>> Thanks,\n>> Andrey\n>>\n>> On 21.10.2020 03:24, Laurent Pinchart wrote:\n>>> Initialize the CameraData properties with the properties exposed by the\n>>> sensor.\n>>>\n>>> Signed-off-by: Laurent Pinchart \n>>> ---\n>>>   src/libcamera/pipeline/simple/simple.cpp | 2 ++\n>>>   1 file changed, 2 insertions(+)\n>>>\n>>> diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\n>>> index 8868a43beeb4..4b6f708e8fee 100644\n>>> --- a/src/libcamera/pipeline/simple/simple.cpp\n>>> +++ b/src/libcamera/pipeline/simple/simple.cpp\n>>> @@ -324,6 +324,8 @@ int SimpleCameraData::init()\n>>>           return -EINVAL;\n>>>       }\n>>> +    properties_ = sensor_->properties();\n>>> +\n>>>       return 0;\n>>>   }\n>>>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 65D5CC3D3C\n\tfor ;\n\tWed, 21 Oct 2020 14:05:06 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E49CE61DDB;\n\tWed, 21 Oct 2020 16:05:05 +0200 (CEST)","from mail-lj1-x241.google.com (mail-lj1-x241.google.com\n\t[IPv6:2a00:1450:4864:20::241])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 48F1E61D85\n\tfor ;\n\tWed, 21 Oct 2020 16:05:05 +0200 (CEST)","by mail-lj1-x241.google.com with SMTP id c21so2705645ljn.13\n\tfor ;\n\tWed, 21 Oct 2020 07:05:05 -0700 (PDT)","from [192.168.118.216] ([85.249.41.73])\n\tby smtp.gmail.com with ESMTPSA id\n\tm4sm439643ljg.137.2020.10.21.07.05.02\n\t(version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n\tWed, 21 Oct 2020 07:05:03 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"TbxUmy6S\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=subject:from:to:references:message-id:date:user-agent:mime-version\n\t:in-reply-to:content-language:content-transfer-encoding;\n\tbh=H72+S+MkEm65zubDpkY2L0JZA5Cjjzp3MEE3x5p6H5M=;\n\tb=TbxUmy6SewkbUdbB7MlwNYCgdD6uPzvIssngyN81v2cLTuZ64kh+zs/J/uA90HnD1c\n\tN3eFd0xtu6y1tgIKi7A54n379qB46t0vNqmCZVCnKs/l4QmKh2sUSGYNgByrvLC2O/ZK\n\to9uPUGHmLvyThm6VAYwdy1+aH58Ft/iF3k/9ODBGro+Bm1yzdz2Hr1rl9C9MD7psNJsL\n\tIyK0ETrhpLyJkjJsyqgtEOTYgCzEP3gX/a7Ffl2rDWZLqm9ZWeXr3hI9J/vClFCWS0NF\n\t5ybXxUkA9Xbx6sreBmFxOJD2DVjgbpb9dMNnnZ6huzYxVjw4DmHMLPE1LErB0VFLuhYn\n\tzmSA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:from:to:references:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=H72+S+MkEm65zubDpkY2L0JZA5Cjjzp3MEE3x5p6H5M=;\n\tb=nXk2tlMjjU/Qm2I9087PVundnSNvhcqIU9FGQJOXdlcFvwv4kZWEXnDejfbpfjJNmV\n\trOo+xKXWohJY27+cSXi4MB3xdV7X5ZlsjGN0S/rNhFUPTTZnAVaTvbaJLUrIpax6cZkU\n\tBL0CZSZVJJQ0ywsoSzloJuNYNM5JzW1jU4k8gSdkv9PF2Y4vYhN+zlfJT2IXe9goWa+Z\n\t+c4ZEfMLwtJPsI9eYriWbdnbTOVsLntO2IlhBX5ZOWscL1wPSYV2UaYq9FIuB+kfFf8p\n\t9nVT2hR8jbhs+meOz8PpksyvGiHaCSIW72GlFiohzO95jFdbTWryEkK+nhtxgpm+kueF\n\tKSLA==","X-Gm-Message-State":"AOAM5301PMBD2QqiJb3z87Lwx+raTglDmGjktjZUdDC1isrmnWfv8Wvl\n\t+M8m/n/CjQuNUk0edl2MszBWdgreSqSetw==","X-Google-Smtp-Source":"ABdhPJxEmyH8GdAhx1oW71hTCJpkcngQ/QVr/MK3S2bsp3N2tfboGZCHBIkkfov1WNoj0YPqUc2H5w==","X-Received":"by 2002:a2e:6e18:: with SMTP id j24mr1188569ljc.91.1603289104566;\n\tWed, 21 Oct 2020 07:05:04 -0700 (PDT)","From":"Andrey Konovalov ","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20201021002418.21764-1-laurent.pinchart@ideasonboard.com>\n\t<20201021002418.21764-2-laurent.pinchart@ideasonboard.com>\n\t\n\t<0a4f3674-c1e9-5072-3e91-d279a5cf1a82@linaro.org>","Message-ID":"<02d913f4-e822-8ccd-fb05-f3fc783b4c59@linaro.org>","Date":"Wed, 21 Oct 2020 17:05:01 +0300","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<0a4f3674-c1e9-5072-3e91-d279a5cf1a82@linaro.org>","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH 1/2] libcamera: pipeline: simple: Set\n\tcamera properties","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Transfer-Encoding":"base64","Content-Type":"text/plain; charset=\"utf-8\"; Format=\"flowed\"","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13374,"web_url":"https://patchwork.libcamera.org/comment/13374/","msgid":"<20201021181551.GJ3942@pendragon.ideasonboard.com>","date":"2020-10-21T18:15:51","subject":"Re: [libcamera-devel] [PATCH 1/2] libcamera: pipeline: simple: Set\n\tcamera properties","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Andrey,\n\nOn Wed, Oct 21, 2020 at 05:05:01PM +0300, Andrey Konovalov wrote:\n> On 21.10.2020 16:59, Andrey Konovalov wrote:\n> > On 21.10.2020 16:16, Andrey Konovalov wrote:\n> >> Hi Laurent,\n> >>\n> >> Thank you for the patch!\n> >> Now I can see (on my setup using simple pipeline):\n> >> -----8<-----\n> >> Property: Rotation = 0\n> >> Property: Location = 0\n> >> Property: Model = imx290\n> >> -----8<-----\n> >> added to the 'cam -c 1 -p' output.\n> > \n> > Also 'cam -l' gives now:\n> > -----8<-----\n> > Available cameras:\n> > 1: Internal front camera (/base/soc/cci@1b0c000/i2c-bus@0/imx290@1a)\n> > -----8<-----\n> > instead of:\n> > -----8<-----\n> > 1: [0:12:22.274562882] [877] ERROR Controls controls.cpp:957 Control 0x00000001 not found\n> > Internal front camera (/base/soc/cci@1b0c000/i2c-bus@0/imx290@1a)\n> > -----8<-----\n> > before the patch.\n> > \n> > The ERROR was due to:\n> > CamApp::cameraName() -> ControlList::get(properties::Location) -> ControlList::find() with the\n> > list of properties supported by the camera not initialized.\n> > \n> > And the old behavior seems to reveal a bug in ControlList::get() - if int32 control is not found,\n> > ControlList::get() returns 0 which can be a valid control value like \"internal front camera\" in the\n> > properties::Location case).\n> \n> After reading the ControlList::get() documentation, I see that undefined behaviour is documented for that\n> case. This is CamApp which should check that the control is present in the list before calling get().\n\nI agree, but in this specific case, the Location property is meant to be\nmandatory, so I don't think cam needs to check for it. We haven't\ndocumented the property as mandatory yet, so that part has to be fixed\n:-)\n\n> Sorry,\n\nNothing to be sorry about.\n\n> >> Tested-by: Andrey Konovalov \n> >>\n> >> Thanks,\n> >> Andrey\n> >>\n> >> On 21.10.2020 03:24, Laurent Pinchart wrote:\n> >>> Initialize the CameraData properties with the properties exposed by the\n> >>> sensor.\n> >>>\n> >>> Signed-off-by: Laurent Pinchart \n> >>> ---\n> >>>   src/libcamera/pipeline/simple/simple.cpp | 2 ++\n> >>>   1 file changed, 2 insertions(+)\n> >>>\n> >>> diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\n> >>> index 8868a43beeb4..4b6f708e8fee 100644\n> >>> --- a/src/libcamera/pipeline/simple/simple.cpp\n> >>> +++ b/src/libcamera/pipeline/simple/simple.cpp\n> >>> @@ -324,6 +324,8 @@ int SimpleCameraData::init()\n> >>>           return -EINVAL;\n> >>>       }\n> >>> +    properties_ = sensor_->properties();\n> >>> +\n> >>>       return 0;\n> >>>   }\n> >>>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C8ECEBDB13\n\tfor ;\n\tWed, 21 Oct 2020 18:16:40 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5DAD9603C1;\n\tWed, 21 Oct 2020 20:16:40 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 91E0560361\n\tfor ;\n\tWed, 21 Oct 2020 20:16:38 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2333ABB5;\n\tWed, 21 Oct 2020 20:16:37 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"QA+m/6Em\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1603304197;\n\tbh=g7gxcpZ0LRY62+YM6gpghEyS/l4SW6DQA6LNivwrX6k=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=QA+m/6EmGYlhiT15qmvsf3ZT1+cHMOKw6R8BVn8znYoIbZdQgh28HG6BHwskB1X9k\n\tkBR9pM8rrY3qzbyaZegCWx/+MVcqM0b4UH9JsHwY8DBU1/QwH3Qry8+q4Q7lAcwaWB\n\ti/MTcZLaKJvzpDdRBL1Hpx7WrEKjFYObJBo74itU=","Date":"Wed, 21 Oct 2020 21:15:51 +0300","From":"Laurent Pinchart ","To":"Andrey Konovalov ","Message-ID":"<20201021181551.GJ3942@pendragon.ideasonboard.com>","References":"<20201021002418.21764-1-laurent.pinchart@ideasonboard.com>\n\t<20201021002418.21764-2-laurent.pinchart@ideasonboard.com>\n\t\n\t<0a4f3674-c1e9-5072-3e91-d279a5cf1a82@linaro.org>\n\t<02d913f4-e822-8ccd-fb05-f3fc783b4c59@linaro.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<02d913f4-e822-8ccd-fb05-f3fc783b4c59@linaro.org>","Subject":"Re: [libcamera-devel] [PATCH 1/2] libcamera: pipeline: simple: Set\n\tcamera properties","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]