[{"id":13312,"web_url":"https://patchwork.libcamera.org/comment/13312/","msgid":"<20201021022958.GG2041@pyrite.rasen.tech>","date":"2020-10-21T02:29:58","subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline: Fail match()\n\twhen no camera is registered","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Hi Laurent,\n\nOn Tue, Oct 20, 2020 at 10:51:55PM +0300, Laurent Pinchart wrote:\n> The rkisp1 and simple pipeline handlers can fail to register any camera,\n> if initialization of all the detected cameras fail. In that case, they\n> still return success from their match function. As no camera gets\n> registered, the pipeline handler is immediately destroyed, releasing the\n> acquired media devices, and the camera manager immediately tries to\n> match the same pipeline handler with the same media device, causing an\n> endless loop.\n> \n> Fix it by returning false from the match function if no camera gets\n> registered.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Paul Elder \n\n> ---\n> src/libcamera/pipeline/rkisp1/rkisp1.cpp | 9 ++++++---\n> src/libcamera/pipeline/simple/simple.cpp | 5 ++++-\n> 2 files changed, 10 insertions(+), 4 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> index 2352ab3b234a..c74a2e9bd548 100644\n> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> @@ -1107,10 +1107,13 @@ bool PipelineHandlerRkISP1::match(DeviceEnumerator *enumerator)\n> \tif (!pad)\n> \t\treturn false;\n> \n> -\tfor (MediaLink *link : pad->links())\n> -\t\tcreateCamera(link->source()->entity());\n> +\tbool registered = false;\n> +\tfor (MediaLink *link : pad->links()) {\n> +\t\tif (!createCamera(link->source()->entity()))\n> +\t\t\tregistered = true;\n> +\t}\n> \n> -\treturn true;\n> +\treturn registered;\n> }\n> \n> /* -----------------------------------------------------------------------------\n> diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\n> index 8c00c0ffc121..8868a43beeb4 100644\n> --- a/src/libcamera/pipeline/simple/simple.cpp\n> +++ b/src/libcamera/pipeline/simple/simple.cpp\n> @@ -821,6 +821,8 @@ bool SimplePipelineHandler::match(DeviceEnumerator *enumerator)\n> \t}\n> \n> \t/* Initialize each pipeline and register a corresponding camera. */\n> +\tbool registered = false;\n> +\n> \tfor (std::unique_ptr &data : pipelines) {\n> \t\tint ret = data->init();\n> \t\tif (ret < 0)\n> @@ -830,9 +832,10 @@ bool SimplePipelineHandler::match(DeviceEnumerator *enumerator)\n> \t\t\tCamera::create(this, data->sensor_->id(),\n> \t\t\t\t data->streams());\n> \t\tregisterCamera(std::move(camera), std::move(data));\n> +\t\tregistered = true;\n> \t}\n> \n> -\treturn true;\n> +\treturn registered;\n> }\n> \n> V4L2VideoDevice *SimplePipelineHandler::video(const MediaEntity *entity)\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0B2ADBDB1F\n\tfor ;\n\tWed, 21 Oct 2020 02:30:08 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 994CF60361;\n\tWed, 21 Oct 2020 04:30:07 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4F24A60350\n\tfor ;\n\tWed, 21 Oct 2020 04:30:06 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BB3DC92;\n\tWed, 21 Oct 2020 04:30:04 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"BJzpWxOz\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1603247405;\n\tbh=Kvw1agTPusJLj6fC0pZS/SBlysL1THvBXleF0WREkZA=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=BJzpWxOz0Qi5+pPijBD8SPRwm8HBV8AMzSwf5QdkPdp0aR6kO4EMNiXXiGzyfhnF2\n\tC/9LLaujg0+f/CvgMhkPB3ta7kG9IyQsL4ZLIY0Pdd7KfhaC0CoAiE2oxAkr16TM3G\n\t0dwR9LtSduUce0McSAKMFycFu2vQJ+7JdA04JBxQ=","Date":"Wed, 21 Oct 2020 11:29:58 +0900","From":"paul.elder@ideasonboard.com","To":"Laurent Pinchart ","Message-ID":"<20201021022958.GG2041@pyrite.rasen.tech>","References":"<20201020195155.15537-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201020195155.15537-1-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline: Fail match()\n\twhen no camera is registered","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13313,"web_url":"https://patchwork.libcamera.org/comment/13313/","msgid":"<50f9de57-be4d-cd38-6ac5-a6929249dd69@ideasonboard.com>","date":"2020-10-21T08:16:01","subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline: Fail match()\n\twhen no camera is registered","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 20/10/2020 20:51, Laurent Pinchart wrote:\n> The rkisp1 and simple pipeline handlers can fail to register any camera,\n> if initialization of all the detected cameras fail. In that case, they\n> still return success from their match function. As no camera gets\n> registered, the pipeline handler is immediately destroyed, releasing the\n> acquired media devices, and the camera manager immediately tries to\n> match the same pipeline handler with the same media device, causing an\n> endless loop.\n> \n> Fix it by returning false from the match function if no camera gets\n> registered.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/libcamera/pipeline/rkisp1/rkisp1.cpp | 9 ++++++---\n> src/libcamera/pipeline/simple/simple.cpp | 5 ++++-\n> 2 files changed, 10 insertions(+), 4 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> index 2352ab3b234a..c74a2e9bd548 100644\n> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> @@ -1107,10 +1107,13 @@ bool PipelineHandlerRkISP1::match(DeviceEnumerator *enumerator)\n> \tif (!pad)\n> \t\treturn false;\n> \n> -\tfor (MediaLink *link : pad->links())\n> -\t\tcreateCamera(link->source()->entity());\n> +\tbool registered = false;\n> +\tfor (MediaLink *link : pad->links()) {\n> +\t\tif (!createCamera(link->source()->entity()))\n> +\t\t\tregistered = true;\n> +\t}\n> \n> -\treturn true;\n> +\treturn registered;\n> }\n> \n> /* -----------------------------------------------------------------------------\n> diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\n> index 8c00c0ffc121..8868a43beeb4 100644\n> --- a/src/libcamera/pipeline/simple/simple.cpp\n> +++ b/src/libcamera/pipeline/simple/simple.cpp\n> @@ -821,6 +821,8 @@ bool SimplePipelineHandler::match(DeviceEnumerator *enumerator)\n> \t}\n> \n> \t/* Initialize each pipeline and register a corresponding camera. */\n> +\tbool registered = false;\n> +\n> \tfor (std::unique_ptr &data : pipelines) {\n> \t\tint ret = data->init();\n> \t\tif (ret < 0)\n> @@ -830,9 +832,10 @@ bool SimplePipelineHandler::match(DeviceEnumerator *enumerator)\n> \t\t\tCamera::create(this, data->sensor_->id(),\n> \t\t\t\t data->streams());\n> \t\tregisterCamera(std::move(camera), std::move(data));\n> +\t\tregistered = true;\n> \t}\n> \n> -\treturn true;\n> +\treturn registered;\n> }\n> \n> V4L2VideoDevice *SimplePipelineHandler::video(const MediaEntity *entity)\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CC908BDB13\n\tfor ;\n\tWed, 21 Oct 2020 08:16:08 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 58E7560361;\n\tWed, 21 Oct 2020 10:16:08 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 478C960352\n\tfor ;\n\tWed, 21 Oct 2020 10:16:06 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5C26792;\n\tWed, 21 Oct 2020 10:16:05 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"sG3Hubop\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1603268165;\n\tbh=USVpTwfSRd8PNqfX1+3AhRuCUgH5Pk7v8XOC7QfvSCQ=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=sG3HubopjL2MdCr+5ZrXzUqJI13BK47JIVnvt7pKJJRRy7W5btAGB56pa+IRTT0T+\n\tSnASZTcof77MYW+MMtcHIYjJJCpBI5QI5woLNRsOMR/eV6cg44q28dM1CyblqWk1RQ\n\tu/sm09Hor+yAngWuDIMSHYF7Q/ewbSwtravvy5AI=","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20201020195155.15537-1-laurent.pinchart@ideasonboard.com>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<50f9de57-be4d-cd38-6ac5-a6929249dd69@ideasonboard.com>","Date":"Wed, 21 Oct 2020 09:16:01 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20201020195155.15537-1-laurent.pinchart@ideasonboard.com>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline: Fail match()\n\twhen no camera is registered","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13329,"web_url":"https://patchwork.libcamera.org/comment/13329/","msgid":"<20201021112524.GB2092600@oden.dyn.berto.se>","date":"2020-10-21T11:25:24","subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline: Fail match()\n\twhen no camera is registered","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nNice catch.\n\nOn 2020-10-20 22:51:55 +0300, Laurent Pinchart wrote:\n> The rkisp1 and simple pipeline handlers can fail to register any camera,\n> if initialization of all the detected cameras fail. In that case, they\n> still return success from their match function. As no camera gets\n> registered, the pipeline handler is immediately destroyed, releasing the\n> acquired media devices, and the camera manager immediately tries to\n> match the same pipeline handler with the same media device, causing an\n> endless loop.\n> \n> Fix it by returning false from the match function if no camera gets\n> registered.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/libcamera/pipeline/rkisp1/rkisp1.cpp | 9 ++++++---\n> src/libcamera/pipeline/simple/simple.cpp | 5 ++++-\n> 2 files changed, 10 insertions(+), 4 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> index 2352ab3b234a..c74a2e9bd548 100644\n> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> @@ -1107,10 +1107,13 @@ bool PipelineHandlerRkISP1::match(DeviceEnumerator *enumerator)\n> \tif (!pad)\n> \t\treturn false;\n> \n> -\tfor (MediaLink *link : pad->links())\n> -\t\tcreateCamera(link->source()->entity());\n> +\tbool registered = false;\n> +\tfor (MediaLink *link : pad->links()) {\n> +\t\tif (!createCamera(link->source()->entity()))\n> +\t\t\tregistered = true;\n> +\t}\n> \n> -\treturn true;\n> +\treturn registered;\n> }\n> \n> /* -----------------------------------------------------------------------------\n> diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\n> index 8c00c0ffc121..8868a43beeb4 100644\n> --- a/src/libcamera/pipeline/simple/simple.cpp\n> +++ b/src/libcamera/pipeline/simple/simple.cpp\n> @@ -821,6 +821,8 @@ bool SimplePipelineHandler::match(DeviceEnumerator *enumerator)\n> \t}\n> \n> \t/* Initialize each pipeline and register a corresponding camera. */\n> +\tbool registered = false;\n> +\n> \tfor (std::unique_ptr &data : pipelines) {\n> \t\tint ret = data->init();\n> \t\tif (ret < 0)\n> @@ -830,9 +832,10 @@ bool SimplePipelineHandler::match(DeviceEnumerator *enumerator)\n> \t\t\tCamera::create(this, data->sensor_->id(),\n> \t\t\t\t data->streams());\n> \t\tregisterCamera(std::move(camera), std::move(data));\n> +\t\tregistered = true;\n> \t}\n> \n> -\treturn true;\n> +\treturn registered;\n> }\n> \n> V4L2VideoDevice *SimplePipelineHandler::video(const MediaEntity *entity)\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 04401BDB13\n\tfor ;\n\tWed, 21 Oct 2020 11:25:29 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 89E4360CE0;\n\tWed, 21 Oct 2020 13:25:28 +0200 (CEST)","from mail-lj1-x244.google.com (mail-lj1-x244.google.com\n\t[IPv6:2a00:1450:4864:20::244])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F216360CDD\n\tfor ;\n\tWed, 21 Oct 2020 13:25:26 +0200 (CEST)","by mail-lj1-x244.google.com with SMTP id y16so2249941ljk.1\n\tfor ;\n\tWed, 21 Oct 2020 04:25:26 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\tp14sm349810lfa.244.2020.10.21.04.25.24\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 21 Oct 2020 04:25:25 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"JogZ0fxf\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=ppWNJ9OJEfq72WLdLiuq468uAT6WEL1APCL2j28K7Oo=;\n\tb=JogZ0fxfcOnptcwJxz9NjbdXpVrAQzBUHYToEt8X+vUA15XzjnmXvkmsi02S5vw5ze\n\tgXHacZPnZzowgGaUB4IkaTqo6vqHny4ErqrdK4WobF+FbOK7BdLGnyGawWyPavchHmvx\n\tfsgehcYuDWWz9oHfhraXf20UoD8joec9ks8Z0pt7mn+fJyz1EfgFT0B5eVaKXXaiYwEs\n\tnZoNE+JEevgQyt+7cgZP9mV5rsG24lX745QfA9fzLZdqI3+W3qw9mnSfSJ4I1eGuKhpY\n\tDBt3HN3c/S4R2u30q15WI8KZ2p2PU5hNR0Qpq+tNt2bKALafdld3+1DcRUhrI11PFKU6\n\tm4Qw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=ppWNJ9OJEfq72WLdLiuq468uAT6WEL1APCL2j28K7Oo=;\n\tb=IbH18wHLeL3vICod+jOjcs72bqUbASLm8FRaV0mjMjncmqx2Jnz32rTfbyqKvAgQcq\n\t5vjxMkIF3GCHJQD3uc/jv5iRZDaSzYYM+YJMEyfKdR3mAcOHXsl4ruNwL3zKseBHT3So\n\tAgYxZ19JDqi+9+/WLrRBfkVOyLdBAzkojBxciOk/gDsP4u6CV0oHTnKMZQxNG2SNPerl\n\todXjNocBrM5hqHUIfDdOLnfbpYZDf23iQcoh7vJRxKw/1zJZIem313xZ0zXuHSXIrsih\n\tuUQIV50tJOv4ln42uSoDO5oJUzedNFd/zlUWvqqATA7bXW6N7TdDmdL7k66rp+eLMX4v\n\t+/Mw==","X-Gm-Message-State":"AOAM530laD7R+TpqIDNoYZOwSXuHoYFEMuVBhlrlpWwNjqS7tQP5orBS\n\tToToJhiAiKWGTqQpTeOABsWylw==","X-Google-Smtp-Source":"ABdhPJzNtVOsu29R9/BPRFK1JRpPDetlBXJImvsvMJIMAk4x2kVsBWmlSqfufCi4DwdTG7/PqFQLZQ==","X-Received":"by 2002:a2e:8116:: with SMTP id\n\td22mr1100642ljg.331.1603279526180; \n\tWed, 21 Oct 2020 04:25:26 -0700 (PDT)","Date":"Wed, 21 Oct 2020 13:25:24 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Message-ID":"<20201021112524.GB2092600@oden.dyn.berto.se>","References":"<20201020195155.15537-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201020195155.15537-1-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline: Fail match()\n\twhen no camera is registered","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]