{"id":10147,"url":"https://patchwork.libcamera.org/api/patches/10147/?format=json","web_url":"https://patchwork.libcamera.org/patch/10147/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20201020195155.15537-1-laurent.pinchart@ideasonboard.com>","date":"2020-10-20T19:51:55","name":"[libcamera-devel] libcamera: pipeline: Fail match() when no camera is registered","commit_ref":"8ddaa824ab2302e8d5b8926b1d8a51df7eb47f29","pull_url":null,"state":"accepted","archived":false,"hash":"b1a331e4bcd74187e74c0fb0abf55fdef5c16272","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/10147/mbox/","series":[{"id":1392,"url":"https://patchwork.libcamera.org/api/series/1392/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1392","date":"2020-10-20T19:51:55","name":"[libcamera-devel] libcamera: pipeline: Fail match() when no camera is registered","version":1,"mbox":"https://patchwork.libcamera.org/series/1392/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/10147/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/10147/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 97C38BDB13\n\tfor ;\n\tTue, 20 Oct 2020 19:52:47 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 08F0E61D8E;\n\tTue, 20 Oct 2020 21:52:47 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4390D603B0\n\tfor ;\n\tTue, 20 Oct 2020 21:52:46 +0200 (CEST)","from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BC05CDB1\n\tfor ;\n\tTue, 20 Oct 2020 21:52:45 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"cYPKFmVl\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1603223565;\n\tbh=gkoKl95ISo3XpmowdoMUzBOT9qNMEz4pOs2HQeL3QSc=;\n\th=From:To:Subject:Date:From;\n\tb=cYPKFmVljyO6Q/mTuFL3Uj1XwhV+Hh4L1MftvwM14EeihEMqqFlQQi7bNIueofd+c\n\tQDYzNIgRdDHk3HPGb8Moyj7g82WajB5TtI7Por7rHWVDAFEKb3m+mQLvSIOYOJ/e1H\n\ttsfDQ5rsyFkZ8M5sjFxtYIUSSGA6T35HrhLN9ffE=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 20 Oct 2020 22:51:55 +0300","Message-Id":"<20201020195155.15537-1-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.27.0","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH] libcamera: pipeline: Fail match() when no\n\tcamera is registered","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The rkisp1 and simple pipeline handlers can fail to register any camera,\nif initialization of all the detected cameras fail. In that case, they\nstill return success from their match function. As no camera gets\nregistered, the pipeline handler is immediately destroyed, releasing the\nacquired media devices, and the camera manager immediately tries to\nmatch the same pipeline handler with the same media device, causing an\nendless loop.\n\nFix it by returning false from the match function if no camera gets\nregistered.\n\nSigned-off-by: Laurent Pinchart \n---\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 9 ++++++---\n src/libcamera/pipeline/simple/simple.cpp | 5 ++++-\n 2 files changed, 10 insertions(+), 4 deletions(-)","diff":"diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\nindex 2352ab3b234a..c74a2e9bd548 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n@@ -1107,10 +1107,13 @@ bool PipelineHandlerRkISP1::match(DeviceEnumerator *enumerator)\n \tif (!pad)\n \t\treturn false;\n \n-\tfor (MediaLink *link : pad->links())\n-\t\tcreateCamera(link->source()->entity());\n+\tbool registered = false;\n+\tfor (MediaLink *link : pad->links()) {\n+\t\tif (!createCamera(link->source()->entity()))\n+\t\t\tregistered = true;\n+\t}\n \n-\treturn true;\n+\treturn registered;\n }\n \n /* -----------------------------------------------------------------------------\ndiff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\nindex 8c00c0ffc121..8868a43beeb4 100644\n--- a/src/libcamera/pipeline/simple/simple.cpp\n+++ b/src/libcamera/pipeline/simple/simple.cpp\n@@ -821,6 +821,8 @@ bool SimplePipelineHandler::match(DeviceEnumerator *enumerator)\n \t}\n \n \t/* Initialize each pipeline and register a corresponding camera. */\n+\tbool registered = false;\n+\n \tfor (std::unique_ptr &data : pipelines) {\n \t\tint ret = data->init();\n \t\tif (ret < 0)\n@@ -830,9 +832,10 @@ bool SimplePipelineHandler::match(DeviceEnumerator *enumerator)\n \t\t\tCamera::create(this, data->sensor_->id(),\n \t\t\t\t data->streams());\n \t\tregisterCamera(std::move(camera), std::move(data));\n+\t\tregistered = true;\n \t}\n \n-\treturn true;\n+\treturn registered;\n }\n \n V4L2VideoDevice *SimplePipelineHandler::video(const MediaEntity *entity)\n","prefixes":["libcamera-devel"]}