[{"id":13342,"web_url":"https://patchwork.libcamera.org/comment/13342/","msgid":"<708e7c7d-828f-82ee-e0b6-5980768d975a@ideasonboard.com>","date":"2020-10-21T13:10:19","subject":"Re: [libcamera-devel] [PATCH v2 10/13] android: camera_device:\n\tReport PIPELINE_MAX_DEPTH","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"On 20/10/2020 19:05, Jacopo Mondi wrote:\n> Register the ANDROID_REQUEST_PIPELINE_MAX_DEPTH static property\n> inspecting the value reported by the pipeline handler.\n> \n> If the Camera does not report any suitable value, default the\n> static property to 2.\n> \n> Signed-off-by: Jacopo Mondi \n> ---\n> src/android/camera_device.cpp | 15 ++++++++++++---\n> 1 file changed, 12 insertions(+), 3 deletions(-)\n> \n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index e9404c2f3004..8166b09bb69a 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -13,6 +13,7 @@\n> #include \n> #include \n> \n> +#include \n> #include \n> #include \n> #include \n> @@ -591,6 +592,8 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n> \t\treturn nullptr;\n> \t}\n> \n> +\tconst ControlInfoMap &controlsInfo = camera_->controls();\n> +\n> \t/* Color correction static metadata. */\n> \tstd::vector aberrationModes = {\n> \t\tANDROID_COLOR_CORRECTION_ABERRATION_MODE_OFF,\n> @@ -882,9 +885,15 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n> \tstaticMetadata_->addEntry(ANDROID_REQUEST_PARTIAL_RESULT_COUNT,\n> \t\t\t\t &partialResultCount, 1);\n> \n> -\tuint8_t maxPipelineDepth = 2;\n> -\tstaticMetadata_->addEntry(ANDROID_REQUEST_PIPELINE_MAX_DEPTH,\n> -\t\t\t\t &maxPipelineDepth, 1);\n> +\t{\n> +\t\t/* Default the value to 2 if not reported by the camera. */\n> +\t\tuint8_t maxPipelineDepth = 2;\n> +\t\tconst auto &infoMap = controlsInfo.find(&controls::draft::PipelineDepth);\n> +\t\tif (infoMap != controlsInfo.end())\n> +\t\t\tmaxPipelineDepth = infoMap->second.max().get();\n\nI would certainly put a new line here, and possibly/probably before the\nif statement too. Otherwise it's disguising the scope of the condition IMO.\n\n\nShould we print any kind of a warning if the pipeline handler has not\nreported this control?\n\nI could foresee this being a repeated pattern. Not sure how to best\nhandle that yet though.\n\nBut for now,\n\nReviewed-by: Kieran Bingham \n\n> +\t\tstaticMetadata_->addEntry(ANDROID_REQUEST_PIPELINE_MAX_DEPTH,\n> +\t\t\t\t\t &maxPipelineDepth, 1);\n> +\t}\n> \n> \t/* LIMITED does not support reprocessing. */\n> \tuint32_t maxNumInputStreams = 0;\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AC2B9C3D3C\n\tfor ;\n\tWed, 21 Oct 2020 13:10:26 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 429D761DAB;\n\tWed, 21 Oct 2020 15:10:26 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 94A8560CDD\n\tfor ;\n\tWed, 21 Oct 2020 15:10:24 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E8F3392;\n\tWed, 21 Oct 2020 15:10:23 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"I5QNupSB\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1603285824;\n\tbh=se9OC6T0VxIBHulPEEwT0afCKVQwmdPrNW1LPrKH8VM=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=I5QNupSBJeH808VpztJHDKk9ldkuzDVhqtpRniSwoT2iGQymCcVST6xZq0VCbpsJb\n\t2a/74/H1zWO2ELZbR+oUeG4vWVwTH4uoSPDm80nAV7cXJldJQIOLg2FEifrLNgzXYO\n\t/jeXKKHPgXJM0AouUrlKxuYAgdOTgaM7v+mzbhaA=","To":"Jacopo Mondi , libcamera-devel@lists.libcamera.org","References":"<20201020180534.36855-1-jacopo@jmondi.org>\n\t<20201020180534.36855-11-jacopo@jmondi.org>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<708e7c7d-828f-82ee-e0b6-5980768d975a@ideasonboard.com>","Date":"Wed, 21 Oct 2020 14:10:19 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20201020180534.36855-11-jacopo@jmondi.org>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH v2 10/13] android: camera_device:\n\tReport PIPELINE_MAX_DEPTH","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13356,"web_url":"https://patchwork.libcamera.org/comment/13356/","msgid":"<20201021135640.hqqzc7mbm23ytz4h@uno.localdomain>","date":"2020-10-21T13:56:40","subject":"Re: [libcamera-devel] [PATCH v2 10/13] android: camera_device:\n\tReport PIPELINE_MAX_DEPTH","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Kieran\n\nOn Wed, Oct 21, 2020 at 02:10:19PM +0100, Kieran Bingham wrote:\n> On 20/10/2020 19:05, Jacopo Mondi wrote:\n> > Register the ANDROID_REQUEST_PIPELINE_MAX_DEPTH static property\n> > inspecting the value reported by the pipeline handler.\n> >\n> > If the Camera does not report any suitable value, default the\n> > static property to 2.\n> >\n> > Signed-off-by: Jacopo Mondi \n> > ---\n> > src/android/camera_device.cpp | 15 ++++++++++++---\n> > 1 file changed, 12 insertions(+), 3 deletions(-)\n> >\n> > diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> > index e9404c2f3004..8166b09bb69a 100644\n> > --- a/src/android/camera_device.cpp\n> > +++ b/src/android/camera_device.cpp\n> > @@ -13,6 +13,7 @@\n> > #include \n> > #include \n> >\n> > +#include \n> > #include \n> > #include \n> > #include \n> > @@ -591,6 +592,8 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n> > \t\treturn nullptr;\n> > \t}\n> >\n> > +\tconst ControlInfoMap &controlsInfo = camera_->controls();\n> > +\n> > \t/* Color correction static metadata. */\n> > \tstd::vector aberrationModes = {\n> > \t\tANDROID_COLOR_CORRECTION_ABERRATION_MODE_OFF,\n> > @@ -882,9 +885,15 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n> > \tstaticMetadata_->addEntry(ANDROID_REQUEST_PARTIAL_RESULT_COUNT,\n> > \t\t\t\t &partialResultCount, 1);\n> >\n> > -\tuint8_t maxPipelineDepth = 2;\n> > -\tstaticMetadata_->addEntry(ANDROID_REQUEST_PIPELINE_MAX_DEPTH,\n> > -\t\t\t\t &maxPipelineDepth, 1);\n> > +\t{\n> > +\t\t/* Default the value to 2 if not reported by the camera. */\n> > +\t\tuint8_t maxPipelineDepth = 2;\n> > +\t\tconst auto &infoMap = controlsInfo.find(&controls::draft::PipelineDepth);\n> > +\t\tif (infoMap != controlsInfo.end())\n> > +\t\t\tmaxPipelineDepth = infoMap->second.max().get();\n>\n> I would certainly put a new line here, and possibly/probably before the\n> if statement too. Otherwise it's disguising the scope of the condition IMO.\n>\n>\n> Should we print any kind of a warning if the pipeline handler has not\n> reported this control?\n\nI don't think so. According to the discussion we had on the previous\nseries pipeline handler should not be concerned with android\nspecificities.\n\n>\n> I could foresee this being a repeated pattern. Not sure how to best\n> handle that yet though.\n>\n> But for now,\n>\n> Reviewed-by: Kieran Bingham \n>\n> > +\t\tstaticMetadata_->addEntry(ANDROID_REQUEST_PIPELINE_MAX_DEPTH,\n> > +\t\t\t\t\t &maxPipelineDepth, 1);\n> > +\t}\n> >\n> > \t/* LIMITED does not support reprocessing. */\n> > \tuint32_t maxNumInputStreams = 0;\n> >\n>\n> --\n> Regards\n> --\n> Kieran","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 998FDC3D3C\n\tfor ;\n\tWed, 21 Oct 2020 13:56:45 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1037561E0D;\n\tWed, 21 Oct 2020 15:56:45 +0200 (CEST)","from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net\n\t[217.70.183.199])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E3C8961DDB\n\tfor ;\n\tWed, 21 Oct 2020 15:56:42 +0200 (CEST)","from uno.localdomain (93-34-118-233.ip49.fastwebnet.it\n\t[93.34.118.233]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 70B09FF802;\n\tWed, 21 Oct 2020 13:56:42 +0000 (UTC)"],"X-Originating-IP":"93.34.118.233","Date":"Wed, 21 Oct 2020 15:56:40 +0200","From":"Jacopo Mondi ","To":"Kieran Bingham ","Message-ID":"<20201021135640.hqqzc7mbm23ytz4h@uno.localdomain>","References":"<20201020180534.36855-1-jacopo@jmondi.org>\n\t<20201020180534.36855-11-jacopo@jmondi.org>\n\t<708e7c7d-828f-82ee-e0b6-5980768d975a@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<708e7c7d-828f-82ee-e0b6-5980768d975a@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2 10/13] android: camera_device:\n\tReport PIPELINE_MAX_DEPTH","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]