{"id":10141,"url":"https://patchwork.libcamera.org/api/patches/10141/?format=json","web_url":"https://patchwork.libcamera.org/patch/10141/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20201020180534.36855-9-jacopo@jmondi.org>","date":"2020-10-20T18:05:29","name":"[libcamera-devel,v2,08/13] libcamera: ipu3: Register camera controls","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"e688d179bfffcd398d7c5b57c2f04760ffdd4b84","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/10141/mbox/","series":[{"id":1391,"url":"https://patchwork.libcamera.org/api/series/1391/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1391","date":"2020-10-20T18:05:21","name":"libcamera: Introduce draft controls","version":2,"mbox":"https://patchwork.libcamera.org/series/1391/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/10141/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/10141/checks/","tags":{},"headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B6DD9BDB1F\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 20 Oct 2020 16:05:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8DCF061DEB;\n\tTue, 20 Oct 2020 18:05:23 +0200 (CEST)","from relay10.mail.gandi.net (relay10.mail.gandi.net\n\t[217.70.178.230])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A9A8B61DDD\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 20 Oct 2020 18:05:19 +0200 (CEST)","from uno.lan (93-34-118-233.ip49.fastwebnet.it [93.34.118.233])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay10.mail.gandi.net (Postfix) with ESMTPSA id 4658A240009;\n\tTue, 20 Oct 2020 16:05:19 +0000 (UTC)"],"From":"Jacopo Mondi <jacopo@jmondi.org>","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 20 Oct 2020 20:05:29 +0200","Message-Id":"<20201020180534.36855-9-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.28.0","In-Reply-To":"<20201020180534.36855-1-jacopo@jmondi.org>","References":"<20201020180534.36855-1-jacopo@jmondi.org>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v2 08/13] libcamera: ipu3: Register camera\n\tcontrols","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"Register controls for the IPU3 pipeline handler. The only supported\nCamera control is currently the pipeline depth control.\n\nReport the minimum and maximum values the pipeline handler supports\nfor the pipeline processing stages.\n\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n src/libcamera/pipeline/ipu3/ipu3.cpp | 7 +++++++\n 1 file changed, 7 insertions(+)","diff":"diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\nindex af47739d8d4f..4cbd7ba3007b 100644\n--- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n@@ -12,6 +12,7 @@\n #include <vector>\n \n #include <libcamera/camera.h>\n+#include <libcamera/control_ids.h>\n #include <libcamera/formats.h>\n #include <libcamera/request.h>\n #include <libcamera/stream.h>\n@@ -40,6 +41,10 @@ static constexpr unsigned int IMGU_OUTPUT_HEIGHT_ALIGN = 4;\n static constexpr unsigned int IMGU_OUTPUT_WIDTH_MARGIN = 64;\n static constexpr unsigned int IMGU_OUTPUT_HEIGHT_MARGIN = 32;\n \n+static const ControlInfoMap IPU3Controls = {\n+\t{ &controls::draft::PipelineDepth, ControlInfo(2, 3) },\n+};\n+\n class IPU3CameraData : public CameraData\n {\n public:\n@@ -770,6 +775,8 @@ int PipelineHandlerIPU3::registerCameras()\n \n \t\t/* Initialize the camera properties. */\n \t\tdata->properties_ = cio2->sensor()->properties();\n+\t\t/* Initialze the camera controls. */\n+\t\tdata->controlInfo_ = IPU3Controls;\n \n \t\t/**\n \t\t * \\todo Dynamically assign ImgU and output devices to each\n","prefixes":["libcamera-devel","v2","08/13"]}