[{"id":13339,"web_url":"https://patchwork.libcamera.org/comment/13339/","msgid":"","date":"2020-10-21T13:00:28","subject":"Re: [libcamera-devel] [PATCH v2 06/13] ipa: raspberry: Initialize\n\tControlInfo with values list","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Jacopo,\n\nOn 20/10/2020 19:05, Jacopo Mondi wrote:\n> Initialize the ControlInfoMap of controls supported by the Raspberry\n> pipeline handler and IPA using the list of the enumerated values instead\n> of specifying them manually.\n> \n\nNice!\n\nAside from the post-fix naming, which is probably just a matter of taste\nand can be determined in the previous patch...\n\nThis really is powerful. Suddenly the ControlInfo actually becomes much\nmore strongly typed.\n\nReviewed-by: Kieran Bingham \n\n> Signed-off-by: Jacopo Mondi \n> ---\n> include/libcamera/ipa/raspberrypi.h | 8 ++++----\n> 1 file changed, 4 insertions(+), 4 deletions(-)\n> \n> diff --git a/include/libcamera/ipa/raspberrypi.h b/include/libcamera/ipa/raspberrypi.h\n> index b23baf2f1330..414d757a06c6 100644\n> --- a/include/libcamera/ipa/raspberrypi.h\n> +++ b/include/libcamera/ipa/raspberrypi.h\n> @@ -50,13 +50,13 @@ static const ControlInfoMap Controls = {\n> \t{ &controls::AeEnable, ControlInfo(false, true) },\n> \t{ &controls::ExposureTime, ControlInfo(0, 999999) },\n> \t{ &controls::AnalogueGain, ControlInfo(1.0f, 32.0f) },\n> -\t{ &controls::AeMeteringMode, ControlInfo(0, static_cast(controls::MeteringModeMax)) },\n> -\t{ &controls::AeConstraintMode, ControlInfo(0, static_cast(controls::ConstraintModeMax)) },\n> -\t{ &controls::AeExposureMode, ControlInfo(0, static_cast(controls::ExposureModeMax)) },\n> +\t{ &controls::AeMeteringMode, ControlInfo(controls::AeMeteringModeList) },\n> +\t{ &controls::AeConstraintMode, ControlInfo(controls::AeConstraintModeList) },\n> +\t{ &controls::AeExposureMode, ControlInfo(controls::AeExposureModeList) },\n> \t{ &controls::ExposureValue, ControlInfo(0.0f, 16.0f) },\n> \t{ &controls::AwbEnable, ControlInfo(false, true) },\n> \t{ &controls::ColourGains, ControlInfo(0.0f, 32.0f) },\n> -\t{ &controls::AwbMode, ControlInfo(0, static_cast(controls::AwbModeMax)) },\n> +\t{ &controls::AwbMode, ControlInfo(controls::AwbModeList) },\n> \t{ &controls::Brightness, ControlInfo(-1.0f, 1.0f) },\n> \t{ &controls::Contrast, ControlInfo(0.0f, 32.0f) },\n> \t{ &controls::Saturation, ControlInfo(0.0f, 32.0f) },\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E67C3C3D3C\n\tfor ;\n\tWed, 21 Oct 2020 13:00:32 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7C5AD60CE0;\n\tWed, 21 Oct 2020 15:00:32 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1874460CDD\n\tfor ;\n\tWed, 21 Oct 2020 15:00:31 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8C85F92;\n\tWed, 21 Oct 2020 15:00:30 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ul9BsrQr\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1603285230;\n\tbh=AGOlV1jPVQ4UuLSWy034If6nC6aDLCO9vHm9fTO18Eo=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=ul9BsrQrNnZ07fTsuccYPnbMEut6FMt+TulKXjpZK0zLB1H+vau9w4x7P/ub0SA6c\n\tIaURjcIBtqRTjHn7x6lDhTolgp08y8azA/R/7PXYTiBw1zB9o5Qnefoxz4HwVl0Uu1\n\tgzhPi91ITjxp4iub/YiDOt0kN7FgwWv3efFQ5Ncw=","To":"Jacopo Mondi , libcamera-devel@lists.libcamera.org","References":"<20201020180534.36855-1-jacopo@jmondi.org>\n\t<20201020180534.36855-7-jacopo@jmondi.org>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"","Date":"Wed, 21 Oct 2020 14:00:28 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20201020180534.36855-7-jacopo@jmondi.org>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH v2 06/13] ipa: raspberry: Initialize\n\tControlInfo with values list","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13354,"web_url":"https://patchwork.libcamera.org/comment/13354/","msgid":"<20201021134313.aaqbrlpzg4kchu43@uno.localdomain>","date":"2020-10-21T13:43:13","subject":"Re: [libcamera-devel] [PATCH v2 06/13] ipa: raspberry: Initialize\n\tControlInfo with values list","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"On Wed, Oct 21, 2020 at 02:00:28PM +0100, Kieran Bingham wrote:\n> Hi Jacopo,\n>\n> On 20/10/2020 19:05, Jacopo Mondi wrote:\n> > Initialize the ControlInfoMap of controls supported by the Raspberry\n> > pipeline handler and IPA using the list of the enumerated values instead\n> > of specifying them manually.\n> >\n>\n> Nice!\n>\n> Aside from the post-fix naming, which is probably just a matter of taste\n> and can be determined in the previous patch...\n>\n> This really is powerful. Suddenly the ControlInfo actually becomes much\n> more strongly typed.\n\nIt could be probably be even made shorter with a macro of some kind:\n\nTo replace this:\n { &controls::AeExposureMode, ControlInfo(controls::AeExposureModeList) },\n\nwith:\n#define CONTROL_INFO_ALL_VALUES(_ctrl) \\\n { &controls::##_ctrl, ControlInfo(controls::##_ctrl##List) },\n\nBut for now I think it's ok!\n\n>\n> Reviewed-by: Kieran Bingham \n>\n> > Signed-off-by: Jacopo Mondi \n> > ---\n> > include/libcamera/ipa/raspberrypi.h | 8 ++++----\n> > 1 file changed, 4 insertions(+), 4 deletions(-)\n> >\n> > diff --git a/include/libcamera/ipa/raspberrypi.h b/include/libcamera/ipa/raspberrypi.h\n> > index b23baf2f1330..414d757a06c6 100644\n> > --- a/include/libcamera/ipa/raspberrypi.h\n> > +++ b/include/libcamera/ipa/raspberrypi.h\n> > @@ -50,13 +50,13 @@ static const ControlInfoMap Controls = {\n> > \t{ &controls::AeEnable, ControlInfo(false, true) },\n> > \t{ &controls::ExposureTime, ControlInfo(0, 999999) },\n> > \t{ &controls::AnalogueGain, ControlInfo(1.0f, 32.0f) },\n> > -\t{ &controls::AeMeteringMode, ControlInfo(0, static_cast(controls::MeteringModeMax)) },\n> > -\t{ &controls::AeConstraintMode, ControlInfo(0, static_cast(controls::ConstraintModeMax)) },\n> > -\t{ &controls::AeExposureMode, ControlInfo(0, static_cast(controls::ExposureModeMax)) },\n> > +\t{ &controls::AeMeteringMode, ControlInfo(controls::AeMeteringModeList) },\n> > +\t{ &controls::AeConstraintMode, ControlInfo(controls::AeConstraintModeList) },\n> > +\t{ &controls::AeExposureMode, ControlInfo(controls::AeExposureModeList) },\n> > \t{ &controls::ExposureValue, ControlInfo(0.0f, 16.0f) },\n> > \t{ &controls::AwbEnable, ControlInfo(false, true) },\n> > \t{ &controls::ColourGains, ControlInfo(0.0f, 32.0f) },\n> > -\t{ &controls::AwbMode, ControlInfo(0, static_cast(controls::AwbModeMax)) },\n> > +\t{ &controls::AwbMode, ControlInfo(controls::AwbModeList) },\n> > \t{ &controls::Brightness, ControlInfo(-1.0f, 1.0f) },\n> > \t{ &controls::Contrast, ControlInfo(0.0f, 32.0f) },\n> > \t{ &controls::Saturation, ControlInfo(0.0f, 32.0f) },\n> >\n>\n> --\n> Regards\n> --\n> Kieran","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 727D0C3D3C\n\tfor ;\n\tWed, 21 Oct 2020 13:43:18 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DED5961DF5;\n\tWed, 21 Oct 2020 15:43:17 +0200 (CEST)","from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net\n\t[217.70.183.194])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E0DC561DAB\n\tfor ;\n\tWed, 21 Oct 2020 15:43:15 +0200 (CEST)","from uno.localdomain (93-34-118-233.ip49.fastwebnet.it\n\t[93.34.118.233]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 757BC40009;\n\tWed, 21 Oct 2020 13:43:15 +0000 (UTC)"],"X-Originating-IP":"93.34.118.233","Date":"Wed, 21 Oct 2020 15:43:13 +0200","From":"Jacopo Mondi ","To":"Kieran Bingham ","Message-ID":"<20201021134313.aaqbrlpzg4kchu43@uno.localdomain>","References":"<20201020180534.36855-1-jacopo@jmondi.org>\n\t<20201020180534.36855-7-jacopo@jmondi.org>\n\t","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH v2 06/13] ipa: raspberry: Initialize\n\tControlInfo with values list","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]