[{"id":13338,"web_url":"https://patchwork.libcamera.org/comment/13338/","msgid":"<088a6332-1299-912e-c769-a7ae21003901@ideasonboard.com>","date":"2020-10-21T12:58:17","subject":"Re: [libcamera-devel] [PATCH v2 05/13] libcamera: controls:\n\tGenerate a vector of enumerated values","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Jacopo,\n\nOn 20/10/2020 19:05, Jacopo Mondi wrote:\n> For each Control that support enumerated values generate a vector\n> of ControlValues which contains the full list of values.\n> \n> At the expense of a slight increase in memory occupation this change\n> allows the construction of the ControlInfo associated with a Control\n> from the values list, defaulting the minimum and maximum values\n> reported by the ControlInfo.\n> \n\nPersonally I think this is a good way to handle this data.\n\n\n> Signed-off-by: Jacopo Mondi \n> ---\n> src/libcamera/control_ids.cpp.in | 2 ++\n> utils/gen-controls.py | 10 ++++++++++\n> 2 files changed, 12 insertions(+)\n> \n> diff --git a/src/libcamera/control_ids.cpp.in b/src/libcamera/control_ids.cpp.in\n> index 056645cfbdfb..ca0b5b22f899 100644\n> --- a/src/libcamera/control_ids.cpp.in\n> +++ b/src/libcamera/control_ids.cpp.in\n> @@ -6,8 +6,10 @@\n> *\n> * This file is auto-generated. Do not edit.\n> */\n> +#include \n> \n> #include \n> +#include \n> \n> /**\n> * \\file control_ids.h\n> diff --git a/utils/gen-controls.py b/utils/gen-controls.py\n> index 93cb3885c3da..87036fe7dec1 100755\n> --- a/utils/gen-controls.py\n> +++ b/utils/gen-controls.py\n> @@ -100,6 +100,8 @@ ${description}\n> def generate_h(controls):\n> enum_template_start = string.Template('''enum ${name}Values {''')\n> enum_value_template = string.Template('''\\t${name} = ${value},''')\n> + enum_list_start = string.Template('''static const std::vector ${name}List = {''')\n\n'List' appended to the name feels a bit odd.\n\nSeeing the usage in the next patch,:\n\n&controls::AeMeteringMode, ControlInfo(controls::AeMeteringModeList)\n&controls::AeConstraintMode, ControlInfo(controls::AeConstraintModeList)\n&controls::AeExposureMode, ControlInfo(controls::AeExposureModeList)\n\nThrowing alternatives in to the bikeshed, because that's all it is, this\ncould be 'Values' or 'Enum' on the end.\n\nTo me, List could end up being a list of strings, or floats, or anything.\n\nValues, could also be ... arbitrary numerical values, but matches the\nname in the ControlInfo\n\nEnum ... will be integer values ...\n\n\nBikeshed colours aside:\n\nReviewed-by: Kieran Bingham \n\n> + enum_list_values = string.Template('''\\tstatic_cast(${name}),''')\n> template = string.Template('''extern const Control<${type}> ${name};''')\n> \n> ctrls = []\n> @@ -140,6 +142,14 @@ def generate_h(controls):\n> target_ctrls.append(enum_value_template.substitute(value_info))\n> target_ctrls.append(\"};\")\n> \n> + target_ctrls.append(enum_list_start.substitute(info))\n> + for entry in enum:\n> + value_info = {\n> + 'name': entry['name'],\n> + }\n> + target_ctrls.append(enum_list_values.substitute(value_info))\n> + target_ctrls.append(\"};\")\n> +\n> target_ctrls.append(template.substitute(info))\n> id_value += 1\n> \n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2D49DC3D3C\n\tfor ;\n\tWed, 21 Oct 2020 12:58:21 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B63BB61DAB;\n\tWed, 21 Oct 2020 14:58:20 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3AD8E60CDD\n\tfor ;\n\tWed, 21 Oct 2020 14:58:20 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BB89992;\n\tWed, 21 Oct 2020 14:58:19 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"JgNY70ul\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1603285099;\n\tbh=1zT0SLvT6BFoQvedhxH+hooKSQafn6Q66G327UX3jII=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=JgNY70ulTOpZ18r6rqjQ8X8d9L9/MifRVcIWeQMtDHvAPoRNHR0aNcwjfisCdYman\n\tSynuwATVquCnbiXELpfIPgEbnlUzEgIjFAHt+HZhFiBFEnoiLA69d3NCNiW+g9xk1n\n\tSTc1mj7QzZPVkx33+mcleuHItEj8qOyscWA7IfH0=","To":"Jacopo Mondi , libcamera-devel@lists.libcamera.org","References":"<20201020180534.36855-1-jacopo@jmondi.org>\n\t<20201020180534.36855-6-jacopo@jmondi.org>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<088a6332-1299-912e-c769-a7ae21003901@ideasonboard.com>","Date":"Wed, 21 Oct 2020 13:58:17 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20201020180534.36855-6-jacopo@jmondi.org>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH v2 05/13] libcamera: controls:\n\tGenerate a vector of enumerated values","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13353,"web_url":"https://patchwork.libcamera.org/comment/13353/","msgid":"<20201021134025.etykav34xt4wa7uh@uno.localdomain>","date":"2020-10-21T13:40:25","subject":"Re: [libcamera-devel] [PATCH v2 05/13] libcamera: controls:\n\tGenerate a vector of enumerated values","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Kieran,\n\nOn Wed, Oct 21, 2020 at 01:58:17PM +0100, Kieran Bingham wrote:\n> Hi Jacopo,\n>\n> On 20/10/2020 19:05, Jacopo Mondi wrote:\n> > For each Control that support enumerated values generate a vector\n> > of ControlValues which contains the full list of values.\n> >\n> > At the expense of a slight increase in memory occupation this change\n> > allows the construction of the ControlInfo associated with a Control\n> > from the values list, defaulting the minimum and maximum values\n> > reported by the ControlInfo.\n> >\n>\n> Personally I think this is a good way to handle this data.\n>\n>\n> > Signed-off-by: Jacopo Mondi \n> > ---\n> > src/libcamera/control_ids.cpp.in | 2 ++\n> > utils/gen-controls.py | 10 ++++++++++\n> > 2 files changed, 12 insertions(+)\n> >\n> > diff --git a/src/libcamera/control_ids.cpp.in b/src/libcamera/control_ids.cpp.in\n> > index 056645cfbdfb..ca0b5b22f899 100644\n> > --- a/src/libcamera/control_ids.cpp.in\n> > +++ b/src/libcamera/control_ids.cpp.in\n> > @@ -6,8 +6,10 @@\n> > *\n> > * This file is auto-generated. Do not edit.\n> > */\n> > +#include \n> >\n> > #include \n> > +#include \n> >\n> > /**\n> > * \\file control_ids.h\n> > diff --git a/utils/gen-controls.py b/utils/gen-controls.py\n> > index 93cb3885c3da..87036fe7dec1 100755\n> > --- a/utils/gen-controls.py\n> > +++ b/utils/gen-controls.py\n> > @@ -100,6 +100,8 @@ ${description}\n> > def generate_h(controls):\n> > enum_template_start = string.Template('''enum ${name}Values {''')\n> > enum_value_template = string.Template('''\\t${name} = ${value},''')\n> > + enum_list_start = string.Template('''static const std::vector ${name}List = {''')\n>\n> 'List' appended to the name feels a bit odd.\n>\n> Seeing the usage in the next patch,:\n>\n> &controls::AeMeteringMode, ControlInfo(controls::AeMeteringModeList)\n> &controls::AeConstraintMode, ControlInfo(controls::AeConstraintModeList)\n> &controls::AeExposureMode, ControlInfo(controls::AeExposureModeList)\n>\n> Throwing alternatives in to the bikeshed, because that's all it is, this\n> could be 'Values' or 'Enum' on the end.\n>\n\n'Values' is taken as you can see a few lines above\nI'm not excited by 'Enum' to be honest\n\nWhat if we rename the value enumeration with 'Value' and the vector\n'Values' :\n\nenum ControlXYZValue {\n ControlXYZOne,\n ControlXYZTwo,\n ControlXYZThree,\n};\nstatic const std::vector ControlXYZValues = {\n static_cast(ControlXYZOne),\n static_cast(ControlXYZTwo),\n static_cast(ControlXYZThree),\n};\n\n> To me, List could end up being a list of strings, or floats, or anything.\n>\n> Values, could also be ... arbitrary numerical values, but matches the\n> name in the ControlInfo\n>\n> Enum ... will be integer values ...\n>\n>\n> Bikeshed colours aside:\n>\n> Reviewed-by: Kieran Bingham \n>\n\nThanks\n j\n\n> > + enum_list_values = string.Template('''\\tstatic_cast(${name}),''')\n> > template = string.Template('''extern const Control<${type}> ${name};''')\n> >\n> > ctrls = []\n> > @@ -140,6 +142,14 @@ def generate_h(controls):\n> > target_ctrls.append(enum_value_template.substitute(value_info))\n> > target_ctrls.append(\"};\")\n> >\n> > + target_ctrls.append(enum_list_start.substitute(info))\n> > + for entry in enum:\n> > + value_info = {\n> > + 'name': entry['name'],\n> > + }\n> > + target_ctrls.append(enum_list_values.substitute(value_info))\n> > + target_ctrls.append(\"};\")\n> > +\n> > target_ctrls.append(template.substitute(info))\n> > id_value += 1\n> >\n> >\n>\n> --\n> Regards\n> --\n> Kieran","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EB21BBDB13\n\tfor ;\n\tWed, 21 Oct 2020 13:40:28 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8614761DC5;\n\tWed, 21 Oct 2020 15:40:28 +0200 (CEST)","from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net\n\t[217.70.183.194])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 53E8761DAB\n\tfor ;\n\tWed, 21 Oct 2020 15:40:27 +0200 (CEST)","from uno.localdomain (93-34-118-233.ip49.fastwebnet.it\n\t[93.34.118.233]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay2-d.mail.gandi.net (Postfix) with ESMTPSA id DEB1C40007;\n\tWed, 21 Oct 2020 13:40:26 +0000 (UTC)"],"X-Originating-IP":"93.34.118.233","Date":"Wed, 21 Oct 2020 15:40:25 +0200","From":"Jacopo Mondi ","To":"Kieran Bingham ","Message-ID":"<20201021134025.etykav34xt4wa7uh@uno.localdomain>","References":"<20201020180534.36855-1-jacopo@jmondi.org>\n\t<20201020180534.36855-6-jacopo@jmondi.org>\n\t<088a6332-1299-912e-c769-a7ae21003901@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<088a6332-1299-912e-c769-a7ae21003901@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2 05/13] libcamera: controls:\n\tGenerate a vector of enumerated values","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13355,"web_url":"https://patchwork.libcamera.org/comment/13355/","msgid":"<0fa5e1fe-1c4d-6409-a1c7-d0dd2557d91f@ideasonboard.com>","date":"2020-10-21T13:51:17","subject":"Re: [libcamera-devel] [PATCH v2 05/13] libcamera: controls:\n\tGenerate a vector of enumerated values","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Jacopo,\n\n\nOn 21/10/2020 14:40, Jacopo Mondi wrote:\n> Hi Kieran,\n> \n> On Wed, Oct 21, 2020 at 01:58:17PM +0100, Kieran Bingham wrote:\n>> Hi Jacopo,\n>>\n>> On 20/10/2020 19:05, Jacopo Mondi wrote:\n>>> For each Control that support enumerated values generate a vector\n>>> of ControlValues which contains the full list of values.\n>>>\n>>> At the expense of a slight increase in memory occupation this change\n>>> allows the construction of the ControlInfo associated with a Control\n>>> from the values list, defaulting the minimum and maximum values\n>>> reported by the ControlInfo.\n>>>\n>>\n>> Personally I think this is a good way to handle this data.\n>>\n>>\n>>> Signed-off-by: Jacopo Mondi \n>>> ---\n>>> src/libcamera/control_ids.cpp.in | 2 ++\n>>> utils/gen-controls.py | 10 ++++++++++\n>>> 2 files changed, 12 insertions(+)\n>>>\n>>> diff --git a/src/libcamera/control_ids.cpp.in b/src/libcamera/control_ids.cpp.in\n>>> index 056645cfbdfb..ca0b5b22f899 100644\n>>> --- a/src/libcamera/control_ids.cpp.in\n>>> +++ b/src/libcamera/control_ids.cpp.in\n>>> @@ -6,8 +6,10 @@\n>>> *\n>>> * This file is auto-generated. Do not edit.\n>>> */\n>>> +#include \n>>>\n>>> #include \n>>> +#include \n>>>\n>>> /**\n>>> * \\file control_ids.h\n>>> diff --git a/utils/gen-controls.py b/utils/gen-controls.py\n>>> index 93cb3885c3da..87036fe7dec1 100755\n>>> --- a/utils/gen-controls.py\n>>> +++ b/utils/gen-controls.py\n>>> @@ -100,6 +100,8 @@ ${description}\n>>> def generate_h(controls):\n>>> enum_template_start = string.Template('''enum ${name}Values {''')\n>>> enum_value_template = string.Template('''\\t${name} = ${value},''')\n>>> + enum_list_start = string.Template('''static const std::vector ${name}List = {''')\n>>\n>> 'List' appended to the name feels a bit odd.\n>>\n>> Seeing the usage in the next patch,:\n>>\n>> &controls::AeMeteringMode, ControlInfo(controls::AeMeteringModeList)\n>> &controls::AeConstraintMode, ControlInfo(controls::AeConstraintModeList)\n>> &controls::AeExposureMode, ControlInfo(controls::AeExposureModeList)\n>>\n>> Throwing alternatives in to the bikeshed, because that's all it is, this\n>> could be 'Values' or 'Enum' on the end.\n>>\n> \n> 'Values' is taken as you can see a few lines above\n> I'm not excited by 'Enum' to be honest\n> \n> What if we rename the value enumeration with 'Value' and the vector\n> 'Values' :\n\nOr rename the enum to Enum,\n\n> \n> enum ControlXYZValue {\n\nenum ControlXYZEnum {\n\n?\n--\nKieran\n\n> ControlXYZOne,\n> ControlXYZTwo,\n> ControlXYZThree,\n> };\n\n> static const std::vector ControlXYZValues = {\n> static_cast(ControlXYZOne),\n> static_cast(ControlXYZTwo),\n> static_cast(ControlXYZThree),\n> };\n> \n>> To me, List could end up being a list of strings, or floats, or anything.\n>>\n>> Values, could also be ... arbitrary numerical values, but matches the\n>> name in the ControlInfo\n>>\n>> Enum ... will be integer values ...\n>>\n>>\n>> Bikeshed colours aside:\n>>\n>> Reviewed-by: Kieran Bingham \n>>\n> \n> Thanks\n> j\n> \n>>> + enum_list_values = string.Template('''\\tstatic_cast(${name}),''')\n>>> template = string.Template('''extern const Control<${type}> ${name};''')\n>>>\n>>> ctrls = []\n>>> @@ -140,6 +142,14 @@ def generate_h(controls):\n>>> target_ctrls.append(enum_value_template.substitute(value_info))\n>>> target_ctrls.append(\"};\")\n>>>\n>>> + target_ctrls.append(enum_list_start.substitute(info))\n>>> + for entry in enum:\n>>> + value_info = {\n>>> + 'name': entry['name'],\n>>> + }\n>>> + target_ctrls.append(enum_list_values.substitute(value_info))\n>>> + target_ctrls.append(\"};\")\n>>> +\n>>> target_ctrls.append(template.substitute(info))\n>>> id_value += 1\n>>>\n>>>\n>>\n>> --\n>> Regards\n>> --\n>> Kieran","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 82227BDB13\n\tfor ;\n\tWed, 21 Oct 2020 13:51:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0801561DF5;\n\tWed, 21 Oct 2020 15:51:23 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A3D5861DAB\n\tfor ;\n\tWed, 21 Oct 2020 15:51:21 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DA90592;\n\tWed, 21 Oct 2020 15:51:20 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ChoKR2Ss\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1603288281;\n\tbh=Oy4vQ2rY4bA/ForWMOPPehTsS/O4zKp9rui8fB2YeA8=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=ChoKR2SsEgv9xgnMbLY33IdYVofP2RsvPA4CReBL50ohCtlOrRKw0QotcuriSuChw\n\tjCqPRc/adYg4MusLNpnElizT9oSLcpT1rRItU9ElEcAV423oKCRLkV9vaPUBxGu6V5\n\tF3JdeGfIV6PQyLKBaBUH8rBs+EdvYTIfvIby1DKA=","To":"Jacopo Mondi ","References":"<20201020180534.36855-1-jacopo@jmondi.org>\n\t<20201020180534.36855-6-jacopo@jmondi.org>\n\t<088a6332-1299-912e-c769-a7ae21003901@ideasonboard.com>\n\t<20201021134025.etykav34xt4wa7uh@uno.localdomain>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<0fa5e1fe-1c4d-6409-a1c7-d0dd2557d91f@ideasonboard.com>","Date":"Wed, 21 Oct 2020 14:51:17 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20201021134025.etykav34xt4wa7uh@uno.localdomain>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH v2 05/13] libcamera: controls:\n\tGenerate a vector of enumerated values","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]