[{"id":13287,"web_url":"https://patchwork.libcamera.org/comment/13287/","msgid":"<2dc8ebfb-b06c-7df6-51cd-776f73bbcc72@ideasonboard.com>","date":"2020-10-20T10:07:01","subject":"Re: [libcamera-devel] [PATCH v2 8/8] meson: Enable -Wextra-semi for\n\tclang","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Hiro,\n\nOn 20/10/2020 10:15, Hirokazu Honda wrote:\n> The option, -Wextra-semi, helps developers to find unnecessary\n> semicolons. This option is available with clang.\n> \n> Signed-off-by: Hirokazu Honda \n> Reviewed-by: Laurent Pinchart \n\nSo I only actually had comments on 6/8.\n\nFor this and all other patches in this series:\nReviewed-by: Kieran Bingham \n\n> ---\n> meson.build | 4 ++++\n> 1 file changed, 4 insertions(+)\n> \n> diff --git a/meson.build b/meson.build\n> index de15cc1..b0c17d3 100644\n> --- a/meson.build\n> +++ b/meson.build\n> @@ -64,6 +64,10 @@ if cc.get_id() == 'clang'\n> '-stdlib=libc++',\n> ]\n> endif\n> +\n> + cpp_arguments += [\n> + '-Wextra-semi',\n> + ]\n> endif\n> \n> if cc.get_id() == 'gcc'\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 19035BDB13\n\tfor ;\n\tTue, 20 Oct 2020 10:07:06 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DA33B61373;\n\tTue, 20 Oct 2020 12:07:05 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 662AF603AF\n\tfor ;\n\tTue, 20 Oct 2020 12:07:04 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EA87752;\n\tTue, 20 Oct 2020 12:07:03 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"QS7EZ+bj\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1603188424;\n\tbh=6D4vcgqiIoH2eH7qNI+s1RnkUl6EpScHRlATsySvQOo=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=QS7EZ+bjgDay1EikAMd70QNjvLmHKXCIooKdu3bDuqzyC4Ppz2bOVoOUtv1/FgXlX\n\tOPfbKwlv9PSkpotUMV5SMP7F38XW9ht2+EGK5LAgj3tUJmgLrYzvCiCECkQOGHmwi3\n\tuxF174YIePGE/ih2YSSKJM00H4nPGKBHUNukecYg=","To":"Hirokazu Honda , libcamera-devel@lists.libcamera.org","References":"<20201020091505.138898-1-hiroh@chromium.org>\n\t<20201020091505.138898-8-hiroh@chromium.org>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<2dc8ebfb-b06c-7df6-51cd-776f73bbcc72@ideasonboard.com>","Date":"Tue, 20 Oct 2020 11:07:01 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20201020091505.138898-8-hiroh@chromium.org>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH v2 8/8] meson: Enable -Wextra-semi for\n\tclang","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13309,"web_url":"https://patchwork.libcamera.org/comment/13309/","msgid":"","date":"2020-10-21T00:38:40","subject":"Re: [libcamera-devel] [PATCH v2 8/8] meson: Enable -Wextra-semi for\n\tclang","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/people/63/","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"content":"Thanks Kieran and Niklas for reviewing.\nThanks Laurent for pushing the series to master.\n\n\nOn Tue, Oct 20, 2020 at 7:07 PM Kieran Bingham\n wrote:\n>\n> Hi Hiro,\n>\n> On 20/10/2020 10:15, Hirokazu Honda wrote:\n> > The option, -Wextra-semi, helps developers to find unnecessary\n> > semicolons. This option is available with clang.\n> >\n> > Signed-off-by: Hirokazu Honda \n> > Reviewed-by: Laurent Pinchart \n>\n> So I only actually had comments on 6/8.\n>\n> For this and all other patches in this series:\n> Reviewed-by: Kieran Bingham \n>\n> > ---\n> > meson.build | 4 ++++\n> > 1 file changed, 4 insertions(+)\n> >\n> > diff --git a/meson.build b/meson.build\n> > index de15cc1..b0c17d3 100644\n> > --- a/meson.build\n> > +++ b/meson.build\n> > @@ -64,6 +64,10 @@ if cc.get_id() == 'clang'\n> > '-stdlib=libc++',\n> > ]\n> > endif\n> > +\n> > + cpp_arguments += [\n> > + '-Wextra-semi',\n> > + ]\n> > endif\n> >\n> > if cc.get_id() == 'gcc'\n> >\n>\n> --\n> Regards\n> --\n> Kieran","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1A927BDB13\n\tfor ;\n\tWed, 21 Oct 2020 00:38:56 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8FBFF61D9E;\n\tWed, 21 Oct 2020 02:38:55 +0200 (CEST)","from mail-ed1-x542.google.com (mail-ed1-x542.google.com\n\t[IPv6:2a00:1450:4864:20::542])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 23FBD60350\n\tfor ;\n\tWed, 21 Oct 2020 02:38:54 +0200 (CEST)","by mail-ed1-x542.google.com with SMTP id p13so615079edi.7\n\tfor ;\n\tTue, 20 Oct 2020 17:38:54 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"hHWlWbn1\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=OyCR2VsOTuO3bm4xNp2LNoOZXqiTu4HoQP2h8FIElpM=;\n\tb=hHWlWbn1OlUs4UN/nQBfWibRLQuQhgZ6rMSGrjp5JQKfDhr8tU6UJfGOnOyXEw1+7T\n\tKPdgvXLfIDLQuHFmvnF5oO6cnunAUqIGzrm1pr6uqWj0KKZAaHbT0fe101c/OmdC/fJM\n\tOAv7X4Wjl8XhADmKDYCpsW0BfELuQw9/Z3pcs=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=OyCR2VsOTuO3bm4xNp2LNoOZXqiTu4HoQP2h8FIElpM=;\n\tb=sadrTIaEa0YgF2GfRqFaXcMfWNO++3iUKOcuw5ul1OAfuXaVwt8UwVYD37TMd0injM\n\tDbZrhsGWhduBz3ZTKFll5OB8IPEFftB/eIi7WbTMkN++n6lgAfS3XpzzV0yA+prDj5Kd\n\tX9+StJlf2oJoGObd7vD2dOy3CWFAcCGIEdFEP94BKjxiEeqIhTnmDkz5SFlsWbBBmYCU\n\t+RB70hRgHK+R85Sy7200ldx5RnJWp3V3knuRMnWL6/+ylpBEjuLGu/gKzhQvErLzn06T\n\trxeHCRrHzU8imjFYnLlcR6eDC1kg3WLAT8K4k21qQ7JAnsBebD7Xdd5vAJRs2lsWvmEo\n\tHxyw==","X-Gm-Message-State":"AOAM532aChDnxSLTbY6SBVRHSQPUwkQwto6jo6dDALrTed49UpysnVEq\n\t8EJsxvpXQDHTYs4i4T5kQ669D7VNTuO/al+1DhL/Fw==","X-Google-Smtp-Source":"ABdhPJzJsWnlL2c2ZuSH4x2RCG91hZGzYOvyfnuv/WJ3OvLQmOyVSF0tdHzXDYtp1RnAT1ky5z7uhvuJ3gxXF99QDh0=","X-Received":"by 2002:a05:6402:22ae:: with SMTP id\n\tcx14mr549037edb.73.1603240731860; \n\tTue, 20 Oct 2020 17:38:51 -0700 (PDT)","MIME-Version":"1.0","References":"<20201020091505.138898-1-hiroh@chromium.org>\n\t<20201020091505.138898-8-hiroh@chromium.org>\n\t<2dc8ebfb-b06c-7df6-51cd-776f73bbcc72@ideasonboard.com>","In-Reply-To":"<2dc8ebfb-b06c-7df6-51cd-776f73bbcc72@ideasonboard.com>","From":"Hirokazu Honda ","Date":"Wed, 21 Oct 2020 09:38:40 +0900","Message-ID":"","To":"kieran.bingham@ideasonboard.com","Subject":"Re: [libcamera-devel] [PATCH v2 8/8] meson: Enable -Wextra-semi for\n\tclang","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]