[{"id":13285,"web_url":"https://patchwork.libcamera.org/comment/13285/","msgid":"<20201020100312.GM18688@pendragon.ideasonboard.com>","date":"2020-10-20T10:03:12","subject":"Re: [libcamera-devel] [PATCH v2 6/8] libcamera: Omit extra\n\tsemicolons","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Hiro-san,\n\nThank you for the patch.\n\nOn Tue, Oct 20, 2020 at 06:15:03PM +0900, Hirokazu Honda wrote:\n> The end semicolons with LOG_DEFINE_CATEGORY,\n> LOG_DECLARE_CATEGORY and REGISTER_PIPELINE_HANDLER are\n> unnecessary.\n> \n> Signed-off-by: Hirokazu Honda <hiroh@chromium.org>\n\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\n> ---\n>  Documentation/guides/pipeline-handler.rst             | 4 ++--\n>  src/libcamera/byte_stream_buffer.cpp                  | 2 +-\n>  src/libcamera/camera_sensor.cpp                       | 2 +-\n>  src/libcamera/file.cpp                                | 2 +-\n>  src/libcamera/pipeline/ipu3/ipu3.cpp                  | 4 ++--\n>  src/libcamera/pipeline/raspberrypi/raspberrypi.cpp    | 2 +-\n>  src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp | 2 +-\n>  src/libcamera/pipeline/rkisp1/rkisp1.cpp              | 2 +-\n>  src/libcamera/pipeline/simple/converter.cpp           | 2 +-\n>  src/libcamera/pipeline/simple/simple.cpp              | 2 +-\n>  src/libcamera/pipeline/uvcvideo/uvcvideo.cpp          | 2 +-\n>  src/libcamera/pipeline/vimc/vimc.cpp                  | 2 +-\n>  src/libcamera/sysfs.cpp                               | 2 +-\n>  13 files changed, 15 insertions(+), 15 deletions(-)\n> \n> diff --git a/Documentation/guides/pipeline-handler.rst b/Documentation/guides/pipeline-handler.rst\n> index 71ef205..d0370f1 100644\n> --- a/Documentation/guides/pipeline-handler.rst\n> +++ b/Documentation/guides/pipeline-handler.rst\n> @@ -258,7 +258,7 @@ methods for the overridden class members.\n>            return false;\n>     }\n>  \n> -   REGISTER_PIPELINE_HANDLER(PipelineHandlerVivid);\n> +   REGISTER_PIPELINE_HANDLER(PipelineHandlerVivid)\n>  \n>     } /* namespace libcamera */\n>  \n> @@ -1470,4 +1470,4 @@ application which will render the frames in a window for visual inspection:\n>  \n>  .. TODO: Running qcam with the vivid pipeline handler appears to have a bug and\n>           no visual frames are seen. However disabling zero-copy on qcam renders\n> -         them successfully.\n> \\ No newline at end of file\n> +         them successfully.\n> diff --git a/src/libcamera/byte_stream_buffer.cpp b/src/libcamera/byte_stream_buffer.cpp\n> index df7029b..7db5501 100644\n> --- a/src/libcamera/byte_stream_buffer.cpp\n> +++ b/src/libcamera/byte_stream_buffer.cpp\n> @@ -14,7 +14,7 @@\n>  \n>  namespace libcamera {\n>  \n> -LOG_DEFINE_CATEGORY(Serialization);\n> +LOG_DEFINE_CATEGORY(Serialization)\n>  \n>  /**\n>   * \\file byte_stream_buffer.h\n> diff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp\n> index 78c7cee..935de52 100644\n> --- a/src/libcamera/camera_sensor.cpp\n> +++ b/src/libcamera/camera_sensor.cpp\n> @@ -28,7 +28,7 @@\n>  \n>  namespace libcamera {\n>  \n> -LOG_DEFINE_CATEGORY(CameraSensor);\n> +LOG_DEFINE_CATEGORY(CameraSensor)\n>  \n>  /**\n>   * \\struct CameraSensorInfo\n> diff --git a/src/libcamera/file.cpp b/src/libcamera/file.cpp\n> index 04b0cb6..3a3f5bb 100644\n> --- a/src/libcamera/file.cpp\n> +++ b/src/libcamera/file.cpp\n> @@ -23,7 +23,7 @@\n>  \n>  namespace libcamera {\n>  \n> -LOG_DEFINE_CATEGORY(File);\n> +LOG_DEFINE_CATEGORY(File)\n>  \n>  /**\n>   * \\class File\n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index f5a20d3..af47739 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -66,7 +66,7 @@ public:\n>  \n>  \tStatus validate() override;\n>  \n> -\tconst StreamConfiguration &cio2Format() const { return cio2Configuration_; };\n> +\tconst StreamConfiguration &cio2Format() const { return cio2Configuration_; }\n>  \tconst ImgUDevice::PipeConfig imguConfig() const { return pipeConfig_; }\n>  \n>  private:\n> @@ -866,6 +866,6 @@ void IPU3CameraData::cio2BufferReady(FrameBuffer *buffer)\n>  \timgu_->input_->queueBuffer(buffer);\n>  }\n>  \n> -REGISTER_PIPELINE_HANDLER(PipelineHandlerIPU3);\n> +REGISTER_PIPELINE_HANDLER(PipelineHandlerIPU3)\n>  \n>  } /* namespace libcamera */\n> diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> index 26dbd25..331ada7 100644\n> --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> @@ -1675,6 +1675,6 @@ FrameBuffer *RPiCameraData::updateQueue(std::queue<FrameBuffer *> &q, uint64_t t\n>  \treturn nullptr;\n>  }\n>  \n> -REGISTER_PIPELINE_HANDLER(PipelineHandlerRPi);\n> +REGISTER_PIPELINE_HANDLER(PipelineHandlerRPi)\n>  \n>  } /* namespace libcamera */\n> diff --git a/src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp b/src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp\n> index 0572acc..62605c0 100644\n> --- a/src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp\n> +++ b/src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp\n> @@ -17,7 +17,7 @@\n>  \n>  namespace libcamera {\n>  \n> -LOG_DEFINE_CATEGORY(RPI_S_W);\n> +LOG_DEFINE_CATEGORY(RPI_S_W)\n>  \n>  namespace RPi {\n>  \n> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> index aec590f..2352ab3 100644\n> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> @@ -1184,6 +1184,6 @@ void PipelineHandlerRkISP1::statReady(FrameBuffer *buffer)\n>  \tdata->ipa_->processEvent(op);\n>  }\n>  \n> -REGISTER_PIPELINE_HANDLER(PipelineHandlerRkISP1);\n> +REGISTER_PIPELINE_HANDLER(PipelineHandlerRkISP1)\n>  \n>  } /* namespace libcamera */\n> diff --git a/src/libcamera/pipeline/simple/converter.cpp b/src/libcamera/pipeline/simple/converter.cpp\n> index 75fb297..b4ee021 100644\n> --- a/src/libcamera/pipeline/simple/converter.cpp\n> +++ b/src/libcamera/pipeline/simple/converter.cpp\n> @@ -21,7 +21,7 @@\n>  \n>  namespace libcamera {\n>  \n> -LOG_DECLARE_CATEGORY(SimplePipeline);\n> +LOG_DECLARE_CATEGORY(SimplePipeline)\n>  \n>  SimpleConverter::SimpleConverter(MediaDevice *media)\n>  \t: m2m_(nullptr)\n> diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\n> index 7adb17e..8c00c0f 100644\n> --- a/src/libcamera/pipeline/simple/simple.cpp\n> +++ b/src/libcamera/pipeline/simple/simple.cpp\n> @@ -942,6 +942,6 @@ void SimplePipelineHandler::converterDone(FrameBuffer *input,\n>  \tdata->video_->queueBuffer(input);\n>  }\n>  \n> -REGISTER_PIPELINE_HANDLER(SimplePipelineHandler);\n> +REGISTER_PIPELINE_HANDLER(SimplePipelineHandler)\n>  \n>  } /* namespace libcamera */\n> diff --git a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n> index 8ec0dac..a903a82 100644\n> --- a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n> +++ b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n> @@ -654,6 +654,6 @@ void UVCCameraData::bufferReady(FrameBuffer *buffer)\n>  \tpipe_->completeRequest(camera_, request);\n>  }\n>  \n> -REGISTER_PIPELINE_HANDLER(PipelineHandlerUVC);\n> +REGISTER_PIPELINE_HANDLER(PipelineHandlerUVC)\n>  \n>  } /* namespace libcamera */\n> diff --git a/src/libcamera/pipeline/vimc/vimc.cpp b/src/libcamera/pipeline/vimc/vimc.cpp\n> index fc8085f..7416c37 100644\n> --- a/src/libcamera/pipeline/vimc/vimc.cpp\n> +++ b/src/libcamera/pipeline/vimc/vimc.cpp\n> @@ -533,6 +533,6 @@ void VimcCameraData::bufferReady(FrameBuffer *buffer)\n>  \tpipe_->completeRequest(camera_, request);\n>  }\n>  \n> -REGISTER_PIPELINE_HANDLER(PipelineHandlerVimc);\n> +REGISTER_PIPELINE_HANDLER(PipelineHandlerVimc)\n>  \n>  } /* namespace libcamera */\n> diff --git a/src/libcamera/sysfs.cpp b/src/libcamera/sysfs.cpp\n> index 6c8e955..3ebe66f 100644\n> --- a/src/libcamera/sysfs.cpp\n> +++ b/src/libcamera/sysfs.cpp\n> @@ -22,7 +22,7 @@\n>  \n>  namespace libcamera {\n>  \n> -LOG_DEFINE_CATEGORY(SysFs);\n> +LOG_DEFINE_CATEGORY(SysFs)\n>  \n>  namespace sysfs {\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EC9E0BDB1F\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 20 Oct 2020 10:03:59 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B8897613AD;\n\tTue, 20 Oct 2020 12:03:59 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 547CA603AF\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 20 Oct 2020 12:03:58 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E641A52;\n\tTue, 20 Oct 2020 12:03:57 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"b07rgP7l\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1603188238;\n\tbh=ToPAGqexrvIEjiE3XdUMXMxliHmyRW2RWDRK8150Qqw=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=b07rgP7luVAXj7e6PovVuVg/X0es4MSe5e+qGkR3PDJDQg53HzFhcBQluxybueUl8\n\tcs9Ge354LQVdhFca8L77QuHosivr8pAD27ib4++3PSjTt9Edl33QkVrYCADpzc/Tsy\n\tGS9JjVO8uTLkLThEnELhAm22jr2kiGYVMmxA49lI=","Date":"Tue, 20 Oct 2020 13:03:12 +0300","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"Hirokazu Honda <hiroh@chromium.org>","Message-ID":"<20201020100312.GM18688@pendragon.ideasonboard.com>","References":"<20201020091505.138898-1-hiroh@chromium.org>\n\t<20201020091505.138898-6-hiroh@chromium.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201020091505.138898-6-hiroh@chromium.org>","Subject":"Re: [libcamera-devel] [PATCH v2 6/8] libcamera: Omit extra\n\tsemicolons","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":13286,"web_url":"https://patchwork.libcamera.org/comment/13286/","msgid":"<df2be037-8231-6ee5-e8f4-72746092785d@ideasonboard.com>","date":"2020-10-20T10:05:31","subject":"Re: [libcamera-devel] [PATCH v2 6/8] libcamera: Omit extra\n\tsemicolons","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Hiro,\n\nOn 20/10/2020 10:15, Hirokazu Honda wrote:\n> The end semicolons with LOG_DEFINE_CATEGORY,\n> LOG_DECLARE_CATEGORY and REGISTER_PIPELINE_HANDLER are\n> unnecessary.\n> \n> Signed-off-by: Hirokazu Honda <hiroh@chromium.org>\n> ---\n>  Documentation/guides/pipeline-handler.rst             | 4 ++--\n>  src/libcamera/byte_stream_buffer.cpp                  | 2 +-\n>  src/libcamera/camera_sensor.cpp                       | 2 +-\n>  src/libcamera/file.cpp                                | 2 +-\n>  src/libcamera/pipeline/ipu3/ipu3.cpp                  | 4 ++--\n>  src/libcamera/pipeline/raspberrypi/raspberrypi.cpp    | 2 +-\n>  src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp | 2 +-\n>  src/libcamera/pipeline/rkisp1/rkisp1.cpp              | 2 +-\n>  src/libcamera/pipeline/simple/converter.cpp           | 2 +-\n>  src/libcamera/pipeline/simple/simple.cpp              | 2 +-\n>  src/libcamera/pipeline/uvcvideo/uvcvideo.cpp          | 2 +-\n>  src/libcamera/pipeline/vimc/vimc.cpp                  | 2 +-\n>  src/libcamera/sysfs.cpp                               | 2 +-\n>  13 files changed, 15 insertions(+), 15 deletions(-)\n> \n> diff --git a/Documentation/guides/pipeline-handler.rst b/Documentation/guides/pipeline-handler.rst\n> index 71ef205..d0370f1 100644\n> --- a/Documentation/guides/pipeline-handler.rst\n> +++ b/Documentation/guides/pipeline-handler.rst\n> @@ -258,7 +258,7 @@ methods for the overridden class members.\n>            return false;\n>     }\n>  \n> -   REGISTER_PIPELINE_HANDLER(PipelineHandlerVivid);\n> +   REGISTER_PIPELINE_HANDLER(PipelineHandlerVivid)\n>  \n>     } /* namespace libcamera */\n>  \n> @@ -1470,4 +1470,4 @@ application which will render the frames in a window for visual inspection:\n>  \n>  .. TODO: Running qcam with the vivid pipeline handler appears to have a bug and\n>           no visual frames are seen. However disabling zero-copy on qcam renders\n> -         them successfully.\n> \\ No newline at end of file\n> +         them successfully.\n\nThe file ending has been changed here.\n\nWhen adding your changes, consider using 'git add -p' to add changes one\nhunk at a time. That gives you chance to review them as they go into the\nstaging/cache before you commit too.\n\nThis can either be ignored or fixed up when applying - either way.\n\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\n\n> diff --git a/src/libcamera/byte_stream_buffer.cpp b/src/libcamera/byte_stream_buffer.cpp\n> index df7029b..7db5501 100644\n> --- a/src/libcamera/byte_stream_buffer.cpp\n> +++ b/src/libcamera/byte_stream_buffer.cpp\n> @@ -14,7 +14,7 @@\n>  \n>  namespace libcamera {\n>  \n> -LOG_DEFINE_CATEGORY(Serialization);\n> +LOG_DEFINE_CATEGORY(Serialization)\n>  \n>  /**\n>   * \\file byte_stream_buffer.h\n> diff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp\n> index 78c7cee..935de52 100644\n> --- a/src/libcamera/camera_sensor.cpp\n> +++ b/src/libcamera/camera_sensor.cpp\n> @@ -28,7 +28,7 @@\n>  \n>  namespace libcamera {\n>  \n> -LOG_DEFINE_CATEGORY(CameraSensor);\n> +LOG_DEFINE_CATEGORY(CameraSensor)\n>  \n>  /**\n>   * \\struct CameraSensorInfo\n> diff --git a/src/libcamera/file.cpp b/src/libcamera/file.cpp\n> index 04b0cb6..3a3f5bb 100644\n> --- a/src/libcamera/file.cpp\n> +++ b/src/libcamera/file.cpp\n> @@ -23,7 +23,7 @@\n>  \n>  namespace libcamera {\n>  \n> -LOG_DEFINE_CATEGORY(File);\n> +LOG_DEFINE_CATEGORY(File)\n>  \n>  /**\n>   * \\class File\n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index f5a20d3..af47739 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -66,7 +66,7 @@ public:\n>  \n>  \tStatus validate() override;\n>  \n> -\tconst StreamConfiguration &cio2Format() const { return cio2Configuration_; };\n> +\tconst StreamConfiguration &cio2Format() const { return cio2Configuration_; }\n>  \tconst ImgUDevice::PipeConfig imguConfig() const { return pipeConfig_; }\n>  \n>  private:\n> @@ -866,6 +866,6 @@ void IPU3CameraData::cio2BufferReady(FrameBuffer *buffer)\n>  \timgu_->input_->queueBuffer(buffer);\n>  }\n>  \n> -REGISTER_PIPELINE_HANDLER(PipelineHandlerIPU3);\n> +REGISTER_PIPELINE_HANDLER(PipelineHandlerIPU3)\n>  \n>  } /* namespace libcamera */\n> diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> index 26dbd25..331ada7 100644\n> --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> @@ -1675,6 +1675,6 @@ FrameBuffer *RPiCameraData::updateQueue(std::queue<FrameBuffer *> &q, uint64_t t\n>  \treturn nullptr;\n>  }\n>  \n> -REGISTER_PIPELINE_HANDLER(PipelineHandlerRPi);\n> +REGISTER_PIPELINE_HANDLER(PipelineHandlerRPi)\n>  \n>  } /* namespace libcamera */\n> diff --git a/src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp b/src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp\n> index 0572acc..62605c0 100644\n> --- a/src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp\n> +++ b/src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp\n> @@ -17,7 +17,7 @@\n>  \n>  namespace libcamera {\n>  \n> -LOG_DEFINE_CATEGORY(RPI_S_W);\n> +LOG_DEFINE_CATEGORY(RPI_S_W)\n>  \n>  namespace RPi {\n>  \n> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> index aec590f..2352ab3 100644\n> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> @@ -1184,6 +1184,6 @@ void PipelineHandlerRkISP1::statReady(FrameBuffer *buffer)\n>  \tdata->ipa_->processEvent(op);\n>  }\n>  \n> -REGISTER_PIPELINE_HANDLER(PipelineHandlerRkISP1);\n> +REGISTER_PIPELINE_HANDLER(PipelineHandlerRkISP1)\n>  \n>  } /* namespace libcamera */\n> diff --git a/src/libcamera/pipeline/simple/converter.cpp b/src/libcamera/pipeline/simple/converter.cpp\n> index 75fb297..b4ee021 100644\n> --- a/src/libcamera/pipeline/simple/converter.cpp\n> +++ b/src/libcamera/pipeline/simple/converter.cpp\n> @@ -21,7 +21,7 @@\n>  \n>  namespace libcamera {\n>  \n> -LOG_DECLARE_CATEGORY(SimplePipeline);\n> +LOG_DECLARE_CATEGORY(SimplePipeline)\n>  \n>  SimpleConverter::SimpleConverter(MediaDevice *media)\n>  \t: m2m_(nullptr)\n> diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\n> index 7adb17e..8c00c0f 100644\n> --- a/src/libcamera/pipeline/simple/simple.cpp\n> +++ b/src/libcamera/pipeline/simple/simple.cpp\n> @@ -942,6 +942,6 @@ void SimplePipelineHandler::converterDone(FrameBuffer *input,\n>  \tdata->video_->queueBuffer(input);\n>  }\n>  \n> -REGISTER_PIPELINE_HANDLER(SimplePipelineHandler);\n> +REGISTER_PIPELINE_HANDLER(SimplePipelineHandler)\n>  \n>  } /* namespace libcamera */\n> diff --git a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n> index 8ec0dac..a903a82 100644\n> --- a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n> +++ b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n> @@ -654,6 +654,6 @@ void UVCCameraData::bufferReady(FrameBuffer *buffer)\n>  \tpipe_->completeRequest(camera_, request);\n>  }\n>  \n> -REGISTER_PIPELINE_HANDLER(PipelineHandlerUVC);\n> +REGISTER_PIPELINE_HANDLER(PipelineHandlerUVC)\n>  \n>  } /* namespace libcamera */\n> diff --git a/src/libcamera/pipeline/vimc/vimc.cpp b/src/libcamera/pipeline/vimc/vimc.cpp\n> index fc8085f..7416c37 100644\n> --- a/src/libcamera/pipeline/vimc/vimc.cpp\n> +++ b/src/libcamera/pipeline/vimc/vimc.cpp\n> @@ -533,6 +533,6 @@ void VimcCameraData::bufferReady(FrameBuffer *buffer)\n>  \tpipe_->completeRequest(camera_, request);\n>  }\n>  \n> -REGISTER_PIPELINE_HANDLER(PipelineHandlerVimc);\n> +REGISTER_PIPELINE_HANDLER(PipelineHandlerVimc)\n>  \n>  } /* namespace libcamera */\n> diff --git a/src/libcamera/sysfs.cpp b/src/libcamera/sysfs.cpp\n> index 6c8e955..3ebe66f 100644\n> --- a/src/libcamera/sysfs.cpp\n> +++ b/src/libcamera/sysfs.cpp\n> @@ -22,7 +22,7 @@\n>  \n>  namespace libcamera {\n>  \n> -LOG_DEFINE_CATEGORY(SysFs);\n> +LOG_DEFINE_CATEGORY(SysFs)\n>  \n>  namespace sysfs {\n>  \n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9E7BCBDB1F\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 20 Oct 2020 10:05:35 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6B2A06052F;\n\tTue, 20 Oct 2020 12:05:35 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2147A603AF\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 20 Oct 2020 12:05:34 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BFE2F52;\n\tTue, 20 Oct 2020 12:05:33 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Flbw+XnH\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1603188333;\n\tbh=X7BBsgcpM3Mjazjsf9GOUAbQDVF+lrStHsMdfBbcB0Y=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=Flbw+XnHI+QbPj+Gjiy2E3J8uaiL3BeX5jWWL/M4rX5aRYFIzBAvoAIxZ7BX3ES4o\n\t1wEvfVMP7WXPEjIMPfjUZGRBCZptSdwLz6slW6OC7LGG8dcLX0AHpCuSNson4YmBYv\n\tEBd10hbTTV4VYbk9sYqACKhdjSHjLfoUPs4/sMng=","To":"Hirokazu Honda <hiroh@chromium.org>, libcamera-devel@lists.libcamera.org","References":"<20201020091505.138898-1-hiroh@chromium.org>\n\t<20201020091505.138898-6-hiroh@chromium.org>","From":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<df2be037-8231-6ee5-e8f4-72746092785d@ideasonboard.com>","Date":"Tue, 20 Oct 2020 11:05:31 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20201020091505.138898-6-hiroh@chromium.org>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH v2 6/8] libcamera: Omit extra\n\tsemicolons","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":13289,"web_url":"https://patchwork.libcamera.org/comment/13289/","msgid":"<20201020101215.GN18688@pendragon.ideasonboard.com>","date":"2020-10-20T10:12:15","subject":"Re: [libcamera-devel] [PATCH v2 6/8] libcamera: Omit extra\n\tsemicolons","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nOn Tue, Oct 20, 2020 at 11:05:31AM +0100, Kieran Bingham wrote:\n> On 20/10/2020 10:15, Hirokazu Honda wrote:\n> > The end semicolons with LOG_DEFINE_CATEGORY,\n> > LOG_DECLARE_CATEGORY and REGISTER_PIPELINE_HANDLER are\n> > unnecessary.\n> > \n> > Signed-off-by: Hirokazu Honda <hiroh@chromium.org>\n> > ---\n> >  Documentation/guides/pipeline-handler.rst             | 4 ++--\n> >  src/libcamera/byte_stream_buffer.cpp                  | 2 +-\n> >  src/libcamera/camera_sensor.cpp                       | 2 +-\n> >  src/libcamera/file.cpp                                | 2 +-\n> >  src/libcamera/pipeline/ipu3/ipu3.cpp                  | 4 ++--\n> >  src/libcamera/pipeline/raspberrypi/raspberrypi.cpp    | 2 +-\n> >  src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp | 2 +-\n> >  src/libcamera/pipeline/rkisp1/rkisp1.cpp              | 2 +-\n> >  src/libcamera/pipeline/simple/converter.cpp           | 2 +-\n> >  src/libcamera/pipeline/simple/simple.cpp              | 2 +-\n> >  src/libcamera/pipeline/uvcvideo/uvcvideo.cpp          | 2 +-\n> >  src/libcamera/pipeline/vimc/vimc.cpp                  | 2 +-\n> >  src/libcamera/sysfs.cpp                               | 2 +-\n> >  13 files changed, 15 insertions(+), 15 deletions(-)\n> > \n> > diff --git a/Documentation/guides/pipeline-handler.rst b/Documentation/guides/pipeline-handler.rst\n> > index 71ef205..d0370f1 100644\n> > --- a/Documentation/guides/pipeline-handler.rst\n> > +++ b/Documentation/guides/pipeline-handler.rst\n> > @@ -258,7 +258,7 @@ methods for the overridden class members.\n> >            return false;\n> >     }\n> >  \n> > -   REGISTER_PIPELINE_HANDLER(PipelineHandlerVivid);\n> > +   REGISTER_PIPELINE_HANDLER(PipelineHandlerVivid)\n> >  \n> >     } /* namespace libcamera */\n> >  \n> > @@ -1470,4 +1470,4 @@ application which will render the frames in a window for visual inspection:\n> >  \n> >  .. TODO: Running qcam with the vivid pipeline handler appears to have a bug and\n> >           no visual frames are seen. However disabling zero-copy on qcam renders\n> > -         them successfully.\n> > \\ No newline at end of file\n> > +         them successfully.\n> \n> The file ending has been changed here.\n> \n> When adding your changes, consider using 'git add -p' to add changes one\n> hunk at a time. That gives you chance to review them as they go into the\n> staging/cache before you commit too.\n> \n> This can either be ignored or fixed up when applying - either way.\n\nI'll leave it in, as it's just the newline character and not a blank\nline. vim doesn't make it easy to remove it, I think it's actually a\ngood idea to have it in (or maybe sometime will tell me I should use\nemacs instead ;-)).\n\n> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n> \n> > diff --git a/src/libcamera/byte_stream_buffer.cpp b/src/libcamera/byte_stream_buffer.cpp\n> > index df7029b..7db5501 100644\n> > --- a/src/libcamera/byte_stream_buffer.cpp\n> > +++ b/src/libcamera/byte_stream_buffer.cpp\n> > @@ -14,7 +14,7 @@\n> >  \n> >  namespace libcamera {\n> >  \n> > -LOG_DEFINE_CATEGORY(Serialization);\n> > +LOG_DEFINE_CATEGORY(Serialization)\n> >  \n> >  /**\n> >   * \\file byte_stream_buffer.h\n> > diff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp\n> > index 78c7cee..935de52 100644\n> > --- a/src/libcamera/camera_sensor.cpp\n> > +++ b/src/libcamera/camera_sensor.cpp\n> > @@ -28,7 +28,7 @@\n> >  \n> >  namespace libcamera {\n> >  \n> > -LOG_DEFINE_CATEGORY(CameraSensor);\n> > +LOG_DEFINE_CATEGORY(CameraSensor)\n> >  \n> >  /**\n> >   * \\struct CameraSensorInfo\n> > diff --git a/src/libcamera/file.cpp b/src/libcamera/file.cpp\n> > index 04b0cb6..3a3f5bb 100644\n> > --- a/src/libcamera/file.cpp\n> > +++ b/src/libcamera/file.cpp\n> > @@ -23,7 +23,7 @@\n> >  \n> >  namespace libcamera {\n> >  \n> > -LOG_DEFINE_CATEGORY(File);\n> > +LOG_DEFINE_CATEGORY(File)\n> >  \n> >  /**\n> >   * \\class File\n> > diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> > index f5a20d3..af47739 100644\n> > --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> > +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> > @@ -66,7 +66,7 @@ public:\n> >  \n> >  \tStatus validate() override;\n> >  \n> > -\tconst StreamConfiguration &cio2Format() const { return cio2Configuration_; };\n> > +\tconst StreamConfiguration &cio2Format() const { return cio2Configuration_; }\n> >  \tconst ImgUDevice::PipeConfig imguConfig() const { return pipeConfig_; }\n> >  \n> >  private:\n> > @@ -866,6 +866,6 @@ void IPU3CameraData::cio2BufferReady(FrameBuffer *buffer)\n> >  \timgu_->input_->queueBuffer(buffer);\n> >  }\n> >  \n> > -REGISTER_PIPELINE_HANDLER(PipelineHandlerIPU3);\n> > +REGISTER_PIPELINE_HANDLER(PipelineHandlerIPU3)\n> >  \n> >  } /* namespace libcamera */\n> > diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> > index 26dbd25..331ada7 100644\n> > --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> > +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> > @@ -1675,6 +1675,6 @@ FrameBuffer *RPiCameraData::updateQueue(std::queue<FrameBuffer *> &q, uint64_t t\n> >  \treturn nullptr;\n> >  }\n> >  \n> > -REGISTER_PIPELINE_HANDLER(PipelineHandlerRPi);\n> > +REGISTER_PIPELINE_HANDLER(PipelineHandlerRPi)\n> >  \n> >  } /* namespace libcamera */\n> > diff --git a/src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp b/src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp\n> > index 0572acc..62605c0 100644\n> > --- a/src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp\n> > +++ b/src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp\n> > @@ -17,7 +17,7 @@\n> >  \n> >  namespace libcamera {\n> >  \n> > -LOG_DEFINE_CATEGORY(RPI_S_W);\n> > +LOG_DEFINE_CATEGORY(RPI_S_W)\n> >  \n> >  namespace RPi {\n> >  \n> > diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> > index aec590f..2352ab3 100644\n> > --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> > +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> > @@ -1184,6 +1184,6 @@ void PipelineHandlerRkISP1::statReady(FrameBuffer *buffer)\n> >  \tdata->ipa_->processEvent(op);\n> >  }\n> >  \n> > -REGISTER_PIPELINE_HANDLER(PipelineHandlerRkISP1);\n> > +REGISTER_PIPELINE_HANDLER(PipelineHandlerRkISP1)\n> >  \n> >  } /* namespace libcamera */\n> > diff --git a/src/libcamera/pipeline/simple/converter.cpp b/src/libcamera/pipeline/simple/converter.cpp\n> > index 75fb297..b4ee021 100644\n> > --- a/src/libcamera/pipeline/simple/converter.cpp\n> > +++ b/src/libcamera/pipeline/simple/converter.cpp\n> > @@ -21,7 +21,7 @@\n> >  \n> >  namespace libcamera {\n> >  \n> > -LOG_DECLARE_CATEGORY(SimplePipeline);\n> > +LOG_DECLARE_CATEGORY(SimplePipeline)\n> >  \n> >  SimpleConverter::SimpleConverter(MediaDevice *media)\n> >  \t: m2m_(nullptr)\n> > diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\n> > index 7adb17e..8c00c0f 100644\n> > --- a/src/libcamera/pipeline/simple/simple.cpp\n> > +++ b/src/libcamera/pipeline/simple/simple.cpp\n> > @@ -942,6 +942,6 @@ void SimplePipelineHandler::converterDone(FrameBuffer *input,\n> >  \tdata->video_->queueBuffer(input);\n> >  }\n> >  \n> > -REGISTER_PIPELINE_HANDLER(SimplePipelineHandler);\n> > +REGISTER_PIPELINE_HANDLER(SimplePipelineHandler)\n> >  \n> >  } /* namespace libcamera */\n> > diff --git a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n> > index 8ec0dac..a903a82 100644\n> > --- a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n> > +++ b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n> > @@ -654,6 +654,6 @@ void UVCCameraData::bufferReady(FrameBuffer *buffer)\n> >  \tpipe_->completeRequest(camera_, request);\n> >  }\n> >  \n> > -REGISTER_PIPELINE_HANDLER(PipelineHandlerUVC);\n> > +REGISTER_PIPELINE_HANDLER(PipelineHandlerUVC)\n> >  \n> >  } /* namespace libcamera */\n> > diff --git a/src/libcamera/pipeline/vimc/vimc.cpp b/src/libcamera/pipeline/vimc/vimc.cpp\n> > index fc8085f..7416c37 100644\n> > --- a/src/libcamera/pipeline/vimc/vimc.cpp\n> > +++ b/src/libcamera/pipeline/vimc/vimc.cpp\n> > @@ -533,6 +533,6 @@ void VimcCameraData::bufferReady(FrameBuffer *buffer)\n> >  \tpipe_->completeRequest(camera_, request);\n> >  }\n> >  \n> > -REGISTER_PIPELINE_HANDLER(PipelineHandlerVimc);\n> > +REGISTER_PIPELINE_HANDLER(PipelineHandlerVimc)\n> >  \n> >  } /* namespace libcamera */\n> > diff --git a/src/libcamera/sysfs.cpp b/src/libcamera/sysfs.cpp\n> > index 6c8e955..3ebe66f 100644\n> > --- a/src/libcamera/sysfs.cpp\n> > +++ b/src/libcamera/sysfs.cpp\n> > @@ -22,7 +22,7 @@\n> >  \n> >  namespace libcamera {\n> >  \n> > -LOG_DEFINE_CATEGORY(SysFs);\n> > +LOG_DEFINE_CATEGORY(SysFs)\n> >  \n> >  namespace sysfs {\n> >","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6BBB0BDB1F\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 20 Oct 2020 10:13:03 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0150461373;\n\tTue, 20 Oct 2020 12:13:03 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B0516603AF\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 20 Oct 2020 12:13:01 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2F75252;\n\tTue, 20 Oct 2020 12:13:01 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"IA1QAcFp\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1603188781;\n\tbh=hCwQKfI2PAvQUX5y68gSqPVS7o7MCS2JqWTg9GYBPGw=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=IA1QAcFp/JuGcCSdO5CfpGDRlshnW8es7sQ9NnkvvrmAjyiugB9+4p0hgOTY2KZ+l\n\tE7a6Wdl6fcJKKnGsQFnNtPMfwf8iJLyzgT42foEzGZ+a9e81cku0D9sv9Tga+uhvL4\n\tFJ+/fU4ix98Y71d+xXv/NhHfG+iKgKOs3XC5NaPk=","Date":"Tue, 20 Oct 2020 13:12:15 +0300","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Message-ID":"<20201020101215.GN18688@pendragon.ideasonboard.com>","References":"<20201020091505.138898-1-hiroh@chromium.org>\n\t<20201020091505.138898-6-hiroh@chromium.org>\n\t<df2be037-8231-6ee5-e8f4-72746092785d@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<df2be037-8231-6ee5-e8f4-72746092785d@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2 6/8] libcamera: Omit extra\n\tsemicolons","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":13291,"web_url":"https://patchwork.libcamera.org/comment/13291/","msgid":"<0c7b8621-ca08-95ad-a382-54f1f5300329@ideasonboard.com>","date":"2020-10-20T10:17:06","subject":"Re: [libcamera-devel] [PATCH v2 6/8] libcamera: Omit extra\n\tsemicolons","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 20/10/2020 11:12, Laurent Pinchart wrote:\n> Hi Kieran,\n> \n> On Tue, Oct 20, 2020 at 11:05:31AM +0100, Kieran Bingham wrote:\n>> On 20/10/2020 10:15, Hirokazu Honda wrote:\n>>> The end semicolons with LOG_DEFINE_CATEGORY,\n>>> LOG_DECLARE_CATEGORY and REGISTER_PIPELINE_HANDLER are\n>>> unnecessary.\n>>>\n>>> Signed-off-by: Hirokazu Honda <hiroh@chromium.org>\n>>> ---\n>>>  Documentation/guides/pipeline-handler.rst             | 4 ++--\n>>>  src/libcamera/byte_stream_buffer.cpp                  | 2 +-\n>>>  src/libcamera/camera_sensor.cpp                       | 2 +-\n>>>  src/libcamera/file.cpp                                | 2 +-\n>>>  src/libcamera/pipeline/ipu3/ipu3.cpp                  | 4 ++--\n>>>  src/libcamera/pipeline/raspberrypi/raspberrypi.cpp    | 2 +-\n>>>  src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp | 2 +-\n>>>  src/libcamera/pipeline/rkisp1/rkisp1.cpp              | 2 +-\n>>>  src/libcamera/pipeline/simple/converter.cpp           | 2 +-\n>>>  src/libcamera/pipeline/simple/simple.cpp              | 2 +-\n>>>  src/libcamera/pipeline/uvcvideo/uvcvideo.cpp          | 2 +-\n>>>  src/libcamera/pipeline/vimc/vimc.cpp                  | 2 +-\n>>>  src/libcamera/sysfs.cpp                               | 2 +-\n>>>  13 files changed, 15 insertions(+), 15 deletions(-)\n>>>\n>>> diff --git a/Documentation/guides/pipeline-handler.rst b/Documentation/guides/pipeline-handler.rst\n>>> index 71ef205..d0370f1 100644\n>>> --- a/Documentation/guides/pipeline-handler.rst\n>>> +++ b/Documentation/guides/pipeline-handler.rst\n>>> @@ -258,7 +258,7 @@ methods for the overridden class members.\n>>>            return false;\n>>>     }\n>>>  \n>>> -   REGISTER_PIPELINE_HANDLER(PipelineHandlerVivid);\n>>> +   REGISTER_PIPELINE_HANDLER(PipelineHandlerVivid)\n>>>  \n>>>     } /* namespace libcamera */\n>>>  \n>>> @@ -1470,4 +1470,4 @@ application which will render the frames in a window for visual inspection:\n>>>  \n>>>  .. TODO: Running qcam with the vivid pipeline handler appears to have a bug and\n>>>           no visual frames are seen. However disabling zero-copy on qcam renders\n>>> -         them successfully.\n>>> \\ No newline at end of file\n>>> +         them successfully.\n>>\n>> The file ending has been changed here.\n>>\n>> When adding your changes, consider using 'git add -p' to add changes one\n>> hunk at a time. That gives you chance to review them as they go into the\n>> staging/cache before you commit too.\n>>\n>> This can either be ignored or fixed up when applying - either way.\n> \n> I'll leave it in, as it's just the newline character and not a blank\n> line. vim doesn't make it easy to remove it, I think it's actually a\n> good idea to have it in (or maybe sometime will tell me I should use\n> emacs instead ;-)).\n> \n\nI actually mis-interpreted it on first read. I thought this was\n/removing/ the newline character.\n\nIndeed, I don't object to it being added.\n\n--\nKieran\n\n\n>> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n>>\n>>> diff --git a/src/libcamera/byte_stream_buffer.cpp b/src/libcamera/byte_stream_buffer.cpp\n>>> index df7029b..7db5501 100644\n>>> --- a/src/libcamera/byte_stream_buffer.cpp\n>>> +++ b/src/libcamera/byte_stream_buffer.cpp\n>>> @@ -14,7 +14,7 @@\n>>>  \n>>>  namespace libcamera {\n>>>  \n>>> -LOG_DEFINE_CATEGORY(Serialization);\n>>> +LOG_DEFINE_CATEGORY(Serialization)\n>>>  \n>>>  /**\n>>>   * \\file byte_stream_buffer.h\n>>> diff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp\n>>> index 78c7cee..935de52 100644\n>>> --- a/src/libcamera/camera_sensor.cpp\n>>> +++ b/src/libcamera/camera_sensor.cpp\n>>> @@ -28,7 +28,7 @@\n>>>  \n>>>  namespace libcamera {\n>>>  \n>>> -LOG_DEFINE_CATEGORY(CameraSensor);\n>>> +LOG_DEFINE_CATEGORY(CameraSensor)\n>>>  \n>>>  /**\n>>>   * \\struct CameraSensorInfo\n>>> diff --git a/src/libcamera/file.cpp b/src/libcamera/file.cpp\n>>> index 04b0cb6..3a3f5bb 100644\n>>> --- a/src/libcamera/file.cpp\n>>> +++ b/src/libcamera/file.cpp\n>>> @@ -23,7 +23,7 @@\n>>>  \n>>>  namespace libcamera {\n>>>  \n>>> -LOG_DEFINE_CATEGORY(File);\n>>> +LOG_DEFINE_CATEGORY(File)\n>>>  \n>>>  /**\n>>>   * \\class File\n>>> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n>>> index f5a20d3..af47739 100644\n>>> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n>>> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n>>> @@ -66,7 +66,7 @@ public:\n>>>  \n>>>  \tStatus validate() override;\n>>>  \n>>> -\tconst StreamConfiguration &cio2Format() const { return cio2Configuration_; };\n>>> +\tconst StreamConfiguration &cio2Format() const { return cio2Configuration_; }\n>>>  \tconst ImgUDevice::PipeConfig imguConfig() const { return pipeConfig_; }\n>>>  \n>>>  private:\n>>> @@ -866,6 +866,6 @@ void IPU3CameraData::cio2BufferReady(FrameBuffer *buffer)\n>>>  \timgu_->input_->queueBuffer(buffer);\n>>>  }\n>>>  \n>>> -REGISTER_PIPELINE_HANDLER(PipelineHandlerIPU3);\n>>> +REGISTER_PIPELINE_HANDLER(PipelineHandlerIPU3)\n>>>  \n>>>  } /* namespace libcamera */\n>>> diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n>>> index 26dbd25..331ada7 100644\n>>> --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n>>> +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n>>> @@ -1675,6 +1675,6 @@ FrameBuffer *RPiCameraData::updateQueue(std::queue<FrameBuffer *> &q, uint64_t t\n>>>  \treturn nullptr;\n>>>  }\n>>>  \n>>> -REGISTER_PIPELINE_HANDLER(PipelineHandlerRPi);\n>>> +REGISTER_PIPELINE_HANDLER(PipelineHandlerRPi)\n>>>  \n>>>  } /* namespace libcamera */\n>>> diff --git a/src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp b/src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp\n>>> index 0572acc..62605c0 100644\n>>> --- a/src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp\n>>> +++ b/src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp\n>>> @@ -17,7 +17,7 @@\n>>>  \n>>>  namespace libcamera {\n>>>  \n>>> -LOG_DEFINE_CATEGORY(RPI_S_W);\n>>> +LOG_DEFINE_CATEGORY(RPI_S_W)\n>>>  \n>>>  namespace RPi {\n>>>  \n>>> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n>>> index aec590f..2352ab3 100644\n>>> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n>>> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n>>> @@ -1184,6 +1184,6 @@ void PipelineHandlerRkISP1::statReady(FrameBuffer *buffer)\n>>>  \tdata->ipa_->processEvent(op);\n>>>  }\n>>>  \n>>> -REGISTER_PIPELINE_HANDLER(PipelineHandlerRkISP1);\n>>> +REGISTER_PIPELINE_HANDLER(PipelineHandlerRkISP1)\n>>>  \n>>>  } /* namespace libcamera */\n>>> diff --git a/src/libcamera/pipeline/simple/converter.cpp b/src/libcamera/pipeline/simple/converter.cpp\n>>> index 75fb297..b4ee021 100644\n>>> --- a/src/libcamera/pipeline/simple/converter.cpp\n>>> +++ b/src/libcamera/pipeline/simple/converter.cpp\n>>> @@ -21,7 +21,7 @@\n>>>  \n>>>  namespace libcamera {\n>>>  \n>>> -LOG_DECLARE_CATEGORY(SimplePipeline);\n>>> +LOG_DECLARE_CATEGORY(SimplePipeline)\n>>>  \n>>>  SimpleConverter::SimpleConverter(MediaDevice *media)\n>>>  \t: m2m_(nullptr)\n>>> diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\n>>> index 7adb17e..8c00c0f 100644\n>>> --- a/src/libcamera/pipeline/simple/simple.cpp\n>>> +++ b/src/libcamera/pipeline/simple/simple.cpp\n>>> @@ -942,6 +942,6 @@ void SimplePipelineHandler::converterDone(FrameBuffer *input,\n>>>  \tdata->video_->queueBuffer(input);\n>>>  }\n>>>  \n>>> -REGISTER_PIPELINE_HANDLER(SimplePipelineHandler);\n>>> +REGISTER_PIPELINE_HANDLER(SimplePipelineHandler)\n>>>  \n>>>  } /* namespace libcamera */\n>>> diff --git a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n>>> index 8ec0dac..a903a82 100644\n>>> --- a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n>>> +++ b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n>>> @@ -654,6 +654,6 @@ void UVCCameraData::bufferReady(FrameBuffer *buffer)\n>>>  \tpipe_->completeRequest(camera_, request);\n>>>  }\n>>>  \n>>> -REGISTER_PIPELINE_HANDLER(PipelineHandlerUVC);\n>>> +REGISTER_PIPELINE_HANDLER(PipelineHandlerUVC)\n>>>  \n>>>  } /* namespace libcamera */\n>>> diff --git a/src/libcamera/pipeline/vimc/vimc.cpp b/src/libcamera/pipeline/vimc/vimc.cpp\n>>> index fc8085f..7416c37 100644\n>>> --- a/src/libcamera/pipeline/vimc/vimc.cpp\n>>> +++ b/src/libcamera/pipeline/vimc/vimc.cpp\n>>> @@ -533,6 +533,6 @@ void VimcCameraData::bufferReady(FrameBuffer *buffer)\n>>>  \tpipe_->completeRequest(camera_, request);\n>>>  }\n>>>  \n>>> -REGISTER_PIPELINE_HANDLER(PipelineHandlerVimc);\n>>> +REGISTER_PIPELINE_HANDLER(PipelineHandlerVimc)\n>>>  \n>>>  } /* namespace libcamera */\n>>> diff --git a/src/libcamera/sysfs.cpp b/src/libcamera/sysfs.cpp\n>>> index 6c8e955..3ebe66f 100644\n>>> --- a/src/libcamera/sysfs.cpp\n>>> +++ b/src/libcamera/sysfs.cpp\n>>> @@ -22,7 +22,7 @@\n>>>  \n>>>  namespace libcamera {\n>>>  \n>>> -LOG_DEFINE_CATEGORY(SysFs);\n>>> +LOG_DEFINE_CATEGORY(SysFs)\n>>>  \n>>>  namespace sysfs {\n>>>  \n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9D7EEBDB13\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 20 Oct 2020 10:17:11 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3858E603AF;\n\tTue, 20 Oct 2020 12:17:11 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 00598603AF\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 20 Oct 2020 12:17:09 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 68B0A52;\n\tTue, 20 Oct 2020 12:17:09 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"PGGOv5UR\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1603189029;\n\tbh=xYK+RMOi//D26fJeg3nf6cZ9JkdwXOcuQwRGlP6/CPI=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=PGGOv5UR87xA81Qpbi00s9pQ6jMhV5zQyEfbxeChgKGQ3Qdy0nwkUyIjl2Mm4/jQA\n\tUtUb6e0wvlk8KkrYCtXow9YrlJ8laEWBkvSrzVEoINV1ymY87nsTLSOl6pURpK51Jd\n\twTXYCV3ffY7CkKiV1yB7S4DZaoZXEcsjC9plHPSk=","To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","References":"<20201020091505.138898-1-hiroh@chromium.org>\n\t<20201020091505.138898-6-hiroh@chromium.org>\n\t<df2be037-8231-6ee5-e8f4-72746092785d@ideasonboard.com>\n\t<20201020101215.GN18688@pendragon.ideasonboard.com>","From":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<0c7b8621-ca08-95ad-a382-54f1f5300329@ideasonboard.com>","Date":"Tue, 20 Oct 2020 11:17:06 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20201020101215.GN18688@pendragon.ideasonboard.com>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH v2 6/8] libcamera: Omit extra\n\tsemicolons","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Reply-To":"kieran.bingham@ideasonboard.com","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]