{"id":10130,"url":"https://patchwork.libcamera.org/api/patches/10130/?format=json","web_url":"https://patchwork.libcamera.org/patch/10130/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20201020091505.138898-6-hiroh@chromium.org>","date":"2020-10-20T09:15:03","name":"[libcamera-devel,v2,6/8] libcamera: Omit extra semicolons","commit_ref":"e04bd18589fb04e5fc3974e79f8ae33d22a159df","pull_url":null,"state":"accepted","archived":false,"hash":"0393b0faf58f176feb22810b79a86dc8503d41fc","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/people/63/?format=json","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/10130/mbox/","series":[{"id":1390,"url":"https://patchwork.libcamera.org/api/series/1390/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1390","date":"2020-10-20T09:14:58","name":"[libcamera-devel,v2,1/8] test: Omit extra semicolons","version":2,"mbox":"https://patchwork.libcamera.org/series/1390/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/10130/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/10130/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E233BBDB1F\n\tfor ;\n\tTue, 20 Oct 2020 09:15:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9F1FD613BB;\n\tTue, 20 Oct 2020 11:15:24 +0200 (CEST)","from mail-pl1-x62b.google.com (mail-pl1-x62b.google.com\n\t[IPv6:2607:f8b0:4864:20::62b])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9A68E61373\n\tfor ;\n\tTue, 20 Oct 2020 11:15:22 +0200 (CEST)","by mail-pl1-x62b.google.com with SMTP id h2so693506pll.11\n\tfor ;\n\tTue, 20 Oct 2020 02:15:22 -0700 (PDT)","from hiroh.tok.corp.google.com\n\t([2401:fa00:8f:2:de4a:3eff:fe7d:f78f])\n\tby smtp.gmail.com with ESMTPSA id\n\tp8sm1482014pgs.34.2020.10.20.02.15.19\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 20 Oct 2020 02:15:20 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"JSWZKxud\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=liyo/oDJijHOpl8icA2YflXE7zcQ+T55ARgEJEs61aw=;\n\tb=JSWZKxudeW1YSr+hmVwNnBe4He2z2M+Xg3MtRVBERg6zj85vjMEerjVwM+yWG0VYxS\n\tl0Z4iFXbC2MDr7zSpmX7yarUaOw8oozjrfKSZj7VgjW2UkCC6D0XCzfQdbdXSccqJzs6\n\tZ1IZCX4ZcJmkCyQKuZekFXabVJzd8xZ508hQc=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=liyo/oDJijHOpl8icA2YflXE7zcQ+T55ARgEJEs61aw=;\n\tb=PPsAEcka5wu/6tC9DYuTvp4VbBn+KuFwykCFrYfEN6JJwKhqKRwTHv7PciOt9cTJ4o\n\taKr5URv84OeT/JcT6eDWeLzPFExt+8bVSCrYQ/h//l+8gUHwka9hydlaxm6nT0/1opn8\n\txFeiP5S1Q86baHdN58t2k4HUrBwVBfpZXFuLyOIcuHDNNPCZAXAku+mH8XlKHesNK760\n\tl2AdFkrZ1XI4OYlw1qq/j8zuzY1vaMywku9AxZh+8isqfa4FiW+EXHbry986A64ps6pk\n\tALP9X2HozNWHa7ib992fJ+2fCA1Ti49LuCNKEKqzv46x1U26KwB4VWRw8D7tH2sTOsyw\n\tVEiQ==","X-Gm-Message-State":"AOAM532AOoT2KzhsdbtlVvaohNsxpmr0v9IIv5aWLrmFI9WbfHuE7P8j\n\tGJNR11OQYuc3JcMlowaRhiVJWq29AjSWYw==","X-Google-Smtp-Source":"ABdhPJy2/iIGlAPoyALzFUE9+DOvOH1qAl+zampY39kSJrPxMOsMcwWGY4BX1C+h/XT+9obMlNoRUg==","X-Received":"by 2002:a17:90b:3114:: with SMTP id\n\tgc20mr1934092pjb.73.1603185320932; \n\tTue, 20 Oct 2020 02:15:20 -0700 (PDT)","From":"Hirokazu Honda ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 20 Oct 2020 18:15:03 +0900","Message-Id":"<20201020091505.138898-6-hiroh@chromium.org>","X-Mailer":"git-send-email 2.29.0.rc1.297.gfa9743e501-goog","In-Reply-To":"<20201020091505.138898-1-hiroh@chromium.org>","References":"<20201020091505.138898-1-hiroh@chromium.org>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v2 6/8] libcamera: Omit extra semicolons","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The end semicolons with LOG_DEFINE_CATEGORY,\nLOG_DECLARE_CATEGORY and REGISTER_PIPELINE_HANDLER are\nunnecessary.\n\nSigned-off-by: Hirokazu Honda \n---\n Documentation/guides/pipeline-handler.rst | 4 ++--\n src/libcamera/byte_stream_buffer.cpp | 2 +-\n src/libcamera/camera_sensor.cpp | 2 +-\n src/libcamera/file.cpp | 2 +-\n src/libcamera/pipeline/ipu3/ipu3.cpp | 4 ++--\n src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 2 +-\n src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp | 2 +-\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 2 +-\n src/libcamera/pipeline/simple/converter.cpp | 2 +-\n src/libcamera/pipeline/simple/simple.cpp | 2 +-\n src/libcamera/pipeline/uvcvideo/uvcvideo.cpp | 2 +-\n src/libcamera/pipeline/vimc/vimc.cpp | 2 +-\n src/libcamera/sysfs.cpp | 2 +-\n 13 files changed, 15 insertions(+), 15 deletions(-)","diff":"diff --git a/Documentation/guides/pipeline-handler.rst b/Documentation/guides/pipeline-handler.rst\nindex 71ef205..d0370f1 100644\n--- a/Documentation/guides/pipeline-handler.rst\n+++ b/Documentation/guides/pipeline-handler.rst\n@@ -258,7 +258,7 @@ methods for the overridden class members.\n return false;\n }\n \n- REGISTER_PIPELINE_HANDLER(PipelineHandlerVivid);\n+ REGISTER_PIPELINE_HANDLER(PipelineHandlerVivid)\n \n } /* namespace libcamera */\n \n@@ -1470,4 +1470,4 @@ application which will render the frames in a window for visual inspection:\n \n .. TODO: Running qcam with the vivid pipeline handler appears to have a bug and\n no visual frames are seen. However disabling zero-copy on qcam renders\n- them successfully.\n\\ No newline at end of file\n+ them successfully.\ndiff --git a/src/libcamera/byte_stream_buffer.cpp b/src/libcamera/byte_stream_buffer.cpp\nindex df7029b..7db5501 100644\n--- a/src/libcamera/byte_stream_buffer.cpp\n+++ b/src/libcamera/byte_stream_buffer.cpp\n@@ -14,7 +14,7 @@\n \n namespace libcamera {\n \n-LOG_DEFINE_CATEGORY(Serialization);\n+LOG_DEFINE_CATEGORY(Serialization)\n \n /**\n * \\file byte_stream_buffer.h\ndiff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp\nindex 78c7cee..935de52 100644\n--- a/src/libcamera/camera_sensor.cpp\n+++ b/src/libcamera/camera_sensor.cpp\n@@ -28,7 +28,7 @@\n \n namespace libcamera {\n \n-LOG_DEFINE_CATEGORY(CameraSensor);\n+LOG_DEFINE_CATEGORY(CameraSensor)\n \n /**\n * \\struct CameraSensorInfo\ndiff --git a/src/libcamera/file.cpp b/src/libcamera/file.cpp\nindex 04b0cb6..3a3f5bb 100644\n--- a/src/libcamera/file.cpp\n+++ b/src/libcamera/file.cpp\n@@ -23,7 +23,7 @@\n \n namespace libcamera {\n \n-LOG_DEFINE_CATEGORY(File);\n+LOG_DEFINE_CATEGORY(File)\n \n /**\n * \\class File\ndiff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\nindex f5a20d3..af47739 100644\n--- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n@@ -66,7 +66,7 @@ public:\n \n \tStatus validate() override;\n \n-\tconst StreamConfiguration &cio2Format() const { return cio2Configuration_; };\n+\tconst StreamConfiguration &cio2Format() const { return cio2Configuration_; }\n \tconst ImgUDevice::PipeConfig imguConfig() const { return pipeConfig_; }\n \n private:\n@@ -866,6 +866,6 @@ void IPU3CameraData::cio2BufferReady(FrameBuffer *buffer)\n \timgu_->input_->queueBuffer(buffer);\n }\n \n-REGISTER_PIPELINE_HANDLER(PipelineHandlerIPU3);\n+REGISTER_PIPELINE_HANDLER(PipelineHandlerIPU3)\n \n } /* namespace libcamera */\ndiff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\nindex 26dbd25..331ada7 100644\n--- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n+++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n@@ -1675,6 +1675,6 @@ FrameBuffer *RPiCameraData::updateQueue(std::queue &q, uint64_t t\n \treturn nullptr;\n }\n \n-REGISTER_PIPELINE_HANDLER(PipelineHandlerRPi);\n+REGISTER_PIPELINE_HANDLER(PipelineHandlerRPi)\n \n } /* namespace libcamera */\ndiff --git a/src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp b/src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp\nindex 0572acc..62605c0 100644\n--- a/src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp\n+++ b/src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp\n@@ -17,7 +17,7 @@\n \n namespace libcamera {\n \n-LOG_DEFINE_CATEGORY(RPI_S_W);\n+LOG_DEFINE_CATEGORY(RPI_S_W)\n \n namespace RPi {\n \ndiff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\nindex aec590f..2352ab3 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n@@ -1184,6 +1184,6 @@ void PipelineHandlerRkISP1::statReady(FrameBuffer *buffer)\n \tdata->ipa_->processEvent(op);\n }\n \n-REGISTER_PIPELINE_HANDLER(PipelineHandlerRkISP1);\n+REGISTER_PIPELINE_HANDLER(PipelineHandlerRkISP1)\n \n } /* namespace libcamera */\ndiff --git a/src/libcamera/pipeline/simple/converter.cpp b/src/libcamera/pipeline/simple/converter.cpp\nindex 75fb297..b4ee021 100644\n--- a/src/libcamera/pipeline/simple/converter.cpp\n+++ b/src/libcamera/pipeline/simple/converter.cpp\n@@ -21,7 +21,7 @@\n \n namespace libcamera {\n \n-LOG_DECLARE_CATEGORY(SimplePipeline);\n+LOG_DECLARE_CATEGORY(SimplePipeline)\n \n SimpleConverter::SimpleConverter(MediaDevice *media)\n \t: m2m_(nullptr)\ndiff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\nindex 7adb17e..8c00c0f 100644\n--- a/src/libcamera/pipeline/simple/simple.cpp\n+++ b/src/libcamera/pipeline/simple/simple.cpp\n@@ -942,6 +942,6 @@ void SimplePipelineHandler::converterDone(FrameBuffer *input,\n \tdata->video_->queueBuffer(input);\n }\n \n-REGISTER_PIPELINE_HANDLER(SimplePipelineHandler);\n+REGISTER_PIPELINE_HANDLER(SimplePipelineHandler)\n \n } /* namespace libcamera */\ndiff --git a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\nindex 8ec0dac..a903a82 100644\n--- a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n+++ b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n@@ -654,6 +654,6 @@ void UVCCameraData::bufferReady(FrameBuffer *buffer)\n \tpipe_->completeRequest(camera_, request);\n }\n \n-REGISTER_PIPELINE_HANDLER(PipelineHandlerUVC);\n+REGISTER_PIPELINE_HANDLER(PipelineHandlerUVC)\n \n } /* namespace libcamera */\ndiff --git a/src/libcamera/pipeline/vimc/vimc.cpp b/src/libcamera/pipeline/vimc/vimc.cpp\nindex fc8085f..7416c37 100644\n--- a/src/libcamera/pipeline/vimc/vimc.cpp\n+++ b/src/libcamera/pipeline/vimc/vimc.cpp\n@@ -533,6 +533,6 @@ void VimcCameraData::bufferReady(FrameBuffer *buffer)\n \tpipe_->completeRequest(camera_, request);\n }\n \n-REGISTER_PIPELINE_HANDLER(PipelineHandlerVimc);\n+REGISTER_PIPELINE_HANDLER(PipelineHandlerVimc)\n \n } /* namespace libcamera */\ndiff --git a/src/libcamera/sysfs.cpp b/src/libcamera/sysfs.cpp\nindex 6c8e955..3ebe66f 100644\n--- a/src/libcamera/sysfs.cpp\n+++ b/src/libcamera/sysfs.cpp\n@@ -22,7 +22,7 @@\n \n namespace libcamera {\n \n-LOG_DEFINE_CATEGORY(SysFs);\n+LOG_DEFINE_CATEGORY(SysFs)\n \n namespace sysfs {\n \n","prefixes":["libcamera-devel","v2","6/8"]}