[{"id":13282,"web_url":"https://patchwork.libcamera.org/comment/13282/","msgid":"<20201020095908.GA685599@oden.dyn.berto.se>","date":"2020-10-20T09:59:08","subject":"Re: [libcamera-devel] [PATCH v2 1/8] test: Omit extra semicolons","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hello Hirokazu-san,\n\nThanks for your work.\n\nOn 2020-10-20 18:14:58 +0900, Hirokazu Honda wrote:\n> TEST_REGISTER macro is main function. The end semicolon with the\n> macro is unnecessary.\n> \n> Signed-off-by: Hirokazu Honda <hiroh@chromium.org>\n> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\nFor the whole series,\n\nReviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n\n> ---\n>  test/camera/buffer_import.cpp                 | 2 +-\n>  test/camera/capture.cpp                       | 2 +-\n>  test/camera/configuration_default.cpp         | 2 +-\n>  test/camera/configuration_set.cpp             | 2 +-\n>  test/camera/statemachine.cpp                  | 2 +-\n>  test/mapped-buffer.cpp                        | 2 +-\n>  test/media_device/media_device_acquire.cpp    | 2 +-\n>  test/media_device/media_device_link_test.cpp  | 2 +-\n>  test/media_device/media_device_print_test.cpp | 2 +-\n>  test/v4l2_subdevice/list_formats.cpp          | 2 +-\n>  test/v4l2_subdevice/test_formats.cpp          | 2 +-\n>  test/v4l2_videodevice/buffer_cache.cpp        | 2 +-\n>  test/v4l2_videodevice/buffer_sharing.cpp      | 2 +-\n>  test/v4l2_videodevice/capture_async.cpp       | 2 +-\n>  test/v4l2_videodevice/controls.cpp            | 2 +-\n>  test/v4l2_videodevice/double_open.cpp         | 2 +-\n>  test/v4l2_videodevice/formats.cpp             | 2 +-\n>  test/v4l2_videodevice/request_buffers.cpp     | 2 +-\n>  test/v4l2_videodevice/stream_on_off.cpp       | 2 +-\n>  test/v4l2_videodevice/v4l2_m2mdevice.cpp      | 4 ++--\n>  20 files changed, 21 insertions(+), 21 deletions(-)\n> \n> diff --git a/test/camera/buffer_import.cpp b/test/camera/buffer_import.cpp\n> index 72ce7b7..4b626df 100644\n> --- a/test/camera/buffer_import.cpp\n> +++ b/test/camera/buffer_import.cpp\n> @@ -168,4 +168,4 @@ private:\n>  \n>  } /* namespace */\n>  \n> -TEST_REGISTER(BufferImportTest);\n> +TEST_REGISTER(BufferImportTest)\n> diff --git a/test/camera/capture.cpp b/test/camera/capture.cpp\n> index c077080..f13ca53 100644\n> --- a/test/camera/capture.cpp\n> +++ b/test/camera/capture.cpp\n> @@ -168,4 +168,4 @@ protected:\n>  \n>  } /* namespace */\n>  \n> -TEST_REGISTER(Capture);\n> +TEST_REGISTER(Capture)\n> diff --git a/test/camera/configuration_default.cpp b/test/camera/configuration_default.cpp\n> index cdd6cb9..c2b2019 100644\n> --- a/test/camera/configuration_default.cpp\n> +++ b/test/camera/configuration_default.cpp\n> @@ -56,4 +56,4 @@ protected:\n>  \n>  } /* namespace */\n>  \n> -TEST_REGISTER(ConfigurationDefault);\n> +TEST_REGISTER(ConfigurationDefault)\n> diff --git a/test/camera/configuration_set.cpp b/test/camera/configuration_set.cpp\n> index 30f19ba..a1dc446 100644\n> --- a/test/camera/configuration_set.cpp\n> +++ b/test/camera/configuration_set.cpp\n> @@ -102,4 +102,4 @@ protected:\n>  \n>  } /* namespace */\n>  \n> -TEST_REGISTER(ConfigurationSet);\n> +TEST_REGISTER(ConfigurationSet)\n> diff --git a/test/camera/statemachine.cpp b/test/camera/statemachine.cpp\n> index e63ab29..f0c3d77 100644\n> --- a/test/camera/statemachine.cpp\n> +++ b/test/camera/statemachine.cpp\n> @@ -211,4 +211,4 @@ protected:\n>  \n>  } /* namespace */\n>  \n> -TEST_REGISTER(Statemachine);\n> +TEST_REGISTER(Statemachine)\n> diff --git a/test/mapped-buffer.cpp b/test/mapped-buffer.cpp\n> index 0279233..5de8201 100644\n> --- a/test/mapped-buffer.cpp\n> +++ b/test/mapped-buffer.cpp\n> @@ -113,4 +113,4 @@ private:\n>  \n>  } /* namespace */\n>  \n> -TEST_REGISTER(MappedBufferTest);\n> +TEST_REGISTER(MappedBufferTest)\n> diff --git a/test/media_device/media_device_acquire.cpp b/test/media_device/media_device_acquire.cpp\n> index d1e3d74..371e30e 100644\n> --- a/test/media_device/media_device_acquire.cpp\n> +++ b/test/media_device/media_device_acquire.cpp\n> @@ -30,4 +30,4 @@ class MediaDeviceAcquire : public MediaDeviceTest\n>  \t}\n>  };\n>  \n> -TEST_REGISTER(MediaDeviceAcquire);\n> +TEST_REGISTER(MediaDeviceAcquire)\n> diff --git a/test/media_device/media_device_link_test.cpp b/test/media_device/media_device_link_test.cpp\n> index fe7542b..5c74905 100644\n> --- a/test/media_device/media_device_link_test.cpp\n> +++ b/test/media_device/media_device_link_test.cpp\n> @@ -219,4 +219,4 @@ class MediaDeviceLinkTest : public MediaDeviceTest\n>  \t}\n>  };\n>  \n> -TEST_REGISTER(MediaDeviceLinkTest);\n> +TEST_REGISTER(MediaDeviceLinkTest)\n> diff --git a/test/media_device/media_device_print_test.cpp b/test/media_device/media_device_print_test.cpp\n> index 1f5e3f3..436d4e8 100644\n> --- a/test/media_device/media_device_print_test.cpp\n> +++ b/test/media_device/media_device_print_test.cpp\n> @@ -151,4 +151,4 @@ int MediaDevicePrintTest::run()\n>  \treturn ret;\n>  }\n>  \n> -TEST_REGISTER(MediaDevicePrintTest);\n> +TEST_REGISTER(MediaDevicePrintTest)\n> diff --git a/test/v4l2_subdevice/list_formats.cpp b/test/v4l2_subdevice/list_formats.cpp\n> index a6044c0..74ec81a 100644\n> --- a/test/v4l2_subdevice/list_formats.cpp\n> +++ b/test/v4l2_subdevice/list_formats.cpp\n> @@ -79,4 +79,4 @@ int ListFormatsTest::run()\n>  \treturn TestPass;\n>  }\n>  \n> -TEST_REGISTER(ListFormatsTest);\n> +TEST_REGISTER(ListFormatsTest)\n> diff --git a/test/v4l2_subdevice/test_formats.cpp b/test/v4l2_subdevice/test_formats.cpp\n> index 679f50b..47f979e 100644\n> --- a/test/v4l2_subdevice/test_formats.cpp\n> +++ b/test/v4l2_subdevice/test_formats.cpp\n> @@ -75,4 +75,4 @@ int FormatHandlingTest::run()\n>  \treturn TestPass;\n>  }\n>  \n> -TEST_REGISTER(FormatHandlingTest);\n> +TEST_REGISTER(FormatHandlingTest)\n> diff --git a/test/v4l2_videodevice/buffer_cache.cpp b/test/v4l2_videodevice/buffer_cache.cpp\n> index b22de88..b3f2bec 100644\n> --- a/test/v4l2_videodevice/buffer_cache.cpp\n> +++ b/test/v4l2_videodevice/buffer_cache.cpp\n> @@ -213,4 +213,4 @@ private:\n>  \n>  } /* namespace */\n>  \n> -TEST_REGISTER(BufferCacheTest);\n> +TEST_REGISTER(BufferCacheTest)\n> diff --git a/test/v4l2_videodevice/buffer_sharing.cpp b/test/v4l2_videodevice/buffer_sharing.cpp\n> index ba2cc40..5e7e2d9 100644\n> --- a/test/v4l2_videodevice/buffer_sharing.cpp\n> +++ b/test/v4l2_videodevice/buffer_sharing.cpp\n> @@ -200,4 +200,4 @@ private:\n>  \tunsigned int framesOutput_;\n>  };\n>  \n> -TEST_REGISTER(BufferSharingTest);\n> +TEST_REGISTER(BufferSharingTest)\n> diff --git a/test/v4l2_videodevice/capture_async.cpp b/test/v4l2_videodevice/capture_async.cpp\n> index 13cbcc8..2b38102 100644\n> --- a/test/v4l2_videodevice/capture_async.cpp\n> +++ b/test/v4l2_videodevice/capture_async.cpp\n> @@ -88,4 +88,4 @@ private:\n>  \tunsigned int frames;\n>  };\n>  \n> -TEST_REGISTER(CaptureAsyncTest);\n> +TEST_REGISTER(CaptureAsyncTest)\n> diff --git a/test/v4l2_videodevice/controls.cpp b/test/v4l2_videodevice/controls.cpp\n> index 9f09d03..8d42508 100644\n> --- a/test/v4l2_videodevice/controls.cpp\n> +++ b/test/v4l2_videodevice/controls.cpp\n> @@ -127,4 +127,4 @@ protected:\n>  \t}\n>  };\n>  \n> -TEST_REGISTER(V4L2ControlTest);\n> +TEST_REGISTER(V4L2ControlTest)\n> diff --git a/test/v4l2_videodevice/double_open.cpp b/test/v4l2_videodevice/double_open.cpp\n> index 5768d40..7d11f6f 100644\n> --- a/test/v4l2_videodevice/double_open.cpp\n> +++ b/test/v4l2_videodevice/double_open.cpp\n> @@ -38,4 +38,4 @@ protected:\n>  \n>  } /* namespace */\n>  \n> -TEST_REGISTER(DoubleOpen);\n> +TEST_REGISTER(DoubleOpen)\n> diff --git a/test/v4l2_videodevice/formats.cpp b/test/v4l2_videodevice/formats.cpp\n> index 043732d..b5020d2 100644\n> --- a/test/v4l2_videodevice/formats.cpp\n> +++ b/test/v4l2_videodevice/formats.cpp\n> @@ -74,4 +74,4 @@ protected:\n>  \t}\n>  };\n>  \n> -TEST_REGISTER(Format);\n> +TEST_REGISTER(Format)\n> diff --git a/test/v4l2_videodevice/request_buffers.cpp b/test/v4l2_videodevice/request_buffers.cpp\n> index 2f8dfe1..fb57714 100644\n> --- a/test/v4l2_videodevice/request_buffers.cpp\n> +++ b/test/v4l2_videodevice/request_buffers.cpp\n> @@ -26,4 +26,4 @@ protected:\n>  \t}\n>  };\n>  \n> -TEST_REGISTER(RequestBuffersTest);\n> +TEST_REGISTER(RequestBuffersTest)\n> diff --git a/test/v4l2_videodevice/stream_on_off.cpp b/test/v4l2_videodevice/stream_on_off.cpp\n> index ce48310..4ed99e9 100644\n> --- a/test/v4l2_videodevice/stream_on_off.cpp\n> +++ b/test/v4l2_videodevice/stream_on_off.cpp\n> @@ -33,4 +33,4 @@ protected:\n>  \t}\n>  };\n>  \n> -TEST_REGISTER(StreamOnStreamOffTest);\n> +TEST_REGISTER(StreamOnStreamOffTest)\n> diff --git a/test/v4l2_videodevice/v4l2_m2mdevice.cpp b/test/v4l2_videodevice/v4l2_m2mdevice.cpp\n> index 44a39d4..616261e 100644\n> --- a/test/v4l2_videodevice/v4l2_m2mdevice.cpp\n> +++ b/test/v4l2_videodevice/v4l2_m2mdevice.cpp\n> @@ -187,7 +187,7 @@ protected:\n>  \tvoid cleanup()\n>  \t{\n>  \t\tdelete vim2m_;\n> -\t};\n> +\t}\n>  \n>  private:\n>  \tstd::unique_ptr<DeviceEnumerator> enumerator_;\n> @@ -201,4 +201,4 @@ private:\n>  \tunsigned int captureFrames_;\n>  };\n>  \n> -TEST_REGISTER(V4L2M2MDeviceTest);\n> +TEST_REGISTER(V4L2M2MDeviceTest)\n> -- \n> 2.29.0.rc1.297.gfa9743e501-goog\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8D732BDB13\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 20 Oct 2020 09:59:12 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1A52B61373;\n\tTue, 20 Oct 2020 11:59:12 +0200 (CEST)","from mail-lf1-x142.google.com (mail-lf1-x142.google.com\n\t[IPv6:2a00:1450:4864:20::142])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A914C60353\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 20 Oct 2020 11:59:10 +0200 (CEST)","by mail-lf1-x142.google.com with SMTP id 184so1365677lfd.6\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 20 Oct 2020 02:59:10 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\t192sm224584lfo.278.2020.10.20.02.59.08\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 20 Oct 2020 02:59:09 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"dKM6dd1G\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=FkIqK2ADXidz9UvFWNOf08zxCJk3Yna9ubUD+cKTlDw=;\n\tb=dKM6dd1GmsYlq3U2HPNeucYkq8i306firEHadJskeaZEPRLSIjN3p49og4Gep2UtSh\n\t+04YVnMbP3c+VNHeleSYp5req54Bo9hg4uyUbqAz/wPmUOn03/uhX4IqGsRSxSYL04U9\n\t4zqkuXbAhQQgEEp4o/NnmnyZGs5DfqGLYyP0smPHmCffAs3B6IXp6zfYuGbcCMHSzPiD\n\t9iERtdyf/IGNqXxG7egSKVHiIL6PiqtIgnlWroZ0OowBh8ahgw5BYXFASc8LtBdxwUbf\n\t20lrJ5gVEHOAzqnFkPAiV1JqL95tVhnpAB6rAX/9IERAuBRJdeuJnlzR9TW1w8l1QrFo\n\t5t1A==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=FkIqK2ADXidz9UvFWNOf08zxCJk3Yna9ubUD+cKTlDw=;\n\tb=gUZ6JnvnY4D3uMX5RzJg+hvsq0l9HP8+QVXuFxWDiGCuMY8wjYoGcemmAJtjBgbbvL\n\tqsO4RTUMPuT/11N0Gxvnn8cZUfO8tUrQctKuV43QCmVVdbx5O2IEI4wrevUj5rV8uEha\n\tfVgc46Mmi75wyvsmGHmfZz6FlBrWwrtjIR/TLNLHcB7CA6qqI1E7tanaV7oz/Ou0l9LF\n\t4NrWZ7x+jS2kf7LqeSgLHq+IjfeBbCmf49LGIL1+o1kae74kwH5OqoUm86ZhLoBh3RZ/\n\t0FN1J2F07LOymBMbioD1pkMes60SJETs05mn2EDWKgUWNvjQNGl0ylVT3OxdQMpJF9bM\n\twaWA==","X-Gm-Message-State":"AOAM532wZo7ZeAKwrWRkGM1pcvtP6FH88imjqBNCqtio5wsLEAcyotcW\n\t3t24QS+w9eqLMngz7U07Z/x/+g==","X-Google-Smtp-Source":"ABdhPJyNzDZSNZjG1w0PmUD9hqQ4JYGHu+Y+xluKpRDQrSqKo3FIbFZ8USA2TPXcxrnuY6ELki0+wQ==","X-Received":"by 2002:a05:6512:1182:: with SMTP id\n\tg2mr635743lfr.198.1603187949836; \n\tTue, 20 Oct 2020 02:59:09 -0700 (PDT)","Date":"Tue, 20 Oct 2020 11:59:08 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= <niklas.soderlund@ragnatech.se>","To":"Hirokazu Honda <hiroh@chromium.org>","Message-ID":"<20201020095908.GA685599@oden.dyn.berto.se>","References":"<20201020091505.138898-1-hiroh@chromium.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201020091505.138898-1-hiroh@chromium.org>","Subject":"Re: [libcamera-devel] [PATCH v2 1/8] test: Omit extra semicolons","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":13283,"web_url":"https://patchwork.libcamera.org/comment/13283/","msgid":"<be728ec0-f8a4-091d-c875-1ae054191fa3@ideasonboard.com>","date":"2020-10-20T10:00:25","subject":"Re: [libcamera-devel] [PATCH v2 1/8] test: Omit extra semicolons","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Hiro,\n\nI love a good cleanup, especially when the cleanup is then enforced by\ncompiler / checkstyle warnings ;-)\n\n\nOn 20/10/2020 10:14, Hirokazu Honda wrote:\n> TEST_REGISTER macro is main function. The end semicolon with the\n> macro is unnecessary.\n\n\nHrm, I wondered if we should/could handle this by making it actually use\na semi-colon in TEST_REGISTER ... but given the scope / definition of it\nimplements a main function - I don't think it's workable, or a way forwards.\n\nSo this looks good to me.\n\n> Signed-off-by: Hirokazu Honda <hiroh@chromium.org>\n> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\n\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\n> ---\n>  test/camera/buffer_import.cpp                 | 2 +-\n>  test/camera/capture.cpp                       | 2 +-\n>  test/camera/configuration_default.cpp         | 2 +-\n>  test/camera/configuration_set.cpp             | 2 +-\n>  test/camera/statemachine.cpp                  | 2 +-\n>  test/mapped-buffer.cpp                        | 2 +-\n>  test/media_device/media_device_acquire.cpp    | 2 +-\n>  test/media_device/media_device_link_test.cpp  | 2 +-\n>  test/media_device/media_device_print_test.cpp | 2 +-\n>  test/v4l2_subdevice/list_formats.cpp          | 2 +-\n>  test/v4l2_subdevice/test_formats.cpp          | 2 +-\n>  test/v4l2_videodevice/buffer_cache.cpp        | 2 +-\n>  test/v4l2_videodevice/buffer_sharing.cpp      | 2 +-\n>  test/v4l2_videodevice/capture_async.cpp       | 2 +-\n>  test/v4l2_videodevice/controls.cpp            | 2 +-\n>  test/v4l2_videodevice/double_open.cpp         | 2 +-\n>  test/v4l2_videodevice/formats.cpp             | 2 +-\n>  test/v4l2_videodevice/request_buffers.cpp     | 2 +-\n>  test/v4l2_videodevice/stream_on_off.cpp       | 2 +-\n>  test/v4l2_videodevice/v4l2_m2mdevice.cpp      | 4 ++--\n>  20 files changed, 21 insertions(+), 21 deletions(-)\n> \n> diff --git a/test/camera/buffer_import.cpp b/test/camera/buffer_import.cpp\n> index 72ce7b7..4b626df 100644\n> --- a/test/camera/buffer_import.cpp\n> +++ b/test/camera/buffer_import.cpp\n> @@ -168,4 +168,4 @@ private:\n>  \n>  } /* namespace */\n>  \n> -TEST_REGISTER(BufferImportTest);\n> +TEST_REGISTER(BufferImportTest)\n> diff --git a/test/camera/capture.cpp b/test/camera/capture.cpp\n> index c077080..f13ca53 100644\n> --- a/test/camera/capture.cpp\n> +++ b/test/camera/capture.cpp\n> @@ -168,4 +168,4 @@ protected:\n>  \n>  } /* namespace */\n>  \n> -TEST_REGISTER(Capture);\n> +TEST_REGISTER(Capture)\n> diff --git a/test/camera/configuration_default.cpp b/test/camera/configuration_default.cpp\n> index cdd6cb9..c2b2019 100644\n> --- a/test/camera/configuration_default.cpp\n> +++ b/test/camera/configuration_default.cpp\n> @@ -56,4 +56,4 @@ protected:\n>  \n>  } /* namespace */\n>  \n> -TEST_REGISTER(ConfigurationDefault);\n> +TEST_REGISTER(ConfigurationDefault)\n> diff --git a/test/camera/configuration_set.cpp b/test/camera/configuration_set.cpp\n> index 30f19ba..a1dc446 100644\n> --- a/test/camera/configuration_set.cpp\n> +++ b/test/camera/configuration_set.cpp\n> @@ -102,4 +102,4 @@ protected:\n>  \n>  } /* namespace */\n>  \n> -TEST_REGISTER(ConfigurationSet);\n> +TEST_REGISTER(ConfigurationSet)\n> diff --git a/test/camera/statemachine.cpp b/test/camera/statemachine.cpp\n> index e63ab29..f0c3d77 100644\n> --- a/test/camera/statemachine.cpp\n> +++ b/test/camera/statemachine.cpp\n> @@ -211,4 +211,4 @@ protected:\n>  \n>  } /* namespace */\n>  \n> -TEST_REGISTER(Statemachine);\n> +TEST_REGISTER(Statemachine)\n> diff --git a/test/mapped-buffer.cpp b/test/mapped-buffer.cpp\n> index 0279233..5de8201 100644\n> --- a/test/mapped-buffer.cpp\n> +++ b/test/mapped-buffer.cpp\n> @@ -113,4 +113,4 @@ private:\n>  \n>  } /* namespace */\n>  \n> -TEST_REGISTER(MappedBufferTest);\n> +TEST_REGISTER(MappedBufferTest)\n> diff --git a/test/media_device/media_device_acquire.cpp b/test/media_device/media_device_acquire.cpp\n> index d1e3d74..371e30e 100644\n> --- a/test/media_device/media_device_acquire.cpp\n> +++ b/test/media_device/media_device_acquire.cpp\n> @@ -30,4 +30,4 @@ class MediaDeviceAcquire : public MediaDeviceTest\n>  \t}\n>  };\n>  \n> -TEST_REGISTER(MediaDeviceAcquire);\n> +TEST_REGISTER(MediaDeviceAcquire)\n> diff --git a/test/media_device/media_device_link_test.cpp b/test/media_device/media_device_link_test.cpp\n> index fe7542b..5c74905 100644\n> --- a/test/media_device/media_device_link_test.cpp\n> +++ b/test/media_device/media_device_link_test.cpp\n> @@ -219,4 +219,4 @@ class MediaDeviceLinkTest : public MediaDeviceTest\n>  \t}\n>  };\n>  \n> -TEST_REGISTER(MediaDeviceLinkTest);\n> +TEST_REGISTER(MediaDeviceLinkTest)\n> diff --git a/test/media_device/media_device_print_test.cpp b/test/media_device/media_device_print_test.cpp\n> index 1f5e3f3..436d4e8 100644\n> --- a/test/media_device/media_device_print_test.cpp\n> +++ b/test/media_device/media_device_print_test.cpp\n> @@ -151,4 +151,4 @@ int MediaDevicePrintTest::run()\n>  \treturn ret;\n>  }\n>  \n> -TEST_REGISTER(MediaDevicePrintTest);\n> +TEST_REGISTER(MediaDevicePrintTest)\n> diff --git a/test/v4l2_subdevice/list_formats.cpp b/test/v4l2_subdevice/list_formats.cpp\n> index a6044c0..74ec81a 100644\n> --- a/test/v4l2_subdevice/list_formats.cpp\n> +++ b/test/v4l2_subdevice/list_formats.cpp\n> @@ -79,4 +79,4 @@ int ListFormatsTest::run()\n>  \treturn TestPass;\n>  }\n>  \n> -TEST_REGISTER(ListFormatsTest);\n> +TEST_REGISTER(ListFormatsTest)\n> diff --git a/test/v4l2_subdevice/test_formats.cpp b/test/v4l2_subdevice/test_formats.cpp\n> index 679f50b..47f979e 100644\n> --- a/test/v4l2_subdevice/test_formats.cpp\n> +++ b/test/v4l2_subdevice/test_formats.cpp\n> @@ -75,4 +75,4 @@ int FormatHandlingTest::run()\n>  \treturn TestPass;\n>  }\n>  \n> -TEST_REGISTER(FormatHandlingTest);\n> +TEST_REGISTER(FormatHandlingTest)\n> diff --git a/test/v4l2_videodevice/buffer_cache.cpp b/test/v4l2_videodevice/buffer_cache.cpp\n> index b22de88..b3f2bec 100644\n> --- a/test/v4l2_videodevice/buffer_cache.cpp\n> +++ b/test/v4l2_videodevice/buffer_cache.cpp\n> @@ -213,4 +213,4 @@ private:\n>  \n>  } /* namespace */\n>  \n> -TEST_REGISTER(BufferCacheTest);\n> +TEST_REGISTER(BufferCacheTest)\n> diff --git a/test/v4l2_videodevice/buffer_sharing.cpp b/test/v4l2_videodevice/buffer_sharing.cpp\n> index ba2cc40..5e7e2d9 100644\n> --- a/test/v4l2_videodevice/buffer_sharing.cpp\n> +++ b/test/v4l2_videodevice/buffer_sharing.cpp\n> @@ -200,4 +200,4 @@ private:\n>  \tunsigned int framesOutput_;\n>  };\n>  \n> -TEST_REGISTER(BufferSharingTest);\n> +TEST_REGISTER(BufferSharingTest)\n> diff --git a/test/v4l2_videodevice/capture_async.cpp b/test/v4l2_videodevice/capture_async.cpp\n> index 13cbcc8..2b38102 100644\n> --- a/test/v4l2_videodevice/capture_async.cpp\n> +++ b/test/v4l2_videodevice/capture_async.cpp\n> @@ -88,4 +88,4 @@ private:\n>  \tunsigned int frames;\n>  };\n>  \n> -TEST_REGISTER(CaptureAsyncTest);\n> +TEST_REGISTER(CaptureAsyncTest)\n> diff --git a/test/v4l2_videodevice/controls.cpp b/test/v4l2_videodevice/controls.cpp\n> index 9f09d03..8d42508 100644\n> --- a/test/v4l2_videodevice/controls.cpp\n> +++ b/test/v4l2_videodevice/controls.cpp\n> @@ -127,4 +127,4 @@ protected:\n>  \t}\n>  };\n>  \n> -TEST_REGISTER(V4L2ControlTest);\n> +TEST_REGISTER(V4L2ControlTest)\n> diff --git a/test/v4l2_videodevice/double_open.cpp b/test/v4l2_videodevice/double_open.cpp\n> index 5768d40..7d11f6f 100644\n> --- a/test/v4l2_videodevice/double_open.cpp\n> +++ b/test/v4l2_videodevice/double_open.cpp\n> @@ -38,4 +38,4 @@ protected:\n>  \n>  } /* namespace */\n>  \n> -TEST_REGISTER(DoubleOpen);\n> +TEST_REGISTER(DoubleOpen)\n> diff --git a/test/v4l2_videodevice/formats.cpp b/test/v4l2_videodevice/formats.cpp\n> index 043732d..b5020d2 100644\n> --- a/test/v4l2_videodevice/formats.cpp\n> +++ b/test/v4l2_videodevice/formats.cpp\n> @@ -74,4 +74,4 @@ protected:\n>  \t}\n>  };\n>  \n> -TEST_REGISTER(Format);\n> +TEST_REGISTER(Format)\n> diff --git a/test/v4l2_videodevice/request_buffers.cpp b/test/v4l2_videodevice/request_buffers.cpp\n> index 2f8dfe1..fb57714 100644\n> --- a/test/v4l2_videodevice/request_buffers.cpp\n> +++ b/test/v4l2_videodevice/request_buffers.cpp\n> @@ -26,4 +26,4 @@ protected:\n>  \t}\n>  };\n>  \n> -TEST_REGISTER(RequestBuffersTest);\n> +TEST_REGISTER(RequestBuffersTest)\n> diff --git a/test/v4l2_videodevice/stream_on_off.cpp b/test/v4l2_videodevice/stream_on_off.cpp\n> index ce48310..4ed99e9 100644\n> --- a/test/v4l2_videodevice/stream_on_off.cpp\n> +++ b/test/v4l2_videodevice/stream_on_off.cpp\n> @@ -33,4 +33,4 @@ protected:\n>  \t}\n>  };\n>  \n> -TEST_REGISTER(StreamOnStreamOffTest);\n> +TEST_REGISTER(StreamOnStreamOffTest)\n> diff --git a/test/v4l2_videodevice/v4l2_m2mdevice.cpp b/test/v4l2_videodevice/v4l2_m2mdevice.cpp\n> index 44a39d4..616261e 100644\n> --- a/test/v4l2_videodevice/v4l2_m2mdevice.cpp\n> +++ b/test/v4l2_videodevice/v4l2_m2mdevice.cpp\n> @@ -187,7 +187,7 @@ protected:\n>  \tvoid cleanup()\n>  \t{\n>  \t\tdelete vim2m_;\n> -\t};\n> +\t}\n>  \n>  private:\n>  \tstd::unique_ptr<DeviceEnumerator> enumerator_;\n> @@ -201,4 +201,4 @@ private:\n>  \tunsigned int captureFrames_;\n>  };\n>  \n> -TEST_REGISTER(V4L2M2MDeviceTest);\n> +TEST_REGISTER(V4L2M2MDeviceTest)\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F1439BDB13\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 20 Oct 2020 10:00:31 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BE5136052F;\n\tTue, 20 Oct 2020 12:00:31 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 83D71603AF\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 20 Oct 2020 12:00:30 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id F3AE252;\n\tTue, 20 Oct 2020 12:00:29 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"KJXlXn8W\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1603188030;\n\tbh=BWg4ER2UCUuZhLpiwmnAXdEuAYUqmGXV9vB+x/mlRwM=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=KJXlXn8Wh376taXfWoSMQi4EY5Bn8jdKGhR/h/sEldW2uDkLxvpj3y8Ho/nRuTtlD\n\ttCyQBRSiTb/sJVMQCQzJPb8aGpR0icfhR2DCkDRA5njXqCUkzYg7RM8lcQgqngdZH5\n\t3pLftrYA3puG2boXY1Zko88bK2SYd960NNri6gVw=","To":"Hirokazu Honda <hiroh@chromium.org>, libcamera-devel@lists.libcamera.org","References":"<20201020091505.138898-1-hiroh@chromium.org>","From":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<be728ec0-f8a4-091d-c875-1ae054191fa3@ideasonboard.com>","Date":"Tue, 20 Oct 2020 11:00:25 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20201020091505.138898-1-hiroh@chromium.org>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH v2 1/8] test: Omit extra semicolons","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]