[{"id":13301,"web_url":"https://patchwork.libcamera.org/comment/13301/","msgid":"","date":"2020-10-20T11:15:12","subject":"Re: [libcamera-devel] [PATCH v2 4/4] android: camera_stream: Make\n\tsome member variables constant","submitter":{"id":1,"url":"https://patchwork.libcamera.org/api/people/1/","name":"Umang Jain","email":"email@uajain.com"},"content":"Hi Hiro,\n\nThanks for your work.\n\nOn 10/20/20 1:12 PM, Hirokazu Honda wrote:\n> CameraStream initializes several member variables in the\n> initializer list. Some of them are unchanged after. This makes\n> them constant. Especially, doing to |cameraDevice_| represents\n> CameraStream doesn't have the ownership of it.\n>\n> Signed-off-by: Hirokazu Honda \n> ---\n> src/android/camera_stream.cpp | 7 +++----\n> src/android/camera_stream.h | 10 +++++-----\n> 2 files changed, 8 insertions(+), 9 deletions(-)\n>\n> diff --git a/src/android/camera_stream.cpp b/src/android/camera_stream.cpp\n> index 28a6e09..9644b74 100644\n> --- a/src/android/camera_stream.cpp\n> +++ b/src/android/camera_stream.cpp\n> @@ -38,13 +38,12 @@ LOG_DECLARE_CATEGORY(HAL);\n> * and buffer allocation.\n> */\n> \n> -CameraStream::CameraStream(CameraDevice *cameraDevice, Type type,\n> +CameraStream::CameraStream(CameraDevice const *cameraDevice, Type type,\n> \t\t\t camera3_stream_t *camera3Stream, unsigned int index)\n> -\t: cameraDevice_(cameraDevice), type_(type),\n> +\t: cameraDevice_(cameraDevice),\n> +\t config_(cameraDevice->cameraConfiguration()), type_(type),\n> \t camera3Stream_(camera3Stream), index_(index)\n> {\n> -\tconfig_ = cameraDevice_->cameraConfiguration();\n> -\n> \tif (type_ == Type::Internal || type_ == Type::Mapped) {\n> \t\t/*\n> \t\t * \\todo There might be multiple post-processors. The logic\n> diff --git a/src/android/camera_stream.h b/src/android/camera_stream.h\n> index c367a5f..23c139d 100644\n> --- a/src/android/camera_stream.h\n> +++ b/src/android/camera_stream.h\n> @@ -109,7 +109,7 @@ public:\n> \t\tInternal,\n> \t\tMapped,\n> \t};\n> -\tCameraStream(CameraDevice *cameraDevice, Type type,\n> +\tCameraStream(CameraDevice const *cameraDevice, Type type,\n> \t\t camera3_stream_t *camera3Stream, unsigned int index);\n> \n> \tType type() const { return type_; }\n> @@ -124,11 +124,11 @@ public:\n> \tvoid putBuffer(libcamera::FrameBuffer *buffer);\n> \n> private:\n> -\tCameraDevice *cameraDevice_;\n> -\tlibcamera::CameraConfiguration *config_;\n> -\tType type_;\n> +\tCameraDevice const *cameraDevice_;\n> +\tconst libcamera::CameraConfiguration *config_;\n> +\tconst Type type_;\nI am not really sure if type_ should be of const type. It is owned by \nthe CameraStream but yes, I don't think type_ would be mysteriously \nassigned to some other Type somewhere underneath. Jacopo, can you please \npitch in here if this seems good to you?\n\nReviewed-by: Umang Jain \n> \tcamera3_stream_t *camera3Stream_;\n> -\tunsigned int index_;\n> +\tconst unsigned int index_;\n> \n> \tstd::unique_ptr allocator_;\n> \tstd::vector buffers_;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C9609BDB1F\n\tfor ;\n\tTue, 20 Oct 2020 11:15:18 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5EAD861D85;\n\tTue, 20 Oct 2020 13:15:18 +0200 (CEST)","from mail.uajain.com (static.126.159.217.95.clients.your-server.de\n\t[95.217.159.126])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AB13160357\n\tfor ;\n\tTue, 20 Oct 2020 13:15:16 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=uajain.com header.i=@uajain.com\n\theader.b=\"mBYu2G9G\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=uajain.com; s=mail;\n\tt=1603192516; bh=djizAtkQ5nGvl68ym5tsONHdJTG4+XGT3ltwDHuWgGc=;\n\th=Subject:To:Cc:References:From:In-Reply-To;\n\tb=mBYu2G9GHoFu3DU0C/hqw2LaQB8q4TmokU1AJn+xyBZ+HS9U7yqr4ahaNlihHHOSI\n\teyihCnkxYKUg+MiyDkr8ikYbRRzCfXFIWVukiHr+sJX2bUE3HLv7FQFL5szda7966D\n\tlr5lflkPQZGTb9EbRIsX8x28JjgZ9XF4xdDDVWAihRTMUJ61zW8QnQS+Ii/DEEJvPS\n\trk0G/KKBja/UMY+OZ2uR1P32XYtuNNZZl9bBcF0AWSmxKhvbSklUs2WotH3Y9jrL9a\n\tw7swv0r33YP/fuvYwOczc8FS3qWfWY4tpZyuvOmOOD5La/tRQulng0hXwu4HjA/2kv\n\t6QDtlsf7Kd8iA==","To":"Hirokazu Honda , libcamera-devel@lists.libcamera.org","References":"<20201020074229.119151-1-hiroh@chromium.org>\n\t<20201020074229.119151-4-hiroh@chromium.org>","From":"Umang Jain ","Message-ID":"","Date":"Tue, 20 Oct 2020 16:45:12 +0530","Mime-Version":"1.0","In-Reply-To":"<20201020074229.119151-4-hiroh@chromium.org>","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH v2 4/4] android: camera_stream: Make\n\tsome member variables constant","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Transfer-Encoding":"7bit","Content-Type":"text/plain; charset=\"us-ascii\"; Format=\"flowed\"","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13306,"web_url":"https://patchwork.libcamera.org/comment/13306/","msgid":"<5260b810-2d18-402a-826a-b4bf1e6d4994@ideasonboard.com>","date":"2020-10-20T15:28:01","subject":"Re: [libcamera-devel] [PATCH v2 4/4] android: camera_stream: Make\n\tsome member variables constant","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Hiro/Umang,\n\nOn 20/10/2020 12:15, Umang Jain wrote:\n> Hi Hiro,\n> \n> Thanks for your work.\n> \n> On 10/20/20 1:12 PM, Hirokazu Honda wrote:\n>> CameraStream initializes several member variables in the\n>> initializer list. Some of them are unchanged after. This makes\n>> them constant. Especially, doing to |cameraDevice_| represents\n>> CameraStream doesn't have the ownership of it.\n>>\n>> Signed-off-by: Hirokazu Honda \n>> ---\n>>   src/android/camera_stream.cpp |  7 +++----\n>>   src/android/camera_stream.h   | 10 +++++-----\n>>   2 files changed, 8 insertions(+), 9 deletions(-)\n>>\n>> diff --git a/src/android/camera_stream.cpp\n>> b/src/android/camera_stream.cpp\n>> index 28a6e09..9644b74 100644\n>> --- a/src/android/camera_stream.cpp\n>> +++ b/src/android/camera_stream.cpp\n>> @@ -38,13 +38,12 @@ LOG_DECLARE_CATEGORY(HAL);\n>>    * and buffer allocation.\n>>    */\n>>   -CameraStream::CameraStream(CameraDevice *cameraDevice, Type type,\n>> +CameraStream::CameraStream(CameraDevice const *cameraDevice, Type type,\n>>                  camera3_stream_t *camera3Stream, unsigned int index)\n>> -    : cameraDevice_(cameraDevice), type_(type),\n>> +    : cameraDevice_(cameraDevice),\n>> +      config_(cameraDevice->cameraConfiguration()), type_(type),\n>>         camera3Stream_(camera3Stream), index_(index)\n>>   {\n>> -    config_ = cameraDevice_->cameraConfiguration();\n>> -\n>>       if (type_ == Type::Internal || type_ == Type::Mapped) {\n>>           /*\n>>            * \\todo There might be multiple post-processors. The logic\n>> diff --git a/src/android/camera_stream.h b/src/android/camera_stream.h\n>> index c367a5f..23c139d 100644\n>> --- a/src/android/camera_stream.h\n>> +++ b/src/android/camera_stream.h\n>> @@ -109,7 +109,7 @@ public:\n>>           Internal,\n>>           Mapped,\n>>       };\n>> -    CameraStream(CameraDevice *cameraDevice, Type type,\n>> +    CameraStream(CameraDevice const *cameraDevice, Type type,\n>>                camera3_stream_t *camera3Stream, unsigned int index);\n>>         Type type() const { return type_; }\n>> @@ -124,11 +124,11 @@ public:\n>>       void putBuffer(libcamera::FrameBuffer *buffer);\n>>     private:\n>> -    CameraDevice *cameraDevice_;\n>> -    libcamera::CameraConfiguration *config_;\n>> -    Type type_;\n>> +    CameraDevice const *cameraDevice_;\n>> +    const libcamera::CameraConfiguration *config_;\n>> +    const Type type_;\n> I am not really sure if type_ should be of const type. It is owned by\n> the CameraStream but yes, I don't think type_ would be mysteriously\n> assigned to some other Type somewhere underneath. Jacopo, can you please\n> pitch in here if this seems good to you?\n\nAs it stands at the moment, this is fine. The type_ should not change\nonce created.\n\nIf this usage changes in the future, then we can update, so I think this\nis fine.\n\nReviewed-by: Kieran Bingham \n\n> \n> Reviewed-by: Umang Jain \n>>       camera3_stream_t *camera3Stream_;\n>> -    unsigned int index_;\n>> +    const unsigned int index_;\n>>         std::unique_ptr allocator_;\n>>       std::vector buffers_;\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6EBE0BDB13\n\tfor ;\n\tTue, 20 Oct 2020 15:28:07 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F205661D83;\n\tTue, 20 Oct 2020 17:28:06 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1511961D7F\n\tfor ;\n\tTue, 20 Oct 2020 17:28:06 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7DC2552;\n\tTue, 20 Oct 2020 17:28:05 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"jrwC2wBp\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1603207685;\n\tbh=VwHIof9zpFw8DPJFgUvJ4DL+RFTAynLsKEqXilz56DU=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=jrwC2wBpkTMUzJbSGdUYxnOsrThEbtutumgll4cfX+sznik1PATX4Snnx6dmC80VJ\n\teTs2dhTIU4AFLKWg1tb/Eg7P+kuZCfsGzwaUryK4XosVmhwQ9iM1HL3555/i9QxHeg\n\tPH4o55mN1naSPRr0WRhyFUmEwHmNSuK3PrhLPbeI=","To":"Umang Jain , Hirokazu Honda ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20201020074229.119151-1-hiroh@chromium.org>\n\t<20201020074229.119151-4-hiroh@chromium.org>\n\t","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<5260b810-2d18-402a-826a-b4bf1e6d4994@ideasonboard.com>","Date":"Tue, 20 Oct 2020 16:28:01 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH v2 4/4] android: camera_stream: Make\n\tsome member variables constant","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13307,"web_url":"https://patchwork.libcamera.org/comment/13307/","msgid":"<20201020165847.GR18688@pendragon.ideasonboard.com>","date":"2020-10-20T16:58:47","subject":"Re: [libcamera-devel] [PATCH v2 4/4] android: camera_stream: Make\n\tsome member variables constant","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hello,\n\nOn Tue, Oct 20, 2020 at 04:28:01PM +0100, Kieran Bingham wrote:\n> On 20/10/2020 12:15, Umang Jain wrote:\n> > On 10/20/20 1:12 PM, Hirokazu Honda wrote:\n> >> CameraStream initializes several member variables in the\n> >> initializer list. Some of them are unchanged after. This makes\n> >> them constant. Especially, doing to |cameraDevice_| represents\n> >> CameraStream doesn't have the ownership of it.\n> >>\n> >> Signed-off-by: Hirokazu Honda \n> >> ---\n> >>   src/android/camera_stream.cpp |  7 +++----\n> >>   src/android/camera_stream.h   | 10 +++++-----\n> >>   2 files changed, 8 insertions(+), 9 deletions(-)\n> >>\n> >> diff --git a/src/android/camera_stream.cpp\n> >> b/src/android/camera_stream.cpp\n> >> index 28a6e09..9644b74 100644\n> >> --- a/src/android/camera_stream.cpp\n> >> +++ b/src/android/camera_stream.cpp\n> >> @@ -38,13 +38,12 @@ LOG_DECLARE_CATEGORY(HAL);\n> >>    * and buffer allocation.\n> >>    */\n> >>   -CameraStream::CameraStream(CameraDevice *cameraDevice, Type type,\n> >> +CameraStream::CameraStream(CameraDevice const *cameraDevice, Type type,\n> >>                  camera3_stream_t *camera3Stream, unsigned int index)\n> >> -    : cameraDevice_(cameraDevice), type_(type),\n> >> +    : cameraDevice_(cameraDevice),\n> >> +      config_(cameraDevice->cameraConfiguration()), type_(type),\n> >>         camera3Stream_(camera3Stream), index_(index)\n> >>   {\n> >> -    config_ = cameraDevice_->cameraConfiguration();\n> >> -\n> >>       if (type_ == Type::Internal || type_ == Type::Mapped) {\n> >>           /*\n> >>            * \\todo There might be multiple post-processors. The logic\n> >> diff --git a/src/android/camera_stream.h b/src/android/camera_stream.h\n> >> index c367a5f..23c139d 100644\n> >> --- a/src/android/camera_stream.h\n> >> +++ b/src/android/camera_stream.h\n> >> @@ -109,7 +109,7 @@ public:\n> >>           Internal,\n> >>           Mapped,\n> >>       };\n> >> -    CameraStream(CameraDevice *cameraDevice, Type type,\n> >> +    CameraStream(CameraDevice const *cameraDevice, Type type,\n> >>                camera3_stream_t *camera3Stream, unsigned int index);\n> >>         Type type() const { return type_; }\n> >> @@ -124,11 +124,11 @@ public:\n> >>       void putBuffer(libcamera::FrameBuffer *buffer);\n> >>     private:\n> >> -    CameraDevice *cameraDevice_;\n> >> -    libcamera::CameraConfiguration *config_;\n> >> -    Type type_;\n> >> +    CameraDevice const *cameraDevice_;\n> >> +    const libcamera::CameraConfiguration *config_;\n> >> +    const Type type_;\n> > I am not really sure if type_ should be of const type. It is owned by\n> > the CameraStream but yes, I don't think type_ would be mysteriously\n> > assigned to some other Type somewhere underneath. Jacopo, can you please\n> > pitch in here if this seems good to you?\n> \n> As it stands at the moment, this is fine. The type_ should not change\n> once created.\n> \n> If this usage changes in the future, then we can update, so I think this\n> is fine.\n\nQualifying class members that are not meant to change during the\nlifetime of an object is not something we currently do, and we should.\nThere's no need for tree-wide patches at this point, but let's remember\nthis good coding practice.\n\n> Reviewed-by: Kieran Bingham \n>\n> > Reviewed-by: Umang Jain \n> >\n> >>       camera3_stream_t *camera3Stream_;\n> >> -    unsigned int index_;\n> >> +    const unsigned int index_;\n> >>         std::unique_ptr allocator_;\n> >>       std::vector buffers_;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D6160BDB13\n\tfor ;\n\tTue, 20 Oct 2020 16:59:35 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4482F61DCD;\n\tTue, 20 Oct 2020 18:59:35 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C4B8561D89\n\tfor ;\n\tTue, 20 Oct 2020 18:59:33 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 32F2D92;\n\tTue, 20 Oct 2020 18:59:33 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"RppqEXVw\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1603213173;\n\tbh=pmk2PHhSB54D1oKsO7mWbI3J+/9qrJIYCf27kyWD0DU=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=RppqEXVw/SpfddYwAbU7//u5eBdbfOzIEph4NuzrQoBW4xWtaWsA0aaugeNOFZj27\n\t8htRK20ISwJLMzC+HSJhSnAhNDoI1ZVZln1tTzR9IKR5gN7pWcMCzXBHs6y61FTHsC\n\t5T21WL+qIfD+UFuY4lkOejPQaN9GVyDMf44WsX2A=","Date":"Tue, 20 Oct 2020 19:58:47 +0300","From":"Laurent Pinchart ","To":"Kieran Bingham ","Message-ID":"<20201020165847.GR18688@pendragon.ideasonboard.com>","References":"<20201020074229.119151-1-hiroh@chromium.org>\n\t<20201020074229.119151-4-hiroh@chromium.org>\n\t\n\t<5260b810-2d18-402a-826a-b4bf1e6d4994@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<5260b810-2d18-402a-826a-b4bf1e6d4994@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2 4/4] android: camera_stream: Make\n\tsome member variables constant","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13311,"web_url":"https://patchwork.libcamera.org/comment/13311/","msgid":"","date":"2020-10-21T01:06:32","subject":"Re: [libcamera-devel] [PATCH v2 4/4] android: camera_stream: Make\n\tsome member variables constant","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/people/63/","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"content":"Hi Uman, Kierna and Laurent,\n\nOn Wed, Oct 21, 2020 at 1:59 AM Laurent Pinchart\n wrote:\n>\n> Hello,\n>\n> On Tue, Oct 20, 2020 at 04:28:01PM +0100, Kieran Bingham wrote:\n> > On 20/10/2020 12:15, Umang Jain wrote:\n> > > On 10/20/20 1:12 PM, Hirokazu Honda wrote:\n> > >> CameraStream initializes several member variables in the\n> > >> initializer list. Some of them are unchanged after. This makes\n> > >> them constant. Especially, doing to |cameraDevice_| represents\n> > >> CameraStream doesn't have the ownership of it.\n> > >>\n> > >> Signed-off-by: Hirokazu Honda \n> > >> ---\n> > >> src/android/camera_stream.cpp | 7 +++----\n> > >> src/android/camera_stream.h | 10 +++++-----\n> > >> 2 files changed, 8 insertions(+), 9 deletions(-)\n> > >>\n> > >> diff --git a/src/android/camera_stream.cpp\n> > >> b/src/android/camera_stream.cpp\n> > >> index 28a6e09..9644b74 100644\n> > >> --- a/src/android/camera_stream.cpp\n> > >> +++ b/src/android/camera_stream.cpp\n> > >> @@ -38,13 +38,12 @@ LOG_DECLARE_CATEGORY(HAL);\n> > >> * and buffer allocation.\n> > >> */\n> > >> -CameraStream::CameraStream(CameraDevice *cameraDevice, Type type,\n> > >> +CameraStream::CameraStream(CameraDevice const *cameraDevice, Type type,\n> > >> camera3_stream_t *camera3Stream, unsigned int index)\n> > >> - : cameraDevice_(cameraDevice), type_(type),\n> > >> + : cameraDevice_(cameraDevice),\n> > >> + config_(cameraDevice->cameraConfiguration()), type_(type),\n> > >> camera3Stream_(camera3Stream), index_(index)\n> > >> {\n> > >> - config_ = cameraDevice_->cameraConfiguration();\n> > >> -\n> > >> if (type_ == Type::Internal || type_ == Type::Mapped) {\n> > >> /*\n> > >> * \\todo There might be multiple post-processors. The logic\n> > >> diff --git a/src/android/camera_stream.h b/src/android/camera_stream.h\n> > >> index c367a5f..23c139d 100644\n> > >> --- a/src/android/camera_stream.h\n> > >> +++ b/src/android/camera_stream.h\n> > >> @@ -109,7 +109,7 @@ public:\n> > >> Internal,\n> > >> Mapped,\n> > >> };\n> > >> - CameraStream(CameraDevice *cameraDevice, Type type,\n> > >> + CameraStream(CameraDevice const *cameraDevice, Type type,\n> > >> camera3_stream_t *camera3Stream, unsigned int index);\n> > >> Type type() const { return type_; }\n> > >> @@ -124,11 +124,11 @@ public:\n> > >> void putBuffer(libcamera::FrameBuffer *buffer);\n> > >> private:\n> > >> - CameraDevice *cameraDevice_;\n> > >> - libcamera::CameraConfiguration *config_;\n> > >> - Type type_;\n> > >> + CameraDevice const *cameraDevice_;\n> > >> + const libcamera::CameraConfiguration *config_;\n> > >> + const Type type_;\n> > > I am not really sure if type_ should be of const type. It is owned by\n> > > the CameraStream but yes, I don't think type_ would be mysteriously\n> > > assigned to some other Type somewhere underneath. Jacopo, can you please\n> > > pitch in here if this seems good to you?\n> >\n> > As it stands at the moment, this is fine. The type_ should not change\n> > once created.\n> >\n> > If this usage changes in the future, then we can update, so I think this\n> > is fine.\n>\n> Qualifying class members that are not meant to change during the\n> lifetime of an object is not something we currently do, and we should.\n> There's no need for tree-wide patches at this point, but let's remember\n> this good coding practice.\n>\n\nThanks for the comments.\nAck.\n\nBest Regards,\n-Hiro\n\n\n> > Reviewed-by: Kieran Bingham \n> >\n> > > Reviewed-by: Umang Jain \n> > >\n> > >> camera3_stream_t *camera3Stream_;\n> > >> - unsigned int index_;\n> > >> + const unsigned int index_;\n> > >> std::unique_ptr allocator_;\n> > >> std::vector buffers_;\n>\n> --\n> Regards,\n>\n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1F216BDB1F\n\tfor ;\n\tWed, 21 Oct 2020 01:06:45 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AE1A761D9E;\n\tWed, 21 Oct 2020 03:06:44 +0200 (CEST)","from mail-ej1-x641.google.com (mail-ej1-x641.google.com\n\t[IPv6:2a00:1450:4864:20::641])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 82BAA60350\n\tfor ;\n\tWed, 21 Oct 2020 03:06:43 +0200 (CEST)","by mail-ej1-x641.google.com with SMTP id e22so459333ejr.4\n\tfor ;\n\tTue, 20 Oct 2020 18:06:43 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"ldIWQRqk\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=QrtIxiPuYNSDQirT40ov9ITD1vr3k4Da35WErzzLmlg=;\n\tb=ldIWQRqkoxEIBddeJgzD3cpzDeNataZBnWt17SFRfKnmScxIj3kt0Q/n2ooKw5V4mV\n\tDZhMyVfDMJ4poN3dCH7+eaRllLa7nBopEOTdln3ZfqM+WIsqEnndUm6AwjKs5TBW15Rn\n\t0W1ELBUGFIns9CzDCeScHNH4qGAwZj5d6hbLQ=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=QrtIxiPuYNSDQirT40ov9ITD1vr3k4Da35WErzzLmlg=;\n\tb=B8uHod9/xBTaRSdwNqfkFkGabLgicW27mbz2YemJoOXBXKrOxma/xkmAYAwtenAcjX\n\tLI3VaIcJr6ORKB5sNtEIVl6k6pieBFscTMIhCvVxMgAlvCpqFndxgjVUzgZco+nsJIt3\n\tzIt/cr4mu63e/vE0UUhdAGf4ZOXwhp38fqlKHhA8k5vRu6xlAnWx9LLb2FP/OdIMLZyF\n\tWd4oLNwbm1PVjfcslJPFVJFpVdzmZixNSnC9jhfok/krN07hx7+kFCradLNDhKDyoQH2\n\tCv1gXv52R/XEespSJ8XdYdYvkz6tApvLrnXoLEzsAynOL8iipDPTrpWy6z+pMMp7bG1g\n\tSsBg==","X-Gm-Message-State":"AOAM5323IpdrtpWnQmmXhkJtmnCp31JRGmAr9xtF98/SAqmerLlzbskg\n\tCNSbgsad6tdR6uDiBCVZMMr0ls8XEqDjUKs6sd3otA==","X-Google-Smtp-Source":"ABdhPJy/sCR8GGJnvFuED3ZeQbuVdl3g41WpqmCndIi6+CL69iG1dk1W9dO5zAEJOkbCeupfBRyQ62vRKll3bznDuW0=","X-Received":"by 2002:a17:906:2894:: with SMTP id\n\to20mr851388ejd.221.1603242403115; \n\tTue, 20 Oct 2020 18:06:43 -0700 (PDT)","MIME-Version":"1.0","References":"<20201020074229.119151-1-hiroh@chromium.org>\n\t<20201020074229.119151-4-hiroh@chromium.org>\n\t\n\t<5260b810-2d18-402a-826a-b4bf1e6d4994@ideasonboard.com>\n\t<20201020165847.GR18688@pendragon.ideasonboard.com>","In-Reply-To":"<20201020165847.GR18688@pendragon.ideasonboard.com>","From":"Hirokazu Honda ","Date":"Wed, 21 Oct 2020 10:06:32 +0900","Message-ID":"","To":"Laurent Pinchart ","Subject":"Re: [libcamera-devel] [PATCH v2 4/4] android: camera_stream: Make\n\tsome member variables constant","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]