[{"id":13298,"web_url":"https://patchwork.libcamera.org/comment/13298/","msgid":"","date":"2020-10-20T10:45:21","subject":"Re: [libcamera-devel] [PATCH v2 3/4] android: post_processor_jpeg:\n\tMake |cameraDevice_| constant","submitter":{"id":1,"url":"https://patchwork.libcamera.org/api/people/1/","name":"Umang Jain","email":"email@uajain.com"},"content":"Hi Hiro,\n\nThanks for your work.\n\nOn 10/20/20 1:12 PM, Hirokazu Honda wrote:\n> PostProcessorJpeg doesn't have the ownership of CameraDevice given\n> in the constructor. To clarify it, this makes the member variable\n> constant.\n>\n> Signed-off-by: Hirokazu Honda \n> ---\n> src/android/jpeg/post_processor_jpeg.cpp | 2 +-\n> src/android/jpeg/post_processor_jpeg.h | 4 ++--\n> 2 files changed, 3 insertions(+), 3 deletions(-)\n>\n> diff --git a/src/android/jpeg/post_processor_jpeg.cpp b/src/android/jpeg/post_processor_jpeg.cpp\n> index 6f33631..f895d1f 100644\n> --- a/src/android/jpeg/post_processor_jpeg.cpp\n> +++ b/src/android/jpeg/post_processor_jpeg.cpp\n> @@ -20,7 +20,7 @@ using namespace libcamera;\n> \n> LOG_DEFINE_CATEGORY(JPEG);\n> \n> -PostProcessorJpeg::PostProcessorJpeg(CameraDevice *device)\n> +PostProcessorJpeg::PostProcessorJpeg(CameraDevice const *device)\n> \t: cameraDevice_(device)\n> {\n> }\n> diff --git a/src/android/jpeg/post_processor_jpeg.h b/src/android/jpeg/post_processor_jpeg.h\n> index ae636ff..8e25b29 100644\n> --- a/src/android/jpeg/post_processor_jpeg.h\n> +++ b/src/android/jpeg/post_processor_jpeg.h\n> @@ -19,7 +19,7 @@ class CameraDevice;\n> class PostProcessorJpeg : public PostProcessor\n> {\n> public:\n> -\tPostProcessorJpeg(CameraDevice *device);\n> +\tPostProcessorJpeg(CameraDevice const *device);\n> \n> \tint configure(const libcamera::StreamConfiguration &incfg,\n> \t\t const libcamera::StreamConfiguration &outcfg) override;\n> @@ -28,7 +28,7 @@ public:\n> \t\t CameraMetadata *metadata) override;\n> \n> private:\n> -\tCameraDevice *cameraDevice_;\n> +\tCameraDevice const *cameraDevice_;\n> \tstd::unique_ptr encoder_;\n> \tlibcamera::Size streamSize_;\n> };\nNot a hard-blocker but I think libcamera uses the other style for \n`const` definition - `const class *ptr_;` I would refer to overlords to \nuse their discretion here before pushing.\n\nReviewed-by: Umang Jain ","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1F7FABDB1F\n\tfor ;\n\tTue, 20 Oct 2020 10:45:28 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7EEC761D82;\n\tTue, 20 Oct 2020 12:45:27 +0200 (CEST)","from mail.uajain.com (static.126.159.217.95.clients.your-server.de\n\t[95.217.159.126])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BBA5460CDD\n\tfor ;\n\tTue, 20 Oct 2020 12:45:25 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=uajain.com header.i=@uajain.com\n\theader.b=\"U2cDQ9vk\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=uajain.com; s=mail;\n\tt=1603190725; bh=UE6lEUp+8Q/LjUTLtRdPuMq+aL/N2Q4JYuRWUP40azQ=;\n\th=Subject:To:Cc:References:From:In-Reply-To;\n\tb=U2cDQ9vk66GY9Jkrkw1mLRIxC8QP6B4d9Gp7SS+O4ccaAPofdCAPR9WoBmLdDwDty\n\tIOugwBHREfcvmM50ruPEZK06I3xA6ThnMyKNpJcYLhk1wkAmkrOFGXo+AQlQAL/qHb\n\tFxrVhInEMpSrgIubcTpfn0zbvI5/3PVWD9NDtEZfKrJCAnXcyY0l+8pE0Lrbc3cQtW\n\thlkBcpN03Z2Vw3K4SRPxOhW/DqW1K4n8oLQptI6Ax9RvP12gMeoqXvG76N/b5kVSAJ\n\tV+JpwyR/aukPdYnPRsNlAjMXFGeYyTWCd+dqwk7Aa+PVqjMYjrKDIZiDYwcDVFhG4B\n\tTDyexa1sQRW2A==","To":"Hirokazu Honda , libcamera-devel@lists.libcamera.org","References":"<20201020074229.119151-1-hiroh@chromium.org>\n\t<20201020074229.119151-3-hiroh@chromium.org>","From":"Umang Jain ","Message-ID":"","Date":"Tue, 20 Oct 2020 16:15:21 +0530","Mime-Version":"1.0","In-Reply-To":"<20201020074229.119151-3-hiroh@chromium.org>","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH v2 3/4] android: post_processor_jpeg:\n\tMake |cameraDevice_| constant","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Transfer-Encoding":"7bit","Content-Type":"text/plain; charset=\"us-ascii\"; Format=\"flowed\"","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13305,"web_url":"https://patchwork.libcamera.org/comment/13305/","msgid":"<96d9a929-5d71-63a9-d26d-30fc3654192f@ideasonboard.com>","date":"2020-10-20T15:08:37","subject":"Re: [libcamera-devel] [PATCH v2 3/4] android: post_processor_jpeg:\n\tMake |cameraDevice_| constant","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Hiro,\n\nOn 20/10/2020 11:45, Umang Jain wrote:\n> Hi Hiro,\n> \n> Thanks for your work.\n> \n> On 10/20/20 1:12 PM, Hirokazu Honda wrote:\n>> PostProcessorJpeg doesn't have the ownership of CameraDevice given\n>> in the constructor. To clarify it, this makes the member variable\n>> constant.\n>>\n>> Signed-off-by: Hirokazu Honda \n>> ---\n>>   src/android/jpeg/post_processor_jpeg.cpp | 2 +-\n>>   src/android/jpeg/post_processor_jpeg.h   | 4 ++--\n>>   2 files changed, 3 insertions(+), 3 deletions(-)\n>>\n>> diff --git a/src/android/jpeg/post_processor_jpeg.cpp\n>> b/src/android/jpeg/post_processor_jpeg.cpp\n>> index 6f33631..f895d1f 100644\n>> --- a/src/android/jpeg/post_processor_jpeg.cpp\n>> +++ b/src/android/jpeg/post_processor_jpeg.cpp\n>> @@ -20,7 +20,7 @@ using namespace libcamera;\n>>     LOG_DEFINE_CATEGORY(JPEG);\n>>   -PostProcessorJpeg::PostProcessorJpeg(CameraDevice *device)\n>> +PostProcessorJpeg::PostProcessorJpeg(CameraDevice const *device)\n>>       : cameraDevice_(device)\n>>   {\n>>   }\n>> diff --git a/src/android/jpeg/post_processor_jpeg.h\n>> b/src/android/jpeg/post_processor_jpeg.h\n>> index ae636ff..8e25b29 100644\n>> --- a/src/android/jpeg/post_processor_jpeg.h\n>> +++ b/src/android/jpeg/post_processor_jpeg.h\n>> @@ -19,7 +19,7 @@ class CameraDevice;\n>>   class PostProcessorJpeg : public PostProcessor\n>>   {\n>>   public:\n>> -    PostProcessorJpeg(CameraDevice *device);\n>> +    PostProcessorJpeg(CameraDevice const *device);\n>>         int configure(const libcamera::StreamConfiguration &incfg,\n>>                 const libcamera::StreamConfiguration &outcfg) override;\n>> @@ -28,7 +28,7 @@ public:\n>>               CameraMetadata *metadata) override;\n>>     private:\n>> -    CameraDevice *cameraDevice_;\n>> +    CameraDevice const *cameraDevice_;\n>>       std::unique_ptr encoder_;\n>>       libcamera::Size streamSize_;\n>>   };\n> Not a hard-blocker but I think libcamera uses the other style for\n> `const` definition - `const class *ptr_;` I would refer to overlords to\n> use their discretion here before pushing.\n\nIndeed, i think this should be a prefixed const.\n\nI can update locally, assuming there's nothing else critical.\n\nReviewed-by: Kieran Bingham \n\n> \n> Reviewed-by: Umang Jain \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A4F1DBDB1F\n\tfor ;\n\tTue, 20 Oct 2020 15:08:42 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 389D061D88;\n\tTue, 20 Oct 2020 17:08:42 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D8A8361D7F\n\tfor ;\n\tTue, 20 Oct 2020 17:08:40 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 51A8352;\n\tTue, 20 Oct 2020 17:08:40 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"bvP+j8f/\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1603206520;\n\tbh=eArT0ilxeBiuIu2CdtFsy0/ucEuWZwdUWlgh/Deg4+c=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=bvP+j8f/HZYyF5Ref+0Y+IpwxF0WcwpwRYCIksA7vFdvSDTP/CA8IWAfwVGXr6whn\n\tiVGjBqLqUGgLsoK3JqVxQMK+zrkAhJ/PYrOtEQ7p3lrUsfpcN7vrPO/JzAFDGGe4EH\n\tdlCkR4In5lMp+xL6IlIgVhcKMDJ8sl+F1/yB6gLA=","To":"Umang Jain , Hirokazu Honda ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20201020074229.119151-1-hiroh@chromium.org>\n\t<20201020074229.119151-3-hiroh@chromium.org>\n\t","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<96d9a929-5d71-63a9-d26d-30fc3654192f@ideasonboard.com>","Date":"Tue, 20 Oct 2020 16:08:37 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH v2 3/4] android: post_processor_jpeg:\n\tMake |cameraDevice_| constant","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13310,"web_url":"https://patchwork.libcamera.org/comment/13310/","msgid":"","date":"2020-10-21T01:03:59","subject":"Re: [libcamera-devel] [PATCH v2 3/4] android: post_processor_jpeg:\n\tMake |cameraDevice_| constant","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/people/63/","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"content":"On Wed, Oct 21, 2020 at 12:08 AM Kieran Bingham\n wrote:\n>\n> Hi Hiro,\n>\n> On 20/10/2020 11:45, Umang Jain wrote:\n> > Hi Hiro,\n> >\n> > Thanks for your work.\n> >\n> > On 10/20/20 1:12 PM, Hirokazu Honda wrote:\n> >> PostProcessorJpeg doesn't have the ownership of CameraDevice given\n> >> in the constructor. To clarify it, this makes the member variable\n> >> constant.\n> >>\n> >> Signed-off-by: Hirokazu Honda \n> >> ---\n> >> src/android/jpeg/post_processor_jpeg.cpp | 2 +-\n> >> src/android/jpeg/post_processor_jpeg.h | 4 ++--\n> >> 2 files changed, 3 insertions(+), 3 deletions(-)\n> >>\n> >> diff --git a/src/android/jpeg/post_processor_jpeg.cpp\n> >> b/src/android/jpeg/post_processor_jpeg.cpp\n> >> index 6f33631..f895d1f 100644\n> >> --- a/src/android/jpeg/post_processor_jpeg.cpp\n> >> +++ b/src/android/jpeg/post_processor_jpeg.cpp\n> >> @@ -20,7 +20,7 @@ using namespace libcamera;\n> >> LOG_DEFINE_CATEGORY(JPEG);\n> >> -PostProcessorJpeg::PostProcessorJpeg(CameraDevice *device)\n> >> +PostProcessorJpeg::PostProcessorJpeg(CameraDevice const *device)\n> >> : cameraDevice_(device)\n> >> {\n> >> }\n> >> diff --git a/src/android/jpeg/post_processor_jpeg.h\n> >> b/src/android/jpeg/post_processor_jpeg.h\n> >> index ae636ff..8e25b29 100644\n> >> --- a/src/android/jpeg/post_processor_jpeg.h\n> >> +++ b/src/android/jpeg/post_processor_jpeg.h\n> >> @@ -19,7 +19,7 @@ class CameraDevice;\n> >> class PostProcessorJpeg : public PostProcessor\n> >> {\n> >> public:\n> >> - PostProcessorJpeg(CameraDevice *device);\n> >> + PostProcessorJpeg(CameraDevice const *device);\n> >> int configure(const libcamera::StreamConfiguration &incfg,\n> >> const libcamera::StreamConfiguration &outcfg) override;\n> >> @@ -28,7 +28,7 @@ public:\n> >> CameraMetadata *metadata) override;\n> >> private:\n> >> - CameraDevice *cameraDevice_;\n> >> + CameraDevice const *cameraDevice_;\n> >> std::unique_ptr encoder_;\n> >> libcamera::Size streamSize_;\n> >> };\n> > Not a hard-blocker but I think libcamera uses the other style for\n> > `const` definition - `const class *ptr_;` I would refer to overlords to\n> > use their discretion here before pushing.\n>\n> Indeed, i think this should be a prefixed const.\n>\n\nOops, I made a mistake here.\nI intended to change it to `class *const ptr_`, which means the ptr\nvalue (not value pointed by the ptr) cannot be changed.\n(The mistake is because I have been writing for it as `class* const\nptr_` in my life.)\n\nI changed so in the next patch.\n\n> I can update locally, assuming there's nothing else critical.\n>\n> Reviewed-by: Kieran Bingham \n>\n> >\n> > Reviewed-by: Umang Jain \n> > _______________________________________________\n> > libcamera-devel mailing list\n> > libcamera-devel@lists.libcamera.org\n> > https://lists.libcamera.org/listinfo/libcamera-devel\n>\n> --\n> Regards\n> --\n> Kieran","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5D1A6BDB1F\n\tfor ;\n\tWed, 21 Oct 2020 01:04:12 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D8FC061DAB;\n\tWed, 21 Oct 2020 03:04:11 +0200 (CEST)","from mail-ed1-x544.google.com (mail-ed1-x544.google.com\n\t[IPv6:2a00:1450:4864:20::544])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B0C8B60350\n\tfor ;\n\tWed, 21 Oct 2020 03:04:10 +0200 (CEST)","by mail-ed1-x544.google.com with SMTP id dn5so642272edb.10\n\tfor ;\n\tTue, 20 Oct 2020 18:04:10 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"moIjG1/q\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=G7UojYXjT1KLw9ZD+UqUkKs979OY0uQK3c/TuXlIPLI=;\n\tb=moIjG1/qcBf0In1YmHwXJ0jz8QrGLNLALwIhnWm2Czd0lMGErPQqChm4x99P+bWn0Z\n\tvtdY668B6OEmoAFht/h5Muv1DiHwAPjftHAFCHrvRW4bK6I8NxrC3cEvYGnjua5WLOqZ\n\tnOS78XD8kGVndck7dU5yktO7D51cadgRE2CJw=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=G7UojYXjT1KLw9ZD+UqUkKs979OY0uQK3c/TuXlIPLI=;\n\tb=XPYoPcVkgnHJHcjO0hdahRYjlrtdQn3d3SKJGciUvRTo2NHbKE6N0gqx2oNjOZ9wya\n\tHbZVsRQphSR+wvFJpgNvq10l2tsq2oTYA2fZiEZsMXQfvi4ORI7sHT11s44mwCnaZckM\n\tOvAHCxm812hSeo9sUki+nFjoC30BjmXSYvvsZy2cltIANC7JDaTAwMgoxWfrRe/pHmPP\n\t0sCVfxdCDtk5yGPzTiRQacmZx3asFPM0xPYGN8PLdpR+iQ5LG+B+NYgprBjR+M0mBaB+\n\tKW6+eL4+odeaOVH2xJbQTqBDWOVVCWboS7tt6fqZm/LFQ8n23JzjBhlIqeMCwaxQR5ZP\n\tZrnA==","X-Gm-Message-State":"AOAM531QvIqtQHBFPsEDMELhY4uXr0fY0u2LnZPFHUsKGO+6LwchSZMD\n\tL6rKeerTIvSvJwaygi4iCoDh8cMxkW/3CuZR+QDxWXhB4GU=","X-Google-Smtp-Source":"ABdhPJx0RDZPrEeYL579bkUFOtEFMLQkOss4LwcmiCJcDX5f0bwsDUiI90PqpMI+VO4vp4fIu4twrZ7QtfPqpfO7COk=","X-Received":"by 2002:a50:ef0a:: with SMTP id m10mr659155eds.116.1603242250240;\n\tTue, 20 Oct 2020 18:04:10 -0700 (PDT)","MIME-Version":"1.0","References":"<20201020074229.119151-1-hiroh@chromium.org>\n\t<20201020074229.119151-3-hiroh@chromium.org>\n\t\n\t<96d9a929-5d71-63a9-d26d-30fc3654192f@ideasonboard.com>","In-Reply-To":"<96d9a929-5d71-63a9-d26d-30fc3654192f@ideasonboard.com>","From":"Hirokazu Honda ","Date":"Wed, 21 Oct 2020 10:03:59 +0900","Message-ID":"","To":"kieran.bingham@ideasonboard.com","Subject":"Re: [libcamera-devel] [PATCH v2 3/4] android: post_processor_jpeg:\n\tMake |cameraDevice_| constant","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]