[{"id":13295,"web_url":"https://patchwork.libcamera.org/comment/13295/","msgid":"","date":"2020-10-20T10:38:40","subject":"Re: [libcamera-devel] [PATCH v2 2/4] android: Modify Encoder\n\tinterface","submitter":{"id":1,"url":"https://patchwork.libcamera.org/api/people/1/","name":"Umang Jain","email":"email@uajain.com"},"content":"Hi Hiro,\n\nThanks for your work.\n\nOn 10/20/20 1:12 PM, Hirokazu Honda wrote:\n> In Encoder::encode(), the |source| argument doesn't have to be a\n> pointer. This replaces its type, const pointer, with const\n> reference as the latter is preferred to the former.\n> libcamera::Span is chea to construct/copy/move. We should deal\ns/chea/cheap\n> with the type as pass-by-value parameter. Therefore this also\n> drops the const reference in the |destination| argument.\n>\n> Signed-off-by: Hirokazu Honda \nLGTM again.\nReviewed-by: Umang Jain \n> ---\n> src/android/jpeg/encoder.h | 4 ++--\n> src/android/jpeg/encoder_libjpeg.cpp | 6 +++---\n> src/android/jpeg/encoder_libjpeg.h | 4 ++--\n> src/android/jpeg/post_processor_jpeg.cpp | 2 +-\n> 4 files changed, 8 insertions(+), 8 deletions(-)\n>\n> diff --git a/src/android/jpeg/encoder.h b/src/android/jpeg/encoder.h\n> index 4483153..4fe71cf 100644\n> --- a/src/android/jpeg/encoder.h\n> +++ b/src/android/jpeg/encoder.h\n> @@ -17,8 +17,8 @@ public:\n> \tvirtual ~Encoder() {};\n> \n> \tvirtual int configure(const libcamera::StreamConfiguration &cfg) = 0;\n> -\tvirtual int encode(const libcamera::FrameBuffer *source,\n> -\t\t\t const libcamera::Span &destination,\n> +\tvirtual int encode(const libcamera::FrameBuffer &source,\n> +\t\t\t libcamera::Span destination,\n> \t\t\t const libcamera::Span &exifData) = 0;\n> };\n> \n> diff --git a/src/android/jpeg/encoder_libjpeg.cpp b/src/android/jpeg/encoder_libjpeg.cpp\n> index 8995ba5..4236c9d 100644\n> --- a/src/android/jpeg/encoder_libjpeg.cpp\n> +++ b/src/android/jpeg/encoder_libjpeg.cpp\n> @@ -179,11 +179,11 @@ void EncoderLibJpeg::compressNV(const libcamera::MappedBuffer *frame)\n> \t}\n> }\n> \n> -int EncoderLibJpeg::encode(const FrameBuffer *source,\n> -\t\t\t const libcamera::Span &dest,\n> +int EncoderLibJpeg::encode(const FrameBuffer &source,\n> +\t\t\t libcamera::Span dest,\n> \t\t\t const libcamera::Span &exifData)\n> {\n> -\tMappedFrameBuffer frame(source, PROT_READ);\n> +\tMappedFrameBuffer frame(&source, PROT_READ);\n> \tif (!frame.isValid()) {\n> \t\tLOG(JPEG, Error) << \"Failed to map FrameBuffer : \"\n> \t\t\t\t << strerror(frame.error());\n> diff --git a/src/android/jpeg/encoder_libjpeg.h b/src/android/jpeg/encoder_libjpeg.h\n> index 934caef..391a53c 100644\n> --- a/src/android/jpeg/encoder_libjpeg.h\n> +++ b/src/android/jpeg/encoder_libjpeg.h\n> @@ -21,8 +21,8 @@ public:\n> \t~EncoderLibJpeg();\n> \n> \tint configure(const libcamera::StreamConfiguration &cfg) override;\n> -\tint encode(const libcamera::FrameBuffer *source,\n> -\t\t const libcamera::Span &destination,\n> +\tint encode(const libcamera::FrameBuffer &source,\n> +\t\t libcamera::Span destination,\n> \t\t const libcamera::Span &exifData) override;\n> \n> private:\n> diff --git a/src/android/jpeg/post_processor_jpeg.cpp b/src/android/jpeg/post_processor_jpeg.cpp\n> index 55b9088..6f33631 100644\n> --- a/src/android/jpeg/post_processor_jpeg.cpp\n> +++ b/src/android/jpeg/post_processor_jpeg.cpp\n> @@ -67,7 +67,7 @@ int PostProcessorJpeg::process(const libcamera::FrameBuffer &source,\n> \tif (exif.generate() != 0)\n> \t\tLOG(JPEG, Error) << \"Failed to generate valid EXIF data\";\n> \n> -\tint jpeg_size = encoder_->encode(&source, destination, exif.data());\n> +\tint jpeg_size = encoder_->encode(source, destination, exif.data());\nPerfect. I was expecting this from v1.\n> \tif (jpeg_size < 0) {\n> \t\tLOG(JPEG, Error) << \"Failed to encode stream image\";\n> \t\treturn jpeg_size;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D9F41BDB13\n\tfor ;\n\tTue, 20 Oct 2020 10:38:46 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A7F9861D7F;\n\tTue, 20 Oct 2020 12:38:46 +0200 (CEST)","from mail.uajain.com (static.126.159.217.95.clients.your-server.de\n\t[95.217.159.126])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id ACA5460CDD\n\tfor ;\n\tTue, 20 Oct 2020 12:38:45 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=uajain.com header.i=@uajain.com\n\theader.b=\"jRHB8fRl\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=uajain.com; s=mail;\n\tt=1603190325; bh=5JSxQu+kKA5Hfb6Lz4QDxi2fs5C2zd38844g7+3mrmk=;\n\th=Subject:To:Cc:References:From:In-Reply-To;\n\tb=jRHB8fRlkQPc92unRIHOteKA+fC5RfSDe3Q3BGIyoQhAO4SqTSDQNCnmijA3cphd0\n\tgwrr3o/G0ukSsBc5kEOrkTbjZS41dQ7Fvb8qfKudXQYyoxpieqilGTabMelFFy5zVH\n\tef8iCkhQ2VL+ZY4L28+eNh8ejUo3if1Vph31uxa6g1A98ftccwfbBMNS4R51g6/y8b\n\tClGIyQu4RWD9QlxzYqfR9fzwPwdC2g+YFDtlk7zNTsEToLVatkrFcq3ypPgyC8cKMk\n\tfWkoTDMJRzL5y59byaXE6DRS6UTiIy18HrY+Xjc2olKzGiYxvV6DHjZdbnDV/DLghl\n\tP2R1rrC7JFX5w==","To":"Hirokazu Honda , libcamera-devel@lists.libcamera.org","References":"<20201020074229.119151-1-hiroh@chromium.org>\n\t<20201020074229.119151-2-hiroh@chromium.org>","From":"Umang Jain ","Message-ID":"","Date":"Tue, 20 Oct 2020 16:08:40 +0530","Mime-Version":"1.0","In-Reply-To":"<20201020074229.119151-2-hiroh@chromium.org>","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH v2 2/4] android: Modify Encoder\n\tinterface","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Transfer-Encoding":"7bit","Content-Type":"text/plain; charset=\"us-ascii\"; Format=\"flowed\"","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13302,"web_url":"https://patchwork.libcamera.org/comment/13302/","msgid":"<5320ee4a-c373-b120-3c8c-33d4549567b3@ideasonboard.com>","date":"2020-10-20T14:57:39","subject":"Re: [libcamera-devel] [PATCH v2 2/4] android: Modify Encoder\n\tinterface","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Hiro,\n\nOn 20/10/2020 11:38, Umang Jain wrote:\n> Hi Hiro,\n> \n> Thanks for your work.\n> \n> On 10/20/20 1:12 PM, Hirokazu Honda wrote:\n>> In Encoder::encode(), the |source| argument doesn't have to be a\n>> pointer. This replaces its type, const pointer, with const\n>> reference as the latter is preferred to the former.\n>> libcamera::Span is chea to construct/copy/move. We should deal\n> s/chea/cheap\n\nHrm, this is fine in the original. Must have caught it while editing.\n\n>> with the type as pass-by-value parameter. Therefore this also\n>> drops the const reference in the |destination| argument.\n>>\n>> Signed-off-by: Hirokazu Honda \n> LGTM again.\n> Reviewed-by: Umang Jain \n\nReviewed-by: Kieran Bingham \n\n>> ---\n>>   src/android/jpeg/encoder.h               | 4 ++--\n>>   src/android/jpeg/encoder_libjpeg.cpp     | 6 +++---\n>>   src/android/jpeg/encoder_libjpeg.h       | 4 ++--\n>>   src/android/jpeg/post_processor_jpeg.cpp | 2 +-\n>>   4 files changed, 8 insertions(+), 8 deletions(-)\n>>\n>> diff --git a/src/android/jpeg/encoder.h b/src/android/jpeg/encoder.h\n>> index 4483153..4fe71cf 100644\n>> --- a/src/android/jpeg/encoder.h\n>> +++ b/src/android/jpeg/encoder.h\n>> @@ -17,8 +17,8 @@ public:\n>>       virtual ~Encoder() {};\n>>         virtual int configure(const libcamera::StreamConfiguration\n>> &cfg) = 0;\n>> -    virtual int encode(const libcamera::FrameBuffer *source,\n>> -               const libcamera::Span &destination,\n>> +    virtual int encode(const libcamera::FrameBuffer &source,\n>> +               libcamera::Span destination,\n>>                  const libcamera::Span &exifData) = 0;\n>>   };\n>>   diff --git a/src/android/jpeg/encoder_libjpeg.cpp\n>> b/src/android/jpeg/encoder_libjpeg.cpp\n>> index 8995ba5..4236c9d 100644\n>> --- a/src/android/jpeg/encoder_libjpeg.cpp\n>> +++ b/src/android/jpeg/encoder_libjpeg.cpp\n>> @@ -179,11 +179,11 @@ void EncoderLibJpeg::compressNV(const\n>> libcamera::MappedBuffer *frame)\n>>       }\n>>   }\n>>   -int EncoderLibJpeg::encode(const FrameBuffer *source,\n>> -               const libcamera::Span &dest,\n>> +int EncoderLibJpeg::encode(const FrameBuffer &source,\n>> +               libcamera::Span dest,\n>>                  const libcamera::Span &exifData)\n>>   {\n>> -    MappedFrameBuffer frame(source, PROT_READ);\n>> +    MappedFrameBuffer frame(&source, PROT_READ);\n\nPerhaps MappedFrameBuffer should also take a reference, but lets not\nworry about that here.\n\n>>       if (!frame.isValid()) {\n>>           LOG(JPEG, Error) << \"Failed to map FrameBuffer : \"\n>>                    << strerror(frame.error());\n>> diff --git a/src/android/jpeg/encoder_libjpeg.h\n>> b/src/android/jpeg/encoder_libjpeg.h\n>> index 934caef..391a53c 100644\n>> --- a/src/android/jpeg/encoder_libjpeg.h\n>> +++ b/src/android/jpeg/encoder_libjpeg.h\n>> @@ -21,8 +21,8 @@ public:\n>>       ~EncoderLibJpeg();\n>>         int configure(const libcamera::StreamConfiguration &cfg)\n>> override;\n>> -    int encode(const libcamera::FrameBuffer *source,\n>> -           const libcamera::Span &destination,\n>> +    int encode(const libcamera::FrameBuffer &source,\n>> +           libcamera::Span destination,\n>>              const libcamera::Span &exifData) override;\n>>     private:\n>> diff --git a/src/android/jpeg/post_processor_jpeg.cpp\n>> b/src/android/jpeg/post_processor_jpeg.cpp\n>> index 55b9088..6f33631 100644\n>> --- a/src/android/jpeg/post_processor_jpeg.cpp\n>> +++ b/src/android/jpeg/post_processor_jpeg.cpp\n>> @@ -67,7 +67,7 @@ int PostProcessorJpeg::process(const\n>> libcamera::FrameBuffer &source,\n>>       if (exif.generate() != 0)\n>>           LOG(JPEG, Error) << \"Failed to generate valid EXIF data\";\n>>   -    int jpeg_size = encoder_->encode(&source, destination,\n>> exif.data());\n>> +    int jpeg_size = encoder_->encode(source, destination, exif.data());\n> Perfect. I was expecting this from v1.\n>>       if (jpeg_size < 0) {\n>>           LOG(JPEG, Error) << \"Failed to encode stream image\";\n>>           return jpeg_size;\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 06208BDB1F\n\tfor ;\n\tTue, 20 Oct 2020 14:57:45 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 63AE261D85;\n\tTue, 20 Oct 2020 16:57:44 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9A18760357\n\tfor ;\n\tTue, 20 Oct 2020 16:57:43 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6C08752;\n\tTue, 20 Oct 2020 16:57:42 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"VdqCQiIg\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1603205863;\n\tbh=lz9/U4FRJO4IE317BXd4QhUxRugDKinReQAZfSR3OCM=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=VdqCQiIglBpRIS0kl60dFb6fn6tQAcmEnFdrbETz5GUo64Mhgx03+fjf2SiIVeFEV\n\tGtdcjcllEaTRMRriP5CyMRhzRj7btBQAiSiwSlgk19JIAHIyBw7BiEkPjw3l3FXe5X\n\ts7rwf0OSztTmmvAHU9Veyi+/6y7PkgA885W2E9eQ=","To":"Umang Jain , Hirokazu Honda ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20201020074229.119151-1-hiroh@chromium.org>\n\t<20201020074229.119151-2-hiroh@chromium.org>\n\t","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<5320ee4a-c373-b120-3c8c-33d4549567b3@ideasonboard.com>","Date":"Tue, 20 Oct 2020 15:57:39 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH v2 2/4] android: Modify Encoder\n\tinterface","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13304,"web_url":"https://patchwork.libcamera.org/comment/13304/","msgid":"","date":"2020-10-20T15:05:27","subject":"Re: [libcamera-devel] [PATCH v2 2/4] android: Modify Encoder\n\tinterface","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"On 20/10/2020 15:57, Kieran Bingham wrote:\n> Hi Hiro,\n> \n> On 20/10/2020 11:38, Umang Jain wrote:\n>> Hi Hiro,\n>>\n>> Thanks for your work.\n>>\n>> On 10/20/20 1:12 PM, Hirokazu Honda wrote:\n>>> In Encoder::encode(), the |source| argument doesn't have to be a\n>>> pointer. This replaces its type, const pointer, with const\n>>> reference as the latter is preferred to the former.\n>>> libcamera::Span is chea to construct/copy/move. We should deal\n>> s/chea/cheap\n> \n> Hrm, this is fine in the original. Must have caught it while editing.\n\nIgnore that - I was comparing against a different patch ;-)\n\nFixed up here locally.\n\n> \n>>> with the type as pass-by-value parameter. Therefore this also\n>>> drops the const reference in the |destination| argument.\n>>>\n>>> Signed-off-by: Hirokazu Honda \n>> LGTM again.\n>> Reviewed-by: Umang Jain \n> \n> Reviewed-by: Kieran Bingham \n> \n>>> ---\n>>>   src/android/jpeg/encoder.h               | 4 ++--\n>>>   src/android/jpeg/encoder_libjpeg.cpp     | 6 +++---\n>>>   src/android/jpeg/encoder_libjpeg.h       | 4 ++--\n>>>   src/android/jpeg/post_processor_jpeg.cpp | 2 +-\n>>>   4 files changed, 8 insertions(+), 8 deletions(-)\n>>>\n>>> diff --git a/src/android/jpeg/encoder.h b/src/android/jpeg/encoder.h\n>>> index 4483153..4fe71cf 100644\n>>> --- a/src/android/jpeg/encoder.h\n>>> +++ b/src/android/jpeg/encoder.h\n>>> @@ -17,8 +17,8 @@ public:\n>>>       virtual ~Encoder() {};\n>>>         virtual int configure(const libcamera::StreamConfiguration\n>>> &cfg) = 0;\n>>> -    virtual int encode(const libcamera::FrameBuffer *source,\n>>> -               const libcamera::Span &destination,\n>>> +    virtual int encode(const libcamera::FrameBuffer &source,\n>>> +               libcamera::Span destination,\n>>>                  const libcamera::Span &exifData) = 0;\n>>>   };\n>>>   diff --git a/src/android/jpeg/encoder_libjpeg.cpp\n>>> b/src/android/jpeg/encoder_libjpeg.cpp\n>>> index 8995ba5..4236c9d 100644\n>>> --- a/src/android/jpeg/encoder_libjpeg.cpp\n>>> +++ b/src/android/jpeg/encoder_libjpeg.cpp\n>>> @@ -179,11 +179,11 @@ void EncoderLibJpeg::compressNV(const\n>>> libcamera::MappedBuffer *frame)\n>>>       }\n>>>   }\n>>>   -int EncoderLibJpeg::encode(const FrameBuffer *source,\n>>> -               const libcamera::Span &dest,\n>>> +int EncoderLibJpeg::encode(const FrameBuffer &source,\n>>> +               libcamera::Span dest,\n>>>                  const libcamera::Span &exifData)\n>>>   {\n>>> -    MappedFrameBuffer frame(source, PROT_READ);\n>>> +    MappedFrameBuffer frame(&source, PROT_READ);\n> \n> Perhaps MappedFrameBuffer should also take a reference, but lets not\n> worry about that here.\n> \n>>>       if (!frame.isValid()) {\n>>>           LOG(JPEG, Error) << \"Failed to map FrameBuffer : \"\n>>>                    << strerror(frame.error());\n>>> diff --git a/src/android/jpeg/encoder_libjpeg.h\n>>> b/src/android/jpeg/encoder_libjpeg.h\n>>> index 934caef..391a53c 100644\n>>> --- a/src/android/jpeg/encoder_libjpeg.h\n>>> +++ b/src/android/jpeg/encoder_libjpeg.h\n>>> @@ -21,8 +21,8 @@ public:\n>>>       ~EncoderLibJpeg();\n>>>         int configure(const libcamera::StreamConfiguration &cfg)\n>>> override;\n>>> -    int encode(const libcamera::FrameBuffer *source,\n>>> -           const libcamera::Span &destination,\n>>> +    int encode(const libcamera::FrameBuffer &source,\n>>> +           libcamera::Span destination,\n>>>              const libcamera::Span &exifData) override;\n>>>     private:\n>>> diff --git a/src/android/jpeg/post_processor_jpeg.cpp\n>>> b/src/android/jpeg/post_processor_jpeg.cpp\n>>> index 55b9088..6f33631 100644\n>>> --- a/src/android/jpeg/post_processor_jpeg.cpp\n>>> +++ b/src/android/jpeg/post_processor_jpeg.cpp\n>>> @@ -67,7 +67,7 @@ int PostProcessorJpeg::process(const\n>>> libcamera::FrameBuffer &source,\n>>>       if (exif.generate() != 0)\n>>>           LOG(JPEG, Error) << \"Failed to generate valid EXIF data\";\n>>>   -    int jpeg_size = encoder_->encode(&source, destination,\n>>> exif.data());\n>>> +    int jpeg_size = encoder_->encode(source, destination, exif.data());\n>> Perfect. I was expecting this from v1.\n>>>       if (jpeg_size < 0) {\n>>>           LOG(JPEG, Error) << \"Failed to encode stream image\";\n>>>           return jpeg_size;\n>>\n>> _______________________________________________\n>> libcamera-devel mailing list\n>> libcamera-devel@lists.libcamera.org\n>> https://lists.libcamera.org/listinfo/libcamera-devel\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1231DBDB13\n\tfor ;\n\tTue, 20 Oct 2020 15:05:33 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9A95261D83;\n\tTue, 20 Oct 2020 17:05:32 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 393D561D7F\n\tfor ;\n\tTue, 20 Oct 2020 17:05:31 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7B3CB52;\n\tTue, 20 Oct 2020 17:05:30 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"twAZngHZ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1603206330;\n\tbh=znHOVyoyTpnMiO6cJO1sKq60kaTbErjlWARRtG/Gz94=;\n\th=Reply-To:Subject:From:To:References:Date:In-Reply-To:From;\n\tb=twAZngHZUukNbKhmE8BKLjvEfmvtp8zySj+aM6/0n98qAfYGifN+GWwJn8aw34kUm\n\tKqTspUgbDPdXSu5XCCFv00tAlLAVY2Pqq11JTCLf5m+ErE+0znuPUdc8vVy5Xl0xE9\n\tAq2lboqO4U2EP1YiG4AWbQBWm7CtyfGcZ9OBnNRU=","From":"Kieran Bingham ","To":"Umang Jain , Hirokazu Honda ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20201020074229.119151-1-hiroh@chromium.org>\n\t<20201020074229.119151-2-hiroh@chromium.org>\n\t\n\t<5320ee4a-c373-b120-3c8c-33d4549567b3@ideasonboard.com>","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"","Date":"Tue, 20 Oct 2020 16:05:27 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<5320ee4a-c373-b120-3c8c-33d4549567b3@ideasonboard.com>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH v2 2/4] android: Modify Encoder\n\tinterface","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]