[{"id":13293,"web_url":"https://patchwork.libcamera.org/comment/13293/","msgid":"<87757a7a-6ed9-6ec6-5f5e-a2440754011f@uajain.com>","date":"2020-10-20T10:30:50","subject":"Re: [libcamera-devel] [PATCH v2 1/4] android: Modify PostProcessor\n\tinterface","submitter":{"id":1,"url":"https://patchwork.libcamera.org/api/people/1/","name":"Umang Jain","email":"email@uajain.com"},"content":"Hi Hiro,\n\nOn 10/20/20 1:12 PM, Hirokazu Honda wrote:\n> In PostProcessor::process(), the |source| argument doesn't have\n> to be a pointer. This replace its type, const pointer, with const\n> reference as the latter is preferred to the former.\n> libcamera::Span is cheap to construct/copy/move. We should deal\n> with the type as pass-by-value parameter. Therefore this also\n> drops the const reference in the |destination| argument.\n>\n> Signed-off-by: Hirokazu Honda \n\nThis looks good to me.\nReviewed-by: Umang Jain \n> ---\n> src/android/camera_stream.cpp | 2 +-\n> src/android/jpeg/post_processor_jpeg.cpp | 6 +++---\n> src/android/jpeg/post_processor_jpeg.h | 4 ++--\n> src/android/post_processor.h | 4 ++--\n> 4 files changed, 8 insertions(+), 8 deletions(-)\n>\n> diff --git a/src/android/camera_stream.cpp b/src/android/camera_stream.cpp\n> index 1b8afa8..28a6e09 100644\n> --- a/src/android/camera_stream.cpp\n> +++ b/src/android/camera_stream.cpp\n> @@ -102,7 +102,7 @@ int CameraStream::process(const libcamera::FrameBuffer &source,\n> \tif (!postProcessor_)\n> \t\treturn 0;\n> \n> -\treturn postProcessor_->process(&source, dest->maps()[0], metadata);\n> +\treturn postProcessor_->process(source, dest->maps()[0], metadata);\n> }\n> \n> FrameBuffer *CameraStream::getBuffer()\n> diff --git a/src/android/jpeg/post_processor_jpeg.cpp b/src/android/jpeg/post_processor_jpeg.cpp\n> index 753c28e..55b9088 100644\n> --- a/src/android/jpeg/post_processor_jpeg.cpp\n> +++ b/src/android/jpeg/post_processor_jpeg.cpp\n> @@ -44,8 +44,8 @@ int PostProcessorJpeg::configure(const StreamConfiguration &inCfg,\n> \treturn encoder_->configure(inCfg);\n> }\n> \n> -int PostProcessorJpeg::process(const libcamera::FrameBuffer *source,\n> -\t\t\t const libcamera::Span &destination,\n> +int PostProcessorJpeg::process(const libcamera::FrameBuffer &source,\n> +\t\t\t libcamera::Span destination,\n> \t\t\t CameraMetadata *metadata)\n> {\n> \tif (!encoder_)\n> @@ -67,7 +67,7 @@ int PostProcessorJpeg::process(const libcamera::FrameBuffer *source,\n> \tif (exif.generate() != 0)\n> \t\tLOG(JPEG, Error) << \"Failed to generate valid EXIF data\";\n> \n> -\tint jpeg_size = encoder_->encode(source, destination, exif.data());\n> +\tint jpeg_size = encoder_->encode(&source, destination, exif.data());\nI see that this change is required to keep the patch compile-able \nbecause the argument's type has been changed. I would expect this would \nbe reworked in next patches while correctly the encoder interface.\n> \tif (jpeg_size < 0) {\n> \t\tLOG(JPEG, Error) << \"Failed to encode stream image\";\n> \t\treturn jpeg_size;\n> diff --git a/src/android/jpeg/post_processor_jpeg.h b/src/android/jpeg/post_processor_jpeg.h\n> index 62c8650..ae636ff 100644\n> --- a/src/android/jpeg/post_processor_jpeg.h\n> +++ b/src/android/jpeg/post_processor_jpeg.h\n> @@ -23,8 +23,8 @@ public:\n> \n> \tint configure(const libcamera::StreamConfiguration &incfg,\n> \t\t const libcamera::StreamConfiguration &outcfg) override;\n> -\tint process(const libcamera::FrameBuffer *source,\n> -\t\t const libcamera::Span &destination,\n> +\tint process(const libcamera::FrameBuffer &source,\n> +\t\t libcamera::Span destination,\n> \t\t CameraMetadata *metadata) override;\n> \n> private:\n> diff --git a/src/android/post_processor.h b/src/android/post_processor.h\n> index a891c43..5f87a5d 100644\n> --- a/src/android/post_processor.h\n> +++ b/src/android/post_processor.h\n> @@ -20,8 +20,8 @@ public:\n> \n> \tvirtual int configure(const libcamera::StreamConfiguration &inCfg,\n> \t\t\t const libcamera::StreamConfiguration &outCfg) = 0;\n> -\tvirtual int process(const libcamera::FrameBuffer *source,\n> -\t\t\t const libcamera::Span &destination,\n> +\tvirtual int process(const libcamera::FrameBuffer &source,\n> +\t\t\t libcamera::Span destination,\n> \t\t\t CameraMetadata *metadata) = 0;\n> };\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 52259BDB1F\n\tfor ;\n\tTue, 20 Oct 2020 10:30:56 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DBB0861D80;\n\tTue, 20 Oct 2020 12:30:55 +0200 (CEST)","from mail.uajain.com (static.126.159.217.95.clients.your-server.de\n\t[95.217.159.126])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0E3D860CDD\n\tfor ;\n\tTue, 20 Oct 2020 12:30:55 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=uajain.com header.i=@uajain.com\n\theader.b=\"TxjS8FoH\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=uajain.com; s=mail;\n\tt=1603189854; bh=W2VQT1PnqHf4sAYDodSxT0WsulAFP4sFn7bvjVth1Rg=;\n\th=Subject:To:Cc:References:From:In-Reply-To;\n\tb=TxjS8FoH4k/nIaVm2bvtyBNgyZKMMHDLYEy1fFtTfFVaA9/RerOK07xFtRgJDmwKU\n\tqSpgWgFCHZrsBCZc+60T6AA64C8d1CDhu+rQnEU7HvGE6RGWs9H1XLXDnQ2x0aiHrb\n\tzBg9cFrLCyAHSsUlv8GtxDmg2DZFDADHYoJg4QVZEx6cFQHqHxxWmPJwNYPhZsbwqT\n\taUbE5hb2QhSBuWaMYLS9XKZMychncntd3p35t1fIgtTamPF+4xsWkIcPRZgMcjvIy+\n\t377Sdmfd0UTbfhelXHWPZUl+Jr57J+b0y3Yv0vEomr1SlvTtpUmWq07ysMpf9ruYP6\n\tp03CUDKG7cZ/Q==","To":"Hirokazu Honda , libcamera-devel@lists.libcamera.org","References":"<20201020074229.119151-1-hiroh@chromium.org>","From":"Umang Jain ","Message-ID":"<87757a7a-6ed9-6ec6-5f5e-a2440754011f@uajain.com>","Date":"Tue, 20 Oct 2020 16:00:50 +0530","Mime-Version":"1.0","In-Reply-To":"<20201020074229.119151-1-hiroh@chromium.org>","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH v2 1/4] android: Modify PostProcessor\n\tinterface","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Transfer-Encoding":"7bit","Content-Type":"text/plain; charset=\"us-ascii\"; Format=\"flowed\"","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13303,"web_url":"https://patchwork.libcamera.org/comment/13303/","msgid":"<37374426-1117-8e63-2a42-47c3091dbde9@ideasonboard.com>","date":"2020-10-20T15:02:54","subject":"Re: [libcamera-devel] [PATCH v2 1/4] android: Modify PostProcessor\n\tinterface","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Hiro,\n\nOn 20/10/2020 11:30, Umang Jain wrote:\n> Hi Hiro,\n> \n> On 10/20/20 1:12 PM, Hirokazu Honda wrote:\n>> In PostProcessor::process(), the |source| argument doesn't have\n>> to be a pointer. This replace its type, const pointer, with const\n\ns/replace/replaces/\nor\ns/This replace/Replace/\n\n>> reference as the latter is preferred to the former.\n>> libcamera::Span is cheap to construct/copy/move. We should deal\n>> with the type as pass-by-value parameter. Therefore this also\n>> drops the const reference in the |destination| argument.\n>>\n>> Signed-off-by: Hirokazu Honda \n> \n> This looks good to me.\n> Reviewed-by: Umang Jain \n>> ---\n>>   src/android/camera_stream.cpp            | 2 +-\n>>   src/android/jpeg/post_processor_jpeg.cpp | 6 +++---\n>>   src/android/jpeg/post_processor_jpeg.h   | 4 ++--\n>>   src/android/post_processor.h             | 4 ++--\n>>   4 files changed, 8 insertions(+), 8 deletions(-)\n>>\n>> diff --git a/src/android/camera_stream.cpp\n>> b/src/android/camera_stream.cpp\n>> index 1b8afa8..28a6e09 100644\n>> --- a/src/android/camera_stream.cpp\n>> +++ b/src/android/camera_stream.cpp\n>> @@ -102,7 +102,7 @@ int CameraStream::process(const\n>> libcamera::FrameBuffer &source,\n>>       if (!postProcessor_)\n>>           return 0;\n>>   -    return postProcessor_->process(&source, dest->maps()[0],\n>> metadata);\n>> +    return postProcessor_->process(source, dest->maps()[0], metadata);\n>>   }\n>>     FrameBuffer *CameraStream::getBuffer()\n>> diff --git a/src/android/jpeg/post_processor_jpeg.cpp\n>> b/src/android/jpeg/post_processor_jpeg.cpp\n>> index 753c28e..55b9088 100644\n>> --- a/src/android/jpeg/post_processor_jpeg.cpp\n>> +++ b/src/android/jpeg/post_processor_jpeg.cpp\n>> @@ -44,8 +44,8 @@ int PostProcessorJpeg::configure(const\n>> StreamConfiguration &inCfg,\n>>       return encoder_->configure(inCfg);\n>>   }\n>>   -int PostProcessorJpeg::process(const libcamera::FrameBuffer *source,\n>> -                   const libcamera::Span &destination,\n>> +int PostProcessorJpeg::process(const libcamera::FrameBuffer &source,\n>> +                   libcamera::Span destination,\n>>                      CameraMetadata *metadata)\n>>   {\n>>       if (!encoder_)\n>> @@ -67,7 +67,7 @@ int PostProcessorJpeg::process(const\n>> libcamera::FrameBuffer *source,\n>>       if (exif.generate() != 0)\n>>           LOG(JPEG, Error) << \"Failed to generate valid EXIF data\";\n>>   -    int jpeg_size = encoder_->encode(source, destination,\n>> exif.data());\n>> +    int jpeg_size = encoder_->encode(&source, destination, exif.data());\n> I see that this change is required to keep the patch compile-able\n> because the argument's type has been changed. I would expect this would\n> be reworked in next patches while correctly the encoder interface.\n\n\nIndeed, I see it in the next patch.\n\nThis is the right order to do things, as we couldn't change the encoder\ninterface first, as we couldn't give it a reference.\n\nReviewed-by: Kieran Bingham \n\n>>       if (jpeg_size < 0) {\n>>           LOG(JPEG, Error) << \"Failed to encode stream image\";\n>>           return jpeg_size;\n>> diff --git a/src/android/jpeg/post_processor_jpeg.h\n>> b/src/android/jpeg/post_processor_jpeg.h\n>> index 62c8650..ae636ff 100644\n>> --- a/src/android/jpeg/post_processor_jpeg.h\n>> +++ b/src/android/jpeg/post_processor_jpeg.h\n>> @@ -23,8 +23,8 @@ public:\n>>         int configure(const libcamera::StreamConfiguration &incfg,\n>>                 const libcamera::StreamConfiguration &outcfg) override;\n>> -    int process(const libcamera::FrameBuffer *source,\n>> -            const libcamera::Span &destination,\n>> +    int process(const libcamera::FrameBuffer &source,\n>> +            libcamera::Span destination,\n>>               CameraMetadata *metadata) override;\n>>     private:\n>> diff --git a/src/android/post_processor.h b/src/android/post_processor.h\n>> index a891c43..5f87a5d 100644\n>> --- a/src/android/post_processor.h\n>> +++ b/src/android/post_processor.h\n>> @@ -20,8 +20,8 @@ public:\n>>         virtual int configure(const libcamera::StreamConfiguration\n>> &inCfg,\n>>                     const libcamera::StreamConfiguration &outCfg) = 0;\n>> -    virtual int process(const libcamera::FrameBuffer *source,\n>> -                const libcamera::Span &destination,\n>> +    virtual int process(const libcamera::FrameBuffer &source,\n>> +                libcamera::Span destination,\n>>                   CameraMetadata *metadata) = 0;\n>>   };\n>>   \n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2ADE3BDB13\n\tfor ;\n\tTue, 20 Oct 2020 15:03:00 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 82E6D61D89;\n\tTue, 20 Oct 2020 17:02:59 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 11C3561D7F\n\tfor ;\n\tTue, 20 Oct 2020 17:02:58 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7F46D52;\n\tTue, 20 Oct 2020 17:02:57 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"QNyNLV0C\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1603206177;\n\tbh=+DEyj5i2gKQTbfKZ+GENXChm7cBlnvXKiwqR49yM76A=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=QNyNLV0CG+TU8Rd7sdnEax1b7noK5cD5Jjw0GAyj6G9Jyw0ureWj7WxqklEM6WgwS\n\t9226dNpJJO8NxL8HHLc9QlEh2ACfwzBST10/WMF2N+lhCLbCSf3iqOPj37uvs1+JES\n\tsNhbH//J3yKp8flRsIvKNSRyxBKYkPIkzKJVxmcE=","To":"Umang Jain , Hirokazu Honda ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20201020074229.119151-1-hiroh@chromium.org>\n\t<87757a7a-6ed9-6ec6-5f5e-a2440754011f@uajain.com>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<37374426-1117-8e63-2a42-47c3091dbde9@ideasonboard.com>","Date":"Tue, 20 Oct 2020 16:02:54 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<87757a7a-6ed9-6ec6-5f5e-a2440754011f@uajain.com>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH v2 1/4] android: Modify PostProcessor\n\tinterface","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13308,"web_url":"https://patchwork.libcamera.org/comment/13308/","msgid":"<20201020170721.GS18688@pendragon.ideasonboard.com>","date":"2020-10-20T17:07:21","subject":"Re: [libcamera-devel] [PATCH v2 1/4] android: Modify PostProcessor\n\tinterface","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Hiro-san,\n\nThank you for the patches.\n\nFor the whole series,\n\nReviewed-by: Laurent Pinchart \n\nOn Tue, Oct 20, 2020 at 04:42:26PM +0900, Hirokazu Honda wrote:\n> In PostProcessor::process(), the |source| argument doesn't have\n> to be a pointer. This replace its type, const pointer, with const\n> reference as the latter is preferred to the former.\n> libcamera::Span is cheap to construct/copy/move. We should deal\n> with the type as pass-by-value parameter. Therefore this also\n> drops the const reference in the |destination| argument.\n> \n> Signed-off-by: Hirokazu Honda \n> ---\n> src/android/camera_stream.cpp | 2 +-\n> src/android/jpeg/post_processor_jpeg.cpp | 6 +++---\n> src/android/jpeg/post_processor_jpeg.h | 4 ++--\n> src/android/post_processor.h | 4 ++--\n> 4 files changed, 8 insertions(+), 8 deletions(-)\n> \n> diff --git a/src/android/camera_stream.cpp b/src/android/camera_stream.cpp\n> index 1b8afa8..28a6e09 100644\n> --- a/src/android/camera_stream.cpp\n> +++ b/src/android/camera_stream.cpp\n> @@ -102,7 +102,7 @@ int CameraStream::process(const libcamera::FrameBuffer &source,\n> \tif (!postProcessor_)\n> \t\treturn 0;\n> \n> -\treturn postProcessor_->process(&source, dest->maps()[0], metadata);\n> +\treturn postProcessor_->process(source, dest->maps()[0], metadata);\n> }\n> \n> FrameBuffer *CameraStream::getBuffer()\n> diff --git a/src/android/jpeg/post_processor_jpeg.cpp b/src/android/jpeg/post_processor_jpeg.cpp\n> index 753c28e..55b9088 100644\n> --- a/src/android/jpeg/post_processor_jpeg.cpp\n> +++ b/src/android/jpeg/post_processor_jpeg.cpp\n> @@ -44,8 +44,8 @@ int PostProcessorJpeg::configure(const StreamConfiguration &inCfg,\n> \treturn encoder_->configure(inCfg);\n> }\n> \n> -int PostProcessorJpeg::process(const libcamera::FrameBuffer *source,\n> -\t\t\t const libcamera::Span &destination,\n> +int PostProcessorJpeg::process(const libcamera::FrameBuffer &source,\n> +\t\t\t libcamera::Span destination,\n> \t\t\t CameraMetadata *metadata)\n> {\n> \tif (!encoder_)\n> @@ -67,7 +67,7 @@ int PostProcessorJpeg::process(const libcamera::FrameBuffer *source,\n> \tif (exif.generate() != 0)\n> \t\tLOG(JPEG, Error) << \"Failed to generate valid EXIF data\";\n> \n> -\tint jpeg_size = encoder_->encode(source, destination, exif.data());\n> +\tint jpeg_size = encoder_->encode(&source, destination, exif.data());\n> \tif (jpeg_size < 0) {\n> \t\tLOG(JPEG, Error) << \"Failed to encode stream image\";\n> \t\treturn jpeg_size;\n> diff --git a/src/android/jpeg/post_processor_jpeg.h b/src/android/jpeg/post_processor_jpeg.h\n> index 62c8650..ae636ff 100644\n> --- a/src/android/jpeg/post_processor_jpeg.h\n> +++ b/src/android/jpeg/post_processor_jpeg.h\n> @@ -23,8 +23,8 @@ public:\n> \n> \tint configure(const libcamera::StreamConfiguration &incfg,\n> \t\t const libcamera::StreamConfiguration &outcfg) override;\n> -\tint process(const libcamera::FrameBuffer *source,\n> -\t\t const libcamera::Span &destination,\n> +\tint process(const libcamera::FrameBuffer &source,\n> +\t\t libcamera::Span destination,\n> \t\t CameraMetadata *metadata) override;\n> \n> private:\n> diff --git a/src/android/post_processor.h b/src/android/post_processor.h\n> index a891c43..5f87a5d 100644\n> --- a/src/android/post_processor.h\n> +++ b/src/android/post_processor.h\n> @@ -20,8 +20,8 @@ public:\n> \n> \tvirtual int configure(const libcamera::StreamConfiguration &inCfg,\n> \t\t\t const libcamera::StreamConfiguration &outCfg) = 0;\n> -\tvirtual int process(const libcamera::FrameBuffer *source,\n> -\t\t\t const libcamera::Span &destination,\n> +\tvirtual int process(const libcamera::FrameBuffer &source,\n> +\t\t\t libcamera::Span destination,\n> \t\t\t CameraMetadata *metadata) = 0;\n> };\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4E022BDB1F\n\tfor ;\n\tTue, 20 Oct 2020 17:08:10 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CC40D61D8E;\n\tTue, 20 Oct 2020 19:08:09 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2D98161D83\n\tfor ;\n\tTue, 20 Oct 2020 19:08:08 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9719992;\n\tTue, 20 Oct 2020 19:08:07 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"lexFNtS1\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1603213687;\n\tbh=v2B4JxXj6OT7GuZZzDfZ7lqgcxvSoRr+16hqTyw9sR4=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=lexFNtS1uCLNCNcA1FejM/yviuZliBIl5lkRksaE1lDwXMrrhl7VvreyF4EmVGMoY\n\tFwrQ2jnuWDuRH3+MMOL7hvv1Iolxocf2oRoM77OLUQRR3xhIPvPsrt9kK5MtqI/WyY\n\tY9gphEvm4mFFy/hAU7nLwYexo4g6Z8j0tHs6F54E=","Date":"Tue, 20 Oct 2020 20:07:21 +0300","From":"Laurent Pinchart ","To":"Hirokazu Honda ","Message-ID":"<20201020170721.GS18688@pendragon.ideasonboard.com>","References":"<20201020074229.119151-1-hiroh@chromium.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201020074229.119151-1-hiroh@chromium.org>","Subject":"Re: [libcamera-devel] [PATCH v2 1/4] android: Modify PostProcessor\n\tinterface","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]