[{"id":13277,"web_url":"https://patchwork.libcamera.org/comment/13277/","msgid":"<20201020075143.GI18688@pendragon.ideasonboard.com>","date":"2020-10-20T07:51:43","subject":"Re: [libcamera-devel] [PATCH 8/8] meson: Enable -Wextra-semi for\n\tclang","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Hiro-san,\n\nThank you for the patch.\n\nOn Tue, Oct 20, 2020 at 02:29:05PM +0900, Hirokazu Honda wrote:\n> The option, -Wxtra-semi, helps developers to find unnecessary\n\ns/-Wxtra-semi/-Wextra-semi/\n\n> semicolons. This option is available with clang.\n> \n> Signed-off-by: Hirokazu Honda \n> ---\n> meson.build | 6 ++++++\n> 1 file changed, 6 insertions(+)\n> \n> diff --git a/meson.build b/meson.build\n> index de15cc1..480c861 100644\n> --- a/meson.build\n> +++ b/meson.build\n> @@ -64,6 +64,12 @@ if cc.get_id() == 'clang'\n> '-stdlib=libc++',\n> ]\n> endif\n> +\n> + if cc.has_argument('-Wextra-semi')\n> + cpp_arguments += [\n> + '-Wextra-semi',\n> + ]\n> + endif\n\nThe flag has been supported by clang since v4.0.0, I think we can drop\nthe has_arguments check. Apart from that,\n\nReviewed-by: Laurent Pinchart \n\n> endif\n> \n> if cc.get_id() == 'gcc'","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5D665BDB1F\n\tfor ;\n\tTue, 20 Oct 2020 07:52:31 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A251E613BB;\n\tTue, 20 Oct 2020 09:52:30 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C283A61394\n\tfor ;\n\tTue, 20 Oct 2020 09:52:29 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3EAE952;\n\tTue, 20 Oct 2020 09:52:29 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"VyvtMsoH\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1603180349;\n\tbh=VPlhKtYVEcPDonoW1D73hbf5+opFMOE0rWaNtt98HLk=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=VyvtMsoHeLFzddT9QSaXTsf+My4UzDSkey9NWGtMHxqVSNoelnibZxG8ahBQousR4\n\t3oUr2jLEcgU6QAKDy7lRhOafcIoDdhYW7TaNy3iYbU2IB1A9d9NxdkMMxUtECVvXX7\n\t+FLJI3KjvinA5XQo8up0OFpJ63n3QIYOnZozWehs=","Date":"Tue, 20 Oct 2020 10:51:43 +0300","From":"Laurent Pinchart ","To":"Hirokazu Honda ","Message-ID":"<20201020075143.GI18688@pendragon.ideasonboard.com>","References":"<20201020052905.89267-1-hiroh@chromium.org>\n\t<20201020052905.89267-9-hiroh@chromium.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201020052905.89267-9-hiroh@chromium.org>","Subject":"Re: [libcamera-devel] [PATCH 8/8] meson: Enable -Wextra-semi for\n\tclang","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13279,"web_url":"https://patchwork.libcamera.org/comment/13279/","msgid":"","date":"2020-10-20T08:23:24","subject":"Re: [libcamera-devel] [PATCH 8/8] meson: Enable -Wextra-semi for\n\tclang","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/people/63/","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"content":"On Tue, Oct 20, 2020 at 4:52 PM Laurent Pinchart\n wrote:\n>\n> Hi Hiro-san,\n>\n> Thank you for the patch.\n>\n> On Tue, Oct 20, 2020 at 02:29:05PM +0900, Hirokazu Honda wrote:\n> > The option, -Wxtra-semi, helps developers to find unnecessary\n>\n> s/-Wxtra-semi/-Wextra-semi/\n>\n> > semicolons. This option is available with clang.\n> >\n> > Signed-off-by: Hirokazu Honda \n> > ---\n> > meson.build | 6 ++++++\n> > 1 file changed, 6 insertions(+)\n> >\n> > diff --git a/meson.build b/meson.build\n> > index de15cc1..480c861 100644\n> > --- a/meson.build\n> > +++ b/meson.build\n> > @@ -64,6 +64,12 @@ if cc.get_id() == 'clang'\n> > '-stdlib=libc++',\n> > ]\n> > endif\n> > +\n> > + if cc.has_argument('-Wextra-semi')\n> > + cpp_arguments += [\n> > + '-Wextra-semi',\n> > + ]\n> > + endif\n>\n> The flag has been supported by clang since v4.0.0, I think we can drop\n> the has_arguments check. Apart from that,\n>\n\nThanks, as clang 4.0.0 is released in March 2017, let's drop has_arguments.\n\nRegards,\n-Hiro\n> Reviewed-by: Laurent Pinchart \n>\n> > endif\n> >\n> > if cc.get_id() == 'gcc'\n>\n> --\n> Regards,\n>\n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1AC29BDB1F\n\tfor ;\n\tTue, 20 Oct 2020 08:23:38 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A63DE610C4;\n\tTue, 20 Oct 2020 10:23:37 +0200 (CEST)","from mail-ed1-x544.google.com (mail-ed1-x544.google.com\n\t[IPv6:2a00:1450:4864:20::544])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8AC7D6052F\n\tfor ;\n\tTue, 20 Oct 2020 10:23:35 +0200 (CEST)","by mail-ed1-x544.google.com with SMTP id i5so927069edr.5\n\tfor ;\n\tTue, 20 Oct 2020 01:23:35 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"GhKg1bD3\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=WFfWC5e5a2rBUNh9jIj+3T++Wy5GP2VKjeBKSh1Zukg=;\n\tb=GhKg1bD324T3TfsRPqFn8/MzXOJUIGpDkykRdIzOGIUx4S9NQSGDCjbR0lauD4FE9l\n\tNT5Oju8nsKRZLB+XQyzFsOdBTq2xWLZNw8KRZg2hm0LJbckX1aCpEuIPCHhVoVALD3+n\n\tfWrSawZe7s2Bugvb4fPGVsg2OQh4/eFGKXANg=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=WFfWC5e5a2rBUNh9jIj+3T++Wy5GP2VKjeBKSh1Zukg=;\n\tb=IRVY92ffrN3q9YaFD3TBs6nOZIYjwwzAUsI65QqnVRndlB+F5/78tT7qrNu9q7YHrU\n\tZMYAAH0FxJbeQxq+bm14qR6z1V+MpRwgQA8fmYZgs8/2FByrKoArix3Aq0jZTUm5oH1f\n\tbXGS+cS98hTNu5SoTkCtQG7X4JY94lyZewura5gdkClidvYIcJVWqPJ2n/iW5Sqw3jS7\n\tkuqjQoXMLhwBZV1vIbT9NwbjlBE9PWhSvm5vI99RCAGItYRqO9KgXpTF3fhO/lNQV12r\n\teCuKlbAg3nByq7WlVVYegKYKzx9f6FATjD3zVFRGYbbsIw9l5hJ2fI6t1qKFmAscEx9p\n\tM28g==","X-Gm-Message-State":"AOAM532hKRamjdev8WFF78HvB0/SoknjCGvqyLeFkEqrp0BczW7p+lx1\n\tpHDnJxXJQ+EdFA0ODickOOeve38ph5HzCR6OqYsDLT5ZwPw=","X-Google-Smtp-Source":"ABdhPJymz4xDc5uLuCS3t7tG40aDz6MPySjNg65vmK9eOZVo6JWYj6aP/VvTacrNf7raKLM8C6juBgy7z9umsOG4f5M=","X-Received":"by 2002:a50:ef0a:: with SMTP id\n\tm10mr1644081eds.116.1603182215184; \n\tTue, 20 Oct 2020 01:23:35 -0700 (PDT)","MIME-Version":"1.0","References":"<20201020052905.89267-1-hiroh@chromium.org>\n\t<20201020052905.89267-9-hiroh@chromium.org>\n\t<20201020075143.GI18688@pendragon.ideasonboard.com>","In-Reply-To":"<20201020075143.GI18688@pendragon.ideasonboard.com>","From":"Hirokazu Honda ","Date":"Tue, 20 Oct 2020 17:23:24 +0900","Message-ID":"","To":"Laurent Pinchart ","Subject":"Re: [libcamera-devel] [PATCH 8/8] meson: Enable -Wextra-semi for\n\tclang","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]