[{"id":13276,"web_url":"https://patchwork.libcamera.org/comment/13276/","msgid":"<20201020074547.GH18688@pendragon.ideasonboard.com>","date":"2020-10-20T07:45:47","subject":"Re: [libcamera-devel] [PATCH 7/8] ipa: Omit extra semicolon","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Hiro-san,\n\nThank you for the patch.\n\nOn Tue, Oct 20, 2020 at 02:29:04PM +0900, Hirokazu Honda wrote:\n\nWe try to include a commit message for every patch, even when they're\nsimple. No big deal here, there's no need to resubmit just for this, but\nit's good to keep it in mind for future series.\n\n> Signed-off-by: Hirokazu Honda \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/ipa/raspberrypi/raspberrypi.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp\n> index 48a72dd..1c255aa 100644\n> --- a/src/ipa/raspberrypi/raspberrypi.cpp\n> +++ b/src/ipa/raspberrypi/raspberrypi.cpp\n> @@ -1150,6 +1150,6 @@ struct ipa_context *ipaCreate()\n> \treturn new IPAInterfaceWrapper(std::make_unique());\n> }\n> \n> -}; /* extern \"C\" */\n> +} /* extern \"C\" */\n> \n> } /* namespace libcamera */","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E063ABDB13\n\tfor ;\n\tTue, 20 Oct 2020 07:46:34 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AF15B613BB;\n\tTue, 20 Oct 2020 09:46:34 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8562C61394\n\tfor ;\n\tTue, 20 Oct 2020 09:46:33 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1963A52;\n\tTue, 20 Oct 2020 09:46:33 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"petjLMqt\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1603179993;\n\tbh=4i9FAeMzHnz4/3rfYTHvG+kXhdMekeUp3Hym2ln8xWM=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=petjLMqtUkFpczJD1H2OGjKThoK2eY0mvS1ZF0q53y6OPXAf4A2kpAviVALD3aEZ2\n\t0+Jv6HccRHLFKvPBry1G2uZ95JoVW0C1eEcDejnNwL6kHHUyMYuoF8CLTb6fKXKUFu\n\tXuubDJ3AVI1dflPGD8EZMmIqddd8wXjqJ6obLQ2I=","Date":"Tue, 20 Oct 2020 10:45:47 +0300","From":"Laurent Pinchart ","To":"Hirokazu Honda ","Message-ID":"<20201020074547.GH18688@pendragon.ideasonboard.com>","References":"<20201020052905.89267-1-hiroh@chromium.org>\n\t<20201020052905.89267-8-hiroh@chromium.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201020052905.89267-8-hiroh@chromium.org>","Subject":"Re: [libcamera-devel] [PATCH 7/8] ipa: Omit extra semicolon","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]