[{"id":13275,"web_url":"https://patchwork.libcamera.org/comment/13275/","msgid":"<20201020074436.GG18688@pendragon.ideasonboard.com>","date":"2020-10-20T07:44:36","subject":"Re: [libcamera-devel] [PATCH 6/8] libcamera: Omit extra semicolons","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Hiro-san,\n\nThank you for the patch.\n\nOn Tue, Oct 20, 2020 at 02:29:03PM +0900, Hirokazu Honda wrote:\n> The end semicolons with LOG_DEFINE_CATEGORY and\n> LOG_DECLARE_CATEGORY are unnecessary.\n> \n> Signed-off-by: Hirokazu Honda \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/libcamera/byte_stream_buffer.cpp | 2 +-\n> src/libcamera/camera_sensor.cpp | 2 +-\n> src/libcamera/file.cpp | 2 +-\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 2 +-\n> src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp | 2 +-\n> src/libcamera/pipeline/simple/converter.cpp | 2 +-\n> src/libcamera/sysfs.cpp | 2 +-\n> 7 files changed, 7 insertions(+), 7 deletions(-)\n> \n> diff --git a/src/libcamera/byte_stream_buffer.cpp b/src/libcamera/byte_stream_buffer.cpp\n> index df7029b..7db5501 100644\n> --- a/src/libcamera/byte_stream_buffer.cpp\n> +++ b/src/libcamera/byte_stream_buffer.cpp\n> @@ -14,7 +14,7 @@\n> \n> namespace libcamera {\n> \n> -LOG_DEFINE_CATEGORY(Serialization);\n> +LOG_DEFINE_CATEGORY(Serialization)\n> \n> /**\n> * \\file byte_stream_buffer.h\n> diff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp\n> index 78c7cee..935de52 100644\n> --- a/src/libcamera/camera_sensor.cpp\n> +++ b/src/libcamera/camera_sensor.cpp\n> @@ -28,7 +28,7 @@\n> \n> namespace libcamera {\n> \n> -LOG_DEFINE_CATEGORY(CameraSensor);\n> +LOG_DEFINE_CATEGORY(CameraSensor)\n> \n> /**\n> * \\struct CameraSensorInfo\n> diff --git a/src/libcamera/file.cpp b/src/libcamera/file.cpp\n> index 04b0cb6..3a3f5bb 100644\n> --- a/src/libcamera/file.cpp\n> +++ b/src/libcamera/file.cpp\n> @@ -23,7 +23,7 @@\n> \n> namespace libcamera {\n> \n> -LOG_DEFINE_CATEGORY(File);\n> +LOG_DEFINE_CATEGORY(File)\n> \n> /**\n> * \\class File\n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index f5a20d3..92c65d0 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -66,7 +66,7 @@ public:\n> \n> \tStatus validate() override;\n> \n> -\tconst StreamConfiguration &cio2Format() const { return cio2Configuration_; };\n> +\tconst StreamConfiguration &cio2Format() const { return cio2Configuration_; }\n> \tconst ImgUDevice::PipeConfig imguConfig() const { return pipeConfig_; }\n> \n> private:\n> diff --git a/src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp b/src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp\n> index 0572acc..62605c0 100644\n> --- a/src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp\n> +++ b/src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp\n> @@ -17,7 +17,7 @@\n> \n> namespace libcamera {\n> \n> -LOG_DEFINE_CATEGORY(RPI_S_W);\n> +LOG_DEFINE_CATEGORY(RPI_S_W)\n> \n> namespace RPi {\n> \n> diff --git a/src/libcamera/pipeline/simple/converter.cpp b/src/libcamera/pipeline/simple/converter.cpp\n> index 75fb297..b4ee021 100644\n> --- a/src/libcamera/pipeline/simple/converter.cpp\n> +++ b/src/libcamera/pipeline/simple/converter.cpp\n> @@ -21,7 +21,7 @@\n> \n> namespace libcamera {\n> \n> -LOG_DECLARE_CATEGORY(SimplePipeline);\n> +LOG_DECLARE_CATEGORY(SimplePipeline)\n> \n> SimpleConverter::SimpleConverter(MediaDevice *media)\n> \t: m2m_(nullptr)\n> diff --git a/src/libcamera/sysfs.cpp b/src/libcamera/sysfs.cpp\n> index 6c8e955..3ebe66f 100644\n> --- a/src/libcamera/sysfs.cpp\n> +++ b/src/libcamera/sysfs.cpp\n> @@ -22,7 +22,7 @@\n> \n> namespace libcamera {\n> \n> -LOG_DEFINE_CATEGORY(SysFs);\n> +LOG_DEFINE_CATEGORY(SysFs)\n> \n> namespace sysfs {\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6385BBDB13\n\tfor ;\n\tTue, 20 Oct 2020 07:45:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2FB0F613BB;\n\tTue, 20 Oct 2020 09:45:24 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 000E861394\n\tfor ;\n\tTue, 20 Oct 2020 09:45:22 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9297752;\n\tTue, 20 Oct 2020 09:45:22 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"lUPxCbNB\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1603179922;\n\tbh=1ZWwpzX9t+n1xV7LFYCqqjqaThTnOKHuxVCVDxJV4A4=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=lUPxCbNBxXb60rCo0MpQEGwCCU1mT1TSWU83w4/dA27b3J10AfDn7iWz1yFWx4JwC\n\tnDGC53Gv3KluOTbSWkLeUzLjSQOIp69QydvlbD3XltVBcdItfZDxCy7ah8INXTPCKM\n\tFXX8PGo8+SjsBjwbWj9iyxCm+hkDB2G4GMI5Sk7Q=","Date":"Tue, 20 Oct 2020 10:44:36 +0300","From":"Laurent Pinchart ","To":"Hirokazu Honda ","Message-ID":"<20201020074436.GG18688@pendragon.ideasonboard.com>","References":"<20201020052905.89267-1-hiroh@chromium.org>\n\t<20201020052905.89267-7-hiroh@chromium.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201020052905.89267-7-hiroh@chromium.org>","Subject":"Re: [libcamera-devel] [PATCH 6/8] libcamera: Omit extra semicolons","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]