[{"id":13274,"web_url":"https://patchwork.libcamera.org/comment/13274/","msgid":"<20201020074405.GF18688@pendragon.ideasonboard.com>","date":"2020-10-20T07:44:05","subject":"Re: [libcamera-devel] [PATCH 5/8] include: libcamera: Omit extra\n\tsemicolons","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Hiro-san,\n\nThank you for the patch.\n\nOn Tue, Oct 20, 2020 at 02:29:02PM +0900, Hirokazu Honda wrote:\n> REGISTER_PIPELINE_HANDLER macro is used with the end semicolon\n> everywhere. This removes the end semicolon within the macro.\n> \n> Signed-off-by: Hirokazu Honda \n> ---\n> include/libcamera/internal/pipeline_handler.h | 2 +-\n> include/libcamera/span.h | 2 +-\n> 2 files changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/include/libcamera/internal/pipeline_handler.h b/include/libcamera/internal/pipeline_handler.h\n> index a4e1b52..818a36a 100644\n> --- a/include/libcamera/internal/pipeline_handler.h\n> +++ b/include/libcamera/internal/pipeline_handler.h\n> @@ -145,7 +145,7 @@ private:\t\t\t\t\t\t\t\t\\\n> \t\treturn new handler(manager);\t\t\t\t\\\n> \t}\t\t\t\t\t\t\t\t\\\n> };\t\t\t\t\t\t\t\t\t\\\n> -static handler##Factory global_##handler##Factory;\n> +static handler##Factory global_##handler##Factory\n\nIn most cases we include the semicolon inside the macro\n(LOG_DECLARE_CATEGORY for instance). For consistency, wouldn't it be\nbetter to keep it here, and remove it from pipeline handlers where the\nmacro is used ?\n\n> \n> } /* namespace libcamera */\n> \n> diff --git a/include/libcamera/span.h b/include/libcamera/span.h\n> index a53a80b..c0e4399 100644\n> --- a/include/libcamera/span.h\n> +++ b/include/libcamera/span.h\n> @@ -407,6 +407,6 @@ private:\n> \tsize_type size_;\n> };\n> \n> -}; /* namespace libcamera */\n> +} /* namespace libcamera */\n> \n> #endif /* __LIBCAMERA_SPAN_H__ */","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0A3B0BDB13\n\tfor ;\n\tTue, 20 Oct 2020 07:44:54 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C53B2613B4;\n\tTue, 20 Oct 2020 09:44:53 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A47A961394\n\tfor ;\n\tTue, 20 Oct 2020 09:44:51 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3A41D52;\n\tTue, 20 Oct 2020 09:44:51 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"blBHg4SS\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1603179891;\n\tbh=x7VnzAEnr8W6zGEcBVHaGJQPwLNqx/auzr9a2YPaRFc=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=blBHg4SSuWnmfEcjePYYBP7QBL1i7R9Fv+L50l5TUUnHJsxvr4+BDwo1+qHUyk3vy\n\tT/Ss2VYL+NGqMmPQ4yi/tykLefGH0w+M7GNgvQwmOQqp/Ddr1gJNNyGeli4I/EqX5J\n\tY/BAfmVMaWNW7sr/7AS3aoM0vcc2NoPcHtzRM2iM=","Date":"Tue, 20 Oct 2020 10:44:05 +0300","From":"Laurent Pinchart ","To":"Hirokazu Honda ","Message-ID":"<20201020074405.GF18688@pendragon.ideasonboard.com>","References":"<20201020052905.89267-1-hiroh@chromium.org>\n\t<20201020052905.89267-6-hiroh@chromium.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201020052905.89267-6-hiroh@chromium.org>","Subject":"Re: [libcamera-devel] [PATCH 5/8] include: libcamera: Omit extra\n\tsemicolons","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13278,"web_url":"https://patchwork.libcamera.org/comment/13278/","msgid":"","date":"2020-10-20T08:21:19","subject":"Re: [libcamera-devel] [PATCH 5/8] include: libcamera: Omit extra\n\tsemicolons","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/people/63/","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"content":"Hi Laurent,\n\nOn Tue, Oct 20, 2020 at 4:44 PM Laurent Pinchart\n wrote:\n>\n> Hi Hiro-san,\n>\n> Thank you for the patch.\n>\n> On Tue, Oct 20, 2020 at 02:29:02PM +0900, Hirokazu Honda wrote:\n> > REGISTER_PIPELINE_HANDLER macro is used with the end semicolon\n> > everywhere. This removes the end semicolon within the macro.\n> >\n> > Signed-off-by: Hirokazu Honda \n> > ---\n> > include/libcamera/internal/pipeline_handler.h | 2 +-\n> > include/libcamera/span.h | 2 +-\n> > 2 files changed, 2 insertions(+), 2 deletions(-)\n> >\n> > diff --git a/include/libcamera/internal/pipeline_handler.h b/include/libcamera/internal/pipeline_handler.h\n> > index a4e1b52..818a36a 100644\n> > --- a/include/libcamera/internal/pipeline_handler.h\n> > +++ b/include/libcamera/internal/pipeline_handler.h\n> > @@ -145,7 +145,7 @@ private: \\\n> > return new handler(manager); \\\n> > } \\\n> > }; \\\n> > -static handler##Factory global_##handler##Factory;\n> > +static handler##Factory global_##handler##Factory\n>\n> In most cases we include the semicolon inside the macro\n> (LOG_DECLARE_CATEGORY for instance). For consistency, wouldn't it be\n> better to keep it here, and remove it from pipeline handlers where the\n> macro is used ?\n>\n\nSounds good to me. Thanks.\n\n> >\n> > } /* namespace libcamera */\n> >\n> > diff --git a/include/libcamera/span.h b/include/libcamera/span.h\n> > index a53a80b..c0e4399 100644\n> > --- a/include/libcamera/span.h\n> > +++ b/include/libcamera/span.h\n> > @@ -407,6 +407,6 @@ private:\n> > size_type size_;\n> > };\n> >\n> > -}; /* namespace libcamera */\n> > +} /* namespace libcamera */\n> >\n> > #endif /* __LIBCAMERA_SPAN_H__ */\n>\n> --\n> Regards,\n>\n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5177DBDB13\n\tfor ;\n\tTue, 20 Oct 2020 08:21:32 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C2492613B4;\n\tTue, 20 Oct 2020 10:21:31 +0200 (CEST)","from mail-ej1-x643.google.com (mail-ej1-x643.google.com\n\t[IPv6:2a00:1450:4864:20::643])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 124076052F\n\tfor ;\n\tTue, 20 Oct 2020 10:21:31 +0200 (CEST)","by mail-ej1-x643.google.com with SMTP id z5so1387012ejw.7\n\tfor ;\n\tTue, 20 Oct 2020 01:21:31 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"Z4S8qyKv\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=my63ZYF3+fMgm45faV2FtsyRqIi8SGqo7tojaDVTwgU=;\n\tb=Z4S8qyKv/HXe76WIyxrZzODrOHcBedTYTk1QOFHz5lPrZKarA3JjUaAIdAWhQHYgrX\n\trcysCw2pyJ3bU2iKWfgYVUG1LV/QMqitCAqQwIdO6zu4OdBHhnyf3HwCTUl0Xk3yQbKQ\n\tk1r4mkvrNG+S2fo2dV13bu60frjvKPWSjHukg=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=my63ZYF3+fMgm45faV2FtsyRqIi8SGqo7tojaDVTwgU=;\n\tb=sLnyG3+H9SbHR8M87LRdl4/BQRiAb5KdR2VbpL2OiCEbGn57QMaAkwHWwtHtRe+v5b\n\tNESrzuABIi6jJjTxI2KB99trvhp71OFyZxuWaIDdxwxctpw6zXm/9sTu48VaTzJvb476\n\tqzHbzwaMLFsCfFVqo/4UYDCWo/MVrIc4syqSWGmiTOqEY3gQ8hBjQuEbICREYs1uRgfV\n\tlOggu8orpSRjrj78OUzyY6bRMScoNigZqgJDKLgWxRUya9UoJSWIdNaypqskQawFipAp\n\tCjDXmZ8ijWB9TrBjRJH/HFSEHbYmGMqcdH99SQ7Qjhu+kWFvlTm7f+uLcqCbeitLkAWZ\n\txRkg==","X-Gm-Message-State":"AOAM531l/ntSA6iQ86/u7BYnGl7PWx7Er1p36BVR7PfFv1tpdpsV3pw2\n\t+22nDtRE3JxyQwObvwYx/K9XwbCLFNtioa6FIz9NDP8D4DE=","X-Google-Smtp-Source":"ABdhPJxQkiofofzHFwTaYCWJzLrx0BN1/QXN+fZXl1TP/63n7m/9vb7t+xMq2JhlQI/t+tRvAPIIyhg8GYtQGZ2Md2E=","X-Received":"by 2002:a17:906:b110:: with SMTP id\n\tu16mr1938964ejy.55.1603182090690; \n\tTue, 20 Oct 2020 01:21:30 -0700 (PDT)","MIME-Version":"1.0","References":"<20201020052905.89267-1-hiroh@chromium.org>\n\t<20201020052905.89267-6-hiroh@chromium.org>\n\t<20201020074405.GF18688@pendragon.ideasonboard.com>","In-Reply-To":"<20201020074405.GF18688@pendragon.ideasonboard.com>","From":"Hirokazu Honda ","Date":"Tue, 20 Oct 2020 17:21:19 +0900","Message-ID":"","To":"Laurent Pinchart ","Subject":"Re: [libcamera-devel] [PATCH 5/8] include: libcamera: Omit extra\n\tsemicolons","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]