[{"id":13273,"web_url":"https://patchwork.libcamera.org/comment/13273/","msgid":"<20201020074249.GE18688@pendragon.ideasonboard.com>","date":"2020-10-20T07:42:49","subject":"Re: [libcamera-devel] [PATCH 4/8] android: Omit extra semicolons","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Hiro-san,\n\nThank you for the patch.\n\nOn Tue, Oct 20, 2020 at 02:29:01PM +0900, Hirokazu Honda wrote:\n> The end semicolons with LOG_DECLARE_CATEGORY and\n> LOG_DEFINE_CATEGORY are unnecessary.\n> \n> Signed-off-by: Hirokazu Honda \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/android/camera_device.cpp | 2 +-\n> src/android/camera_hal_manager.cpp | 2 +-\n> src/android/camera_metadata.cpp | 2 +-\n> src/android/camera_stream.cpp | 2 +-\n> src/android/camera_worker.cpp | 2 +-\n> src/android/jpeg/encoder.h | 2 +-\n> src/android/jpeg/encoder_libjpeg.cpp | 2 +-\n> src/android/jpeg/post_processor_jpeg.cpp | 2 +-\n> 8 files changed, 8 insertions(+), 8 deletions(-)\n> \n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index d706cf4..e9404c2 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -129,7 +129,7 @@ const std::map camera3FormatsMap = {\n> \n> } /* namespace */\n> \n> -LOG_DECLARE_CATEGORY(HAL);\n> +LOG_DECLARE_CATEGORY(HAL)\n> \n> MappedCamera3Buffer::MappedCamera3Buffer(const buffer_handle_t camera3buffer,\n> \t\t\t\t\t int flags)\n> diff --git a/src/android/camera_hal_manager.cpp b/src/android/camera_hal_manager.cpp\n> index 2a33f9b..189eda2 100644\n> --- a/src/android/camera_hal_manager.cpp\n> +++ b/src/android/camera_hal_manager.cpp\n> @@ -16,7 +16,7 @@\n> \n> using namespace libcamera;\n> \n> -LOG_DECLARE_CATEGORY(HAL);\n> +LOG_DECLARE_CATEGORY(HAL)\n> \n> /*\n> * \\class CameraHalManager\n> diff --git a/src/android/camera_metadata.cpp b/src/android/camera_metadata.cpp\n> index f0da9ea..edea48f 100644\n> --- a/src/android/camera_metadata.cpp\n> +++ b/src/android/camera_metadata.cpp\n> @@ -11,7 +11,7 @@\n> \n> using namespace libcamera;\n> \n> -LOG_DEFINE_CATEGORY(CameraMetadata);\n> +LOG_DEFINE_CATEGORY(CameraMetadata)\n> \n> CameraMetadata::CameraMetadata(size_t entryCapacity, size_t dataCapacity)\n> {\n> diff --git a/src/android/camera_stream.cpp b/src/android/camera_stream.cpp\n> index 1b8afa8..eae451e 100644\n> --- a/src/android/camera_stream.cpp\n> +++ b/src/android/camera_stream.cpp\n> @@ -15,7 +15,7 @@\n> \n> using namespace libcamera;\n> \n> -LOG_DECLARE_CATEGORY(HAL);\n> +LOG_DECLARE_CATEGORY(HAL)\n> \n> /*\n> * \\class CameraStream\n> diff --git a/src/android/camera_worker.cpp b/src/android/camera_worker.cpp\n> index ff09b75..df43646 100644\n> --- a/src/android/camera_worker.cpp\n> +++ b/src/android/camera_worker.cpp\n> @@ -15,7 +15,7 @@\n> \n> using namespace libcamera;\n> \n> -LOG_DECLARE_CATEGORY(HAL);\n> +LOG_DECLARE_CATEGORY(HAL)\n> \n> /*\n> * \\class CaptureRequest\n> diff --git a/src/android/jpeg/encoder.h b/src/android/jpeg/encoder.h\n> index 4483153..4e85996 100644\n> --- a/src/android/jpeg/encoder.h\n> +++ b/src/android/jpeg/encoder.h\n> @@ -14,7 +14,7 @@\n> class Encoder\n> {\n> public:\n> -\tvirtual ~Encoder() {};\n> +\tvirtual ~Encoder() {}\n> \n> \tvirtual int configure(const libcamera::StreamConfiguration &cfg) = 0;\n> \tvirtual int encode(const libcamera::FrameBuffer *source,\n> diff --git a/src/android/jpeg/encoder_libjpeg.cpp b/src/android/jpeg/encoder_libjpeg.cpp\n> index 8995ba5..f11e004 100644\n> --- a/src/android/jpeg/encoder_libjpeg.cpp\n> +++ b/src/android/jpeg/encoder_libjpeg.cpp\n> @@ -25,7 +25,7 @@\n> \n> using namespace libcamera;\n> \n> -LOG_DECLARE_CATEGORY(JPEG);\n> +LOG_DECLARE_CATEGORY(JPEG)\n> \n> namespace {\n> \n> diff --git a/src/android/jpeg/post_processor_jpeg.cpp b/src/android/jpeg/post_processor_jpeg.cpp\n> index 753c28e..9d452b7 100644\n> --- a/src/android/jpeg/post_processor_jpeg.cpp\n> +++ b/src/android/jpeg/post_processor_jpeg.cpp\n> @@ -18,7 +18,7 @@\n> \n> using namespace libcamera;\n> \n> -LOG_DEFINE_CATEGORY(JPEG);\n> +LOG_DEFINE_CATEGORY(JPEG)\n> \n> PostProcessorJpeg::PostProcessorJpeg(CameraDevice *device)\n> \t: cameraDevice_(device)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 86FD3BDB13\n\tfor ;\n\tTue, 20 Oct 2020 07:43:37 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 52732613B7;\n\tTue, 20 Oct 2020 09:43:37 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EA296610C4\n\tfor ;\n\tTue, 20 Oct 2020 09:43:35 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6DDC052;\n\tTue, 20 Oct 2020 09:43:35 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"d+fw/6Pl\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1603179815;\n\tbh=Lah0MKGydSvxkMrjhq+Z8zxvJKzH6/fNAXiQhuCVvP8=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=d+fw/6PlDmRaN6ZkpcORuMDtRrBx3/BMrs52QK5v634mpr0DSfKH4YbItGOcAE4od\n\tO5Hd4eKe0qMXKbttWAe4iPoxyE9Q1JMg4qZevEnvsmAjzjaa37DHfRpjQ7xidw9ui5\n\tXikuHKlvubdNXMPQ3eAPGSInMfRT4VxpjRZVJp+o=","Date":"Tue, 20 Oct 2020 10:42:49 +0300","From":"Laurent Pinchart ","To":"Hirokazu Honda ","Message-ID":"<20201020074249.GE18688@pendragon.ideasonboard.com>","References":"<20201020052905.89267-1-hiroh@chromium.org>\n\t<20201020052905.89267-5-hiroh@chromium.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201020052905.89267-5-hiroh@chromium.org>","Subject":"Re: [libcamera-devel] [PATCH 4/8] android: Omit extra semicolons","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]