[{"id":13272,"web_url":"https://patchwork.libcamera.org/comment/13272/","msgid":"<20201020074220.GD18688@pendragon.ideasonboard.com>","date":"2020-10-20T07:42:20","subject":"Re: [libcamera-devel] [PATCH 3/8] gstreamer: Omit extra semicolons","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Hiro-san,\n\nThank you for the patch.\n\nOn Tue, Oct 20, 2020 at 02:29:00PM +0900, Hirokazu Honda wrote:\n> Macros used in gstreamer (e.g. G_DEFINE_TYPE) is a function. The\n\ns/is a function/are functions/\n\n> end semicolons with the macros are unnecessary.\n> \n> Signed-off-by: Hirokazu Honda \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/gstreamer/gstlibcamera.cpp | 2 +-\n> src/gstreamer/gstlibcameraallocator.cpp | 2 +-\n> src/gstreamer/gstlibcamerapad.cpp | 2 +-\n> src/gstreamer/gstlibcamerapool.cpp | 2 +-\n> src/gstreamer/gstlibcameraprovider.cpp | 6 +++---\n> src/gstreamer/gstlibcamerasrc.cpp | 2 +-\n> 6 files changed, 8 insertions(+), 8 deletions(-)\n> \n> diff --git a/src/gstreamer/gstlibcamera.cpp b/src/gstreamer/gstlibcamera.cpp\n> index 81c7bb1..52388b5 100644\n> --- a/src/gstreamer/gstlibcamera.cpp\n> +++ b/src/gstreamer/gstlibcamera.cpp\n> @@ -24,4 +24,4 @@ plugin_init(GstPlugin *plugin)\n> \n> GST_PLUGIN_DEFINE(GST_VERSION_MAJOR, GST_VERSION_MINOR,\n> \t\t libcamera, \"libcamera capture plugin\",\n> -\t\t plugin_init, VERSION, \"LGPL\", PACKAGE, \"https://libcamera.org\");\n> +\t\t plugin_init, VERSION, \"LGPL\", PACKAGE, \"https://libcamera.org\")\n> diff --git a/src/gstreamer/gstlibcameraallocator.cpp b/src/gstreamer/gstlibcameraallocator.cpp\n> index 78ded40..13c6b49 100644\n> --- a/src/gstreamer/gstlibcameraallocator.cpp\n> +++ b/src/gstreamer/gstlibcameraallocator.cpp\n> @@ -101,7 +101,7 @@ struct _GstLibcameraAllocator {\n> };\n> \n> G_DEFINE_TYPE(GstLibcameraAllocator, gst_libcamera_allocator,\n> -\t GST_TYPE_DMABUF_ALLOCATOR);\n> +\t GST_TYPE_DMABUF_ALLOCATOR)\n> \n> static gboolean\n> gst_libcamera_allocator_release(GstMiniObject *mini_object)\n> diff --git a/src/gstreamer/gstlibcamerapad.cpp b/src/gstreamer/gstlibcamerapad.cpp\n> index 9f3e2be..c00e81c 100644\n> --- a/src/gstreamer/gstlibcamerapad.cpp\n> +++ b/src/gstreamer/gstlibcamerapad.cpp\n> @@ -27,7 +27,7 @@ enum {\n> \tPROP_STREAM_ROLE\n> };\n> \n> -G_DEFINE_TYPE(GstLibcameraPad, gst_libcamera_pad, GST_TYPE_PAD);\n> +G_DEFINE_TYPE(GstLibcameraPad, gst_libcamera_pad, GST_TYPE_PAD)\n> \n> static void\n> gst_libcamera_pad_set_property(GObject *object, guint prop_id,\n> diff --git a/src/gstreamer/gstlibcamerapool.cpp b/src/gstreamer/gstlibcamerapool.cpp\n> index b756ee3..62db184 100644\n> --- a/src/gstreamer/gstlibcamerapool.cpp\n> +++ b/src/gstreamer/gstlibcamerapool.cpp\n> @@ -29,7 +29,7 @@ struct _GstLibcameraPool {\n> \tStream *stream;\n> };\n> \n> -G_DEFINE_TYPE(GstLibcameraPool, gst_libcamera_pool, GST_TYPE_BUFFER_POOL);\n> +G_DEFINE_TYPE(GstLibcameraPool, gst_libcamera_pool, GST_TYPE_BUFFER_POOL)\n> \n> static GstFlowReturn\n> gst_libcamera_pool_acquire_buffer(GstBufferPool *pool, GstBuffer **buffer,\n> diff --git a/src/gstreamer/gstlibcameraprovider.cpp b/src/gstreamer/gstlibcameraprovider.cpp\n> index cd850d8..ee44dc7 100644\n> --- a/src/gstreamer/gstlibcameraprovider.cpp\n> +++ b/src/gstreamer/gstlibcameraprovider.cpp\n> @@ -35,14 +35,14 @@ enum {\n> \n> #define GST_TYPE_LIBCAMERA_DEVICE gst_libcamera_device_get_type()\n> G_DECLARE_FINAL_TYPE(GstLibcameraDevice, gst_libcamera_device,\n> -\t\t GST_LIBCAMERA, DEVICE, GstDevice);\n> +\t\t GST_LIBCAMERA, DEVICE, GstDevice)\n> \n> struct _GstLibcameraDevice {\n> \tGstDevice parent;\n> \tgchar *name;\n> };\n> \n> -G_DEFINE_TYPE(GstLibcameraDevice, gst_libcamera_device, GST_TYPE_DEVICE);\n> +G_DEFINE_TYPE(GstLibcameraDevice, gst_libcamera_device, GST_TYPE_DEVICE)\n> \n> static GstElement *\n> gst_libcamera_device_create_element(GstDevice *device, const gchar *name)\n> @@ -164,7 +164,7 @@ struct _GstLibcameraProvider {\n> G_DEFINE_TYPE_WITH_CODE(GstLibcameraProvider, gst_libcamera_provider,\n> \t\t\tGST_TYPE_DEVICE_PROVIDER,\n> \t\t\tGST_DEBUG_CATEGORY_INIT(provider_debug, \"libcamera-provider\", 0,\n> -\t\t\t\t\t\t\"libcamera Device Provider\"));\n> +\t\t\t\t\t\t\"libcamera Device Provider\"))\n> \n> static GList *\n> gst_libcamera_provider_probe(GstDeviceProvider *provider)\n> diff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp\n> index 5001083..a099508 100644\n> --- a/src/gstreamer/gstlibcamerasrc.cpp\n> +++ b/src/gstreamer/gstlibcamerasrc.cpp\n> @@ -140,7 +140,7 @@ enum {\n> \n> G_DEFINE_TYPE_WITH_CODE(GstLibcameraSrc, gst_libcamera_src, GST_TYPE_ELEMENT,\n> \t\t\tGST_DEBUG_CATEGORY_INIT(source_debug, \"libcamerasrc\", 0,\n> -\t\t\t\t\t\t\"libcamera Source\"));\n> +\t\t\t\t\t\t\"libcamera Source\"))\n> \n> #define TEMPLATE_CAPS GST_STATIC_CAPS(\"video/x-raw; image/jpeg\")\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D2EFBBDB13\n\tfor ;\n\tTue, 20 Oct 2020 07:43:08 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A0D4E613B4;\n\tTue, 20 Oct 2020 09:43:08 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8BC0A60353\n\tfor ;\n\tTue, 20 Oct 2020 09:43:06 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2A56952;\n\tTue, 20 Oct 2020 09:43:06 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"sSv5MPu3\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1603179786;\n\tbh=68897sTZ4ALeoVCiv1U5l+uBhp5HVk/kjtrMkbMy2zI=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=sSv5MPu3EY2Y+0E7+wIwM2cOw+nFrhRYo3gjoIxv1ecsxuoGLDtHCRBDQcSMSMbz/\n\tPm56yWtP4C6l5zlKRl94F6ukWNyPRg1LJ+4oo3lKZnE0fUxNzn8NipxUdD6M0ed428\n\tKeqv0zBgZk14to+Ut8THsNbvXcabpTswIpScyVis=","Date":"Tue, 20 Oct 2020 10:42:20 +0300","From":"Laurent Pinchart ","To":"Hirokazu Honda ","Message-ID":"<20201020074220.GD18688@pendragon.ideasonboard.com>","References":"<20201020052905.89267-1-hiroh@chromium.org>\n\t<20201020052905.89267-4-hiroh@chromium.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201020052905.89267-4-hiroh@chromium.org>","Subject":"Re: [libcamera-devel] [PATCH 3/8] gstreamer: Omit extra semicolons","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]