[{"id":13271,"web_url":"https://patchwork.libcamera.org/comment/13271/","msgid":"<20201020074151.GC18688@pendragon.ideasonboard.com>","date":"2020-10-20T07:41:51","subject":"Re: [libcamera-devel] [PATCH 2/8] v4l2: Omit extra semicolons","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Hiro-san,\n\nThank you for the patch.\n\nOn Tue, Oct 20, 2020 at 02:28:59PM +0900, Hirokazu Honda wrote:\n> LOG_DECLARE_CATEGORY macro contains the semicolon. The end\n> semicolon with the macro is unnecessary.\n> \n> Signed-off-by: Hirokazu Honda \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/v4l2/v4l2_camera.cpp | 2 +-\n> src/v4l2/v4l2_camera_proxy.cpp | 2 +-\n> 2 files changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/v4l2/v4l2_camera.cpp b/src/v4l2/v4l2_camera.cpp\n> index 35d3bed..97825c7 100644\n> --- a/src/v4l2/v4l2_camera.cpp\n> +++ b/src/v4l2/v4l2_camera.cpp\n> @@ -14,7 +14,7 @@\n> \n> using namespace libcamera;\n> \n> -LOG_DECLARE_CATEGORY(V4L2Compat);\n> +LOG_DECLARE_CATEGORY(V4L2Compat)\n> \n> V4L2Camera::V4L2Camera(std::shared_ptr camera)\n> \t: camera_(camera), isRunning_(false), bufferAllocator_(nullptr),\n> diff --git a/src/v4l2/v4l2_camera_proxy.cpp b/src/v4l2/v4l2_camera_proxy.cpp\n> index 8ff990f..7803d37 100644\n> --- a/src/v4l2/v4l2_camera_proxy.cpp\n> +++ b/src/v4l2/v4l2_camera_proxy.cpp\n> @@ -32,7 +32,7 @@\n> \n> using namespace libcamera;\n> \n> -LOG_DECLARE_CATEGORY(V4L2Compat);\n> +LOG_DECLARE_CATEGORY(V4L2Compat)\n> \n> V4L2CameraProxy::V4L2CameraProxy(unsigned int index,\n> \t\t\t\t std::shared_ptr camera)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 32B99BDB13\n\tfor ;\n\tTue, 20 Oct 2020 07:42:39 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F17646052F;\n\tTue, 20 Oct 2020 09:42:38 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6C6EA60353\n\tfor ;\n\tTue, 20 Oct 2020 09:42:37 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id ED6FE52;\n\tTue, 20 Oct 2020 09:42:36 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Gz8AYtdl\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1603179757;\n\tbh=R97KpTLYv4WIpyNqsGrz50UE7S22UMdIRLcUgDnLEqo=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Gz8AYtdldIiJD/w5XD4rMvRQ7n0cyYMGVKBRqC3QcJ30Z6pxXxb5wPzKgI6062IdS\n\twvzH2NpEUty3Uq2R4WibNKJjlUArNaHkQfx5egH2/FaEUVmKNLFOL0yHZabU7hBTAN\n\tYIq9pjaN/Aeo0SqFSSP12OP9ks/mwMNohU6h+JDQ=","Date":"Tue, 20 Oct 2020 10:41:51 +0300","From":"Laurent Pinchart ","To":"Hirokazu Honda ","Message-ID":"<20201020074151.GC18688@pendragon.ideasonboard.com>","References":"<20201020052905.89267-1-hiroh@chromium.org>\n\t<20201020052905.89267-3-hiroh@chromium.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201020052905.89267-3-hiroh@chromium.org>","Subject":"Re: [libcamera-devel] [PATCH 2/8] v4l2: Omit extra semicolons","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]