[{"id":13270,"web_url":"https://patchwork.libcamera.org/comment/13270/","msgid":"<20201020074113.GB18688@pendragon.ideasonboard.com>","date":"2020-10-20T07:41:13","subject":"Re: [libcamera-devel] [PATCH 1/8] test: Omit extra semicolons","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Hiro-san,\n\nThank you for the patch.\n\nOn Tue, Oct 20, 2020 at 02:28:58PM +0900, Hirokazu Honda wrote:\n> TEST_REGISTER macro is main function. The end semicolon with the\n> macro is unnecessary.\n> \n> Signed-off-by: Hirokazu Honda \n> ---\n> test/camera/buffer_import.cpp | 2 +-\n> test/camera/capture.cpp | 2 +-\n> test/camera/configuration_default.cpp | 2 +-\n> test/camera/configuration_set.cpp | 2 +-\n> test/camera/statemachine.cpp | 2 +-\n> test/mapped-buffer.cpp | 2 +-\n> test/media_device/media_device_acquire.cpp | 2 +-\n> test/media_device/media_device_link_test.cpp | 2 +-\n> test/media_device/media_device_print_test.cpp | 2 +-\n> test/v4l2_subdevice/list_formats.cpp | 2 +-\n> test/v4l2_subdevice/test_formats.cpp | 2 +-\n> test/v4l2_videodevice/buffer_cache.cpp | 2 +-\n> test/v4l2_videodevice/buffer_sharing.cpp | 2 +-\n> test/v4l2_videodevice/capture_async.cpp | 2 +-\n> test/v4l2_videodevice/controls.cpp | 2 +-\n> test/v4l2_videodevice/double_open.cpp | 2 +-\n> test/v4l2_videodevice/formats.cpp | 2 +-\n> test/v4l2_videodevice/request_buffers.cpp | 2 +-\n> test/v4l2_videodevice/stream_on_off.cpp | 2 +-\n> test/v4l2_videodevice/v4l2_m2mdevice.cpp | 4 ++--\n> 20 files changed, 21 insertions(+), 21 deletions(-)\n> \n> diff --git a/test/camera/buffer_import.cpp b/test/camera/buffer_import.cpp\n> index 72ce7b7..4b626df 100644\n> --- a/test/camera/buffer_import.cpp\n> +++ b/test/camera/buffer_import.cpp\n> @@ -168,4 +168,4 @@ private:\n> \n> } /* namespace */\n> \n> -TEST_REGISTER(BufferImportTest);\n> +TEST_REGISTER(BufferImportTest)\n> diff --git a/test/camera/capture.cpp b/test/camera/capture.cpp\n> index c077080..f13ca53 100644\n> --- a/test/camera/capture.cpp\n> +++ b/test/camera/capture.cpp\n> @@ -168,4 +168,4 @@ protected:\n> \n> } /* namespace */\n> \n> -TEST_REGISTER(Capture);\n> +TEST_REGISTER(Capture)\n> diff --git a/test/camera/configuration_default.cpp b/test/camera/configuration_default.cpp\n> index cdd6cb9..c2b2019 100644\n> --- a/test/camera/configuration_default.cpp\n> +++ b/test/camera/configuration_default.cpp\n> @@ -56,4 +56,4 @@ protected:\n> \n> } /* namespace */\n> \n> -TEST_REGISTER(ConfigurationDefault);\n> +TEST_REGISTER(ConfigurationDefault)\n> diff --git a/test/camera/configuration_set.cpp b/test/camera/configuration_set.cpp\n> index 30f19ba..a1dc446 100644\n> --- a/test/camera/configuration_set.cpp\n> +++ b/test/camera/configuration_set.cpp\n> @@ -102,4 +102,4 @@ protected:\n> \n> } /* namespace */\n> \n> -TEST_REGISTER(ConfigurationSet);\n> +TEST_REGISTER(ConfigurationSet)\n> diff --git a/test/camera/statemachine.cpp b/test/camera/statemachine.cpp\n> index e63ab29..f0c3d77 100644\n> --- a/test/camera/statemachine.cpp\n> +++ b/test/camera/statemachine.cpp\n> @@ -211,4 +211,4 @@ protected:\n> \n> } /* namespace */\n> \n> -TEST_REGISTER(Statemachine);\n> +TEST_REGISTER(Statemachine)\n> diff --git a/test/mapped-buffer.cpp b/test/mapped-buffer.cpp\n> index 0279233..5de8201 100644\n> --- a/test/mapped-buffer.cpp\n> +++ b/test/mapped-buffer.cpp\n> @@ -113,4 +113,4 @@ private:\n> \n> } /* namespace */\n> \n> -TEST_REGISTER(MappedBufferTest);\n> +TEST_REGISTER(MappedBufferTest)\n> diff --git a/test/media_device/media_device_acquire.cpp b/test/media_device/media_device_acquire.cpp\n> index d1e3d74..371e30e 100644\n> --- a/test/media_device/media_device_acquire.cpp\n> +++ b/test/media_device/media_device_acquire.cpp\n> @@ -30,4 +30,4 @@ class MediaDeviceAcquire : public MediaDeviceTest\n> \t}\n> };\n> \n> -TEST_REGISTER(MediaDeviceAcquire);\n> +TEST_REGISTER(MediaDeviceAcquire)\n> diff --git a/test/media_device/media_device_link_test.cpp b/test/media_device/media_device_link_test.cpp\n> index fe7542b..5c74905 100644\n> --- a/test/media_device/media_device_link_test.cpp\n> +++ b/test/media_device/media_device_link_test.cpp\n> @@ -219,4 +219,4 @@ class MediaDeviceLinkTest : public MediaDeviceTest\n> \t}\n> };\n> \n> -TEST_REGISTER(MediaDeviceLinkTest);\n> +TEST_REGISTER(MediaDeviceLinkTest)\n> diff --git a/test/media_device/media_device_print_test.cpp b/test/media_device/media_device_print_test.cpp\n> index 1f5e3f3..436d4e8 100644\n> --- a/test/media_device/media_device_print_test.cpp\n> +++ b/test/media_device/media_device_print_test.cpp\n> @@ -151,4 +151,4 @@ int MediaDevicePrintTest::run()\n> \treturn ret;\n> }\n> \n> -TEST_REGISTER(MediaDevicePrintTest);\n> +TEST_REGISTER(MediaDevicePrintTest)\n> diff --git a/test/v4l2_subdevice/list_formats.cpp b/test/v4l2_subdevice/list_formats.cpp\n> index a6044c0..74ec81a 100644\n> --- a/test/v4l2_subdevice/list_formats.cpp\n> +++ b/test/v4l2_subdevice/list_formats.cpp\n> @@ -79,4 +79,4 @@ int ListFormatsTest::run()\n> \treturn TestPass;\n> }\n> \n> -TEST_REGISTER(ListFormatsTest);\n> +TEST_REGISTER(ListFormatsTest)\n> diff --git a/test/v4l2_subdevice/test_formats.cpp b/test/v4l2_subdevice/test_formats.cpp\n> index 679f50b..47f979e 100644\n> --- a/test/v4l2_subdevice/test_formats.cpp\n> +++ b/test/v4l2_subdevice/test_formats.cpp\n> @@ -75,4 +75,4 @@ int FormatHandlingTest::run()\n> \treturn TestPass;\n> }\n> \n> -TEST_REGISTER(FormatHandlingTest);\n> +TEST_REGISTER(FormatHandlingTest)\n> diff --git a/test/v4l2_videodevice/buffer_cache.cpp b/test/v4l2_videodevice/buffer_cache.cpp\n> index b22de88..b3f2bec 100644\n> --- a/test/v4l2_videodevice/buffer_cache.cpp\n> +++ b/test/v4l2_videodevice/buffer_cache.cpp\n> @@ -213,4 +213,4 @@ private:\n> \n> } /* namespace */\n> \n> -TEST_REGISTER(BufferCacheTest);\n> +TEST_REGISTER(BufferCacheTest)\n> diff --git a/test/v4l2_videodevice/buffer_sharing.cpp b/test/v4l2_videodevice/buffer_sharing.cpp\n> index ba2cc40..5e7e2d9 100644\n> --- a/test/v4l2_videodevice/buffer_sharing.cpp\n> +++ b/test/v4l2_videodevice/buffer_sharing.cpp\n> @@ -200,4 +200,4 @@ private:\n> \tunsigned int framesOutput_;\n> };\n> \n> -TEST_REGISTER(BufferSharingTest);\n> +TEST_REGISTER(BufferSharingTest)\n> diff --git a/test/v4l2_videodevice/capture_async.cpp b/test/v4l2_videodevice/capture_async.cpp\n> index 13cbcc8..2b38102 100644\n> --- a/test/v4l2_videodevice/capture_async.cpp\n> +++ b/test/v4l2_videodevice/capture_async.cpp\n> @@ -88,4 +88,4 @@ private:\n> \tunsigned int frames;\n> };\n> \n> -TEST_REGISTER(CaptureAsyncTest);\n> +TEST_REGISTER(CaptureAsyncTest)\n> diff --git a/test/v4l2_videodevice/controls.cpp b/test/v4l2_videodevice/controls.cpp\n> index 9f09d03..8d42508 100644\n> --- a/test/v4l2_videodevice/controls.cpp\n> +++ b/test/v4l2_videodevice/controls.cpp\n> @@ -127,4 +127,4 @@ protected:\n> \t}\n> };\n> \n> -TEST_REGISTER(V4L2ControlTest);\n> +TEST_REGISTER(V4L2ControlTest)\n> diff --git a/test/v4l2_videodevice/double_open.cpp b/test/v4l2_videodevice/double_open.cpp\n> index 5768d40..7d11f6f 100644\n> --- a/test/v4l2_videodevice/double_open.cpp\n> +++ b/test/v4l2_videodevice/double_open.cpp\n> @@ -38,4 +38,4 @@ protected:\n> \n> } /* namespace */\n> \n> -TEST_REGISTER(DoubleOpen);\n> +TEST_REGISTER(DoubleOpen)\n> diff --git a/test/v4l2_videodevice/formats.cpp b/test/v4l2_videodevice/formats.cpp\n> index 043732d..b5020d2 100644\n> --- a/test/v4l2_videodevice/formats.cpp\n> +++ b/test/v4l2_videodevice/formats.cpp\n> @@ -74,4 +74,4 @@ protected:\n> \t}\n> };\n> \n> -TEST_REGISTER(Format);\n> +TEST_REGISTER(Format)\n> diff --git a/test/v4l2_videodevice/request_buffers.cpp b/test/v4l2_videodevice/request_buffers.cpp\n> index 2f8dfe1..fb57714 100644\n> --- a/test/v4l2_videodevice/request_buffers.cpp\n> +++ b/test/v4l2_videodevice/request_buffers.cpp\n> @@ -26,4 +26,4 @@ protected:\n> \t}\n> };\n> \n> -TEST_REGISTER(RequestBuffersTest);\n> +TEST_REGISTER(RequestBuffersTest)\n> diff --git a/test/v4l2_videodevice/stream_on_off.cpp b/test/v4l2_videodevice/stream_on_off.cpp\n> index ce48310..4ed99e9 100644\n> --- a/test/v4l2_videodevice/stream_on_off.cpp\n> +++ b/test/v4l2_videodevice/stream_on_off.cpp\n> @@ -33,4 +33,4 @@ protected:\n> \t}\n> };\n> \n> -TEST_REGISTER(StreamOnStreamOffTest);\n> +TEST_REGISTER(StreamOnStreamOffTest)\n> diff --git a/test/v4l2_videodevice/v4l2_m2mdevice.cpp b/test/v4l2_videodevice/v4l2_m2mdevice.cpp\n> index 44a39d4..616261e 100644\n> --- a/test/v4l2_videodevice/v4l2_m2mdevice.cpp\n> +++ b/test/v4l2_videodevice/v4l2_m2mdevice.cpp\n> @@ -187,7 +187,7 @@ protected:\n> \tvoid cleanup()\n> \t{\n> \t\tdelete vim2m_;\n> -\t};\n> +\t}\n\nThis isn't described in the commit message, but I think it's fine in\nthis case. It's covered by the subject of the patch.\n\nReviewed-by: Laurent Pinchart \n\n> \n> private:\n> \tstd::unique_ptr enumerator_;\n> @@ -201,4 +201,4 @@ private:\n> \tunsigned int captureFrames_;\n> };\n> \n> -TEST_REGISTER(V4L2M2MDeviceTest);\n> +TEST_REGISTER(V4L2M2MDeviceTest)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8A217BDB13\n\tfor ;\n\tTue, 20 Oct 2020 07:42:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 10999613AD;\n\tTue, 20 Oct 2020 09:42:01 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 08C9560353\n\tfor ;\n\tTue, 20 Oct 2020 09:42:00 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6AC6B52;\n\tTue, 20 Oct 2020 09:41:59 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"bE/sQyuZ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1603179719;\n\tbh=VE3CbKSNqoW7NlTpVzruYWNqyjP2l4CNuZVCcYV7mhY=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=bE/sQyuZ644aFcaf4e6tRp44VS/Ytrx7FCu9MAcRWAF/fDlN0qvUIPwrcTXZI+Fot\n\ta6aswH7bydr3/wIUNiyUigk4R1sxy8W6zyMjLnCJuwKQypzngxy37MNKxvbGrXhz49\n\tC2KI5BVn2NciTabNnD91Hbkj3Ckch5N7euCig3Io=","Date":"Tue, 20 Oct 2020 10:41:13 +0300","From":"Laurent Pinchart ","To":"Hirokazu Honda ","Message-ID":"<20201020074113.GB18688@pendragon.ideasonboard.com>","References":"<20201020052905.89267-1-hiroh@chromium.org>\n\t<20201020052905.89267-2-hiroh@chromium.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201020052905.89267-2-hiroh@chromium.org>","Subject":"Re: [libcamera-devel] [PATCH 1/8] test: Omit extra semicolons","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]