[{"id":13268,"web_url":"https://patchwork.libcamera.org/comment/13268/","msgid":"<20201020035739.GF2041@pyrite.rasen.tech>","date":"2020-10-20T03:57:39","subject":"Re: [libcamera-devel] [PATCH v2 3/5] libcamera: camera_manager:\n\tMake CameraManager::Private::mutex_ mutable","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"On Tue, Oct 20, 2020 at 04:40:03AM +0300, Laurent Pinchart wrote:\n> The mutex_ stored in the CameraManager::Private class is used to protect\n> members that may need to be accessed from const functions. Make it\n> mutable to allow this.\n> \n> Signed-off-by: Laurent Pinchart \n> Reviewed-by: Niklas Söderlund \n> Reviewed-by: Jacopo Mondi \n\nReviewed-by: Paul Elder \n\n> ---\n> src/libcamera/camera_manager.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/camera_manager.cpp b/src/libcamera/camera_manager.cpp\n> index 81785f919d8b..3fef69633028 100644\n> --- a/src/libcamera/camera_manager.cpp\n> +++ b/src/libcamera/camera_manager.cpp\n> @@ -50,7 +50,7 @@ public:\n> \t * - initialized_ and status_ during initialization\n> \t * - cameras_ and camerasByDevnum_ after initialization\n> \t */\n> -\tMutex mutex_;\n> +\tmutable Mutex mutex_;\n> \tstd::vector> cameras_;\n> \tstd::map> camerasByDevnum_;\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 25EB7BDB1F\n\tfor ;\n\tTue, 20 Oct 2020 03:57:49 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B23CF610C4;\n\tTue, 20 Oct 2020 05:57:48 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5787E6052F\n\tfor ;\n\tTue, 20 Oct 2020 05:57:47 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A2B5452;\n\tTue, 20 Oct 2020 05:57:45 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"qLkCAf3E\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1603166266;\n\tbh=j9kwl4I1FMevSLCugwn43knLa5cy4SH2UiWhIo1AMd4=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=qLkCAf3ER7tO0HsMoiqMFARuj6rNzk5s/fgF/U0n2WZo+bzwD+F9VU4MIq5h8Q7I2\n\tneAyIE6TU2g3aPJpIZmwdZCBmzdAuoS3k20/V+Uc7Q1DoQRFgu3AAdV+BaOt5aQbBQ\n\tGesn887Tg7+vFJ+Ojfp/x1fY7kvebwkA5d8TQ1sw=","Date":"Tue, 20 Oct 2020 12:57:39 +0900","From":"paul.elder@ideasonboard.com","To":"Laurent Pinchart ","Message-ID":"<20201020035739.GF2041@pyrite.rasen.tech>","References":"<20201020014005.12783-1-laurent.pinchart@ideasonboard.com>\n\t<20201020014005.12783-4-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201020014005.12783-4-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2 3/5] libcamera: camera_manager:\n\tMake CameraManager::Private::mutex_ mutable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]