[{"id":13261,"web_url":"https://patchwork.libcamera.org/comment/13261/","msgid":"<20201020031512.GD2041@pyrite.rasen.tech>","date":"2020-10-20T03:15:12","subject":"Re: [libcamera-devel] [PATCH 5/5] libcamera: Document the libcamera\n\tnamespace","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Hi Laurent,\n\nOn Tue, Oct 20, 2020 at 03:03:10AM +0300, Laurent Pinchart wrote:\n> The libcamera namespace has been left undefined from the start. While\n> the documentation doesn't bring much added value, leaving it out\n> confuses the most recent doxygen master branch:\n\nAll to appease doxygen.\n\n> include/libcamera/transform.h:16: warning: Internal inconsistency: member Identity does not belong to any container!\n> include/libcamera/transform.h:17: warning: Internal inconsistency: member Rot0 does not belong to any container!\n> include/libcamera/transform.h:18: warning: Internal inconsistency: member HFlip does not belong to any container!\n> include/libcamera/transform.h:19: warning: Internal inconsistency: member VFlip does not belong to any container!\n> include/libcamera/transform.h:20: warning: Internal inconsistency: member HVFlip does not belong to any container!\n> include/libcamera/transform.h:21: warning: Internal inconsistency: member Rot180 does not belong to any container!\n> include/libcamera/transform.h:22: warning: Internal inconsistency: member Transpose does not belong to any container!\n> include/libcamera/transform.h:23: warning: Internal inconsistency: member Rot270 does not belong to any container!\n> include/libcamera/transform.h:24: warning: Internal inconsistency: member Rot90 does not belong to any container!\n> include/libcamera/transform.h:26: warning: Internal inconsistency: member Rot180Transpose does not belong to any container!\n> \n> Document it.\n> \n> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\nReviewed-by: Paul Elder <paul.elder@ideasonboard.com>\n\n> ---\n>  src/libcamera/camera_manager.cpp | 3 +++\n>  1 file changed, 3 insertions(+)\n> \n> diff --git a/src/libcamera/camera_manager.cpp b/src/libcamera/camera_manager.cpp\n> index 756f5b2b4a03..81785f919d8b 100644\n> --- a/src/libcamera/camera_manager.cpp\n> +++ b/src/libcamera/camera_manager.cpp\n> @@ -27,6 +27,9 @@\n>   * \\brief The camera manager\n>   */\n>  \n> +/**\n> + * \\brief Top-level libcamera namespace\n> + */\n>  namespace libcamera {\n>  \n>  LOG_DEFINE_CATEGORY(Camera)\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4F741BDB13\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 20 Oct 2020 03:15:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BF6CF61373;\n\tTue, 20 Oct 2020 05:15:22 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E31E86052F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 20 Oct 2020 05:15:20 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4C3E452;\n\tTue, 20 Oct 2020 05:15:19 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"GX8HKZbL\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1603163720;\n\tbh=GiA9yC5Y1OYVzrg0fjIjvLdFZyeS2j+5Ly4E00EaQvA=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=GX8HKZbLuF7zpSFSVh+wZSuAOtkbk6RhJtFimAR4wGlKTxjMZD0lzCMw+L4T+FmaI\n\t3dhPDz+jV4gprfyrJaQYaRLim/xoExR1m6WYsimZ1uTJhkZu7bKGmCBJ/menou2H/U\n\t4AujyuIzTA7frZvzoL+NsHQasW1o5Tl3iUbvRvyw=","Date":"Tue, 20 Oct 2020 12:15:12 +0900","From":"paul.elder@ideasonboard.com","To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","Message-ID":"<20201020031512.GD2041@pyrite.rasen.tech>","References":"<20201020000310.3008-1-laurent.pinchart@ideasonboard.com>\n\t<20201020000310.3008-6-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201020000310.3008-6-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 5/5] libcamera: Document the libcamera\n\tnamespace","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":13265,"web_url":"https://patchwork.libcamera.org/comment/13265/","msgid":"<f38c1ab2-baa2-3da9-228d-ef882eddde13@uajain.com>","date":"2020-10-20T03:31:40","subject":"Re: [libcamera-devel] [PATCH 5/5] libcamera: Document the libcamera\n\tnamespace","submitter":{"id":1,"url":"https://patchwork.libcamera.org/api/people/1/","name":"Umang Jain","email":"email@uajain.com"},"content":"Hi,\n\nOn 10/20/20 8:45 AM, paul.elder@ideasonboard.com wrote:\n> Hi Laurent,\n>\n> On Tue, Oct 20, 2020 at 03:03:10AM +0300, Laurent Pinchart wrote:\n>> The libcamera namespace has been left undefined from the start. While\n>> the documentation doesn't bring much added value, leaving it out\n>> confuses the most recent doxygen master branch:\n> All to appease doxygen.\nhaha, indeed. All hail Doxygen!\n>\n>> include/libcamera/transform.h:16: warning: Internal inconsistency: member Identity does not belong to any container!\n>> include/libcamera/transform.h:17: warning: Internal inconsistency: member Rot0 does not belong to any container!\n>> include/libcamera/transform.h:18: warning: Internal inconsistency: member HFlip does not belong to any container!\n>> include/libcamera/transform.h:19: warning: Internal inconsistency: member VFlip does not belong to any container!\n>> include/libcamera/transform.h:20: warning: Internal inconsistency: member HVFlip does not belong to any container!\n>> include/libcamera/transform.h:21: warning: Internal inconsistency: member Rot180 does not belong to any container!\n>> include/libcamera/transform.h:22: warning: Internal inconsistency: member Transpose does not belong to any container!\n>> include/libcamera/transform.h:23: warning: Internal inconsistency: member Rot270 does not belong to any container!\n>> include/libcamera/transform.h:24: warning: Internal inconsistency: member Rot90 does not belong to any container!\n>> include/libcamera/transform.h:26: warning: Internal inconsistency: member Rot180Transpose does not belong to any container!\n>>\n>> Document it.\n>>\n>> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n> Reviewed-by: Paul Elder <paul.elder@ideasonboard.com>\nReviewed-by: Umang Jain <email@uajain.com>\n\nThanks!\n>\n>> ---\n>>   src/libcamera/camera_manager.cpp | 3 +++\n>>   1 file changed, 3 insertions(+)\n>>\n>> diff --git a/src/libcamera/camera_manager.cpp b/src/libcamera/camera_manager.cpp\n>> index 756f5b2b4a03..81785f919d8b 100644\n>> --- a/src/libcamera/camera_manager.cpp\n>> +++ b/src/libcamera/camera_manager.cpp\n>> @@ -27,6 +27,9 @@\n>>    * \\brief The camera manager\n>>    */\n>>   \n>> +/**\n>> + * \\brief Top-level libcamera namespace\n>> + */\n>>   namespace libcamera {\n>>   \n>>   LOG_DEFINE_CATEGORY(Camera)\n>> -- \n>> Regards,\n>>\n>> Laurent Pinchart\n>>\n>> _______________________________________________\n>> libcamera-devel mailing list\n>> libcamera-devel@lists.libcamera.org\n>> https://lists.libcamera.org/listinfo/libcamera-devel\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 659C2BDB1F\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 20 Oct 2020 03:31:46 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C5072610C4;\n\tTue, 20 Oct 2020 05:31:45 +0200 (CEST)","from mail.uajain.com (static.126.159.217.95.clients.your-server.de\n\t[95.217.159.126])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1FF1560CE6\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 20 Oct 2020 05:31:44 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=uajain.com header.i=@uajain.com\n\theader.b=\"F540L4Nx\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=uajain.com; s=mail;\n\tt=1603164703; bh=DqJBusFKCw3qgf62f9d5u0tKVHFD5SGxxVq4R2WWo44=;\n\th=Subject:To:References:From:In-Reply-To;\n\tb=F540L4NxOy57Uml+xOruv/y6EAEIahBqb0gx2EAjvqITLDfclIA0zG4rTl5tC2nnL\n\tjzctWrvzX0aMiqyQ6pG7z8y1IwCH8hgQ7UYLXGmRPs02Z7Ve5RaTKUzuwJCoDo8KJ2\n\tiPczizGOhR0rG27GpPe3IqS4QrIu9oqQvd92S9fXy92E96Pp8OlTd4rcXvcU1PThKs\n\tUTVY0zAFO6DDxzVRqwfRZyC4MWxakHuhqiY5C1H2LCbQLgaKxE+Pw4wKm4ZjBk/Xws\n\tMkWODorXhOQkY78qXtPSQNAC10xJh4rG8qn7hz9wFGsVwsGpzeBVxsaCdmIA6TFkXk\n\tyMqWlQB9K8Izw==","To":"libcamera-devel@lists.libcamera.org","References":"<20201020000310.3008-1-laurent.pinchart@ideasonboard.com>\n\t<20201020000310.3008-6-laurent.pinchart@ideasonboard.com>\n\t<20201020031512.GD2041@pyrite.rasen.tech>","From":"Umang Jain <email@uajain.com>","Message-ID":"<f38c1ab2-baa2-3da9-228d-ef882eddde13@uajain.com>","Date":"Tue, 20 Oct 2020 09:01:40 +0530","Mime-Version":"1.0","In-Reply-To":"<20201020031512.GD2041@pyrite.rasen.tech>","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH 5/5] libcamera: Document the libcamera\n\tnamespace","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Content-Transfer-Encoding":"7bit","Content-Type":"text/plain; charset=\"us-ascii\"; Format=\"flowed\"","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":13266,"web_url":"https://patchwork.libcamera.org/comment/13266/","msgid":"<20201020033158.GC7412@pendragon.ideasonboard.com>","date":"2020-10-20T03:31:58","subject":"Re: [libcamera-devel] [PATCH 5/5] libcamera: Document the libcamera\n\tnamespace","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Tue, Oct 20, 2020 at 12:15:12PM +0900, paul.elder@ideasonboard.com wrote:\n> Hi Laurent,\n> \n> On Tue, Oct 20, 2020 at 03:03:10AM +0300, Laurent Pinchart wrote:\n> > The libcamera namespace has been left undefined from the start. While\n> > the documentation doesn't bring much added value, leaving it out\n> > confuses the most recent doxygen master branch:\n> \n> All to appease doxygen.\n\nThe life of a developer: appeasing their tools :-) When it's not doxygen\nit's the compiler, and when it's not the compiler it's meson. And when\nit's none of them, our SD cards blow up or our mother boards decide to\nto divorce from DRAM modules. Any resemblance to developers working on\nlibcamera if completely intentional, I'm sure the person I'm thinking\nabout will recognize himself :-)\n\n> > include/libcamera/transform.h:16: warning: Internal inconsistency: member Identity does not belong to any container!\n> > include/libcamera/transform.h:17: warning: Internal inconsistency: member Rot0 does not belong to any container!\n> > include/libcamera/transform.h:18: warning: Internal inconsistency: member HFlip does not belong to any container!\n> > include/libcamera/transform.h:19: warning: Internal inconsistency: member VFlip does not belong to any container!\n> > include/libcamera/transform.h:20: warning: Internal inconsistency: member HVFlip does not belong to any container!\n> > include/libcamera/transform.h:21: warning: Internal inconsistency: member Rot180 does not belong to any container!\n> > include/libcamera/transform.h:22: warning: Internal inconsistency: member Transpose does not belong to any container!\n> > include/libcamera/transform.h:23: warning: Internal inconsistency: member Rot270 does not belong to any container!\n> > include/libcamera/transform.h:24: warning: Internal inconsistency: member Rot90 does not belong to any container!\n> > include/libcamera/transform.h:26: warning: Internal inconsistency: member Rot180Transpose does not belong to any container!\n> > \n> > Document it.\n> > \n> > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n> \n> Reviewed-by: Paul Elder <paul.elder@ideasonboard.com>\n> \n> > ---\n> >  src/libcamera/camera_manager.cpp | 3 +++\n> >  1 file changed, 3 insertions(+)\n> > \n> > diff --git a/src/libcamera/camera_manager.cpp b/src/libcamera/camera_manager.cpp\n> > index 756f5b2b4a03..81785f919d8b 100644\n> > --- a/src/libcamera/camera_manager.cpp\n> > +++ b/src/libcamera/camera_manager.cpp\n> > @@ -27,6 +27,9 @@\n> >   * \\brief The camera manager\n> >   */\n> >  \n> > +/**\n> > + * \\brief Top-level libcamera namespace\n> > + */\n> >  namespace libcamera {\n> >  \n> >  LOG_DEFINE_CATEGORY(Camera)","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 696C9BDB1F\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 20 Oct 2020 03:32:46 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 386CB613AD;\n\tTue, 20 Oct 2020 05:32:46 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 78A4060CE6\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 20 Oct 2020 05:32:45 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 13AA052;\n\tTue, 20 Oct 2020 05:32:45 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Jeyt1ixw\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1603164765;\n\tbh=eH9IPup8OoP2iAhlqUj+uaOtIHsD+L2AFR2WZ8cIhXQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Jeyt1ixwneBvdx036WuiBxUmnzYUl+wQHSU3s9cCIge07WWybO44IHvNtvGFMtQ48\n\ticT3KNeBlb4zHKPrQHDJq/pmI5tqOHYGcWkSjxmzcwHVTy8dsFpI7p7pysK6ze3L7k\n\ta8SLVyN1M4TjkINSBkk0o9QOhhIF4s+cBZqmF4QQ=","Date":"Tue, 20 Oct 2020 06:31:58 +0300","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"paul.elder@ideasonboard.com","Message-ID":"<20201020033158.GC7412@pendragon.ideasonboard.com>","References":"<20201020000310.3008-1-laurent.pinchart@ideasonboard.com>\n\t<20201020000310.3008-6-laurent.pinchart@ideasonboard.com>\n\t<20201020031512.GD2041@pyrite.rasen.tech>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201020031512.GD2041@pyrite.rasen.tech>","Subject":"Re: [libcamera-devel] [PATCH 5/5] libcamera: Document the libcamera\n\tnamespace","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":13296,"web_url":"https://patchwork.libcamera.org/comment/13296/","msgid":"<27c8c039-73ea-79e5-79c6-788a4dead79a@ideasonboard.com>","date":"2020-10-20T10:39:41","subject":"Re: [libcamera-devel] [PATCH 5/5] libcamera: Document the libcamera\n\tnamespace","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 20/10/2020 01:03, Laurent Pinchart wrote:\n> The libcamera namespace has been left undefined from the start. While\n> the documentation doesn't bring much added value, leaving it out\n> confuses the most recent doxygen master branch:\n> \n> include/libcamera/transform.h:16: warning: Internal inconsistency: member Identity does not belong to any container!\n> include/libcamera/transform.h:17: warning: Internal inconsistency: member Rot0 does not belong to any container!\n> include/libcamera/transform.h:18: warning: Internal inconsistency: member HFlip does not belong to any container!\n> include/libcamera/transform.h:19: warning: Internal inconsistency: member VFlip does not belong to any container!\n> include/libcamera/transform.h:20: warning: Internal inconsistency: member HVFlip does not belong to any container!\n> include/libcamera/transform.h:21: warning: Internal inconsistency: member Rot180 does not belong to any container!\n> include/libcamera/transform.h:22: warning: Internal inconsistency: member Transpose does not belong to any container!\n> include/libcamera/transform.h:23: warning: Internal inconsistency: member Rot270 does not belong to any container!\n> include/libcamera/transform.h:24: warning: Internal inconsistency: member Rot90 does not belong to any container!\n> include/libcamera/transform.h:26: warning: Internal inconsistency: member Rot180Transpose does not belong to any container!\n> \n> Document it.\n> \n> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n> ---\n>  src/libcamera/camera_manager.cpp | 3 +++\n>  1 file changed, 3 insertions(+)\n> \n> diff --git a/src/libcamera/camera_manager.cpp b/src/libcamera/camera_manager.cpp\n> index 756f5b2b4a03..81785f919d8b 100644\n> --- a/src/libcamera/camera_manager.cpp\n> +++ b/src/libcamera/camera_manager.cpp\n> @@ -27,6 +27,9 @@\n>   * \\brief The camera manager\n>   */\n>  \n> +/**\n> + * \\brief Top-level libcamera namespace\n> + */\n\nPhew, I was preparing myself to read a 10 page novel.\n\nI can handle one line ;-)\n\nhehe.\n\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\n>  namespace libcamera {\n>  \n>  LOG_DEFINE_CATEGORY(Camera)\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4DCAEBDB13\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 20 Oct 2020 10:39:46 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1C6E661D82;\n\tTue, 20 Oct 2020 12:39:46 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 81B6560CDD\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 20 Oct 2020 12:39:44 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 23C6B52;\n\tTue, 20 Oct 2020 12:39:44 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"EQ6yFVdF\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1603190384;\n\tbh=D5bszevvTnBq4W2IeaCDKzethAy+68NUrdWe7HuicUs=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=EQ6yFVdFnE163e34DSlUqZ3Se5p5JIXvLvan1SQRMb8mESJFPRDWBBXXk33S5oqQZ\n\ta3+1sgJcxIKYBMK5tP4T7WHj0bdJOswqu2IPhmsNqFPaVKb2qwPuPqzFBorfg1Hnb7\n\tJWPW1/eAzcI4c2UACYb+a28c7vLRG7OHJraAyccU=","To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tlibcamera-devel@lists.libcamera.org","References":"<20201020000310.3008-1-laurent.pinchart@ideasonboard.com>\n\t<20201020000310.3008-6-laurent.pinchart@ideasonboard.com>","From":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<27c8c039-73ea-79e5-79c6-788a4dead79a@ideasonboard.com>","Date":"Tue, 20 Oct 2020 11:39:41 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20201020000310.3008-6-laurent.pinchart@ideasonboard.com>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH 5/5] libcamera: Document the libcamera\n\tnamespace","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]