[{"id":13260,"web_url":"https://patchwork.libcamera.org/comment/13260/","msgid":"<20201020025719.GC2041@pyrite.rasen.tech>","date":"2020-10-20T02:57:19","subject":"Re: [libcamera-devel] [PATCH 4/5] libcamera: Drop semicolon after\n\tLOG_{DECLARE, DEFINE}_CATEGORY","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Hi Laurent,\n\nOn Tue, Oct 20, 2020 at 03:03:09AM +0300, Laurent Pinchart wrote:\n> No semicolon is needed after the macro. Drop it in the few locations\n> that have one.\n\nI see android and v4l2 have the same issue in some places. I guess\nthat can be done on top.\n\n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Paul Elder \n\n> ---\n> src/libcamera/byte_stream_buffer.cpp | 2 +-\n> src/libcamera/camera_sensor.cpp | 2 +-\n> src/libcamera/file.cpp | 2 +-\n> src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp | 2 +-\n> src/libcamera/pipeline/simple/converter.cpp | 2 +-\n> src/libcamera/sysfs.cpp | 2 +-\n> 6 files changed, 6 insertions(+), 6 deletions(-)\n> \n> diff --git a/src/libcamera/byte_stream_buffer.cpp b/src/libcamera/byte_stream_buffer.cpp\n> index eb9003927266..7fc6f6944471 100644\n> --- a/src/libcamera/byte_stream_buffer.cpp\n> +++ b/src/libcamera/byte_stream_buffer.cpp\n> @@ -19,7 +19,7 @@\n> \n> namespace libcamera {\n> \n> -LOG_DEFINE_CATEGORY(Serialization);\n> +LOG_DEFINE_CATEGORY(Serialization)\n> \n> /**\n> * \\class ByteStreamBuffer\n> diff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp\n> index 78c7ceec7c44..935de528c496 100644\n> --- a/src/libcamera/camera_sensor.cpp\n> +++ b/src/libcamera/camera_sensor.cpp\n> @@ -28,7 +28,7 @@\n> \n> namespace libcamera {\n> \n> -LOG_DEFINE_CATEGORY(CameraSensor);\n> +LOG_DEFINE_CATEGORY(CameraSensor)\n> \n> /**\n> * \\struct CameraSensorInfo\n> diff --git a/src/libcamera/file.cpp b/src/libcamera/file.cpp\n> index 04b0cb61a1bf..3a3f5bb63ffc 100644\n> --- a/src/libcamera/file.cpp\n> +++ b/src/libcamera/file.cpp\n> @@ -23,7 +23,7 @@\n> \n> namespace libcamera {\n> \n> -LOG_DEFINE_CATEGORY(File);\n> +LOG_DEFINE_CATEGORY(File)\n> \n> /**\n> * \\class File\n> diff --git a/src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp b/src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp\n> index 0572acc93d63..62605c0fceee 100644\n> --- a/src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp\n> +++ b/src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp\n> @@ -17,7 +17,7 @@\n> \n> namespace libcamera {\n> \n> -LOG_DEFINE_CATEGORY(RPI_S_W);\n> +LOG_DEFINE_CATEGORY(RPI_S_W)\n> \n> namespace RPi {\n> \n> diff --git a/src/libcamera/pipeline/simple/converter.cpp b/src/libcamera/pipeline/simple/converter.cpp\n> index 75fb297ebd58..b4ee021f6210 100644\n> --- a/src/libcamera/pipeline/simple/converter.cpp\n> +++ b/src/libcamera/pipeline/simple/converter.cpp\n> @@ -21,7 +21,7 @@\n> \n> namespace libcamera {\n> \n> -LOG_DECLARE_CATEGORY(SimplePipeline);\n> +LOG_DECLARE_CATEGORY(SimplePipeline)\n> \n> SimpleConverter::SimpleConverter(MediaDevice *media)\n> \t: m2m_(nullptr)\n> diff --git a/src/libcamera/sysfs.cpp b/src/libcamera/sysfs.cpp\n> index 6c8e9554188d..3ebe66f8d69b 100644\n> --- a/src/libcamera/sysfs.cpp\n> +++ b/src/libcamera/sysfs.cpp\n> @@ -22,7 +22,7 @@\n> \n> namespace libcamera {\n> \n> -LOG_DEFINE_CATEGORY(SysFs);\n> +LOG_DEFINE_CATEGORY(SysFs)\n> \n> namespace sysfs {\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AB1C6BDB1F\n\tfor ;\n\tTue, 20 Oct 2020 02:57:28 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 38AC261373;\n\tTue, 20 Oct 2020 04:57:28 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 11B5A6052F\n\tfor ;\n\tTue, 20 Oct 2020 04:57:27 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8AC6752;\n\tTue, 20 Oct 2020 04:57:25 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"lNLd0KXn\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1603162646;\n\tbh=5uZsWW4FJ3vHg2g024ZGKbghPDYfgQehpTMcBMAKlqc=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=lNLd0KXn1WKkHtj/kZfUdae5vlHen/lTywAKwoirszF53MvY7VadpsfkKTyVisO6U\n\tfF0tzDph551PaETa4DimetGc7ucLdyQeMOiZnsWTmfXKIt61W0ZMLWsJAVOLOrDa24\n\tBXtcCuYKcas4N38IO4uC+7cIz0zI3ZvXErIoPRQc=","Date":"Tue, 20 Oct 2020 11:57:19 +0900","From":"paul.elder@ideasonboard.com","To":"Laurent Pinchart ","Message-ID":"<20201020025719.GC2041@pyrite.rasen.tech>","References":"<20201020000310.3008-1-laurent.pinchart@ideasonboard.com>\n\t<20201020000310.3008-5-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201020000310.3008-5-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 4/5] libcamera: Drop semicolon after\n\tLOG_{DECLARE, DEFINE}_CATEGORY","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13263,"web_url":"https://patchwork.libcamera.org/comment/13263/","msgid":"<0cd7204b-7587-1e5f-00c2-30e5e860ae71@uajain.com>","date":"2020-10-20T03:27:59","subject":"Re: [libcamera-devel] [PATCH 4/5] libcamera: Drop semicolon after\n\tLOG_{DECLARE, DEFINE}_CATEGORY","submitter":{"id":1,"url":"https://patchwork.libcamera.org/api/people/1/","name":"Umang Jain","email":"email@uajain.com"},"content":"Hi Laurent,\n\nOn 10/20/20 5:33 AM, Laurent Pinchart wrote:\n> No semicolon is needed after the macro. Drop it in the few locations\n> that have one.\n>\n> Signed-off-by: Laurent Pinchart \nLGTM.\nReviewed-by: Umang Jain \n> ---\n> src/libcamera/byte_stream_buffer.cpp | 2 +-\n> src/libcamera/camera_sensor.cpp | 2 +-\n> src/libcamera/file.cpp | 2 +-\n> src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp | 2 +-\n> src/libcamera/pipeline/simple/converter.cpp | 2 +-\n> src/libcamera/sysfs.cpp | 2 +-\n> 6 files changed, 6 insertions(+), 6 deletions(-)\n>\n> diff --git a/src/libcamera/byte_stream_buffer.cpp b/src/libcamera/byte_stream_buffer.cpp\n> index eb9003927266..7fc6f6944471 100644\n> --- a/src/libcamera/byte_stream_buffer.cpp\n> +++ b/src/libcamera/byte_stream_buffer.cpp\n> @@ -19,7 +19,7 @@\n> \n> namespace libcamera {\n> \n> -LOG_DEFINE_CATEGORY(Serialization);\n> +LOG_DEFINE_CATEGORY(Serialization)\n> \n> /**\n> * \\class ByteStreamBuffer\n> diff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp\n> index 78c7ceec7c44..935de528c496 100644\n> --- a/src/libcamera/camera_sensor.cpp\n> +++ b/src/libcamera/camera_sensor.cpp\n> @@ -28,7 +28,7 @@\n> \n> namespace libcamera {\n> \n> -LOG_DEFINE_CATEGORY(CameraSensor);\n> +LOG_DEFINE_CATEGORY(CameraSensor)\n> \n> /**\n> * \\struct CameraSensorInfo\n> diff --git a/src/libcamera/file.cpp b/src/libcamera/file.cpp\n> index 04b0cb61a1bf..3a3f5bb63ffc 100644\n> --- a/src/libcamera/file.cpp\n> +++ b/src/libcamera/file.cpp\n> @@ -23,7 +23,7 @@\n> \n> namespace libcamera {\n> \n> -LOG_DEFINE_CATEGORY(File);\n> +LOG_DEFINE_CATEGORY(File)\n> \n> /**\n> * \\class File\n> diff --git a/src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp b/src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp\n> index 0572acc93d63..62605c0fceee 100644\n> --- a/src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp\n> +++ b/src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp\n> @@ -17,7 +17,7 @@\n> \n> namespace libcamera {\n> \n> -LOG_DEFINE_CATEGORY(RPI_S_W);\n> +LOG_DEFINE_CATEGORY(RPI_S_W)\n> \n> namespace RPi {\n> \n> diff --git a/src/libcamera/pipeline/simple/converter.cpp b/src/libcamera/pipeline/simple/converter.cpp\n> index 75fb297ebd58..b4ee021f6210 100644\n> --- a/src/libcamera/pipeline/simple/converter.cpp\n> +++ b/src/libcamera/pipeline/simple/converter.cpp\n> @@ -21,7 +21,7 @@\n> \n> namespace libcamera {\n> \n> -LOG_DECLARE_CATEGORY(SimplePipeline);\n> +LOG_DECLARE_CATEGORY(SimplePipeline)\n> \n> SimpleConverter::SimpleConverter(MediaDevice *media)\n> \t: m2m_(nullptr)\n> diff --git a/src/libcamera/sysfs.cpp b/src/libcamera/sysfs.cpp\n> index 6c8e9554188d..3ebe66f8d69b 100644\n> --- a/src/libcamera/sysfs.cpp\n> +++ b/src/libcamera/sysfs.cpp\n> @@ -22,7 +22,7 @@\n> \n> namespace libcamera {\n> \n> -LOG_DEFINE_CATEGORY(SysFs);\n> +LOG_DEFINE_CATEGORY(SysFs)\n> \n> namespace sysfs {\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4E411BDB13\n\tfor ;\n\tTue, 20 Oct 2020 03:28:04 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D3EE461373;\n\tTue, 20 Oct 2020 05:28:03 +0200 (CEST)","from mail.uajain.com (static.126.159.217.95.clients.your-server.de\n\t[95.217.159.126])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B7B9C6052F\n\tfor ;\n\tTue, 20 Oct 2020 05:28:02 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=uajain.com header.i=@uajain.com\n\theader.b=\"Ec/LKE98\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=uajain.com; s=mail;\n\tt=1603164482; bh=KnqDk0lUlVdye0nITYWSE7EdkXz/MVEHjZq3gNkgIzQ=;\n\th=Subject:To:References:From:In-Reply-To;\n\tb=Ec/LKE98gjp48nM+8z9hO5sUf8F9EJJwEEDPbueVTa3VasWBfNOEDBzz+XfVGDpNS\n\tz7ihZJn5pG4e3Xi0gWG8OEQumCWrwGCjWiOK8Ex6N0gT5pRdy9KSAzCyNH0xIXE6qj\n\tiwKrj6qDsKhDmaYXjV46gF+0fhL11jFbXBTPBmtZA4lyYp4NjUlmejm6zPp+/ji43f\n\tvohbBp1AS4jkm+UflYz7RH+EQncAF4BGj5hT5JkwyWj53YL3G8DDLUGas3AWL3i290\n\tqlbIhUY3046P/8Tlp7WVuaztr7Mh3CJtsqrsij/7Kyi574E+PfWG3uJ+TMJUb50Hzd\n\tTwysZth7n2gRw==","To":"libcamera-devel@lists.libcamera.org","References":"<20201020000310.3008-1-laurent.pinchart@ideasonboard.com>\n\t<20201020000310.3008-5-laurent.pinchart@ideasonboard.com>","From":"Umang Jain ","Message-ID":"<0cd7204b-7587-1e5f-00c2-30e5e860ae71@uajain.com>","Date":"Tue, 20 Oct 2020 08:57:59 +0530","Mime-Version":"1.0","In-Reply-To":"<20201020000310.3008-5-laurent.pinchart@ideasonboard.com>","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH 4/5] libcamera: Drop semicolon after\n\tLOG_{DECLARE, DEFINE}_CATEGORY","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Transfer-Encoding":"7bit","Content-Type":"text/plain; charset=\"us-ascii\"; Format=\"flowed\"","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13264,"web_url":"https://patchwork.libcamera.org/comment/13264/","msgid":"<20201020032841.GB7412@pendragon.ideasonboard.com>","date":"2020-10-20T03:28:41","subject":"Re: [libcamera-devel] [PATCH 4/5] libcamera: Drop semicolon after\n\tLOG_{DECLARE, DEFINE}_CATEGORY","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Paul,\n\nOn Tue, Oct 20, 2020 at 11:57:19AM +0900, paul.elder@ideasonboard.com wrote:\n> On Tue, Oct 20, 2020 at 03:03:09AM +0300, Laurent Pinchart wrote:\n> > No semicolon is needed after the macro. Drop it in the few locations\n> > that have one.\n> \n> I see android and v4l2 have the same issue in some places. I guess\n> that can be done on top.\n\nOops, I've missed that. I'll post a new version.\n\n> > Signed-off-by: Laurent Pinchart \n> \n> Reviewed-by: Paul Elder \n> \n> > ---\n> > src/libcamera/byte_stream_buffer.cpp | 2 +-\n> > src/libcamera/camera_sensor.cpp | 2 +-\n> > src/libcamera/file.cpp | 2 +-\n> > src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp | 2 +-\n> > src/libcamera/pipeline/simple/converter.cpp | 2 +-\n> > src/libcamera/sysfs.cpp | 2 +-\n> > 6 files changed, 6 insertions(+), 6 deletions(-)\n> > \n> > diff --git a/src/libcamera/byte_stream_buffer.cpp b/src/libcamera/byte_stream_buffer.cpp\n> > index eb9003927266..7fc6f6944471 100644\n> > --- a/src/libcamera/byte_stream_buffer.cpp\n> > +++ b/src/libcamera/byte_stream_buffer.cpp\n> > @@ -19,7 +19,7 @@\n> > \n> > namespace libcamera {\n> > \n> > -LOG_DEFINE_CATEGORY(Serialization);\n> > +LOG_DEFINE_CATEGORY(Serialization)\n> > \n> > /**\n> > * \\class ByteStreamBuffer\n> > diff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp\n> > index 78c7ceec7c44..935de528c496 100644\n> > --- a/src/libcamera/camera_sensor.cpp\n> > +++ b/src/libcamera/camera_sensor.cpp\n> > @@ -28,7 +28,7 @@\n> > \n> > namespace libcamera {\n> > \n> > -LOG_DEFINE_CATEGORY(CameraSensor);\n> > +LOG_DEFINE_CATEGORY(CameraSensor)\n> > \n> > /**\n> > * \\struct CameraSensorInfo\n> > diff --git a/src/libcamera/file.cpp b/src/libcamera/file.cpp\n> > index 04b0cb61a1bf..3a3f5bb63ffc 100644\n> > --- a/src/libcamera/file.cpp\n> > +++ b/src/libcamera/file.cpp\n> > @@ -23,7 +23,7 @@\n> > \n> > namespace libcamera {\n> > \n> > -LOG_DEFINE_CATEGORY(File);\n> > +LOG_DEFINE_CATEGORY(File)\n> > \n> > /**\n> > * \\class File\n> > diff --git a/src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp b/src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp\n> > index 0572acc93d63..62605c0fceee 100644\n> > --- a/src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp\n> > +++ b/src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp\n> > @@ -17,7 +17,7 @@\n> > \n> > namespace libcamera {\n> > \n> > -LOG_DEFINE_CATEGORY(RPI_S_W);\n> > +LOG_DEFINE_CATEGORY(RPI_S_W)\n> > \n> > namespace RPi {\n> > \n> > diff --git a/src/libcamera/pipeline/simple/converter.cpp b/src/libcamera/pipeline/simple/converter.cpp\n> > index 75fb297ebd58..b4ee021f6210 100644\n> > --- a/src/libcamera/pipeline/simple/converter.cpp\n> > +++ b/src/libcamera/pipeline/simple/converter.cpp\n> > @@ -21,7 +21,7 @@\n> > \n> > namespace libcamera {\n> > \n> > -LOG_DECLARE_CATEGORY(SimplePipeline);\n> > +LOG_DECLARE_CATEGORY(SimplePipeline)\n> > \n> > SimpleConverter::SimpleConverter(MediaDevice *media)\n> > \t: m2m_(nullptr)\n> > diff --git a/src/libcamera/sysfs.cpp b/src/libcamera/sysfs.cpp\n> > index 6c8e9554188d..3ebe66f8d69b 100644\n> > --- a/src/libcamera/sysfs.cpp\n> > +++ b/src/libcamera/sysfs.cpp\n> > @@ -22,7 +22,7 @@\n> > \n> > namespace libcamera {\n> > \n> > -LOG_DEFINE_CATEGORY(SysFs);\n> > +LOG_DEFINE_CATEGORY(SysFs)\n> > \n> > namespace sysfs {","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7D3CBBDB13\n\tfor ;\n\tTue, 20 Oct 2020 03:29:29 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 49E1460CE6;\n\tTue, 20 Oct 2020 05:29:29 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 27E996052F\n\tfor ;\n\tTue, 20 Oct 2020 05:29:28 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B15F352;\n\tTue, 20 Oct 2020 05:29:27 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"uooyatXM\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1603164567;\n\tbh=1aajoYfejPPVz9NhaIc99RpVrTOMXIdMncpdB+hxf40=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=uooyatXMaIcN0IE6qYoQ4RSapHOLmgjkr2A9EyJwyrvs4fLfHYJtqXZhxzkGXvgrx\n\tRAzNpLJkI6cEpb3acMSt2htTb91vOCA9FbZe09NGwrqJ+dl+N/64OHitSwSp0IOTJP\n\tKEu+Dpn6QLl71W+bNxbBj+uhFHyxncJ0dwtByD9c=","Date":"Tue, 20 Oct 2020 06:28:41 +0300","From":"Laurent Pinchart ","To":"paul.elder@ideasonboard.com","Message-ID":"<20201020032841.GB7412@pendragon.ideasonboard.com>","References":"<20201020000310.3008-1-laurent.pinchart@ideasonboard.com>\n\t<20201020000310.3008-5-laurent.pinchart@ideasonboard.com>\n\t<20201020025719.GC2041@pyrite.rasen.tech>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201020025719.GC2041@pyrite.rasen.tech>","Subject":"Re: [libcamera-devel] [PATCH 4/5] libcamera: Drop semicolon after\n\tLOG_{DECLARE, DEFINE}_CATEGORY","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13294,"web_url":"https://patchwork.libcamera.org/comment/13294/","msgid":"<0171d253-d721-051b-ae32-3d7e36037408@ideasonboard.com>","date":"2020-10-20T10:38:07","subject":"Re: [libcamera-devel] [PATCH 4/5] libcamera: Drop semicolon after\n\tLOG_{DECLARE, DEFINE}_CATEGORY","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 20/10/2020 04:28, Laurent Pinchart wrote:\n> Hi Paul,\n> \n> On Tue, Oct 20, 2020 at 11:57:19AM +0900, paul.elder@ideasonboard.com wrote:\n>> On Tue, Oct 20, 2020 at 03:03:09AM +0300, Laurent Pinchart wrote:\n>>> No semicolon is needed after the macro. Drop it in the few locations\n>>> that have one.\n>>\n>> I see android and v4l2 have the same issue in some places. I guess\n>> that can be done on top.\n> \n> Oops, I've missed that. I'll post a new version.\n\nWere these not caught by Hiro's series?\n\nEither way, as long as they're done ;-)\n\nReviewed-by: Kieran Bingham \n\n>>> Signed-off-by: Laurent Pinchart \n>>\n>> Reviewed-by: Paul Elder \n>>\n>>> ---\n>>> src/libcamera/byte_stream_buffer.cpp | 2 +-\n>>> src/libcamera/camera_sensor.cpp | 2 +-\n>>> src/libcamera/file.cpp | 2 +-\n>>> src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp | 2 +-\n>>> src/libcamera/pipeline/simple/converter.cpp | 2 +-\n>>> src/libcamera/sysfs.cpp | 2 +-\n>>> 6 files changed, 6 insertions(+), 6 deletions(-)\n>>>\n>>> diff --git a/src/libcamera/byte_stream_buffer.cpp b/src/libcamera/byte_stream_buffer.cpp\n>>> index eb9003927266..7fc6f6944471 100644\n>>> --- a/src/libcamera/byte_stream_buffer.cpp\n>>> +++ b/src/libcamera/byte_stream_buffer.cpp\n>>> @@ -19,7 +19,7 @@\n>>> \n>>> namespace libcamera {\n>>> \n>>> -LOG_DEFINE_CATEGORY(Serialization);\n>>> +LOG_DEFINE_CATEGORY(Serialization)\n>>> \n>>> /**\n>>> * \\class ByteStreamBuffer\n>>> diff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp\n>>> index 78c7ceec7c44..935de528c496 100644\n>>> --- a/src/libcamera/camera_sensor.cpp\n>>> +++ b/src/libcamera/camera_sensor.cpp\n>>> @@ -28,7 +28,7 @@\n>>> \n>>> namespace libcamera {\n>>> \n>>> -LOG_DEFINE_CATEGORY(CameraSensor);\n>>> +LOG_DEFINE_CATEGORY(CameraSensor)\n>>> \n>>> /**\n>>> * \\struct CameraSensorInfo\n>>> diff --git a/src/libcamera/file.cpp b/src/libcamera/file.cpp\n>>> index 04b0cb61a1bf..3a3f5bb63ffc 100644\n>>> --- a/src/libcamera/file.cpp\n>>> +++ b/src/libcamera/file.cpp\n>>> @@ -23,7 +23,7 @@\n>>> \n>>> namespace libcamera {\n>>> \n>>> -LOG_DEFINE_CATEGORY(File);\n>>> +LOG_DEFINE_CATEGORY(File)\n>>> \n>>> /**\n>>> * \\class File\n>>> diff --git a/src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp b/src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp\n>>> index 0572acc93d63..62605c0fceee 100644\n>>> --- a/src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp\n>>> +++ b/src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp\n>>> @@ -17,7 +17,7 @@\n>>> \n>>> namespace libcamera {\n>>> \n>>> -LOG_DEFINE_CATEGORY(RPI_S_W);\n>>> +LOG_DEFINE_CATEGORY(RPI_S_W)\n>>> \n>>> namespace RPi {\n>>> \n>>> diff --git a/src/libcamera/pipeline/simple/converter.cpp b/src/libcamera/pipeline/simple/converter.cpp\n>>> index 75fb297ebd58..b4ee021f6210 100644\n>>> --- a/src/libcamera/pipeline/simple/converter.cpp\n>>> +++ b/src/libcamera/pipeline/simple/converter.cpp\n>>> @@ -21,7 +21,7 @@\n>>> \n>>> namespace libcamera {\n>>> \n>>> -LOG_DECLARE_CATEGORY(SimplePipeline);\n>>> +LOG_DECLARE_CATEGORY(SimplePipeline)\n>>> \n>>> SimpleConverter::SimpleConverter(MediaDevice *media)\n>>> \t: m2m_(nullptr)\n>>> diff --git a/src/libcamera/sysfs.cpp b/src/libcamera/sysfs.cpp\n>>> index 6c8e9554188d..3ebe66f8d69b 100644\n>>> --- a/src/libcamera/sysfs.cpp\n>>> +++ b/src/libcamera/sysfs.cpp\n>>> @@ -22,7 +22,7 @@\n>>> \n>>> namespace libcamera {\n>>> \n>>> -LOG_DEFINE_CATEGORY(SysFs);\n>>> +LOG_DEFINE_CATEGORY(SysFs)\n>>> \n>>> namespace sysfs {\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B2A79BDB13\n\tfor ;\n\tTue, 20 Oct 2020 10:38:12 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4EE6F61D82;\n\tTue, 20 Oct 2020 12:38:12 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BABF860CDD\n\tfor ;\n\tTue, 20 Oct 2020 12:38:10 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2C82D52;\n\tTue, 20 Oct 2020 12:38:10 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"t9hHk/TC\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1603190290;\n\tbh=JghQyDFUA1iRK/PePfjap1fXoa1heqSUkjFzD2VqPKc=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=t9hHk/TCfZ4Yqd2xyCl317RQPmzNI++YatiFvB6nvrQdjZe0D/h6L/kMqtivjoAZ1\n\tOdhee+38Bgj7FOwM9KI/C/o81NoA+N5LCgDDwbrQN0T0l7m+sn9UnoT184LeFChTZ9\n\tMxx4LVb4kPNMeAaZlszc3DlfwhGGJ3u/Ta7ijVWY=","To":"Laurent Pinchart ,\n\tpaul.elder@ideasonboard.com","References":"<20201020000310.3008-1-laurent.pinchart@ideasonboard.com>\n\t<20201020000310.3008-5-laurent.pinchart@ideasonboard.com>\n\t<20201020025719.GC2041@pyrite.rasen.tech>\n\t<20201020032841.GB7412@pendragon.ideasonboard.com>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<0171d253-d721-051b-ae32-3d7e36037408@ideasonboard.com>","Date":"Tue, 20 Oct 2020 11:38:07 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20201020032841.GB7412@pendragon.ideasonboard.com>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH 4/5] libcamera: Drop semicolon after\n\tLOG_{DECLARE, DEFINE}_CATEGORY","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]