[{"id":13259,"web_url":"https://patchwork.libcamera.org/comment/13259/","msgid":"<20201020025455.GB2041@pyrite.rasen.tech>","date":"2020-10-20T02:54:55","subject":"Re: [libcamera-devel] [PATCH 3/5] libcamera: Place doxygen \\file\n\tblock above namespace","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Hi Laurent,\n\nOn Tue, Oct 20, 2020 at 03:03:08AM +0300, Laurent Pinchart wrote:\n> Make the whole code base consistent by placing the doxygen \\file block\n> above the libcamera namespace opening. There's a single offender, and\n> two locations in which a white line is missing.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Paul Elder \n\n> ---\n> src/libcamera/byte_stream_buffer.cpp | 8 ++++----\n> src/libcamera/v4l2_pixelformat.cpp | 1 +\n> src/libcamera/v4l2_videodevice.cpp | 1 +\n> 3 files changed, 6 insertions(+), 4 deletions(-)\n> \n> diff --git a/src/libcamera/byte_stream_buffer.cpp b/src/libcamera/byte_stream_buffer.cpp\n> index df7029b02a7f..eb9003927266 100644\n> --- a/src/libcamera/byte_stream_buffer.cpp\n> +++ b/src/libcamera/byte_stream_buffer.cpp\n> @@ -12,15 +12,15 @@\n> \n> #include \"libcamera/internal/log.h\"\n> \n> -namespace libcamera {\n> -\n> -LOG_DEFINE_CATEGORY(Serialization);\n> -\n> /**\n> * \\file byte_stream_buffer.h\n> * \\brief Managed memory container for serialized data\n> */\n> \n> +namespace libcamera {\n> +\n> +LOG_DEFINE_CATEGORY(Serialization);\n> +\n> /**\n> * \\class ByteStreamBuffer\n> * \\brief Wrap a memory buffer and provide sequential data read and write\n> diff --git a/src/libcamera/v4l2_pixelformat.cpp b/src/libcamera/v4l2_pixelformat.cpp\n> index 6b05909f56ae..03ab085c1231 100644\n> --- a/src/libcamera/v4l2_pixelformat.cpp\n> +++ b/src/libcamera/v4l2_pixelformat.cpp\n> @@ -22,6 +22,7 @@\n> * \\file v4l2_pixelformat.h\n> * \\brief V4L2 Pixel Format\n> */\n> +\n> namespace libcamera {\n> \n> LOG_DECLARE_CATEGORY(V4L2)\n> diff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp\n> index 508522ef42bb..16162e1edba3 100644\n> --- a/src/libcamera/v4l2_videodevice.cpp\n> +++ b/src/libcamera/v4l2_videodevice.cpp\n> @@ -32,6 +32,7 @@\n> * \\file v4l2_videodevice.h\n> * \\brief V4L2 Video Device\n> */\n> +\n> namespace libcamera {\n> \n> LOG_DECLARE_CATEGORY(V4L2)\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2718DBDB13\n\tfor ;\n\tTue, 20 Oct 2020 02:55:06 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id ACE2461373;\n\tTue, 20 Oct 2020 04:55:05 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 13B286052F\n\tfor ;\n\tTue, 20 Oct 2020 04:55:04 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 606BB52;\n\tTue, 20 Oct 2020 04:55:02 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"HVVmXHv+\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1603162503;\n\tbh=z+4WFRFtj5rL9lTbcmGjEHfZbwBCzgLOjb8qFArHGLc=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=HVVmXHv+K6I97WfumoTKtIwKFy2bNIS5sshg6m0NIoHcK2dqyMUZ/8+LJpl9LKKKL\n\tc9WY8BqQXW7tMapVwkb+t05N9rxUzbm6utlZeDP52QjSMOL0fVWzJyLe3k19OGAlcw\n\t7WXE2eYWxT5DP+7BsPSNhvSs0AwOexc0DLCSsyng=","Date":"Tue, 20 Oct 2020 11:54:55 +0900","From":"paul.elder@ideasonboard.com","To":"Laurent Pinchart ","Message-ID":"<20201020025455.GB2041@pyrite.rasen.tech>","References":"<20201020000310.3008-1-laurent.pinchart@ideasonboard.com>\n\t<20201020000310.3008-4-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201020000310.3008-4-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 3/5] libcamera: Place doxygen \\file\n\tblock above namespace","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13267,"web_url":"https://patchwork.libcamera.org/comment/13267/","msgid":"","date":"2020-10-20T03:48:57","subject":"Re: [libcamera-devel] [PATCH 3/5] libcamera: Place doxygen \\file\n\tblock above namespace","submitter":{"id":1,"url":"https://patchwork.libcamera.org/api/people/1/","name":"Umang Jain","email":"email@uajain.com"},"content":"Hi Laurent,\n\nThank you for the patch.\n\nOn 10/20/20 5:33 AM, Laurent Pinchart wrote:\n> Make the whole code base consistent by placing the doxygen \\file block\n> above the libcamera namespace opening. There's a single offender, and\n> two locations in which a white line is missing.\n>\n> Signed-off-by: Laurent Pinchart \nLGTM. I found src/libcamera/utils.cpp to be a bit-special but seems OK \nto me. It would help you can double check it too.\nReviewed-by: Umang Jain \n> ---\n> src/libcamera/byte_stream_buffer.cpp | 8 ++++----\n> src/libcamera/v4l2_pixelformat.cpp | 1 +\n> src/libcamera/v4l2_videodevice.cpp | 1 +\n> 3 files changed, 6 insertions(+), 4 deletions(-)\n>\n> diff --git a/src/libcamera/byte_stream_buffer.cpp b/src/libcamera/byte_stream_buffer.cpp\n> index df7029b02a7f..eb9003927266 100644\n> --- a/src/libcamera/byte_stream_buffer.cpp\n> +++ b/src/libcamera/byte_stream_buffer.cpp\n> @@ -12,15 +12,15 @@\n> \n> #include \"libcamera/internal/log.h\"\n> \n> -namespace libcamera {\n> -\n> -LOG_DEFINE_CATEGORY(Serialization);\n> -\n> /**\n> * \\file byte_stream_buffer.h\n> * \\brief Managed memory container for serialized data\n> */\n> \n> +namespace libcamera {\n> +\n> +LOG_DEFINE_CATEGORY(Serialization);\n> +\n> /**\n> * \\class ByteStreamBuffer\n> * \\brief Wrap a memory buffer and provide sequential data read and write\n> diff --git a/src/libcamera/v4l2_pixelformat.cpp b/src/libcamera/v4l2_pixelformat.cpp\n> index 6b05909f56ae..03ab085c1231 100644\n> --- a/src/libcamera/v4l2_pixelformat.cpp\n> +++ b/src/libcamera/v4l2_pixelformat.cpp\n> @@ -22,6 +22,7 @@\n> * \\file v4l2_pixelformat.h\n> * \\brief V4L2 Pixel Format\n> */\n> +\n> namespace libcamera {\n> \n> LOG_DECLARE_CATEGORY(V4L2)\n> diff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp\n> index 508522ef42bb..16162e1edba3 100644\n> --- a/src/libcamera/v4l2_videodevice.cpp\n> +++ b/src/libcamera/v4l2_videodevice.cpp\n> @@ -32,6 +32,7 @@\n> * \\file v4l2_videodevice.h\n> * \\brief V4L2 Video Device\n> */\n> +\n> namespace libcamera {\n> \n> LOG_DECLARE_CATEGORY(V4L2)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 32E2EBDB13\n\tfor ;\n\tTue, 20 Oct 2020 03:49:03 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BC657613AD;\n\tTue, 20 Oct 2020 05:49:02 +0200 (CEST)","from mail.uajain.com (static.126.159.217.95.clients.your-server.de\n\t[95.217.159.126])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8288960351\n\tfor ;\n\tTue, 20 Oct 2020 05:49:01 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=uajain.com header.i=@uajain.com\n\theader.b=\"UyS2oqXM\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=uajain.com; s=mail;\n\tt=1603165740; bh=Ic+QHHwLSiCIb4s6Sfy1OqhGwScDhxhTWGTCmWhM4GM=;\n\th=Subject:To:References:From:In-Reply-To;\n\tb=UyS2oqXMHByw/nitHzEi8N6PHbyZ4e5RLJhCsTypQNk9/r/O8MqkRBKozNx3GZvFt\n\tIeNmQrIm/YSE2fxgWoOWhDYgJ/vvAN12bUBciRIHDjo/3VhNuylKuqIHuuCpqvKCvF\n\tC05KQ3Z2fOm8Oe5cpaX9XjqexLxVXRRxizRJeGGlQjHx1Snh7sHXet1B00e+eC6sMs\n\tqKkHy5jyvOl1fidpHiN9Ch9Ew005ygxZHbhDrU7zuOG+mnzK9X24t/nM0b/IhzK0kn\n\t5GHhGvrder0eJr/Tra8yE8Vckqg5lPkWlUBoJSaBHdwIFUifqhZ7kwruY1/B15aCVF\n\tbx0p5LDkmayUQ==","To":"libcamera-devel@lists.libcamera.org","References":"<20201020000310.3008-1-laurent.pinchart@ideasonboard.com>\n\t<20201020000310.3008-4-laurent.pinchart@ideasonboard.com>","From":"Umang Jain ","Message-ID":"","Date":"Tue, 20 Oct 2020 09:18:57 +0530","Mime-Version":"1.0","In-Reply-To":"<20201020000310.3008-4-laurent.pinchart@ideasonboard.com>","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH 3/5] libcamera: Place doxygen \\file\n\tblock above namespace","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Transfer-Encoding":"7bit","Content-Type":"text/plain; charset=\"us-ascii\"; Format=\"flowed\"","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13280,"web_url":"https://patchwork.libcamera.org/comment/13280/","msgid":"<20201020085742.GK18688@pendragon.ideasonboard.com>","date":"2020-10-20T08:57:42","subject":"Re: [libcamera-devel] [PATCH 3/5] libcamera: Place doxygen \\file\n\tblock above namespace","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Umang,\n\nOn Tue, Oct 20, 2020 at 09:18:57AM +0530, Umang Jain wrote:\n> On 10/20/20 5:33 AM, Laurent Pinchart wrote:\n> > Make the whole code base consistent by placing the doxygen \\file block\n> > above the libcamera namespace opening. There's a single offender, and\n> > two locations in which a white line is missing.\n> >\n> > Signed-off-by: Laurent Pinchart \n>\n> LGTM. I found src/libcamera/utils.cpp to be a bit-special but seems OK \n> to me. It would help you can double check it too.\n\nI think it's fine too. Thanks for checking.\n\n> Reviewed-by: Umang Jain \n>\n> > ---\n> > src/libcamera/byte_stream_buffer.cpp | 8 ++++----\n> > src/libcamera/v4l2_pixelformat.cpp | 1 +\n> > src/libcamera/v4l2_videodevice.cpp | 1 +\n> > 3 files changed, 6 insertions(+), 4 deletions(-)\n> >\n> > diff --git a/src/libcamera/byte_stream_buffer.cpp b/src/libcamera/byte_stream_buffer.cpp\n> > index df7029b02a7f..eb9003927266 100644\n> > --- a/src/libcamera/byte_stream_buffer.cpp\n> > +++ b/src/libcamera/byte_stream_buffer.cpp\n> > @@ -12,15 +12,15 @@\n> > \n> > #include \"libcamera/internal/log.h\"\n> > \n> > -namespace libcamera {\n> > -\n> > -LOG_DEFINE_CATEGORY(Serialization);\n> > -\n> > /**\n> > * \\file byte_stream_buffer.h\n> > * \\brief Managed memory container for serialized data\n> > */\n> > \n> > +namespace libcamera {\n> > +\n> > +LOG_DEFINE_CATEGORY(Serialization);\n> > +\n> > /**\n> > * \\class ByteStreamBuffer\n> > * \\brief Wrap a memory buffer and provide sequential data read and write\n> > diff --git a/src/libcamera/v4l2_pixelformat.cpp b/src/libcamera/v4l2_pixelformat.cpp\n> > index 6b05909f56ae..03ab085c1231 100644\n> > --- a/src/libcamera/v4l2_pixelformat.cpp\n> > +++ b/src/libcamera/v4l2_pixelformat.cpp\n> > @@ -22,6 +22,7 @@\n> > * \\file v4l2_pixelformat.h\n> > * \\brief V4L2 Pixel Format\n> > */\n> > +\n> > namespace libcamera {\n> > \n> > LOG_DECLARE_CATEGORY(V4L2)\n> > diff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp\n> > index 508522ef42bb..16162e1edba3 100644\n> > --- a/src/libcamera/v4l2_videodevice.cpp\n> > +++ b/src/libcamera/v4l2_videodevice.cpp\n> > @@ -32,6 +32,7 @@\n> > * \\file v4l2_videodevice.h\n> > * \\brief V4L2 Video Device\n> > */\n> > +\n> > namespace libcamera {\n> > \n> > LOG_DECLARE_CATEGORY(V4L2)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 96A2DBDB13\n\tfor ;\n\tTue, 20 Oct 2020 08:58:30 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F33D261394;\n\tTue, 20 Oct 2020 10:58:29 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 831426052F\n\tfor ;\n\tTue, 20 Oct 2020 10:58:28 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E2BE752;\n\tTue, 20 Oct 2020 10:58:27 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"WkFzv6tK\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1603184308;\n\tbh=POdDwrm4S0TQaHApYX+TW3nj8cgZ34Sz4SRzqIM1q6k=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=WkFzv6tK7mYtHQQxzYhv1Te5pHGHwu7fq3MYI3m+Oh7E+mL9HOy3pCeyVimrRxKro\n\tA6jaxn+jqNDpwWAau+SPHl2hkc0EDci3Q1VHnaduXBUcQf9aaFMghorYJSJeGbK7Eh\n\t9iqJTdj+nV41OR4Wbsw5UotvxZS/eDRot7+JEvMk=","Date":"Tue, 20 Oct 2020 11:57:42 +0300","From":"Laurent Pinchart ","To":"Umang Jain ","Message-ID":"<20201020085742.GK18688@pendragon.ideasonboard.com>","References":"<20201020000310.3008-1-laurent.pinchart@ideasonboard.com>\n\t<20201020000310.3008-4-laurent.pinchart@ideasonboard.com>\n\t","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH 3/5] libcamera: Place doxygen \\file\n\tblock above namespace","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13297,"web_url":"https://patchwork.libcamera.org/comment/13297/","msgid":"","date":"2020-10-20T10:41:27","subject":"Re: [libcamera-devel] [PATCH 3/5] libcamera: Place doxygen \\file\n\tblock above namespace","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"On 20/10/2020 01:03, Laurent Pinchart wrote:\n> Make the whole code base consistent by placing the doxygen \\file block\n> above the libcamera namespace opening. There's a single offender, and\n> two locations in which a white line is missing.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/libcamera/byte_stream_buffer.cpp | 8 ++++----\n> src/libcamera/v4l2_pixelformat.cpp | 1 +\n> src/libcamera/v4l2_videodevice.cpp | 1 +\n> 3 files changed, 6 insertions(+), 4 deletions(-)\n> \n> diff --git a/src/libcamera/byte_stream_buffer.cpp b/src/libcamera/byte_stream_buffer.cpp\n> index df7029b02a7f..eb9003927266 100644\n> --- a/src/libcamera/byte_stream_buffer.cpp\n> +++ b/src/libcamera/byte_stream_buffer.cpp\n> @@ -12,15 +12,15 @@\n> \n> #include \"libcamera/internal/log.h\"\n> \n> -namespace libcamera {\n> -\n> -LOG_DEFINE_CATEGORY(Serialization);\n> -\n> /**\n> * \\file byte_stream_buffer.h\n> * \\brief Managed memory container for serialized data\n> */\n> \n> +namespace libcamera {\n> +\n> +LOG_DEFINE_CATEGORY(Serialization);\n> +\n> /**\n> * \\class ByteStreamBuffer\n> * \\brief Wrap a memory buffer and provide sequential data read and write\n> diff --git a/src/libcamera/v4l2_pixelformat.cpp b/src/libcamera/v4l2_pixelformat.cpp\n> index 6b05909f56ae..03ab085c1231 100644\n> --- a/src/libcamera/v4l2_pixelformat.cpp\n> +++ b/src/libcamera/v4l2_pixelformat.cpp\n> @@ -22,6 +22,7 @@\n> * \\file v4l2_pixelformat.h\n> * \\brief V4L2 Pixel Format\n> */\n> +\n> namespace libcamera {\n> \n> LOG_DECLARE_CATEGORY(V4L2)\n> diff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp\n> index 508522ef42bb..16162e1edba3 100644\n> --- a/src/libcamera/v4l2_videodevice.cpp\n> +++ b/src/libcamera/v4l2_videodevice.cpp\n> @@ -32,6 +32,7 @@\n> * \\file v4l2_videodevice.h\n> * \\brief V4L2 Video Device\n> */\n> +\n> namespace libcamera {\n> \n> LOG_DECLARE_CATEGORY(V4L2)\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4FB7BBDB13\n\tfor ;\n\tTue, 20 Oct 2020 10:41:33 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D9ACD61D82;\n\tTue, 20 Oct 2020 12:41:32 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 449F060CDD\n\tfor ;\n\tTue, 20 Oct 2020 12:41:31 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B391C52;\n\tTue, 20 Oct 2020 12:41:30 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Ko212mLs\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1603190490;\n\tbh=SEU7fxnsvN38B3p1fnq8eAootWloW2FJH4PXEO9cWxc=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=Ko212mLscFYr4W/gvdMktXfNKUFpZeeIKdljVTO+XJnxYwXuUoVCJ7nF1ntA2gzQt\n\t9gWb9GIDHKgnM2Npoh1WGZZJ8pNgnwwSzQ2SN8c1LP+ve5lvEaDtHC0dM1UT3RkRnD\n\tIcMkG2f6lbcH7SF1WQFfJyTNDeK+gpIqm4c+8L2E=","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20201020000310.3008-1-laurent.pinchart@ideasonboard.com>\n\t<20201020000310.3008-4-laurent.pinchart@ideasonboard.com>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"","Date":"Tue, 20 Oct 2020 11:41:27 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20201020000310.3008-4-laurent.pinchart@ideasonboard.com>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH 3/5] libcamera: Place doxygen \\file\n\tblock above namespace","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]