[{"id":134,"web_url":"https://patchwork.libcamera.org/comment/134/","msgid":"<9669696.uWYQpTI0B1@avalon>","date":"2018-12-30T20:30:15","subject":"Re: [libcamera-devel] [PATCH v2 05/12] libcamera:\n\tdevice_enumerator: add DeviceEnumerator class","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Niklas,\n\nThank you for the patch.\n\nOn Saturday, 29 December 2018 05:28:48 EET Niklas Söderlund wrote:\n> Provide a DeviceEnumerator base class which enumerates all media devices\n> in the system and information about them, resolving Media Controller\n> data structures to paths and a method to search in all the enumerated\n> information.\n> \n> Signed-off-by: Niklas Söderlund \n> ---\n> * Changes since v1\n> - Add strerror() logging if open() or ioctl() fails.\n> - Use reinterpret_cast.\n> - s/NULL/nullptr.\n> - Break some lines to better fit 80 character lines.\n> ---\n> src/libcamera/device_enumerator.cpp | 155 ++++++++++++++++++++++\n> src/libcamera/include/device_enumerator.h | 22 +++\n> 2 files changed, 177 insertions(+)\n> \n> diff --git a/src/libcamera/device_enumerator.cpp\n> b/src/libcamera/device_enumerator.cpp index\n> 61b32bb921581f49..df9e89a1afeecda1 100644\n> --- a/src/libcamera/device_enumerator.cpp\n> +++ b/src/libcamera/device_enumerator.cpp\n> @@ -5,6 +5,12 @@\n> * device_enumerator.cpp - Enumeration and matching\n> */\n> \n> +#include \n> +#include \n> +#include \n> +#include \n> +#include \n> +\n> #include \"device_enumerator.h\"\n> #include \"log.h\"\n> \n> @@ -111,4 +117,153 @@ bool DeviceMatch::match(const DeviceInfo *info) const\n> \treturn true;\n> }\n> \n> +/*\n> ---------------------------------------------------------------------------\n> -- + * Enumerator Base\n> + */\n> +\n> +DeviceEnumerator::~DeviceEnumerator()\n> +{\n> +\tfor (DeviceInfo *dev : devices_) {\n> +\t\tif (dev->busy())\n> +\t\t\tLOG(Error) << \"Removing device info while still in use\";\n> +\n> +\t\tdelete dev;\n> +\t}\n> +}\n> +\n> +int DeviceEnumerator::addDevice(const std::string &devnode)\n> +{\n> +\tint fd, ret;\n> +\n> +\tstruct media_device_info info = {};\n> +\tstd::map entities;\n> +\n> +\tfd = open(devnode.c_str(), O_RDWR);\n> +\tif (fd < 0) {\n> +\t\tret = -errno;\n> +\t\tLOG(Info) << \"Unable to open \" << devnode <<\n> +\t\t\t \" (\" << strerror(-ret) << \"), skipping\";\n> +\t\treturn ret;\n> +\t}\n> +\n> +\tret = readInfo(fd, info);\n> +\tif (ret)\n> +\t\tgoto out;\n> +\n> +\tret = readTopology(fd, entities);\n> +\tif (ret)\n> +\t\tgoto out;\n> +\n> +\tdevices_.push_back(new DeviceInfo(devnode, info, entities));\n> +out:\n> +\tclose(fd);\n> +\n> +\treturn ret;\n> +}\n> +\n> +int DeviceEnumerator::readInfo(int fd, struct media_device_info &info)\n> +{\n> +\tint ret;\n> +\n> +\tret = ioctl(fd, MEDIA_IOC_DEVICE_INFO, &info);\n> +\tif (ret < 0) {\n> +\t\tret = -errno;\n> +\t\tLOG(Info) << \"Unable to read device info \" <<\n> +\t\t\t \" (\" << strerror(-ret) << \"), skipping\";\n> +\t\treturn ret;\n> +\t}\n> +\n> +\treturn 0;\n> +}\n> +\n> +int DeviceEnumerator::readTopology(int fd, std::map std::string> &entities) +{\n> +\tstruct media_v2_topology topology;\n> +\tstruct media_v2_entity *ents = nullptr;\n> +\tstruct media_v2_interface *ifaces = nullptr;\n> +\tstruct media_v2_link *links = nullptr;\n> +\tint ret;\n> +\n> +\twhile (true) {\n> +\t\ttopology = {};\n> +\n> +\t\tret = ioctl(fd, MEDIA_IOC_G_TOPOLOGY, &topology);\n> +\t\tif (ret < 0)\n> +\t\t\treturn -errno;\n> +\n> +\t\t__u64 version = topology.topology_version;\n> +\n> +\t\tents = new media_v2_entity[topology.num_entities]();\n> +\t\tifaces = new media_v2_interface[topology.num_interfaces]();\n> +\t\tlinks = new media_v2_link[topology.num_links]();\n> +\t\ttopology.ptr_entities = reinterpret_cast<__u64>(ents);\n> +\t\ttopology.ptr_interfaces = reinterpret_cast<__u64>(ifaces);\n> +\t\ttopology.ptr_links = reinterpret_cast<__u64>(links);\n> +\n> +\t\tret = ioctl(fd, MEDIA_IOC_G_TOPOLOGY, &topology);\n> +\t\tif (ret < 0) {\n> +\t\t\tret = -errno;\n> +\t\t\tgoto done;\n> +\t\t}\n\nI think this could be simplified with a single ioctl call inside the loop. As \nthe code will be replaced with MediaDevice it's no big deal though, so\n\nReviewed-by: Laurent Pinchart \n\n> +\t\tif (version == topology.topology_version)\n> +\t\t\tbreak;\n> +\n> +\t\tdelete[] links;\n> +\t\tdelete[] ifaces;\n> +\t\tdelete[] ents;\n> +\t}\n> +\n> +\tfor (unsigned int link_id = 0; link_id < topology.num_links; link_id++) {\n> +\t\tunsigned int iface_id, ent_id;\n> +\t\tstd::string devnode;\n> +\n> +\t\tif ((links[link_id].flags & MEDIA_LNK_FL_LINK_TYPE) !=\n> +\t\t MEDIA_LNK_FL_INTERFACE_LINK)\n> +\t\t\tcontinue;\n> +\n> +\t\tfor (iface_id = 0; iface_id < topology.num_interfaces; iface_id++)\n> +\t\t\tif (links[link_id].source_id == ifaces[iface_id].id)\n> +\t\t\t\tbreak;\n> +\n> +\t\tfor (ent_id = 0; ent_id < topology.num_entities; ent_id++)\n> +\t\t\tif (links[link_id].sink_id == ents[ent_id].id)\n> +\t\t\t\tbreak;\n> +\n> +\t\tif (ent_id >= topology.num_entities ||\n> +\t\t iface_id >= topology.num_interfaces)\n> +\t\t\tcontinue;\n> +\n> +\t\tdevnode = lookupDevnode(ifaces[iface_id].devnode.major,\n> +\t\t\t\t\tifaces[iface_id].devnode.minor);\n> +\t\tif (devnode == \"\")\n> +\t\t\tbreak;\n> +\n> +\t\tentities[ents[ent_id].name] = devnode;\n> +\t}\n> +done:\n> +\tdelete[] links;\n> +\tdelete[] ifaces;\n> +\tdelete[] ents;\n> +\n> +\treturn ret;\n> +}\n> +\n> +DeviceInfo *DeviceEnumerator::search(DeviceMatch &dm) const\n> +{\n> +\tDeviceInfo *info = nullptr;\n> +\n> +\tfor (DeviceInfo *dev : devices_) {\n> +\t\tif (dev->busy())\n> +\t\t\tcontinue;\n> +\n> +\t\tif (dm.match(dev)) {\n> +\t\t\tinfo = dev;\n> +\t\t\tbreak;\n> +\t\t}\n> +\t}\n> +\n> +\treturn info;\n> +}\n> +\n> } /* namespace libcamera */\n> diff --git a/src/libcamera/include/device_enumerator.h\n> b/src/libcamera/include/device_enumerator.h index\n> ed1e986ff45f95f5..1f8cef3311012308 100644\n> --- a/src/libcamera/include/device_enumerator.h\n> +++ b/src/libcamera/include/device_enumerator.h\n> @@ -53,6 +53,28 @@ private:\n> \tstd::vector entities_;\n> };\n> \n> +class DeviceEnumerator\n> +{\n> +public:\n> +\tvirtual ~DeviceEnumerator();\n> +\n> +\tvirtual int init() = 0;\n> +\tvirtual int enumerate() = 0;\n> +\n> +\tDeviceInfo *search(DeviceMatch &dm) const;\n> +\n> +protected:\n> +\tint addDevice(const std::string &devnode);\n> +\n> +private:\n> +\tstd::vector devices_;\n> +\n> +\tint readInfo(int fd, struct media_device_info &info);\n> +\tint readTopology(int fd, std::map &entities);\n> +\n> +\tvirtual std::string lookupDevnode(int major, int minor) = 0;\n> +};\n> +\n> } /* namespace libcamera */\n> \n> #endif\t/* __LIBCAMERA_DEVICE_ENUMERATOR_H__ */","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C64F5600CC\n\tfor ;\n\tSun, 30 Dec 2018 21:29:18 +0100 (CET)","from avalon.localnet (unknown\n\t[IPv6:2a02:a03f:3ad5:900:7d1d:858b:75d5:534d])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 595D950A;\n\tSun, 30 Dec 2018 21:29:18 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1546201758;\n\tbh=pA1rsut72mtm2zS43q8OAuf1WpRE0O59p3q+Lx35WM8=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=R7/NgL3jEPSfIlZoez52/245BMpSLj41MTfIEWlcWBwsThTYqYw97cwhvE6j8+lTw\n\toyRI18VNKoE6fxohyl5i2yGLCVsME+PCbOGKQWrxDWXVpkn/gbT5Hk7SrxQYKOBr3Y\n\tUapUEE9omr++QVwG34Urm8dDE87MyDC7HwU7RGUk=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Sun, 30 Dec 2018 22:30:15 +0200","Message-ID":"<9669696.uWYQpTI0B1@avalon>","Organization":"Ideas on Board Oy","In-Reply-To":"<20181229032855.26249-6-niklas.soderlund@ragnatech.se>","References":"<20181229032855.26249-1-niklas.soderlund@ragnatech.se>\n\t<20181229032855.26249-6-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","Content-Type":"text/plain; charset=\"iso-8859-1\"","Subject":"Re: [libcamera-devel] [PATCH v2 05/12] libcamera:\n\tdevice_enumerator: add DeviceEnumerator class","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sun, 30 Dec 2018 20:29:19 -0000"}},{"id":136,"web_url":"https://patchwork.libcamera.org/comment/136/","msgid":"<20181230203846.GD31866@bigcity.dyn.berto.se>","date":"2018-12-30T20:38:46","subject":"Re: [libcamera-devel] [PATCH v2 05/12] libcamera:\n\tdevice_enumerator: add DeviceEnumerator class","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your feedback.\n\nOn 2018-12-30 22:30:15 +0200, Laurent Pinchart wrote:\n> Hi Niklas,\n> \n> Thank you for the patch.\n> \n> On Saturday, 29 December 2018 05:28:48 EET Niklas Söderlund wrote:\n> > Provide a DeviceEnumerator base class which enumerates all media devices\n> > in the system and information about them, resolving Media Controller\n> > data structures to paths and a method to search in all the enumerated\n> > information.\n> > \n> > Signed-off-by: Niklas Söderlund \n> > ---\n> > * Changes since v1\n> > - Add strerror() logging if open() or ioctl() fails.\n> > - Use reinterpret_cast.\n> > - s/NULL/nullptr.\n> > - Break some lines to better fit 80 character lines.\n> > ---\n> > src/libcamera/device_enumerator.cpp | 155 ++++++++++++++++++++++\n> > src/libcamera/include/device_enumerator.h | 22 +++\n> > 2 files changed, 177 insertions(+)\n> > \n> > diff --git a/src/libcamera/device_enumerator.cpp\n> > b/src/libcamera/device_enumerator.cpp index\n> > 61b32bb921581f49..df9e89a1afeecda1 100644\n> > --- a/src/libcamera/device_enumerator.cpp\n> > +++ b/src/libcamera/device_enumerator.cpp\n> > @@ -5,6 +5,12 @@\n> > * device_enumerator.cpp - Enumeration and matching\n> > */\n> > \n> > +#include \n> > +#include \n> > +#include \n> > +#include \n> > +#include \n> > +\n> > #include \"device_enumerator.h\"\n> > #include \"log.h\"\n> > \n> > @@ -111,4 +117,153 @@ bool DeviceMatch::match(const DeviceInfo *info) const\n> > \treturn true;\n> > }\n> > \n> > +/*\n> > ---------------------------------------------------------------------------\n> > -- + * Enumerator Base\n> > + */\n> > +\n> > +DeviceEnumerator::~DeviceEnumerator()\n> > +{\n> > +\tfor (DeviceInfo *dev : devices_) {\n> > +\t\tif (dev->busy())\n> > +\t\t\tLOG(Error) << \"Removing device info while still in use\";\n> > +\n> > +\t\tdelete dev;\n> > +\t}\n> > +}\n> > +\n> > +int DeviceEnumerator::addDevice(const std::string &devnode)\n> > +{\n> > +\tint fd, ret;\n> > +\n> > +\tstruct media_device_info info = {};\n> > +\tstd::map entities;\n> > +\n> > +\tfd = open(devnode.c_str(), O_RDWR);\n> > +\tif (fd < 0) {\n> > +\t\tret = -errno;\n> > +\t\tLOG(Info) << \"Unable to open \" << devnode <<\n> > +\t\t\t \" (\" << strerror(-ret) << \"), skipping\";\n> > +\t\treturn ret;\n> > +\t}\n> > +\n> > +\tret = readInfo(fd, info);\n> > +\tif (ret)\n> > +\t\tgoto out;\n> > +\n> > +\tret = readTopology(fd, entities);\n> > +\tif (ret)\n> > +\t\tgoto out;\n> > +\n> > +\tdevices_.push_back(new DeviceInfo(devnode, info, entities));\n> > +out:\n> > +\tclose(fd);\n> > +\n> > +\treturn ret;\n> > +}\n> > +\n> > +int DeviceEnumerator::readInfo(int fd, struct media_device_info &info)\n> > +{\n> > +\tint ret;\n> > +\n> > +\tret = ioctl(fd, MEDIA_IOC_DEVICE_INFO, &info);\n> > +\tif (ret < 0) {\n> > +\t\tret = -errno;\n> > +\t\tLOG(Info) << \"Unable to read device info \" <<\n> > +\t\t\t \" (\" << strerror(-ret) << \"), skipping\";\n> > +\t\treturn ret;\n> > +\t}\n> > +\n> > +\treturn 0;\n> > +}\n> > +\n> > +int DeviceEnumerator::readTopology(int fd, std::map > std::string> &entities) +{\n> > +\tstruct media_v2_topology topology;\n> > +\tstruct media_v2_entity *ents = nullptr;\n> > +\tstruct media_v2_interface *ifaces = nullptr;\n> > +\tstruct media_v2_link *links = nullptr;\n> > +\tint ret;\n> > +\n> > +\twhile (true) {\n> > +\t\ttopology = {};\n> > +\n> > +\t\tret = ioctl(fd, MEDIA_IOC_G_TOPOLOGY, &topology);\n> > +\t\tif (ret < 0)\n> > +\t\t\treturn -errno;\n> > +\n> > +\t\t__u64 version = topology.topology_version;\n> > +\n> > +\t\tents = new media_v2_entity[topology.num_entities]();\n> > +\t\tifaces = new media_v2_interface[topology.num_interfaces]();\n> > +\t\tlinks = new media_v2_link[topology.num_links]();\n> > +\t\ttopology.ptr_entities = reinterpret_cast<__u64>(ents);\n> > +\t\ttopology.ptr_interfaces = reinterpret_cast<__u64>(ifaces);\n> > +\t\ttopology.ptr_links = reinterpret_cast<__u64>(links);\n> > +\n> > +\t\tret = ioctl(fd, MEDIA_IOC_G_TOPOLOGY, &topology);\n> > +\t\tif (ret < 0) {\n> > +\t\t\tret = -errno;\n> > +\t\t\tgoto done;\n> > +\t\t}\n> \n> I think this could be simplified with a single ioctl call inside the loop. As \n> the code will be replaced with MediaDevice it's no big deal though, so\n\nI agree this can be reworked for the MediaDevice.\n\n> \n> Reviewed-by: Laurent Pinchart \n\nThanks.\n\n> \n> > +\t\tif (version == topology.topology_version)\n> > +\t\t\tbreak;\n> > +\n> > +\t\tdelete[] links;\n> > +\t\tdelete[] ifaces;\n> > +\t\tdelete[] ents;\n> > +\t}\n> > +\n> > +\tfor (unsigned int link_id = 0; link_id < topology.num_links; link_id++) {\n> > +\t\tunsigned int iface_id, ent_id;\n> > +\t\tstd::string devnode;\n> > +\n> > +\t\tif ((links[link_id].flags & MEDIA_LNK_FL_LINK_TYPE) !=\n> > +\t\t MEDIA_LNK_FL_INTERFACE_LINK)\n> > +\t\t\tcontinue;\n> > +\n> > +\t\tfor (iface_id = 0; iface_id < topology.num_interfaces; iface_id++)\n> > +\t\t\tif (links[link_id].source_id == ifaces[iface_id].id)\n> > +\t\t\t\tbreak;\n> > +\n> > +\t\tfor (ent_id = 0; ent_id < topology.num_entities; ent_id++)\n> > +\t\t\tif (links[link_id].sink_id == ents[ent_id].id)\n> > +\t\t\t\tbreak;\n> > +\n> > +\t\tif (ent_id >= topology.num_entities ||\n> > +\t\t iface_id >= topology.num_interfaces)\n> > +\t\t\tcontinue;\n> > +\n> > +\t\tdevnode = lookupDevnode(ifaces[iface_id].devnode.major,\n> > +\t\t\t\t\tifaces[iface_id].devnode.minor);\n> > +\t\tif (devnode == \"\")\n> > +\t\t\tbreak;\n> > +\n> > +\t\tentities[ents[ent_id].name] = devnode;\n> > +\t}\n> > +done:\n> > +\tdelete[] links;\n> > +\tdelete[] ifaces;\n> > +\tdelete[] ents;\n> > +\n> > +\treturn ret;\n> > +}\n> > +\n> > +DeviceInfo *DeviceEnumerator::search(DeviceMatch &dm) const\n> > +{\n> > +\tDeviceInfo *info = nullptr;\n> > +\n> > +\tfor (DeviceInfo *dev : devices_) {\n> > +\t\tif (dev->busy())\n> > +\t\t\tcontinue;\n> > +\n> > +\t\tif (dm.match(dev)) {\n> > +\t\t\tinfo = dev;\n> > +\t\t\tbreak;\n> > +\t\t}\n> > +\t}\n> > +\n> > +\treturn info;\n> > +}\n> > +\n> > } /* namespace libcamera */\n> > diff --git a/src/libcamera/include/device_enumerator.h\n> > b/src/libcamera/include/device_enumerator.h index\n> > ed1e986ff45f95f5..1f8cef3311012308 100644\n> > --- a/src/libcamera/include/device_enumerator.h\n> > +++ b/src/libcamera/include/device_enumerator.h\n> > @@ -53,6 +53,28 @@ private:\n> > \tstd::vector entities_;\n> > };\n> > \n> > +class DeviceEnumerator\n> > +{\n> > +public:\n> > +\tvirtual ~DeviceEnumerator();\n> > +\n> > +\tvirtual int init() = 0;\n> > +\tvirtual int enumerate() = 0;\n> > +\n> > +\tDeviceInfo *search(DeviceMatch &dm) const;\n> > +\n> > +protected:\n> > +\tint addDevice(const std::string &devnode);\n> > +\n> > +private:\n> > +\tstd::vector devices_;\n> > +\n> > +\tint readInfo(int fd, struct media_device_info &info);\n> > +\tint readTopology(int fd, std::map &entities);\n> > +\n> > +\tvirtual std::string lookupDevnode(int major, int minor) = 0;\n> > +};\n> > +\n> > } /* namespace libcamera */\n> > \n> > #endif\t/* __LIBCAMERA_DEVICE_ENUMERATOR_H__ */\n> \n> \n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> \n>","headers":{"Return-Path":"","Received":["from mail-lj1-x242.google.com (mail-lj1-x242.google.com\n\t[IPv6:2a00:1450:4864:20::242])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AA4BD600CC\n\tfor ;\n\tSun, 30 Dec 2018 21:38:55 +0100 (CET)","by mail-lj1-x242.google.com with SMTP id l15-v6so22494383lja.9\n\tfor ;\n\tSun, 30 Dec 2018 12:38:55 -0800 (PST)","from localhost (89-233-230-99.cust.bredband2.com. [89.233.230.99])\n\tby smtp.gmail.com with ESMTPSA id\n\tr10-v6sm9886738ljj.71.2018.12.30.12.38.47\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tSun, 30 Dec 2018 12:38:47 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=FPG+P007h1DrlPoErKASLo3wRWZyw3qK+XNKOi4HBQ0=;\n\tb=lV2TUFW0LuhmXs+/VU0iHLUo6svtC6dvJAZEwA67cTxzskfyfguT8v6kS7X+yslV13\n\toQkDdWuSZbbR3YJR0Ugu6gOR3fdATbAk0CzznyGFfGrOpKy1KzoRmTWpMKN0dSKjOy+Q\n\tBoHiWCXoBDDQy08bop8Y5NvbGhmfyQ3SQDLz0msBomThCpS4bj9bVmYgCJEH9/s4sOvX\n\t4+Q2l6kx+IvR1FtJHDivp7jjzRCdYho2liYN4KKqOlaj+mvFygg83hxqwUJHg97K0+9d\n\tVvrWJO4QIdht9TBfb9XyU+cfloErFHLsyKoDDMlMkGm+QvwlQzk0ZbhZqadrNzs0ynM6\n\t+t+g==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=FPG+P007h1DrlPoErKASLo3wRWZyw3qK+XNKOi4HBQ0=;\n\tb=MkYIgB8gEifobbQNokSXJsNgEF9L/kQTQPE5l1o84X1Xw6GXLxW1e+fhcscLMmNfnP\n\tU5OcwJLntyExgFDKYHyLMDNrnl1EE1DbUA5JtmpEjGbbRNPaNRhUov3s5z2sFi4nZK80\n\t5JLFfFWLOZGR0lKPb4GXpt2Bg5YryQEGA3/nEHlyQlxjI/4mxcOcM9q7YCqdklPRPdiY\n\t/TkTd8oN0eru5+WDFl53irlAVaXMh7kNRV8BWEFfkj0gyqq5s2IGhfuhR7lwKpKzeR/s\n\tfxE49QfIbzbhqtpZb1QRYqDe9kTnjA+uTwaRvJYSHenvxw6aVGQBH+SohnGnMHE+8taT\n\tcZiA==","X-Gm-Message-State":"AJcUukf5vPJ0LBZRPK8Hio79a1CCzY64GZoGVYLoW+Eq4qnhs84yEjhW\n\tPjmMBD5hYtT9NBws7cFACzadFuDDRUA=","X-Google-Smtp-Source":"ALg8bN4q331XjO3mi+47QXBWegMIlzuxAawBKQfjsuogCNnCYFqJIrbAc1CARaSCRn8WjI9+Bid7iA==","X-Received":"by 2002:a2e:5c07:: with SMTP id\n\tq7-v6mr21460686ljb.119.1546202327812; \n\tSun, 30 Dec 2018 12:38:47 -0800 (PST)","Date":"Sun, 30 Dec 2018 21:38:46 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20181230203846.GD31866@bigcity.dyn.berto.se>","References":"<20181229032855.26249-1-niklas.soderlund@ragnatech.se>\n\t<20181229032855.26249-6-niklas.soderlund@ragnatech.se>\n\t<9669696.uWYQpTI0B1@avalon>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<9669696.uWYQpTI0B1@avalon>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH v2 05/12] libcamera:\n\tdevice_enumerator: add DeviceEnumerator class","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sun, 30 Dec 2018 20:38:56 -0000"}}]