{"id":10097,"url":"https://patchwork.libcamera.org/api/patches/10097/?format=json","web_url":"https://patchwork.libcamera.org/patch/10097/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20201019125156.26751-4-david.plowman@raspberrypi.com>","date":"2020-10-19T12:51:54","name":"[libcamera-devel,v4,3/5] libcamera: Add ScalerCrop control","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"c081c561febac29dba3f2471faf2e5c447f6043f","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/?format=json","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/10097/mbox/","series":[{"id":1384,"url":"https://patchwork.libcamera.org/api/series/1384/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1384","date":"2020-10-19T12:51:51","name":"Digital zoom","version":4,"mbox":"https://patchwork.libcamera.org/series/1384/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/10097/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/10097/checks/","tags":{},"headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1B3F1BDB1F\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 19 Oct 2020 12:52:11 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DD9C261373;\n\tMon, 19 Oct 2020 14:52:10 +0200 (CEST)","from mail-wr1-x429.google.com (mail-wr1-x429.google.com\n\t[IPv6:2a00:1450:4864:20::429])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CEF2B613B7\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 19 Oct 2020 14:52:07 +0200 (CEST)","by mail-wr1-x429.google.com with SMTP id t9so11255409wrq.11\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 19 Oct 2020 05:52:07 -0700 (PDT)","from pi4-davidp.pitowers.org\n\t([2a00:1098:3142:14:1ce1:9965:4328:89c4])\n\tby smtp.gmail.com with ESMTPSA id\n\tq6sm16634335wma.0.2020.10.19.05.52.06\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 19 Oct 2020 05:52:06 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"oJVw8URS\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=4HzMT0ebVPZrBLwm6+ejkeV+aBJ486+lHoNIiQ8cjD0=;\n\tb=oJVw8URSBASdHW0bGhKU/oEsN1jTMVxEhMfQ0G5jGdBia81h5g21UUMnURR9g7jwAg\n\tsfmyV5RfRoh3EWWhA8jaw1sBP0xf0oDodyg7mtjolgw0b9W5mn6buf93Y8GQmgPzOis5\n\t/x2bE1/b7tWlargcmwN2huviB2byMmkEXJZeKCWlfYpnsgWDK2usH+qwZhRmCMuYA4u1\n\tOci2HPkAf/igdHGMD6ug2jhSifaeYsI3JcpE81dh4W9ekA9wnCYDnC0iXOr49f4cpY7G\n\twXWI5Kg4ibw2Ja7iLuaTOFmYq5R0cp3iK3XvirxPNumSLprzlN4gsveOtxLTMbT741Gh\n\teq2g==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=4HzMT0ebVPZrBLwm6+ejkeV+aBJ486+lHoNIiQ8cjD0=;\n\tb=AXYIifwapx+aF9D3O/RxK1HwY867iHWlyn8wUbX+4cdFxsYMD4tgC5XoOD0FQcjmId\n\tj5T52fMt7ENE5tq4InRkibTnbcnE/SRuLC5GebX+J4PWZMN+rzNhuz+d1puujSwK8KzD\n\tPalXWU0iHvfZrcrplBQd+XUmouItw0euvWnyfIsaJlu/HBgsfktY5hJ9ExBOXpaBl1Ba\n\tMQm3uy3UV3Wals6Ck6bGVpJs+lf65KMrjYtbRqAjYvGcWRuqZqb6E8oZzMLN0+imv428\n\t9bhS8u9XQ+wWuRQsDkMfy+y6C2JaoRpONXhBSr6T/S+fJc4D/4EjqxP2quIPqkZ/Gkxq\n\tQcgQ==","X-Gm-Message-State":"AOAM532AEKs0fEx27vzPfY52dpE6PabguEry/dzr7Q9wtLdFCVx2DDeL\n\tf4Cck2Q8HGPO0dPFnFsxL4+Omv7Udtl23g==","X-Google-Smtp-Source":"ABdhPJyc1dxeJUCjJg/LeB3jbXKxtxS8uYcRTQ+gOfTaOPu8kQCqjOCp3M4xpbO+nhbxTpQaDgjbMg==","X-Received":"by 2002:adf:f103:: with SMTP id\n\tr3mr21155631wro.153.1603111927238; \n\tMon, 19 Oct 2020 05:52:07 -0700 (PDT)","From":"David Plowman <david.plowman@raspberrypi.com>","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 19 Oct 2020 13:51:54 +0100","Message-Id":"<20201019125156.26751-4-david.plowman@raspberrypi.com>","X-Mailer":"git-send-email 2.20.1","In-Reply-To":"<20201019125156.26751-1-david.plowman@raspberrypi.com>","References":"<20201019125156.26751-1-david.plowman@raspberrypi.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v4 3/5] libcamera: Add ScalerCrop control","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"The ScalerCrop control selects how much of the sensor's output image\nwill be scaled to form the output image. It can be used to implement\ndigital zoom.\n\nSigned-off-by: David Plowman <david.plowman@raspberrypi.com>\n---\n src/libcamera/control_ids.yaml  | 12 ++++++++++++\n src/libcamera/property_ids.yaml |  5 ++++-\n 2 files changed, 16 insertions(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml\nindex 4c415545..c6fbcd56 100644\n--- a/src/libcamera/control_ids.yaml\n+++ b/src/libcamera/control_ids.yaml\n@@ -284,4 +284,16 @@ controls:\n         order in an array of 9 floating point values.\n \n       size: [3x3]\n+\n+  - ScalerCrop:\n+      type: Rectangle\n+      description: |\n+        Sets the image portion that will be scaled up to form the whole of\n+        the final output image. The selection rectangle is expressed in the\n+        sensor's native pixels and defined relative to the size of the frame\n+        described by the ScalerCropMaximum property.\n+\n+        This control can be used to implement digital zoom.\n+\n+        \\sa properties::ScalerCropMaximum\n ...\ndiff --git a/src/libcamera/property_ids.yaml b/src/libcamera/property_ids.yaml\nindex 022cf65d..2d0fe9d3 100644\n--- a/src/libcamera/property_ids.yaml\n+++ b/src/libcamera/property_ids.yaml\n@@ -678,7 +678,10 @@ controls:\n \n         This property is valid only after the Camera has been successfully\n         configured and its value changes whenever a new configuration is\n-        applied.\n+        applied. It can be used to implement digital zoom in conjunction with\n+        the ScalerCrop control.\n+\n+        \\sa controls::ScalerCrop\n \n         \\todo Turn this property into a \"maximum control value\" for the\n         ScalerCrop control once \"dynamic\" controls have been implemented.\n","prefixes":["libcamera-devel","v4","3/5"]}