{"id":10096,"url":"https://patchwork.libcamera.org/api/patches/10096/?format=json","web_url":"https://patchwork.libcamera.org/patch/10096/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20201019125156.26751-3-david.plowman@raspberrypi.com>","date":"2020-10-19T12:51:53","name":"[libcamera-devel,v4,2/5] libcamera: Initialise the ScalerCropMaximum property","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"223250116c9c7eec7024acb555ea326dd930de47","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/?format=json","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/10096/mbox/","series":[{"id":1384,"url":"https://patchwork.libcamera.org/api/series/1384/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1384","date":"2020-10-19T12:51:51","name":"Digital zoom","version":4,"mbox":"https://patchwork.libcamera.org/series/1384/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/10096/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/10096/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A7E16BDB1F\n\tfor ;\n\tMon, 19 Oct 2020 12:52:10 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 72147613AD;\n\tMon, 19 Oct 2020 14:52:10 +0200 (CEST)","from mail-wm1-x344.google.com (mail-wm1-x344.google.com\n\t[IPv6:2a00:1450:4864:20::344])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D8345610C4\n\tfor ;\n\tMon, 19 Oct 2020 14:52:06 +0200 (CEST)","by mail-wm1-x344.google.com with SMTP id q5so12730870wmq.0\n\tfor ;\n\tMon, 19 Oct 2020 05:52:06 -0700 (PDT)","from pi4-davidp.pitowers.org\n\t([2a00:1098:3142:14:1ce1:9965:4328:89c4])\n\tby smtp.gmail.com with ESMTPSA id\n\tq6sm16634335wma.0.2020.10.19.05.52.05\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 19 Oct 2020 05:52:05 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"lcdgmQOp\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=uIX91jVoGdT6Gr8iX2Oiu/Y8Rs2VGCZWrOox2SJ1UZE=;\n\tb=lcdgmQOptFl7DL6ncRlgQKj7HLxeNw7dziajMgvrSDNJ00WwrDxUpaq0V1+JU2kzZp\n\tTAFynin5IlLdvLWszDAGmVkMmRmY4kfq5tWsZpDVQQpOt7VEiTkOP8OWeCXcQvzKnIQm\n\tTO7WRlY27ErckdH3Ld9sR11BAgcFdr06dcHBT+iHXpkrqvp/sCaFiZKY2ghwVpQza5FC\n\tyL0RWo0BwlncfNa27A8HVbvuZEcxMt1yE0WdSjnZ5PfUgzb2S4hLsMFWcWU6Rq4Y0J+g\n\tyIGf4GKIne+1hpnaLtwrA7CaLN6LC2ILd0cGdxjc803Y97h15cFrsC0nmuzRkaZwc28f\n\tFaEw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=uIX91jVoGdT6Gr8iX2Oiu/Y8Rs2VGCZWrOox2SJ1UZE=;\n\tb=ntd8hfWV/o2oPA75xUtd0Q0KLV1PYInAHZLh94KLgBKr+7oBUV0HDTO2knFrruLdaU\n\tk3fxremYe/f6ukf+5NATrhisIquQc0zFzWEJ4506atU9cv9bBtbehPlj7pvBNr9wmcY+\n\twUtpT+XX00NcsQ6/zVGTOcWJx88RF1884dvcm4XsIRTjIuTN7CyGH6SgZRruQiptpaA+\n\tsHs06umxwnkyRyzcWG6oiypAOYbuUuTLSxmfjvnkOoUWydC9KmVG3hozZGEXT+dPVwmJ\n\t2dsH/iON0FAtHlIxJtQNqF3IZbZhk3VkEA36ev9abjyiVSfmOxHtQKnLmOEQepL7A1dK\n\tBxPA==","X-Gm-Message-State":"AOAM533GoQi9n1RUKvpgdUPvj9NhRprE94gIzpKyW4WC9K4D4M4n7aCQ\n\tJtaFG04g4qvX9L8YJ0sazcizz8a7TRjDng==","X-Google-Smtp-Source":"ABdhPJwSa9kQNuHWbtKx3DHvp+4Tpi2Vh5B4wgdaD92EyZXPr/12xoBTBDhCq6kStrrQAq1zO5bkpw==","X-Received":"by 2002:a1c:7707:: with SMTP id t7mr18573074wmi.54.1603111926355;\n\tMon, 19 Oct 2020 05:52:06 -0700 (PDT)","From":"David Plowman ","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 19 Oct 2020 13:51:53 +0100","Message-Id":"<20201019125156.26751-3-david.plowman@raspberrypi.com>","X-Mailer":"git-send-email 2.20.1","In-Reply-To":"<20201019125156.26751-1-david.plowman@raspberrypi.com>","References":"<20201019125156.26751-1-david.plowman@raspberrypi.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v4 2/5] libcamera: Initialise the\n\tScalerCropMaximum property","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Add a default initialisation according to the sensor resolution,\nthough it will need updating when the camera mode changes.\n\nSigned-off-by: David Plowman \n---\n src/libcamera/camera_sensor.cpp | 6 ++++++\n 1 file changed, 6 insertions(+)","diff":"diff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp\nindex 78c7ceec..ae25c5c6 100644\n--- a/src/libcamera/camera_sensor.cpp\n+++ b/src/libcamera/camera_sensor.cpp\n@@ -279,6 +279,12 @@ int CameraSensor::init()\n \t */\n \tresolution_ = sizes_.back();\n \n+\t/*\n+\t * Set a default value for the ScalerCropMaximum, though it will have to\n+\t * be updated when new camera modes are chosen.\n+\t */\n+\tproperties_.set(properties::ScalerCropMaximum, Rectangle{ 0, 0, resolution_ });\n+\n \treturn 0;\n }\n \n","prefixes":["libcamera-devel","v4","2/5"]}