[{"id":13241,"web_url":"https://patchwork.libcamera.org/comment/13241/","msgid":"<20201019021754.GH4174@pendragon.ideasonboard.com>","date":"2020-10-19T02:17:54","subject":"Re: [libcamera-devel] [PATCH] include: linux: Update\n\tV4L2_CID_USER_BCM2835_ISP_BASE to match upstream tree","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Naush,\n\nThank you for the patch.\n\nOn Fri, Oct 16, 2020 at 11:50:38AM +0100, Naushir Patuck wrote:\n> The V4L2_CID_USER_BCM2835_ISP_BASE has changed in the downstream\n> Raspberry Pi 5.9 kernel to match the upstream defines, see here:\n> https://github.com/raspberrypi/linux/pull/3897.\n> \n> Note, that this will cause an ABI breakage with the current downstream\n> Raspberry Pi 5.4 kernel until both this change and the following PR has\n> been merged: https://github.com/raspberrypi/linux/pull/3897\n\nI see that the pull request has been merged, so I'll merge this as well.\n\n> Signed-off-by: Naushir Patuck \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> include/linux/v4l2-controls.h | 8 +++++++-\n> 1 file changed, 7 insertions(+), 1 deletion(-)\n> \n> diff --git a/include/linux/v4l2-controls.h b/include/linux/v4l2-controls.h\n> index 24eea2b6..39f4bcb5 100644\n> --- a/include/linux/v4l2-controls.h\n> +++ b/include/linux/v4l2-controls.h\n> @@ -192,9 +192,15 @@ enum v4l2_colorfx {\n> * We reserve 16 controls for this driver. */\n> #define V4L2_CID_USER_IMX_BASE\t\t\t(V4L2_CID_USER_BASE + 0x10b0)\n> \n> +/*\n> + * The base for the atmel isc driver controls.\n> + * We reserve 32 controls for this driver.\n> + */\n> +#define V4L2_CID_USER_ATMEL_ISC_BASE\t\t(V4L2_CID_USER_BASE + 0x10c0)\n> +\n> /* The base for the bcm2835-isp driver controls.\n> * We reserve 16 controls for this driver. */\n> -#define V4L2_CID_USER_BCM2835_ISP_BASE\t\t(V4L2_CID_USER_BASE + 0x10c0)\n> +#define V4L2_CID_USER_BCM2835_ISP_BASE\t\t(V4L2_CID_USER_BASE + 0x10e0)\n> \n> /* MPEG-class control IDs */\n> /* The MPEG controls are applicable to all codec controls","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1832EBDB13\n\tfor ;\n\tMon, 19 Oct 2020 02:18:44 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6C72F610D5;\n\tMon, 19 Oct 2020 04:18:43 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E195060CE0\n\tfor ;\n\tMon, 19 Oct 2020 04:18:41 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5005C270;\n\tMon, 19 Oct 2020 04:18:41 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ReuoKt7N\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1603073921;\n\tbh=bh1Me97pcqUkiAGGE0y5swedupuAjIjws49JEg7RbgM=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=ReuoKt7NvGC58FshFiJ6GfO7nbMFyZ4Bx+LTT66vJdqZ8jT80M+py7Nbcky9UbJp8\n\tYOqDSjzuakf6JazbN7mq4ulGCD4XTJD+tNhjJFDFW7kkkvNuof0ifVAtw5gJxWi2C/\n\tBv9Fu94GYux1wwyt+XweocZrKpkthrg212PeclTQ=","Date":"Mon, 19 Oct 2020 05:17:54 +0300","From":"Laurent Pinchart ","To":"Naushir Patuck ","Message-ID":"<20201019021754.GH4174@pendragon.ideasonboard.com>","References":"<20201016105038.158774-1-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201016105038.158774-1-naush@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH] include: linux: Update\n\tV4L2_CID_USER_BCM2835_ISP_BASE to match upstream tree","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]