{"id":10088,"url":"https://patchwork.libcamera.org/api/patches/10088/?format=json","web_url":"https://patchwork.libcamera.org/patch/10088/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20201016090014.64703-12-kieran.bingham@ideasonboard.com>","date":"2020-10-16T09:00:14","name":"[libcamera-devel,v3,11/11] meson: Enable shadowed variable warning","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"82b3b6f97c0f2c60b9440ae381c7af196b4cce87","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/10088/mbox/","series":[{"id":1379,"url":"https://patchwork.libcamera.org/api/series/1379/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1379","date":"2020-10-16T09:00:03","name":"Shadowed Variables","version":3,"mbox":"https://patchwork.libcamera.org/series/1379/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/10088/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/10088/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5B68FBDB1F\n\tfor ;\n\tFri, 16 Oct 2020 09:00:30 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1E38B610FA;\n\tFri, 16 Oct 2020 11:00:30 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 97E2C6112E\n\tfor ;\n\tFri, 16 Oct 2020 11:00:23 +0200 (CEST)","from Q.local (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net\n\t[86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1E262A43;\n\tFri, 16 Oct 2020 11:00:23 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"sTAa8rF0\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1602838823;\n\tbh=O3OBYbBju3Jq7whE8hk85xRyOoWpkBaOjL9lB8/08rU=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=sTAa8rF08JLmD1uubqk02lAQYHtzZK5kyVNcmZZMHFEycfNtkno6MbQ82d/LW28X4\n\tK60xpz3tQk8rWPJQphnzh/ti9TSNo+/xL/LWSz6ECRtVrRwa8gwMsPRgDJHXxctAyN\n\tO2H4XCAJvK4Xere27eRyBfTcXL814bSEzvj7Y+uQ=","From":"Kieran Bingham ","To":"libcamera devel ","Date":"Fri, 16 Oct 2020 10:00:14 +0100","Message-Id":"<20201016090014.64703-12-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20201016090014.64703-1-kieran.bingham@ideasonboard.com>","References":"<20201016090014.64703-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v3 11/11] meson: Enable shadowed variable\n\twarning","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Shadowing variables can lead to unexpected bugs where a code path\nutilises a variable that may not have been intended by the developer,\nleading to hard to find bugs.\n\nEnable warnings for shadowed variables as defined at:\n https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wshadow\n\nAs an effect of utilising -Werror, this will cause variable or type\nshadowing to become a build-time error.\n\nSuggested-by: Laurent Pinchart \nSigned-off-by: Kieran Bingham \nReviewed-by: Niklas Söderlund \nReviewed-by: Laurent Pinchart \n---\n meson.build | 1 +\n 1 file changed, 1 insertion(+)","diff":"diff --git a/meson.build b/meson.build\nindex de15cc16da81..10423f523ca5 100644\n--- a/meson.build\n+++ b/meson.build\n@@ -38,6 +38,7 @@ if cc.has_header_symbol('stdlib.h', 'secure_getenv', prefix : '#define _GNU_SOUR\n endif\n \n common_arguments = [\n+ '-Wshadow',\n '-include', 'config.h',\n ]\n \n","prefixes":["libcamera-devel","v3","11/11"]}