{"id":10087,"url":"https://patchwork.libcamera.org/api/patches/10087/?format=json","web_url":"https://patchwork.libcamera.org/patch/10087/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20201016090014.64703-11-kieran.bingham@ideasonboard.com>","date":"2020-10-16T09:00:13","name":"[libcamera-devel,v3,10/11] android: metadata: Disable -Wshadow","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"f4f229ee51c0938c546db0181ada98c218e82e30","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/10087/mbox/","series":[{"id":1379,"url":"https://patchwork.libcamera.org/api/series/1379/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1379","date":"2020-10-16T09:00:03","name":"Shadowed Variables","version":3,"mbox":"https://patchwork.libcamera.org/series/1379/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/10087/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/10087/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D4FF2BDB1F\n\tfor ;\n\tFri, 16 Oct 2020 09:00:29 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A2DD46113A;\n\tFri, 16 Oct 2020 11:00:29 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 04AD5610F4\n\tfor ;\n\tFri, 16 Oct 2020 11:00:23 +0200 (CEST)","from Q.local (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net\n\t[86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0FA5E528;\n\tFri, 16 Oct 2020 11:00:22 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"usta4vXx\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1602838822;\n\tbh=YHsLJI2kNu7op+SLWQILLWi3aXuX1iFj4Cq9Mg2dXZg=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=usta4vXxXbPManIpJlxTqYb8klNV4MHCIdNOnWnfCTaqbijd9UUPN3EAO+VTwoN+V\n\t2znY12f93uvV2FhO94Irhbwi+OeA9eQrTy8JCJMivfP99AquIBXtohxECbevUD39dA\n\tjGh/2rJ535SmwZQ3i9ZcnBJQbospGUyy1qW17JI8=","From":"Kieran Bingham ","To":"libcamera devel ","Date":"Fri, 16 Oct 2020 10:00:13 +0100","Message-Id":"<20201016090014.64703-11-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20201016090014.64703-1-kieran.bingham@ideasonboard.com>","References":"<20201016090014.64703-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v3 10/11] android: metadata: Disable\n\t-Wshadow","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Do not warn on shadowed variables inside the metadata library,\nwhich is directly imported without modifications.\n\nSuggested-by: Laurent Pinchart \nSigned-off-by: Kieran Bingham \nReviewed-by: Niklas Söderlund \nReviewed-by: Laurent Pinchart \n---\n src/android/meson.build | 1 +\n 1 file changed, 1 insertion(+)","diff":"diff --git a/src/android/meson.build b/src/android/meson.build\nindex b2b2293cf62d..2103745dd822 100644\n--- a/src/android/meson.build\n+++ b/src/android/meson.build\n@@ -32,4 +32,5 @@ android_camera_metadata_sources = files([\n \n android_camera_metadata = static_library('camera_metadata',\n android_camera_metadata_sources,\n+ cpp_args : '-Wnoshadow',\n include_directories : android_includes)\n","prefixes":["libcamera-devel","v3","10/11"]}