{"id":10076,"url":"https://patchwork.libcamera.org/api/patches/10076/?format=json","web_url":"https://patchwork.libcamera.org/patch/10076/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20201016055119.682577-1-paul.elder@ideasonboard.com>","date":"2020-10-16T05:51:19","name":"[libcamera-devel] simple-cam: Reuse Requests","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"d767c88ace816a7baab01f5a1d6782bebb923778","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/?format=json","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/10076/mbox/","series":[{"id":1378,"url":"https://patchwork.libcamera.org/api/series/1378/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1378","date":"2020-10-16T05:51:19","name":"[libcamera-devel] simple-cam: Reuse Requests","version":1,"mbox":"https://patchwork.libcamera.org/series/1378/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/10076/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/10076/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BB154BE905\n\tfor ;\n\tFri, 16 Oct 2020 05:51:42 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 346DE60F61;\n\tFri, 16 Oct 2020 07:51:42 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2E27360354\n\tfor ;\n\tFri, 16 Oct 2020 07:51:40 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A357F528;\n\tFri, 16 Oct 2020 07:51:38 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"mvZyuZYX\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1602827499;\n\tbh=45GwxK1nIMcjnmyr55/Jzr+4PBm4UZoVaxoSACi8aRE=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=mvZyuZYXoomQyfrmAFyOt2jRxKw+AJKQrBbsTqVeAFz444hlIhng7QEazQsHkLEst\n\tNmW/r3+13Qfahsa3MqadNZimnbWbkFUWUBfY1aWcKPcAVjJ2hHaN3DJKkgxE5eYE2e\n\tnf6mr0oVb2UHwapfTRRRfkjzjOrYcVSxIJ5IhxKA=","From":"Paul Elder ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 16 Oct 2020 14:51:19 +0900","Message-Id":"<20201016055119.682577-1-paul.elder@ideasonboard.com>","X-Mailer":"git-send-email 2.27.0","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH] simple-cam: Reuse Requests","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Update simple-cam to reuse Request objects, and use the new API with\nunique pointers.\n\nSigned-off-by: Paul Elder \n---\n simple-cam.cpp | 35 ++++++++---------------------------\n 1 file changed, 8 insertions(+), 27 deletions(-)","diff":"diff --git a/simple-cam.cpp b/simple-cam.cpp\nindex 3aa975e..727bb6d 100644\n--- a/simple-cam.cpp\n+++ b/simple-cam.cpp\n@@ -55,27 +55,8 @@ static void requestComplete(Request *request)\n \t\t */\n \t}\n \n-\t/*\n-\t * Re-queue a Request to the camera.\n-\t *\n-\t * Create a new request and populate it with one buffer for each\n-\t * stream.\n-\t */\n-\trequest = camera->createRequest();\n-\tif (!request)\n-\t{\n-\t\tstd::cerr << \"Can't create request\" << std::endl;\n-\t\treturn;\n-\t}\n-\n-\tfor (auto it = buffers.begin(); it != buffers.end(); ++it)\n-\t{\n-\t\tconst Stream *stream = it->first;\n-\t\tFrameBuffer *buffer = it->second;\n-\n-\t\trequest->addBuffer(stream, buffer);\n-\t}\n-\n+\t/* Re-queue the Request to the camera. */\n+\trequest->reuse(Request::ReuseBuffers);\n \tcamera->queueRequest(request);\n }\n \n@@ -263,9 +244,9 @@ int main()\n \t */\n \tStream *stream = streamConfig.stream();\n \tconst std::vector> &buffers = allocator->buffers(stream);\n-\tstd::vector requests;\n+\tstd::vector> requests;\n \tfor (unsigned int i = 0; i < buffers.size(); ++i) {\n-\t\tRequest *request = camera->createRequest();\n+\t\tstd::unique_ptr request = camera->createRequest();\n \t\tif (!request)\n \t\t{\n \t\t\tstd::cerr << \"Can't create request\" << std::endl;\n@@ -281,13 +262,13 @@ int main()\n \t\t\treturn ret;\n \t\t}\n \n-\t\trequests.push_back(request);\n-\n \t\t/*\n \t\t * Controls can be added to a request on a per frame basis.\n \t\t */\n \t\tControlList &controls = request->controls();\n \t\tcontrols.set(controls::Brightness, 0.5);\n+\n+\t\trequests.push_back(std::move(request));\n \t}\n \n \t/*\n@@ -323,8 +304,8 @@ int main()\n \t * Camera::requestCompleted Signal is called.\n \t */\n \tcamera->start();\n-\tfor (Request *request : requests)\n-\t\tcamera->queueRequest(request);\n+\tfor (std::unique_ptr &request : requests)\n+\t\tcamera->queueRequest(request.get());\n \n \t/*\n \t * --------------------------------------------------------------------\n","prefixes":["libcamera-devel"]}