[{"id":13226,"web_url":"https://patchwork.libcamera.org/comment/13226/","msgid":"<20201015232420.2sd3gfgqeqsasygj@oden.dyn.berto.se>","date":"2020-10-15T23:24:20","subject":"Re: [libcamera-devel] [PATCH v2 10/11] android: metadata: Disable\n\t-Wshadow","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Kieran,\n\nOn 2020-10-15 23:37:49 +0100, Kieran Bingham wrote:\n> Do not warn on shadowed variables inside the metadata library,\n> which is directly imported without modifications.\n> \n> Signed-off-by: Kieran Bingham \n\nNeat solution :-)\n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/android/meson.build | 1 +\n> 1 file changed, 1 insertion(+)\n> \n> diff --git a/src/android/meson.build b/src/android/meson.build\n> index b2b2293cf62d..2103745dd822 100644\n> --- a/src/android/meson.build\n> +++ b/src/android/meson.build\n> @@ -32,4 +32,5 @@ android_camera_metadata_sources = files([\n> \n> android_camera_metadata = static_library('camera_metadata',\n> android_camera_metadata_sources,\n> + cpp_args : '-Wnoshadow',\n> include_directories : android_includes)\n> -- \n> 2.25.1\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 35F89BE174\n\tfor ;\n\tThu, 15 Oct 2020 23:24:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EB9A360E5A;\n\tFri, 16 Oct 2020 01:24:23 +0200 (CEST)","from mail-lf1-x143.google.com (mail-lf1-x143.google.com\n\t[IPv6:2a00:1450:4864:20::143])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9997860E36\n\tfor ;\n\tFri, 16 Oct 2020 01:24:22 +0200 (CEST)","by mail-lf1-x143.google.com with SMTP id c141so635582lfg.5\n\tfor ;\n\tThu, 15 Oct 2020 16:24:22 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\ty21sm173180lfk.49.2020.10.15.16.24.21\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 15 Oct 2020 16:24:21 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"Xyd2Z78e\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=o1Y4kPZVyg4yKiY6souBTvAPBJw8pYqbzvFIvlFipUk=;\n\tb=Xyd2Z78e6z9Fna82S9iFBOaOzQsDzVt3CNYKtTBX1c0meffr+pFdpHd3Aee4BF59DV\n\tA/tfoZR7wgoCaFYlCJEQSTBzWJ9PmmU24BCRw32HseZHHs4EYqVwEkcz9JRBDeATYKjB\n\tjcyyUvSU3UpgN2GAIoO/3jNYEvWtxIjatX8M19/CGhARhs7BUoDVT3gfJWqYR6BIeT9g\n\tvf2wrxX2Fnevy07idZYiBsXfmpdLfNmi+r9AacnrQ5uOx0OqwJG+zHsGcqXzcX5rr35O\n\tAjy+4zhLUO1UUTiVzqcS3UpY+RXw6FXry//4PAlt5JJ9V2OA52AphLPieFTx0XGqX6vh\n\tOAdw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=o1Y4kPZVyg4yKiY6souBTvAPBJw8pYqbzvFIvlFipUk=;\n\tb=MJIXgUqYuNb+f9NhZ8zVbx2C5ECOWvZnSQr55aX4sKtxMPyl35Yx6Vs7fNYPQiJGbc\n\tXxxb6fom7aGZYQfE/7hujRGbA2I4hwS5H/7b4Oz1S9j+J+qOvbNUELfw7X+99TJl888H\n\tJkO7vQhzRleFnkUscApP/UdTjaKKW0nS2Dv3BA8P7hGQ7xHS5MU0L1clBnQ8AUGjJZ8D\n\te/tpzbtbt3Zh3DSr/gA60PkrOfhNFRZEOPIxe4l3jk+sgi153l/IyJRwQ+D6LAJNkF7l\n\tPqBhamY2FDX093XiIDKsIVWSrR3aoWK9i+FkCHVngUYk15HFvirkniU4wxy7ZNY5JpfX\n\tKrcw==","X-Gm-Message-State":"AOAM531oaYa1AUnrmd8zIqX6WLUR6p2rTMJ2bWYZMrqN4g54Yzzvsm5v\n\tH99xQyZbDA70+CCngNt1qCgMQQ==","X-Google-Smtp-Source":"ABdhPJwjA7ZyNnB1Vl15UW5R3PpDohv6kQySyPOApV+YHsF+cWdZJRnp7JDGY0f7rQmtnw+BmIzrvQ==","X-Received":"by 2002:a19:40ca:: with SMTP id n193mr262819lfa.96.1602804262051;\n\tThu, 15 Oct 2020 16:24:22 -0700 (PDT)","Date":"Fri, 16 Oct 2020 01:24:20 +0200","From":"Niklas =?utf-8?q?S=C3=B6derlund?= ","To":"Kieran Bingham ","Message-ID":"<20201015232420.2sd3gfgqeqsasygj@oden.dyn.berto.se>","References":"<20201015223750.58563-1-kieran.bingham@ideasonboard.com>\n\t<20201015223750.58563-11-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201015223750.58563-11-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2 10/11] android: metadata: Disable\n\t-Wshadow","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13229,"web_url":"https://patchwork.libcamera.org/comment/13229/","msgid":"<20201016004354.GC3829@pendragon.ideasonboard.com>","date":"2020-10-16T00:43:54","subject":"Re: [libcamera-devel] [PATCH v2 10/11] android: metadata: Disable\n\t-Wshadow","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Thu, Oct 15, 2020 at 11:37:49PM +0100, Kieran Bingham wrote:\n> Do not warn on shadowed variables inside the metadata library,\n> which is directly imported without modifications.\n> \n> Signed-off-by: Kieran Bingham \n\nThat's better than removing the shadowing I think.\n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/android/meson.build | 1 +\n> 1 file changed, 1 insertion(+)\n> \n> diff --git a/src/android/meson.build b/src/android/meson.build\n> index b2b2293cf62d..2103745dd822 100644\n> --- a/src/android/meson.build\n> +++ b/src/android/meson.build\n> @@ -32,4 +32,5 @@ android_camera_metadata_sources = files([\n> \n> android_camera_metadata = static_library('camera_metadata',\n> android_camera_metadata_sources,\n> + cpp_args : '-Wnoshadow',\n> include_directories : android_includes)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 264A2BE905\n\tfor ;\n\tFri, 16 Oct 2020 00:44:42 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E801660E36;\n\tFri, 16 Oct 2020 02:44:41 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CC9F6600F2\n\tfor ;\n\tFri, 16 Oct 2020 02:44:40 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 609B9556;\n\tFri, 16 Oct 2020 02:44:40 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"sN5WRZI+\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1602809080;\n\tbh=AMyGkZZoq8iDesY/G8TxYCwnOebATlIxTNphCVSDRNI=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=sN5WRZI+YSV/tnxCI23DpOrQRwGT7srEqTQr3bfQ9Ob9tK+lItK2Grh8NabB+WOAW\n\tI0MgJ593xdDKb8tJ5/ug9fa3gCJ1GuoFtU2TdMz1CiOMKMrASNLBsBjre75Yus5ZQ7\n\tIWA8N65ZIgDOIYEzR725v0TNiGOF2ZTOlWX4GcRY=","Date":"Fri, 16 Oct 2020 03:43:54 +0300","From":"Laurent Pinchart ","To":"Kieran Bingham ","Message-ID":"<20201016004354.GC3829@pendragon.ideasonboard.com>","References":"<20201015223750.58563-1-kieran.bingham@ideasonboard.com>\n\t<20201015223750.58563-11-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201015223750.58563-11-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2 10/11] android: metadata: Disable\n\t-Wshadow","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]