{"id":10071,"url":"https://patchwork.libcamera.org/api/patches/10071/?format=json","web_url":"https://patchwork.libcamera.org/patch/10071/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20201015223750.58563-11-kieran.bingham@ideasonboard.com>","date":"2020-10-15T22:37:49","name":"[libcamera-devel,v2,10/11] android: metadata: Disable -Wshadow","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"f4f229ee51c0938c546db0181ada98c218e82e30","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/10071/mbox/","series":[{"id":1376,"url":"https://patchwork.libcamera.org/api/series/1376/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1376","date":"2020-10-15T22:37:39","name":"Shadowed Variables","version":2,"mbox":"https://patchwork.libcamera.org/series/1376/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/10071/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/10071/checks/","tags":{},"headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5011CBEEE0\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 15 Oct 2020 22:38:04 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 154AC61056;\n\tFri, 16 Oct 2020 00:38:04 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 64B4961027\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 16 Oct 2020 00:37:59 +0200 (CEST)","from Q.local (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net\n\t[86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EC7EC556;\n\tFri, 16 Oct 2020 00:37:58 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"hbdBDNrC\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1602801479;\n\tbh=jTktellVnBLLEmLhgHHZeUgXx2t0uOwYFh6yj+iC4cE=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=hbdBDNrC/HCKoxwb5bxeLvDagK0tcUxCuAbZex/v72Bw+d/f57aJYjFdPDYW1w6a/\n\trNnVqnA6wyLQeRTGijaGZY/0cNCKu3g1e+BwL2ALgu+XtiRUS70bBjbNfdl7cLMhE4\n\tzmuLDO0f1NuebXVAw14oZqm3G2/hmwN/nl1NflZE=","From":"Kieran Bingham <kieran.bingham@ideasonboard.com>","To":"libcamera devel <libcamera-devel@lists.libcamera.org>","Date":"Thu, 15 Oct 2020 23:37:49 +0100","Message-Id":"<20201015223750.58563-11-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20201015223750.58563-1-kieran.bingham@ideasonboard.com>","References":"<20201015223750.58563-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v2 10/11] android: metadata: Disable\n\t-Wshadow","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"Do not warn on shadowed variables inside the metadata library,\nwhich is directly imported without modifications.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/android/meson.build | 1 +\n 1 file changed, 1 insertion(+)","diff":"diff --git a/src/android/meson.build b/src/android/meson.build\nindex b2b2293cf62d..2103745dd822 100644\n--- a/src/android/meson.build\n+++ b/src/android/meson.build\n@@ -32,4 +32,5 @@ android_camera_metadata_sources = files([\n \n android_camera_metadata = static_library('camera_metadata',\n                                          android_camera_metadata_sources,\n+                                         cpp_args : '-Wnoshadow',\n                                          include_directories : android_includes)\n","prefixes":["libcamera-devel","v2","10/11"]}