[{"id":13224,"web_url":"https://patchwork.libcamera.org/comment/13224/","msgid":"<20201015232124.6mxlijypx37ojqp3@oden.dyn.berto.se>","date":"2020-10-15T23:21:24","subject":"Re: [libcamera-devel] [PATCH v2 06/11] libcamera: pipeline:\n\trpi_stream: Explicitly name requestBuffer","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Kieran,\n\nOn 2020-10-15 23:37:45 +0100, Kieran Bingham wrote:\n> The FrameBuffer used to track any addition to the reqeust in an\n> under-run event was aliased against the returned buffer, being placed\n> back on the availableBuffers_ queue.\n> \n> Rename the aliased variable to be more explicit that it is a separate\n> Buffer.\n> \n> Signed-off-by: Kieran Bingham \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/libcamera/pipeline/raspberrypi/rpi_stream.cpp | 8 ++++----\n> 1 file changed, 4 insertions(+), 4 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/raspberrypi/rpi_stream.cpp b/src/libcamera/pipeline/raspberrypi/rpi_stream.cpp\n> index 1a42cc17bcba..3a5dadab81e0 100644\n> --- a/src/libcamera/pipeline/raspberrypi/rpi_stream.cpp\n> +++ b/src/libcamera/pipeline/raspberrypi/rpi_stream.cpp\n> @@ -163,9 +163,9 @@ void Stream::returnBuffer(FrameBuffer *buffer)\n> \t * If so, do it now as availableBuffers_ will not be empty.\n> \t */\n> \twhile (!requestBuffers_.empty()) {\n> -\t\tFrameBuffer *buffer = requestBuffers_.front();\n> +\t\tFrameBuffer *requestBuffer = requestBuffers_.front();\n> \n> -\t\tif (!buffer) {\n> +\t\tif (!requestBuffer) {\n> \t\t\t/*\n> \t\t\t * We want to queue an internal buffer, but none\n> \t\t\t * are available. Can't do anything, quit the loop.\n> @@ -177,12 +177,12 @@ void Stream::returnBuffer(FrameBuffer *buffer)\n> \t\t\t * We want to queue an internal buffer, and at least one\n> \t\t\t * is available.\n> \t\t\t */\n> -\t\t\tbuffer = availableBuffers_.front();\n> +\t\t\trequestBuffer = availableBuffers_.front();\n> \t\t\tavailableBuffers_.pop();\n> \t\t}\n> \n> \t\trequestBuffers_.pop();\n> -\t\tqueueToDevice(buffer);\n> +\t\tqueueToDevice(requestBuffer);\n> \t}\n> }\n> \n> -- \n> 2.25.1\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EF6C9BE174\n\tfor ;\n\tThu, 15 Oct 2020 23:21:27 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BEB8D61027;\n\tFri, 16 Oct 2020 01:21:27 +0200 (CEST)","from mail-lf1-x143.google.com (mail-lf1-x143.google.com\n\t[IPv6:2a00:1450:4864:20::143])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9B98460E36\n\tfor ;\n\tFri, 16 Oct 2020 01:21:26 +0200 (CEST)","by mail-lf1-x143.google.com with SMTP id b1so595160lfp.11\n\tfor ;\n\tThu, 15 Oct 2020 16:21:26 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\tw15sm169535lff.134.2020.10.15.16.21.25\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 15 Oct 2020 16:21:25 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"jUG2jpzx\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=TbZzMr6T1cGTaP4IJcjnSbLOQUC6YI5D57u5XhEsorQ=;\n\tb=jUG2jpzxUww9+Hn4/ZbQ95kx/n3BdY88t3krogHSd4AZGt2yfjQKCgrRtqyOmTbJS9\n\tR7NDrE7fTKJCBkZz50xFtVLPoLyo0zsjoAjesFVexrfpwKeASSeCzO7uR8sDDtGiaibm\n\tfaAxtxYHFJVGKzgq5gofYv3JtRSunivdEyvQKbUykO0Kaw7HoSgZcUdmsBQzE+2cAT/6\n\tS+oJ8MIFtKVtEpr+Dqk7kuAOLTlJV8wrP6OjZ2VYxQ7kXUobYauf4v/NiClVJUB/xIL8\n\t8AoU0ECq5Yr7LNjyCo5POqCiTRss2Il5i/bXQmGBv6yNzPfK13WxBT4snFKyKVV/5w5K\n\tB7Mw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=TbZzMr6T1cGTaP4IJcjnSbLOQUC6YI5D57u5XhEsorQ=;\n\tb=S6i+b9eTBF7mskSHs2ojhg0XRVAKvPKf81tvP/ckMxjKOlphpKNPvFJxotpAj9C5wX\n\tvtKky87lrLpE7xNYlaTyqhAznrDwHUA4k6CTbNp7zLCFqDBlkC2Qpvij4qsof2quOSZL\n\tSSpJajCW/3aDx2fRXsxpg5n1SYiv/U4CoQw1Y79RWeyjZ1cFjlr9yi/vfGZi0epLg1Ac\n\t2oHp17NAfS94/bLQbnpJinqyPH2yzi8ycThKOVpoX72wxL6bnhrDU+Az8APqua6Ni43Q\n\tUy/3khjfh3Z+mtXn5UZu93PVJou1E7BvdrWTb2iRmI+03chQ69tEbf8XFnKXrwVa3a94\n\tHang==","X-Gm-Message-State":"AOAM532B0ZFjFQkbhqMioJ62nzI2obYPxrSQwIN8VQ//dZiHgROOb1Ub\n\twUbTBGttWnvk7Nx/ytETrQxh9cKMWuyt6w==","X-Google-Smtp-Source":"ABdhPJwXT6kxcPYNY1hysdjDT9bedvAccOEYMIsgNeIvKvrgOlBN7AQl1bigV7tgPk4MXVaS5tCiWg==","X-Received":"by 2002:a19:f819:: with SMTP id a25mr263226lff.382.1602804086108;\n\tThu, 15 Oct 2020 16:21:26 -0700 (PDT)","Date":"Fri, 16 Oct 2020 01:21:24 +0200","From":"Niklas =?utf-8?q?S=C3=B6derlund?= ","To":"Kieran Bingham ","Message-ID":"<20201015232124.6mxlijypx37ojqp3@oden.dyn.berto.se>","References":"<20201015223750.58563-1-kieran.bingham@ideasonboard.com>\n\t<20201015223750.58563-7-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201015223750.58563-7-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2 06/11] libcamera: pipeline:\n\trpi_stream: Explicitly name requestBuffer","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]