[{"id":13222,"web_url":"https://patchwork.libcamera.org/comment/13222/","msgid":"","date":"2020-10-15T22:39:09","subject":"Re: [libcamera-devel] [PATCH v2 02/11] qcam: main_window:\n\tExplicitly name raw buffer","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"On 15/10/2020 23:37, Kieran Bingham wrote:\n> The buffer obtained for queuing to a raw stream aliases the buffer\n> passed in for the main view finder stream.\n> \n> Prevent aliasing, and explicitly name the buffer as a separate variable.\n> \n> Suggested-by: Niklas Söderlund \n\nSigned-off-by: Kieran Bingham \n\n> ---\n> src/qcam/main_window.cpp | 8 ++++----\n> 1 file changed, 4 insertions(+), 4 deletions(-)\n> \n> diff --git a/src/qcam/main_window.cpp b/src/qcam/main_window.cpp\n> index 0cbdab9a6bce..f140313ede8d 100644\n> --- a/src/qcam/main_window.cpp\n> +++ b/src/qcam/main_window.cpp\n> @@ -769,16 +769,16 @@ void MainWindow::queueRequest(FrameBuffer *buffer)\n> \trequest->addBuffer(vfStream_, buffer);\n> \n> \tif (captureRaw_) {\n> -\t\tFrameBuffer *buffer = nullptr;\n> +\t\tFrameBuffer *rawBuffer = nullptr;\n> \n> \t\t{\n> \t\t\tQMutexLocker locker(&mutex_);\n> \t\t\tif (!freeBuffers_[rawStream_].isEmpty())\n> -\t\t\t\tbuffer = freeBuffers_[rawStream_].dequeue();\n> +\t\t\t\trawBuffer = freeBuffers_[rawStream_].dequeue();\n> \t\t}\n> \n> -\t\tif (buffer) {\n> -\t\t\trequest->addBuffer(rawStream_, buffer);\n> +\t\tif (rawBuffer) {\n> +\t\t\trequest->addBuffer(rawStream_, rawBuffer);\n> \t\t\tcaptureRaw_ = false;\n> \t\t} else {\n> \t\t\tqWarning() << \"No free buffer available for RAW capture\";\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 95A39BE905\n\tfor ;\n\tThu, 15 Oct 2020 22:39:14 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6267E60E8D;\n\tFri, 16 Oct 2020 00:39:14 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A7736600F2\n\tfor ;\n\tFri, 16 Oct 2020 00:39:12 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4770C556;\n\tFri, 16 Oct 2020 00:39:12 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"M+PJw4b3\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1602801552;\n\tbh=+1KCKCOHbnaTC3yz7Ib9qlE2V+mb/pZWNuNwbo5WbjQ=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=M+PJw4b30wht1YCfETKrgUaHzpTw4p5B+bAo3jBHqYqUl+4uDnzP7g3Aj6BVv5Kha\n\tJ7agjZmGGRfpDAUjnoeLYhWxWDxFmd/FJze7uuAv0wCFzeNH3NZ5FeEnzg4+TFwaDs\n\tEfOLwELaipowgfcPeGQ0gNgMlkXZTucNoCUcQnyw=","To":"libcamera devel ","References":"<20201015223750.58563-1-kieran.bingham@ideasonboard.com>\n\t<20201015223750.58563-3-kieran.bingham@ideasonboard.com>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"","Date":"Thu, 15 Oct 2020 23:39:09 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20201015223750.58563-3-kieran.bingham@ideasonboard.com>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH v2 02/11] qcam: main_window:\n\tExplicitly name raw buffer","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13227,"web_url":"https://patchwork.libcamera.org/comment/13227/","msgid":"<20201015232515.vvsvio6psowq3adm@oden.dyn.berto.se>","date":"2020-10-15T23:25:15","subject":"Re: [libcamera-devel] [PATCH v2 02/11] qcam: main_window:\n\tExplicitly name raw buffer","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Kieran,\n\nOn 2020-10-15 23:39:09 +0100, Kieran Bingham wrote:\n> On 15/10/2020 23:37, Kieran Bingham wrote:\n> > The buffer obtained for queuing to a raw stream aliases the buffer\n> > passed in for the main view finder stream.\n> > \n> > Prevent aliasing, and explicitly name the buffer as a separate variable.\n> > \n> > Suggested-by: Niklas Söderlund \n> \n> Signed-off-by: Kieran Bingham \n\n:-)\n\nReviewed-by: Niklas Söderlund \n\n> \n> > ---\n> > src/qcam/main_window.cpp | 8 ++++----\n> > 1 file changed, 4 insertions(+), 4 deletions(-)\n> > \n> > diff --git a/src/qcam/main_window.cpp b/src/qcam/main_window.cpp\n> > index 0cbdab9a6bce..f140313ede8d 100644\n> > --- a/src/qcam/main_window.cpp\n> > +++ b/src/qcam/main_window.cpp\n> > @@ -769,16 +769,16 @@ void MainWindow::queueRequest(FrameBuffer *buffer)\n> > \trequest->addBuffer(vfStream_, buffer);\n> > \n> > \tif (captureRaw_) {\n> > -\t\tFrameBuffer *buffer = nullptr;\n> > +\t\tFrameBuffer *rawBuffer = nullptr;\n> > \n> > \t\t{\n> > \t\t\tQMutexLocker locker(&mutex_);\n> > \t\t\tif (!freeBuffers_[rawStream_].isEmpty())\n> > -\t\t\t\tbuffer = freeBuffers_[rawStream_].dequeue();\n> > +\t\t\t\trawBuffer = freeBuffers_[rawStream_].dequeue();\n> > \t\t}\n> > \n> > -\t\tif (buffer) {\n> > -\t\t\trequest->addBuffer(rawStream_, buffer);\n> > +\t\tif (rawBuffer) {\n> > +\t\t\trequest->addBuffer(rawStream_, rawBuffer);\n> > \t\t\tcaptureRaw_ = false;\n> > \t\t} else {\n> > \t\t\tqWarning() << \"No free buffer available for RAW capture\";\n> > \n> \n> -- \n> Regards\n> --\n> Kieran","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9D7E5BE174\n\tfor ;\n\tThu, 15 Oct 2020 23:25:18 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6A0CE60F61;\n\tFri, 16 Oct 2020 01:25:18 +0200 (CEST)","from mail-lj1-x241.google.com (mail-lj1-x241.google.com\n\t[IPv6:2a00:1450:4864:20::241])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2866E60E36\n\tfor ;\n\tFri, 16 Oct 2020 01:25:17 +0200 (CEST)","by mail-lj1-x241.google.com with SMTP id d24so526246ljg.10\n\tfor ;\n\tThu, 15 Oct 2020 16:25:17 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\ty14sm219888ljm.123.2020.10.15.16.25.15\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 15 Oct 2020 16:25:16 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"d+VMXC30\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=QUx5cIiuqqPZgt+dmPRda2ARXt2ziZWVucWEA209osY=;\n\tb=d+VMXC30SCOqwDR67aDz35L5lgJBgNCUnqo2hB5PGK9AOWF4sbStAQTpkWH1ovlePh\n\tMxh6NICEyn5mlkkXHkLK1mnuc7+vuh2+EN7rZFoWc0+hwqwz2n7HevCQE6DmMTNb/Ic7\n\tM61peXpRtPaNF3IpMpd7st9cj5czs1kVT1lykpHrX4c4nF89iFsouQFxT1Iy5BA3ehgF\n\tV/hlwMMA6Ni3lnRQDwSydvrnxpnbVz6mtclPi5h7OgGK3h4hHf3MN13Cftscu0doWfk5\n\tWBJmtpy8RQDgCq+5uFguxmJM+JzjHGUjanvASJBMz3eeDV5hZOBUyoQ0NUVB5FQy4xbW\n\t0bew==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=QUx5cIiuqqPZgt+dmPRda2ARXt2ziZWVucWEA209osY=;\n\tb=h5PKV6GfvheVZMHk5X335iCSgE8iR9YsV3k3yLl0Jp0zkNB8FFSnm6XwIj+iS9CmnT\n\tgrOqS9SqnDLvLJwXylXybjsNtxhKsNZfJzSkuB2oY1VqwETuPxySzAtjX/u28K1A1CyC\n\ttTWSuNj2OIMb7Pol+G6u2cOouUsRiPQpb3mu2FjkVuV/TzpOLAikyfx6ProoPmZn+2o/\n\tD7j3cxtnwWraKzK1aUU5gWXgN4VkCbeM79LHI6smDif6OM/8tjJxkC4NVPDaHeL3b2yr\n\t9ur/6OtZC2+hfqOga5bBhVFp18I/BLAL0FM+3/CQ2CGREK18wfVQGuHZ9cXI0MEa90sK\n\t4ZiA==","X-Gm-Message-State":"AOAM533dYu0CzaMNAIseVgUIA84tIqnli/b2v0ZV77xkbBH3Ab2VwmOY\n\t/YqXfYR4TY9F7rR9acWb6xwsWYe9ewjp9Q==","X-Google-Smtp-Source":"ABdhPJzUe1vaynxlHxEXq6RyCU8YCwXpQj+2jLbvJ0jGmSJ2yaWAsjfPq6k6uYDjyPcxH0x6tjndRw==","X-Received":"by 2002:a2e:9a17:: with SMTP id o23mr417817lji.242.1602804316634;\n\tThu, 15 Oct 2020 16:25:16 -0700 (PDT)","Date":"Fri, 16 Oct 2020 01:25:15 +0200","From":"Niklas =?utf-8?q?S=C3=B6derlund?= ","To":"Kieran Bingham ","Message-ID":"<20201015232515.vvsvio6psowq3adm@oden.dyn.berto.se>","References":"<20201015223750.58563-1-kieran.bingham@ideasonboard.com>\n\t<20201015223750.58563-3-kieran.bingham@ideasonboard.com>\n\t","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH v2 02/11] qcam: main_window:\n\tExplicitly name raw buffer","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13230,"web_url":"https://patchwork.libcamera.org/comment/13230/","msgid":"<20201016011212.GF3829@pendragon.ideasonboard.com>","date":"2020-10-16T01:12:12","subject":"Re: [libcamera-devel] [PATCH v2 02/11] qcam: main_window:\n\tExplicitly name raw buffer","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Thu, Oct 15, 2020 at 11:37:41PM +0100, Kieran Bingham wrote:\n> The buffer obtained for queuing to a raw stream aliases the buffer\n\ns/aliases/shadows/\n\n> passed in for the main view finder stream.\n> \n> Prevent aliasing, and explicitly name the buffer as a separate variable.\n\ns/aliasing/shadowing/\n\nCould you double-check that no other patch in this series needs a\nsimilar fix in its commit message ?\n\n> Suggested-by: Niklas Söderlund \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/qcam/main_window.cpp | 8 ++++----\n> 1 file changed, 4 insertions(+), 4 deletions(-)\n> \n> diff --git a/src/qcam/main_window.cpp b/src/qcam/main_window.cpp\n> index 0cbdab9a6bce..f140313ede8d 100644\n> --- a/src/qcam/main_window.cpp\n> +++ b/src/qcam/main_window.cpp\n> @@ -769,16 +769,16 @@ void MainWindow::queueRequest(FrameBuffer *buffer)\n> \trequest->addBuffer(vfStream_, buffer);\n> \n> \tif (captureRaw_) {\n> -\t\tFrameBuffer *buffer = nullptr;\n> +\t\tFrameBuffer *rawBuffer = nullptr;\n> \n> \t\t{\n> \t\t\tQMutexLocker locker(&mutex_);\n> \t\t\tif (!freeBuffers_[rawStream_].isEmpty())\n> -\t\t\t\tbuffer = freeBuffers_[rawStream_].dequeue();\n> +\t\t\t\trawBuffer = freeBuffers_[rawStream_].dequeue();\n> \t\t}\n> \n> -\t\tif (buffer) {\n> -\t\t\trequest->addBuffer(rawStream_, buffer);\n> +\t\tif (rawBuffer) {\n> +\t\t\trequest->addBuffer(rawStream_, rawBuffer);\n> \t\t\tcaptureRaw_ = false;\n> \t\t} else {\n> \t\t\tqWarning() << \"No free buffer available for RAW capture\";","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C63D0BE174\n\tfor ;\n\tFri, 16 Oct 2020 01:13:00 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5BB1D60F23;\n\tFri, 16 Oct 2020 03:13:00 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1F87A600F2\n\tfor ;\n\tFri, 16 Oct 2020 03:12:59 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8BA81528;\n\tFri, 16 Oct 2020 03:12:58 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"jw9IwXUR\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1602810778;\n\tbh=d0vlogu2L592Kwwm78VcuES1wMrehCOvG0bgyLHM9H4=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=jw9IwXURKFI6dYnI9+qYlARU5Cu5n3JQBDTEsLPAdfmvsXC4QiEyRBGiBLMa+xqGV\n\tvinZtLnNfRf8VigaU7XAtRfrIcutr7uq+CD4RyM+K3WWAJNYrUMhUotIjrb1R9pUW3\n\tXOOe8ZxoBpaEL+8e9tquB6G13nwEfYGXQNXM9u3s=","Date":"Fri, 16 Oct 2020 04:12:12 +0300","From":"Laurent Pinchart ","To":"Kieran Bingham ","Message-ID":"<20201016011212.GF3829@pendragon.ideasonboard.com>","References":"<20201015223750.58563-1-kieran.bingham@ideasonboard.com>\n\t<20201015223750.58563-3-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201015223750.58563-3-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2 02/11] qcam: main_window:\n\tExplicitly name raw buffer","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]