[{"id":13184,"web_url":"https://patchwork.libcamera.org/comment/13184/","msgid":"","date":"2020-10-13T15:21:04","subject":"Re: [libcamera-devel] [PATCH 08/10] ipa: raspberrypi: Re-use\n\titerator variable","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"content":"Hi Kieran\n\nThanks for tidying this!\n\nOn Tue, 13 Oct 2020 at 16:12, Kieran Bingham\n wrote:\n>\n> The function gauss_seidel2_SOR() makes use of a function scoped iterator\n> 'i', for several loops, and has a precedence of re-using the function\n> scoped iterator declaration, but then proceeds to alias the iterator\n> with a new declaration in one of the later loops.\n>\n> Re-use the existing iterator variable for consistency, and to prevent\n> variable aliasing.\n>\n> Signed-off-by: Kieran Bingham \n\nReviewed-by: David Plowman \n\n> ---\n> src/ipa/raspberrypi/controller/rpi/alsc.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/src/ipa/raspberrypi/controller/rpi/alsc.cpp b/src/ipa/raspberrypi/controller/rpi/alsc.cpp\n> index 42fbc8a476ad..8447f8bec18b 100644\n> --- a/src/ipa/raspberrypi/controller/rpi/alsc.cpp\n> +++ b/src/ipa/raspberrypi/controller/rpi/alsc.cpp\n> @@ -628,7 +628,7 @@ static double gauss_seidel2_SOR(double const M[XY][4], double omega,\n> lambda[i] = compute_lambda_bottom(i, M, lambda);\n> lambda[0] = compute_lambda_bottom_start(0, M, lambda);\n> double max_diff = 0;\n> - for (int i = 0; i < XY; i++) {\n> + for (i = 0; i < XY; i++) {\n> lambda[i] = old_lambda[i] + (lambda[i] - old_lambda[i]) * omega;\n> if (fabs(lambda[i] - old_lambda[i]) > fabs(max_diff))\n> max_diff = lambda[i] - old_lambda[i];\n> --\n> 2.25.1\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 16275BEEE0\n\tfor ;\n\tTue, 13 Oct 2020 15:21:19 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9236760E5A;\n\tTue, 13 Oct 2020 17:21:18 +0200 (CEST)","from mail-oi1-x242.google.com (mail-oi1-x242.google.com\n\t[IPv6:2607:f8b0:4864:20::242])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 38F2A60DFD\n\tfor ;\n\tTue, 13 Oct 2020 17:21:17 +0200 (CEST)","by mail-oi1-x242.google.com with SMTP id s21so5029733oij.0\n\tfor ;\n\tTue, 13 Oct 2020 08:21:17 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"OKPjM6Ll\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=f0ziAxcUAcM42L8foh1zkQLef+Unefeu1r6e8VI5Md8=;\n\tb=OKPjM6Ll69Z/wq6lUrMwvQ0TXpvJ3b5WyPcKmSWBEhG9MCdjVVA5v0avj3miR+DBMk\n\tUuNpKH7Fnt9Hb28Y8JTbzNYKXP+NyeAEHhcB0g/3mJHjn717Hk+q1UBrQHE7rXz3s9u0\n\t4rMbnOG7kJer8WpRFzruDqzObwuzDUWdXm7VJqyzUJbi+mNGzSpmAanCv/M3Zr2DPHSl\n\t4o9rusljlQLtxMBiT6cdjzN9y642jAGm/mS+N25C1zKeEXYUhn+VmvonL/7B3Ai0IWxQ\n\tIhj6vTSNiEH3UMhNGdmw2ZmEvRD1mSnQHgFvFbuj4QZNPDZ6FnPpY12mmI5hP6gzxn4T\n\tCT/Q==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=f0ziAxcUAcM42L8foh1zkQLef+Unefeu1r6e8VI5Md8=;\n\tb=R4XqN0RDgZZ8CYw1mXSPXPG7knp8aZameTCObVe95n4I8BcLkOQkiTwiz56lBMpnHm\n\toQpQVKmyQ0chIORo5I9hhUaoO+knxlO5vhresCpF2GyFU6U9Ud/ASRKux+h9zAD8cx2S\n\td0UPdQq8ADBI7jsSR5DoWfC5Qy2khHMdKrW2PcYqj/BRVxApDF3D3lpC2ZFRenVcxUcN\n\tomKorqZbp6R9U/rgeco/YHMLRuyDSuH4wyGrbPMGIgJ114clvSP4R2yhnrco3yAX/n/B\n\ttFJ9OCnhAFr3nSEtxJjrRGLixtKWldb5fli+scz98+RxOGr0JEjo+FnDzIEczsW8Ku77\n\tM1fg==","X-Gm-Message-State":"AOAM531Q41C92/vpqzX1kliiU0oMEtpIaSsEfYN/xZf/PMDB/UvlASVi\n\tNTRg90ZL7BUEkngbn1qcYio5viqcGvzWMfqWnll5EwZciyw=","X-Google-Smtp-Source":"ABdhPJw25OkYpqP1saV9uH25aF4AJhndaYWjVN8wtgZnr9yYbB7/3yiPXan9jrIR68mckRBIhIGDSi72hMM4j9scYFM=","X-Received":"by 2002:a05:6808:696:: with SMTP id\n\tk22mr145910oig.107.1602602475789; \n\tTue, 13 Oct 2020 08:21:15 -0700 (PDT)","MIME-Version":"1.0","References":"<20201013151241.3557005-1-kieran.bingham@ideasonboard.com>\n\t<20201013151241.3557005-9-kieran.bingham@ideasonboard.com>","In-Reply-To":"<20201013151241.3557005-9-kieran.bingham@ideasonboard.com>","From":"David Plowman ","Date":"Tue, 13 Oct 2020 16:21:04 +0100","Message-ID":"","To":"Kieran Bingham ","Subject":"Re: [libcamera-devel] [PATCH 08/10] ipa: raspberrypi: Re-use\n\titerator variable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13202,"web_url":"https://patchwork.libcamera.org/comment/13202/","msgid":"<20201014123208.nsgcde2lhkof2hkc@oden.dyn.berto.se>","date":"2020-10-14T12:32:08","subject":"Re: [libcamera-devel] [PATCH 08/10] ipa: raspberrypi: Re-use\n\titerator variable","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Kieran,\n\nOn 2020-10-13 16:12:39 +0100, Kieran Bingham wrote:\n> The function gauss_seidel2_SOR() makes use of a function scoped iterator\n> 'i', for several loops, and has a precedence of re-using the function\n> scoped iterator declaration, but then proceeds to alias the iterator\n> with a new declaration in one of the later loops.\n> \n> Re-use the existing iterator variable for consistency, and to prevent\n> variable aliasing.\n> \n> Signed-off-by: Kieran Bingham \n> ---\n> src/ipa/raspberrypi/controller/rpi/alsc.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/ipa/raspberrypi/controller/rpi/alsc.cpp b/src/ipa/raspberrypi/controller/rpi/alsc.cpp\n> index 42fbc8a476ad..8447f8bec18b 100644\n> --- a/src/ipa/raspberrypi/controller/rpi/alsc.cpp\n> +++ b/src/ipa/raspberrypi/controller/rpi/alsc.cpp\n> @@ -628,7 +628,7 @@ static double gauss_seidel2_SOR(double const M[XY][4], double omega,\n> \t\tlambda[i] = compute_lambda_bottom(i, M, lambda);\n> \tlambda[0] = compute_lambda_bottom_start(0, M, lambda);\n> \tdouble max_diff = 0;\n> -\tfor (int i = 0; i < XY; i++) {\n> +\tfor (i = 0; i < XY; i++) {\n\nThis change itself is good but reading the top of the function we have,\n\n static double gauss_seidel2_SOR(double const M[XY][4], double omega,\n\t\t\t\t double lambda[XY])\n {\n\t double old_lambda[XY];\n\t for (int i = 0; i < XY; i++)\n\t\t old_lambda[i] = lambda[i];\n\t int i;\n\nWould it not make sens to also fix this up in this patch?\n\n> \t\tlambda[i] = old_lambda[i] + (lambda[i] - old_lambda[i]) * omega;\n> \t\tif (fabs(lambda[i] - old_lambda[i]) > fabs(max_diff))\n> \t\t\tmax_diff = lambda[i] - old_lambda[i];\n> -- \n> 2.25.1\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BAE24BEEE0\n\tfor ;\n\tWed, 14 Oct 2020 12:32:11 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 31DF460E79;\n\tWed, 14 Oct 2020 14:32:11 +0200 (CEST)","from mail-lj1-x243.google.com (mail-lj1-x243.google.com\n\t[IPv6:2a00:1450:4864:20::243])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 74B8960354\n\tfor ;\n\tWed, 14 Oct 2020 14:32:10 +0200 (CEST)","by mail-lj1-x243.google.com with SMTP id y16so3025748ljk.1\n\tfor ;\n\tWed, 14 Oct 2020 05:32:10 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\tu3sm1079212lfm.57.2020.10.14.05.32.08\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 14 Oct 2020 05:32:09 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"L8XXxxEn\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=Z/z6D0VsZS4egwxlaXiL3I/FnjfZ5bbFfD3CY4TpXJc=;\n\tb=L8XXxxEnSxPkS51Eex8/rZonSIl0g5Sgb2NEjFKBGXcqVw+sw/H65AdEKqE4+3lt8A\n\tdUCzatVw0zOc97c8rYHe4rSkq9SiJDSkTe4KwEK6I3advMgwekj1t7O48KLOG4Int3LD\n\t5SD6OcKAa3upKy7LIJdwRwIdhfTPCT/2AoX4Rjeqsq2Dmq8Ij11tm7H/N7FwVRq0/xUy\n\tG4PgNS4DFcAMrObJPyTA4k5u2aljXT76H9Y1FQJUoA78PHQOMgWLPFRx3yiKtedhfxfO\n\t+rp7BN0WVc6r6n1RQUHolcgcLE4sJPKP74Hj5GsoXruWGIzdtrmZBs9bf67oucNs14zO\n\talew==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=Z/z6D0VsZS4egwxlaXiL3I/FnjfZ5bbFfD3CY4TpXJc=;\n\tb=LknKEmbw+5BtmVhEl6ifnsl3z2L+RmtsO5002uX5bS/4KgAYEyZujnLTFc1NDzUinT\n\tSKF55kARMhkPTv5FVeiMXcYghB8XLdzxQrgKWSrgMFfiya5PE1rQKS5U7cii/Hlv75By\n\tpCoQbgBNit8zUorNC6WagwEFMf+t75wMLjRkCrkpKMU0WqLF7j1bPMR+DUkdXkN8yxZE\n\t1IDQnILJ7dwzRmLXIifShvGY0ICeocGdXwZLtatHUQVNBqKAPmzBg646/+5QgCvuaRmX\n\tr37r7rUuFGQQ3YJfANti/8UCxB+V8MNb+coKouXLOTzWw8xoLltBKk7TGoBxpG9iWjqL\n\tF9xg==","X-Gm-Message-State":"AOAM530pyyML+BBCC0nA4XWNtsiycOJJqMKu2eJEuf9zOFFwsU9opU0E\n\t4VrbRjAcCuy+SoDDRycME2qj/XG1ABaiKA==","X-Google-Smtp-Source":"ABdhPJy/WGYU8HmBvox1jlPYvpZp/VgtlZIau6nV7fKXmA8BsvyNSmTf3AoW8lTHFLsjYarNQPsn+w==","X-Received":"by 2002:a2e:b009:: with SMTP id y9mr1616819ljk.372.1602678729904;\n\tWed, 14 Oct 2020 05:32:09 -0700 (PDT)","Date":"Wed, 14 Oct 2020 14:32:08 +0200","From":"Niklas =?utf-8?q?S=C3=B6derlund?= ","To":"Kieran Bingham ","Message-ID":"<20201014123208.nsgcde2lhkof2hkc@oden.dyn.berto.se>","References":"<20201013151241.3557005-1-kieran.bingham@ideasonboard.com>\n\t<20201013151241.3557005-9-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201013151241.3557005-9-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 08/10] ipa: raspberrypi: Re-use\n\titerator variable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13203,"web_url":"https://patchwork.libcamera.org/comment/13203/","msgid":"<786a5dd5-fa53-3169-398c-506cf48041f7@ideasonboard.com>","date":"2020-10-14T12:37:43","subject":"Re: [libcamera-devel] [PATCH 08/10] ipa: raspberrypi: Re-use\n\titerator variable","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Niklas,\n\nOn 14/10/2020 13:32, Niklas Söderlund wrote:\n> Hi Kieran,\n> \n> On 2020-10-13 16:12:39 +0100, Kieran Bingham wrote:\n>> The function gauss_seidel2_SOR() makes use of a function scoped iterator\n>> 'i', for several loops, and has a precedence of re-using the function\n>> scoped iterator declaration, but then proceeds to alias the iterator\n>> with a new declaration in one of the later loops.\n>>\n>> Re-use the existing iterator variable for consistency, and to prevent\n>> variable aliasing.\n>>\n>> Signed-off-by: Kieran Bingham \n>> ---\n>> src/ipa/raspberrypi/controller/rpi/alsc.cpp | 2 +-\n>> 1 file changed, 1 insertion(+), 1 deletion(-)\n>>\n>> diff --git a/src/ipa/raspberrypi/controller/rpi/alsc.cpp b/src/ipa/raspberrypi/controller/rpi/alsc.cpp\n>> index 42fbc8a476ad..8447f8bec18b 100644\n>> --- a/src/ipa/raspberrypi/controller/rpi/alsc.cpp\n>> +++ b/src/ipa/raspberrypi/controller/rpi/alsc.cpp\n>> @@ -628,7 +628,7 @@ static double gauss_seidel2_SOR(double const M[XY][4], double omega,\n>> \t\tlambda[i] = compute_lambda_bottom(i, M, lambda);\n>> \tlambda[0] = compute_lambda_bottom_start(0, M, lambda);\n>> \tdouble max_diff = 0;\n>> -\tfor (int i = 0; i < XY; i++) {\n>> +\tfor (i = 0; i < XY; i++) {\n> \n> This change itself is good but reading the top of the function we have,\n> \n> static double gauss_seidel2_SOR(double const M[XY][4], double omega,\n> \t\t\t\t double lambda[XY])\n> {\n> \t double old_lambda[XY];\n> \t for (int i = 0; i < XY; i++)\n> \t\t old_lambda[i] = lambda[i];\n> \t int i;\n> \n> Would it not make sens to also fix this up in this patch?\n\nAh, i'd missed that. The scoping means that there is no aliasing, so it\ndidn't trigger the warning.\n\nI've updated the patch, thanks.\n\n--\n\nKieran\n\n\n> \n>> \t\tlambda[i] = old_lambda[i] + (lambda[i] - old_lambda[i]) * omega;\n>> \t\tif (fabs(lambda[i] - old_lambda[i]) > fabs(max_diff))\n>> \t\t\tmax_diff = lambda[i] - old_lambda[i];\n>> -- \n>> 2.25.1\n>>\n>> _______________________________________________\n>> libcamera-devel mailing list\n>> libcamera-devel@lists.libcamera.org\n>> https://lists.libcamera.org/listinfo/libcamera-devel\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BFB99BEEDF\n\tfor ;\n\tWed, 14 Oct 2020 12:37:47 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 483F960E97;\n\tWed, 14 Oct 2020 14:37:47 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 205F460354\n\tfor ;\n\tWed, 14 Oct 2020 14:37:46 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 93008A42;\n\tWed, 14 Oct 2020 14:37:45 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Fv7g3A7g\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1602679065;\n\tbh=GSjZEddMcCP43s+JhsZWxotuPnCX339Sp64Ax081WBM=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=Fv7g3A7g1wjEz+ZIRg40tK7dSZAV1dFcIiwe34doMU4S9vKHBUZp5eMy0lComafww\n\tI3wW7FL+1+JP7p0wdD5McjFQkfsnEE+A1n9MAn5rEQH6Cvp6jThhTOREFVzaS/B8T+\n\tlvDfUHklP866JOFje4viv+itPima3gs2DLfaZ61c=","To":"=?utf-8?q?Niklas_S=C3=B6derlund?= ","References":"<20201013151241.3557005-1-kieran.bingham@ideasonboard.com>\n\t<20201013151241.3557005-9-kieran.bingham@ideasonboard.com>\n\t<20201014123208.nsgcde2lhkof2hkc@oden.dyn.berto.se>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<786a5dd5-fa53-3169-398c-506cf48041f7@ideasonboard.com>","Date":"Wed, 14 Oct 2020 13:37:43 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20201014123208.nsgcde2lhkof2hkc@oden.dyn.berto.se>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH 08/10] ipa: raspberrypi: Re-use\n\titerator variable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]