[{"id":13200,"web_url":"https://patchwork.libcamera.org/comment/13200/","msgid":"<20201014122849.vp2egudrtg5nh35c@oden.dyn.berto.se>","date":"2020-10-14T12:28:49","subject":"Re: [libcamera-devel] [PATCH 06/10] libcamera: v4l2_videodevice:\n\tPrevent aliasing of V4L2BufferCache members","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Kieran,\n\nOn 2020-10-13 16:12:37 +0100, Kieran Bingham wrote:\n> The members free, and lastUsed were not following the libcamera coding\n> style, and were producing an aliased parameter on the construction.\n> \n> Rename them to be marked as member variables with the _ postfix\n> accordingly.\n> \n> Signed-off-by: Kieran Bingham \n\nSorry about this one :-)\n\nReviewed-by: Niklas Söderlund \n\n> ---\n> include/libcamera/internal/v4l2_videodevice.h | 4 ++--\n> src/libcamera/v4l2_videodevice.cpp | 14 +++++++-------\n> 2 files changed, 9 insertions(+), 9 deletions(-)\n> \n> diff --git a/include/libcamera/internal/v4l2_videodevice.h b/include/libcamera/internal/v4l2_videodevice.h\n> index 40ed87e17cfa..53f6a2d5515b 100644\n> --- a/include/libcamera/internal/v4l2_videodevice.h\n> +++ b/include/libcamera/internal/v4l2_videodevice.h\n> @@ -127,8 +127,8 @@ private:\n> \n> \t\tbool operator==(const FrameBuffer &buffer) const;\n> \n> -\t\tbool free;\n> -\t\tuint64_t lastUsed;\n> +\t\tbool free_;\n> +\t\tuint64_t lastUsed_;\n> \n> \tprivate:\n> \t\tstruct Plane {\n> diff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp\n> index 508522ef42bb..96952b26c634 100644\n> --- a/src/libcamera/v4l2_videodevice.cpp\n> +++ b/src/libcamera/v4l2_videodevice.cpp\n> @@ -212,7 +212,7 @@ int V4L2BufferCache::get(const FrameBuffer &buffer)\n> \tfor (unsigned int index = 0; index < cache_.size(); index++) {\n> \t\tconst Entry &entry = cache_[index];\n> \n> -\t\tif (!entry.free)\n> +\t\tif (!entry.free_)\n> \t\t\tcontinue;\n> \n> \t\t/* Try to find a cache hit by comparing the planes. */\n> @@ -222,9 +222,9 @@ int V4L2BufferCache::get(const FrameBuffer &buffer)\n> \t\t\tbreak;\n> \t\t}\n> \n> -\t\tif (entry.lastUsed < oldest) {\n> +\t\tif (entry.lastUsed_ < oldest) {\n> \t\t\tuse = index;\n> -\t\t\toldest = entry.lastUsed;\n> +\t\t\toldest = entry.lastUsed_;\n> \t\t}\n> \t}\n> \n> @@ -248,16 +248,16 @@ int V4L2BufferCache::get(const FrameBuffer &buffer)\n> void V4L2BufferCache::put(unsigned int index)\n> {\n> \tASSERT(index < cache_.size());\n> -\tcache_[index].free = true;\n> +\tcache_[index].free_ = true;\n> }\n> \n> V4L2BufferCache::Entry::Entry()\n> -\t: free(true), lastUsed(0)\n> +\t: free_(true), lastUsed_(0)\n> {\n> }\n> \n> -V4L2BufferCache::Entry::Entry(bool free, uint64_t lastUsed, const FrameBuffer &buffer)\n> -\t: free(free), lastUsed(lastUsed)\n> +V4L2BufferCache::Entry::Entry(bool free, uint64_t age, const FrameBuffer &buffer)\n> +\t: free_(free), lastUsed_(age)\n> {\n> \tfor (const FrameBuffer::Plane &plane : buffer.planes())\n> \t\tplanes_.emplace_back(plane);\n> -- \n> 2.25.1\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2E408BEEDF\n\tfor ;\n\tWed, 14 Oct 2020 12:28:52 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EC96D60E9B;\n\tWed, 14 Oct 2020 14:28:51 +0200 (CEST)","from mail-lj1-x241.google.com (mail-lj1-x241.google.com\n\t[IPv6:2a00:1450:4864:20::241])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0D5BF60354\n\tfor ;\n\tWed, 14 Oct 2020 14:28:51 +0200 (CEST)","by mail-lj1-x241.google.com with SMTP id p15so2971544ljj.8\n\tfor ;\n\tWed, 14 Oct 2020 05:28:51 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\ts1sm1100515lfs.66.2020.10.14.05.28.49\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 14 Oct 2020 05:28:49 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"xnYjzzJd\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=0+flP9kCN+OVhTbV2v4BsiyDIio91xMyTI/CHEumnKE=;\n\tb=xnYjzzJd48k1anOprNE9nfrhuRjRH+Kc9p8pGAoVnbjdDzL/gjyeQr25dMm4ZS2lqd\n\tVW0EjoqZmmFtBRbHWJL8CuU9qNR3HltkUwTbsptaSa8XkUVGZMApRF5L4B3r5c1BGFtE\n\tzu2k4A+itTIy3ykQUorxNWZzm9Q03dYlwmSe5OEBPMhAgHg0LLJVwCBkKMs4tGEPDGWZ\n\thZdCUKQnJ5gWCeq1LXoNABSQPy4KimAz9FEULJ2rhQ+kcogYav48jYCPmB3QZefY7jIE\n\t9gpW++0u/NqlEUZ9QyaJ7UgMH0CP2EZFs0NYKhpIB34QfG0TQObsr/FMT6LUCzcFr0/h\n\teNyA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=0+flP9kCN+OVhTbV2v4BsiyDIio91xMyTI/CHEumnKE=;\n\tb=YAam7rL9FuJCT95vpT0KnI8K5pfSrMtKld+OQL/uXDVgJLV0fkbJgj1kW4zmbIOwCe\n\t2DCTfJfNOzl+yKRQDjc50t+lOQX+blG4+aCNPOs+W39fVQvpF9eL/VmcynJH7yhQF8+X\n\t6G9fgTLGV3SZusxm2QcFxVW9Sg99fw893DXmPIywUUndcTe/G9+D4t6fkTZHCmwA1H0m\n\ts7fENlX89tYbNI9vgxjozTBqUj9IWbXzYbbkxVM/5Gj6ilotRAwgCGGCui32xGur+z6D\n\tNuE46zxiNnwnOdY1Rqt5sG47hOpBUgvHQeRmIUc3lWZMYOQDfZK2t9ijsb8MnugXZ1er\n\tuDaA==","X-Gm-Message-State":"AOAM530Og6hGeBKW8/jYitpdoUzQmQmtbrWhtdA7Cb1yDRgmCxw2ah4t\n\tTKrGbx1E3UqLjvWHSEgcS5rjneGUOASzlg==","X-Google-Smtp-Source":"ABdhPJw/59fmO8VWnh/lglkNG5wUqtJTj29yVIIbNwMiMncpq+FrVeppMqwh8rX1L1qTvej6AV7b+A==","X-Received":"by 2002:a2e:85cd:: with SMTP id\n\th13mr1865515ljj.345.1602678530524; \n\tWed, 14 Oct 2020 05:28:50 -0700 (PDT)","Date":"Wed, 14 Oct 2020 14:28:49 +0200","From":"Niklas =?utf-8?q?S=C3=B6derlund?= ","To":"Kieran Bingham ","Message-ID":"<20201014122849.vp2egudrtg5nh35c@oden.dyn.berto.se>","References":"<20201013151241.3557005-1-kieran.bingham@ideasonboard.com>\n\t<20201013151241.3557005-7-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201013151241.3557005-7-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 06/10] libcamera: v4l2_videodevice:\n\tPrevent aliasing of V4L2BufferCache members","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13212,"web_url":"https://patchwork.libcamera.org/comment/13212/","msgid":"<20201015133828.GC3957@pendragon.ideasonboard.com>","date":"2020-10-15T13:38:28","subject":"Re: [libcamera-devel] [PATCH 06/10] libcamera: v4l2_videodevice:\n\tPrevent aliasing of V4L2BufferCache members","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Tue, Oct 13, 2020 at 04:12:37PM +0100, Kieran Bingham wrote:\n> The members free, and lastUsed were not following the libcamera coding\n> style, and were producing an aliased parameter on the construction.\n> \n> Rename them to be marked as member variables with the _ postfix\n> accordingly.\n> \n> Signed-off-by: Kieran Bingham \n> ---\n> include/libcamera/internal/v4l2_videodevice.h | 4 ++--\n> src/libcamera/v4l2_videodevice.cpp | 14 +++++++-------\n> 2 files changed, 9 insertions(+), 9 deletions(-)\n> \n> diff --git a/include/libcamera/internal/v4l2_videodevice.h b/include/libcamera/internal/v4l2_videodevice.h\n> index 40ed87e17cfa..53f6a2d5515b 100644\n> --- a/include/libcamera/internal/v4l2_videodevice.h\n> +++ b/include/libcamera/internal/v4l2_videodevice.h\n> @@ -127,8 +127,8 @@ private:\n> \n> \t\tbool operator==(const FrameBuffer &buffer) const;\n> \n> -\t\tbool free;\n> -\t\tuint64_t lastUsed;\n> +\t\tbool free_;\n> +\t\tuint64_t lastUsed_;\n> \n> \tprivate:\n> \t\tstruct Plane {\n> diff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp\n> index 508522ef42bb..96952b26c634 100644\n> --- a/src/libcamera/v4l2_videodevice.cpp\n> +++ b/src/libcamera/v4l2_videodevice.cpp\n> @@ -212,7 +212,7 @@ int V4L2BufferCache::get(const FrameBuffer &buffer)\n> \tfor (unsigned int index = 0; index < cache_.size(); index++) {\n> \t\tconst Entry &entry = cache_[index];\n> \n> -\t\tif (!entry.free)\n> +\t\tif (!entry.free_)\n> \t\t\tcontinue;\n> \n> \t\t/* Try to find a cache hit by comparing the planes. */\n> @@ -222,9 +222,9 @@ int V4L2BufferCache::get(const FrameBuffer &buffer)\n> \t\t\tbreak;\n> \t\t}\n> \n> -\t\tif (entry.lastUsed < oldest) {\n> +\t\tif (entry.lastUsed_ < oldest) {\n> \t\t\tuse = index;\n> -\t\t\toldest = entry.lastUsed;\n> +\t\t\toldest = entry.lastUsed_;\n> \t\t}\n> \t}\n> \n> @@ -248,16 +248,16 @@ int V4L2BufferCache::get(const FrameBuffer &buffer)\n> void V4L2BufferCache::put(unsigned int index)\n> {\n> \tASSERT(index < cache_.size());\n> -\tcache_[index].free = true;\n> +\tcache_[index].free_ = true;\n> }\n> \n> V4L2BufferCache::Entry::Entry()\n> -\t: free(true), lastUsed(0)\n> +\t: free_(true), lastUsed_(0)\n> {\n> }\n> \n> -V4L2BufferCache::Entry::Entry(bool free, uint64_t lastUsed, const FrameBuffer &buffer)\n> -\t: free(free), lastUsed(lastUsed)\n> +V4L2BufferCache::Entry::Entry(bool free, uint64_t age, const FrameBuffer &buffer)\n> +\t: free_(free), lastUsed_(age)\n\nAny specific reason to rename the function parameter here, or is it a\nleftover ? I assume the latter, so without the rename,\n\nReviewed-by: Laurent Pinchart \n\n> {\n> \tfor (const FrameBuffer::Plane &plane : buffer.planes())\n> \t\tplanes_.emplace_back(plane);","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E0072BE905\n\tfor ;\n\tThu, 15 Oct 2020 13:39:16 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7453D60E8D;\n\tThu, 15 Oct 2020 15:39:16 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 520B6605BF\n\tfor ;\n\tThu, 15 Oct 2020 15:39:15 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B8A75556;\n\tThu, 15 Oct 2020 15:39:14 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"MXdjiiQl\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1602769154;\n\tbh=Ir2tmzqlMRJs7xEKRMIfeJ8p4FwI7/wUIEeo9t320Bc=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=MXdjiiQlcxh/OooTRGbVWnLmrdlJi3X37mTQOItSlPxDCC0auqMIk6ZZ1r4K9Y/gw\n\tGTYTrTD7BIjEr1yZxfMKLrd5BjLw6qCmkv2Pg6phyPZgwJG1cY515BhG/GhjU4TiTk\n\tXNoa0ut/7hz7sxOALNaA6UrIqomR73qbDvSzuuug=","Date":"Thu, 15 Oct 2020 16:38:28 +0300","From":"Laurent Pinchart ","To":"Kieran Bingham ","Message-ID":"<20201015133828.GC3957@pendragon.ideasonboard.com>","References":"<20201013151241.3557005-1-kieran.bingham@ideasonboard.com>\n\t<20201013151241.3557005-7-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201013151241.3557005-7-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 06/10] libcamera: v4l2_videodevice:\n\tPrevent aliasing of V4L2BufferCache members","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13216,"web_url":"https://patchwork.libcamera.org/comment/13216/","msgid":"<4162c9c2-b54a-12a1-eabb-2afc961d9986@ideasonboard.com>","date":"2020-10-15T13:58:56","subject":"Re: [libcamera-devel] [PATCH 06/10] libcamera: v4l2_videodevice:\n\tPrevent aliasing of V4L2BufferCache members","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 15/10/2020 14:38, Laurent Pinchart wrote:\n> Hi Kieran,\n> \n> Thank you for the patch.\n> \n> On Tue, Oct 13, 2020 at 04:12:37PM +0100, Kieran Bingham wrote:\n>> The members free, and lastUsed were not following the libcamera coding\n>> style, and were producing an aliased parameter on the construction.\n>>\n>> Rename them to be marked as member variables with the _ postfix\n>> accordingly.\n>>\n>> Signed-off-by: Kieran Bingham \n>> ---\n>> include/libcamera/internal/v4l2_videodevice.h | 4 ++--\n>> src/libcamera/v4l2_videodevice.cpp | 14 +++++++-------\n>> 2 files changed, 9 insertions(+), 9 deletions(-)\n>>\n>> diff --git a/include/libcamera/internal/v4l2_videodevice.h b/include/libcamera/internal/v4l2_videodevice.h\n>> index 40ed87e17cfa..53f6a2d5515b 100644\n>> --- a/include/libcamera/internal/v4l2_videodevice.h\n>> +++ b/include/libcamera/internal/v4l2_videodevice.h\n>> @@ -127,8 +127,8 @@ private:\n>> \n>> \t\tbool operator==(const FrameBuffer &buffer) const;\n>> \n>> -\t\tbool free;\n>> -\t\tuint64_t lastUsed;\n>> +\t\tbool free_;\n>> +\t\tuint64_t lastUsed_;\n>> \n>> \tprivate:\n>> \t\tstruct Plane {\n>> diff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp\n>> index 508522ef42bb..96952b26c634 100644\n>> --- a/src/libcamera/v4l2_videodevice.cpp\n>> +++ b/src/libcamera/v4l2_videodevice.cpp\n>> @@ -212,7 +212,7 @@ int V4L2BufferCache::get(const FrameBuffer &buffer)\n>> \tfor (unsigned int index = 0; index < cache_.size(); index++) {\n>> \t\tconst Entry &entry = cache_[index];\n>> \n>> -\t\tif (!entry.free)\n>> +\t\tif (!entry.free_)\n>> \t\t\tcontinue;\n>> \n>> \t\t/* Try to find a cache hit by comparing the planes. */\n>> @@ -222,9 +222,9 @@ int V4L2BufferCache::get(const FrameBuffer &buffer)\n>> \t\t\tbreak;\n>> \t\t}\n>> \n>> -\t\tif (entry.lastUsed < oldest) {\n>> +\t\tif (entry.lastUsed_ < oldest) {\n>> \t\t\tuse = index;\n>> -\t\t\toldest = entry.lastUsed;\n>> +\t\t\toldest = entry.lastUsed_;\n>> \t\t}\n>> \t}\n>> \n>> @@ -248,16 +248,16 @@ int V4L2BufferCache::get(const FrameBuffer &buffer)\n>> void V4L2BufferCache::put(unsigned int index)\n>> {\n>> \tASSERT(index < cache_.size());\n>> -\tcache_[index].free = true;\n>> +\tcache_[index].free_ = true;\n>> }\n>> \n>> V4L2BufferCache::Entry::Entry()\n>> -\t: free(true), lastUsed(0)\n>> +\t: free_(true), lastUsed_(0)\n>> {\n>> }\n>> \n>> -V4L2BufferCache::Entry::Entry(bool free, uint64_t lastUsed, const FrameBuffer &buffer)\n>> -\t: free(free), lastUsed(lastUsed)\n>> +V4L2BufferCache::Entry::Entry(bool free, uint64_t age, const FrameBuffer &buffer)\n>> +\t: free_(free), lastUsed_(age)\n> \n> Any specific reason to rename the function parameter here, or is it a\n> leftover ? I assume the latter, so without the rename,\n\nGood spot - indeed, this is a leftover from before I saw adding the _\nwas the correct way forwards.\n\nI'll fix for v2.\n\n\n> \n> Reviewed-by: Laurent Pinchart \n\nThanks.\n\n\n> \n>> {\n>> \tfor (const FrameBuffer::Plane &plane : buffer.planes())\n>> \t\tplanes_.emplace_back(plane);\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 47D5ABE174\n\tfor ;\n\tThu, 15 Oct 2020 13:59:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C148E60E8D;\n\tThu, 15 Oct 2020 15:59:00 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8B687605BF\n\tfor ;\n\tThu, 15 Oct 2020 15:58:59 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id F1ABB556;\n\tThu, 15 Oct 2020 15:58:58 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"QCxL3XiV\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1602770339;\n\tbh=WiFGSNt50ohjFpL5m6cXorwfimnQfVer/7keY/GSkgs=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=QCxL3XiVRpnMyIrqeHoGiTXO6vKV4xbjtD3YZMxEHekrqk33c1FOPQWyrhATBpcP/\n\t9CsrRsIUuUzcZSvFPR27+xkDIPZDYo5nOZq3HOcNSJ7ihc/jISmI+YPp2O5YYZwTX4\n\tqhSLorQn7sM8oEt+f1Jo6yBWUKhA8eS0wsB9Alxw=","To":"Laurent Pinchart ","References":"<20201013151241.3557005-1-kieran.bingham@ideasonboard.com>\n\t<20201013151241.3557005-7-kieran.bingham@ideasonboard.com>\n\t<20201015133828.GC3957@pendragon.ideasonboard.com>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<4162c9c2-b54a-12a1-eabb-2afc961d9986@ideasonboard.com>","Date":"Thu, 15 Oct 2020 14:58:56 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20201015133828.GC3957@pendragon.ideasonboard.com>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH 06/10] libcamera: v4l2_videodevice:\n\tPrevent aliasing of V4L2BufferCache members","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]