[{"id":13199,"web_url":"https://patchwork.libcamera.org/comment/13199/","msgid":"<20201014122741.rdab3253jozcb7nm@oden.dyn.berto.se>","date":"2020-10-14T12:27:41","subject":"Re: [libcamera-devel] [PATCH 05/10] libcamera: pipeline: Use\n\texisting variable definitions","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Kieran,\n\nOn 2020-10-13 16:12:36 +0100, Kieran Bingham wrote:\n> Prevent variable aliasing by removing the redeclaration of variables\n> with the same name (and type) where the existing variable can be reused.\n> \n> Signed-off-by: Kieran Bingham \n> ---\n> src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 2 +-\n> src/libcamera/pipeline/raspberrypi/rpi_stream.cpp | 2 +-\n> src/libcamera/pipeline/simple/simple.cpp | 4 ++--\n> 3 files changed, 4 insertions(+), 4 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> index 85e0a1f26ab6..2d70d984a276 100644\n> --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> @@ -1008,7 +1008,7 @@ int PipelineHandlerRPi::queueAllBuffers(Camera *camera)\n> \t\t\t */\n> \t\t\tunsigned int i;\n> \t\t\tfor (i = 0; i < data->dropFrameCount_; i++) {\n> -\t\t\t\tint ret = stream->queueBuffer(nullptr);\n> +\t\t\t\tret = stream->queueBuffer(nullptr);\n> \t\t\t\tif (ret)\n> \t\t\t\t\treturn ret;\n> \t\t\t}\n> diff --git a/src/libcamera/pipeline/raspberrypi/rpi_stream.cpp b/src/libcamera/pipeline/raspberrypi/rpi_stream.cpp\n> index 1a42cc17bcba..17e38924d653 100644\n> --- a/src/libcamera/pipeline/raspberrypi/rpi_stream.cpp\n> +++ b/src/libcamera/pipeline/raspberrypi/rpi_stream.cpp\n> @@ -163,7 +163,7 @@ void Stream::returnBuffer(FrameBuffer *buffer)\n> \t * If so, do it now as availableBuffers_ will not be empty.\n> \t */\n> \twhile (!requestBuffers_.empty()) {\n> -\t\tFrameBuffer *buffer = requestBuffers_.front();\n> +\t\tbuffer = requestBuffers_.front();\n\nSame comment as for 2/10 about reusing a function argument.\n\n> \n> \t\tif (!buffer) {\n> \t\t\t/*\n> diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\n> index 999c44515023..33daa2fb1b7b 100644\n> --- a/src/libcamera/pipeline/simple/simple.cpp\n> +++ b/src/libcamera/pipeline/simple/simple.cpp\n> @@ -612,8 +612,8 @@ int SimplePipelineHandler::configure(Camera *camera, CameraConfiguration *c)\n> \tuseConverter_ = config->needConversion();\n> \n> \tif (useConverter_) {\n> -\t\tint ret = converter_->configure(pipeConfig.pixelFormat,\n> -\t\t\t\t\t\tpipeConfig.captureSize, &cfg);\n> +\t\tret = converter_->configure(pipeConfig.pixelFormat,\n> +\t\t\t\t\t pipeConfig.captureSize, &cfg);\n> \t\tif (ret < 0) {\n> \t\t\tLOG(SimplePipeline, Error)\n> \t\t\t\t<< \"Unable to configure converter\";\n> -- \n> 2.25.1\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EF43DBEEDF\n\tfor ;\n\tWed, 14 Oct 2020 12:27:44 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 825F660355;\n\tWed, 14 Oct 2020 14:27:44 +0200 (CEST)","from mail-lj1-x241.google.com (mail-lj1-x241.google.com\n\t[IPv6:2a00:1450:4864:20::241])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3525560354\n\tfor ;\n\tWed, 14 Oct 2020 14:27:43 +0200 (CEST)","by mail-lj1-x241.google.com with SMTP id f29so2997413ljo.3\n\tfor ;\n\tWed, 14 Oct 2020 05:27:43 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\tj17sm1163249lji.52.2020.10.14.05.27.41\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 14 Oct 2020 05:27:41 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"X4NyfZIl\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=y6Mm8DjJvML8mqrG0VyYghXMRbwoormH1Lp7DoWuUZo=;\n\tb=X4NyfZIl2likiXVAfJZJZRqBSIUPHip2TVr3MKNkfUMkqrTpzbMycsJaDk8M8eYzSU\n\tbNRBEZ/4dl/P0I13c/tCXxFmezhF/zot+W/iVLOPguMeENcIDb4dhWxwqSfExP0Zeuqn\n\tVGcPnx+A4NYjdeJaMxZaBYAt498t2b3tK7O3S0i+LvCah+RkFgMzWP21T36Y1PkvMNBm\n\t/fUVPoMJUODaIpM3p2DAA392GZBrVF0WzrMR8dFWaLVIIE6MfD7qypazAEGUyd4pSwhB\n\t72Hcu7OK6oMg51H8Z7aBK1LRWcPGzDCtSL9SagxDCgA4jFBskl8JqFMdQWET7iEmTqpm\n\tShNw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=y6Mm8DjJvML8mqrG0VyYghXMRbwoormH1Lp7DoWuUZo=;\n\tb=tR57ZWlXpVrM9ZVpZiX8lXNIouMrBumvEjsFma+gujb6AqPCKorAvHDuBe5yMpXYW/\n\t5SMvJ23d28hoXy5h5hNavXB1nK7mkuTUtEHxqp6BPHaKuO0eOGK53bbdBP/SvCXdAypQ\n\t2Yfc0M2hoJoCcIUwKB0/M8dDff6QOw3BmgVdUjhBpBV2V58w1uIc8heV6pO1jtZlwXIR\n\tKgR/IdJ6Lthxc9uIjdPyOFUCNrznZB8sGB4qBmQ6Fs45UgKf5s+gDt2wXzfkN+EfA89d\n\tPgUjMlXFt+NTZxk1ekudTyXqBjNfrZ3mU7LmVkUhSgz7VlmRjD4btQBslbEnyNnLVBgI\n\t4hug==","X-Gm-Message-State":"AOAM532nmfs6I2y8U8+AK/fWK1ABAQmIza3opvk/6p13KOeyq81m9gRJ\n\t8TgO439pIfFzXF2ZtJybx4AeM3rjDt1FNA==","X-Google-Smtp-Source":"ABdhPJzxQCzyPpj9GKNjKa7Wzbjy/hHwVn6cfALmCwLGHifDfCs6iqfnRD/3znZpk2qzIwSHcdaDZQ==","X-Received":"by 2002:a2e:9745:: with SMTP id f5mr1788774ljj.158.1602678462607;\n\tWed, 14 Oct 2020 05:27:42 -0700 (PDT)","Date":"Wed, 14 Oct 2020 14:27:41 +0200","From":"Niklas =?utf-8?q?S=C3=B6derlund?= ","To":"Kieran Bingham ","Message-ID":"<20201014122741.rdab3253jozcb7nm@oden.dyn.berto.se>","References":"<20201013151241.3557005-1-kieran.bingham@ideasonboard.com>\n\t<20201013151241.3557005-6-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201013151241.3557005-6-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 05/10] libcamera: pipeline: Use\n\texisting variable definitions","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13209,"web_url":"https://patchwork.libcamera.org/comment/13209/","msgid":"","date":"2020-10-15T10:52:20","subject":"Re: [libcamera-devel] [PATCH 05/10] libcamera: pipeline: Use\n\texisting variable definitions","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Niklas,\n\nOn 14/10/2020 13:27, Niklas Söderlund wrote:\n> Hi Kieran,\n> \n> On 2020-10-13 16:12:36 +0100, Kieran Bingham wrote:\n>> Prevent variable aliasing by removing the redeclaration of variables\n>> with the same name (and type) where the existing variable can be reused.\n>>\n>> Signed-off-by: Kieran Bingham \n>> ---\n>> src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 2 +-\n>> src/libcamera/pipeline/raspberrypi/rpi_stream.cpp | 2 +-\n>> src/libcamera/pipeline/simple/simple.cpp | 4 ++--\n>> 3 files changed, 4 insertions(+), 4 deletions(-)\n>>\n>> diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n>> index 85e0a1f26ab6..2d70d984a276 100644\n>> --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n>> +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n>> @@ -1008,7 +1008,7 @@ int PipelineHandlerRPi::queueAllBuffers(Camera *camera)\n>> \t\t\t */\n>> \t\t\tunsigned int i;\n>> \t\t\tfor (i = 0; i < data->dropFrameCount_; i++) {\n>> -\t\t\t\tint ret = stream->queueBuffer(nullptr);\n>> +\t\t\t\tret = stream->queueBuffer(nullptr);\n>> \t\t\t\tif (ret)\n>> \t\t\t\t\treturn ret;\n>> \t\t\t}\n>> diff --git a/src/libcamera/pipeline/raspberrypi/rpi_stream.cpp b/src/libcamera/pipeline/raspberrypi/rpi_stream.cpp\n>> index 1a42cc17bcba..17e38924d653 100644\n>> --- a/src/libcamera/pipeline/raspberrypi/rpi_stream.cpp\n>> +++ b/src/libcamera/pipeline/raspberrypi/rpi_stream.cpp\n>> @@ -163,7 +163,7 @@ void Stream::returnBuffer(FrameBuffer *buffer)\n>> \t * If so, do it now as availableBuffers_ will not be empty.\n>> \t */\n>> \twhile (!requestBuffers_.empty()) {\n>> -\t\tFrameBuffer *buffer = requestBuffers_.front();\n>> +\t\tbuffer = requestBuffers_.front();\n> \n> Same comment as for 2/10 about reusing a function argument.\n\nThis one seems a bit less clear-cut.\n\nThe incoming buffer is one that gets put on the availableBuffers_ queue.\n\nThis new 'buffer' is used from two locations. Both the availableBuffers_\nqueue and the requestBuffers_ queue.\n\nSo there's no clear 'This is a raw Buffer' case like before.\n\nWe could say that it is distinct, that it is the 'next buffer if\nidentified' to queue to the device...\n\nSo that could give a name of ...\n\n nextBuffer, or deviceBuffer ... or just 'buffer'?\n\nI'm inclined to leave this as just re-using the buffer variable\ncurrently....\n\nAny thoughts or better naming?\n\n--\nKieran\n\n\n\n\n> \n>> \n>> \t\tif (!buffer) {\n>> \t\t\t/*\n>> diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\n>> index 999c44515023..33daa2fb1b7b 100644\n>> --- a/src/libcamera/pipeline/simple/simple.cpp\n>> +++ b/src/libcamera/pipeline/simple/simple.cpp\n>> @@ -612,8 +612,8 @@ int SimplePipelineHandler::configure(Camera *camera, CameraConfiguration *c)\n>> \tuseConverter_ = config->needConversion();\n>> \n>> \tif (useConverter_) {\n>> -\t\tint ret = converter_->configure(pipeConfig.pixelFormat,\n>> -\t\t\t\t\t\tpipeConfig.captureSize, &cfg);\n>> +\t\tret = converter_->configure(pipeConfig.pixelFormat,\n>> +\t\t\t\t\t pipeConfig.captureSize, &cfg);\n>> \t\tif (ret < 0) {\n>> \t\t\tLOG(SimplePipeline, Error)\n>> \t\t\t\t<< \"Unable to configure converter\";\n>> -- \n>> 2.25.1\n>>\n>> _______________________________________________\n>> libcamera-devel mailing list\n>> libcamera-devel@lists.libcamera.org\n>> https://lists.libcamera.org/listinfo/libcamera-devel\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6C01DBE174\n\tfor ;\n\tThu, 15 Oct 2020 10:52:27 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E332260E36;\n\tThu, 15 Oct 2020 12:52:26 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A5D68605BF\n\tfor ;\n\tThu, 15 Oct 2020 12:52:24 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 73F13556;\n\tThu, 15 Oct 2020 12:52:23 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"KAvieHc3\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1602759143;\n\tbh=HbG/A/T56dPGtDDD+LXXxDFxzLTXxFe6z40TAWNlmXA=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=KAvieHc3AdIeR2O6SzZRX96eAv9p84bZL6pZo0qVeWhZOavFG5neQgs8OHo9+ObOD\n\t6cjaXlbvFdNuJfIBK6DZmI57EneHukb7NiEiPt3Y2RXl4UxmrybsZ7/m5/MM4eLlGU\n\tzj1OVEkWDG7Ad2kyBp0AmaFe2gU6d+BIDf9L+H8Q=","To":"=?utf-8?q?Niklas_S=C3=B6derlund?= ","References":"<20201013151241.3557005-1-kieran.bingham@ideasonboard.com>\n\t<20201013151241.3557005-6-kieran.bingham@ideasonboard.com>\n\t<20201014122741.rdab3253jozcb7nm@oden.dyn.berto.se>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"","Date":"Thu, 15 Oct 2020 11:52:20 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20201014122741.rdab3253jozcb7nm@oden.dyn.berto.se>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH 05/10] libcamera: pipeline: Use\n\texisting variable definitions","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13210,"web_url":"https://patchwork.libcamera.org/comment/13210/","msgid":"<20201015112123.razh4ywstqc4qgtm@oden.dyn.berto.se>","date":"2020-10-15T11:21:23","subject":"Re: [libcamera-devel] [PATCH 05/10] libcamera: pipeline: Use\n\texisting variable definitions","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Kieran,\n\nOn 2020-10-15 11:52:20 +0100, Kieran Bingham wrote:\n> Hi Niklas,\n> \n> On 14/10/2020 13:27, Niklas Söderlund wrote:\n> > Hi Kieran,\n> > \n> > On 2020-10-13 16:12:36 +0100, Kieran Bingham wrote:\n> >> Prevent variable aliasing by removing the redeclaration of variables\n> >> with the same name (and type) where the existing variable can be reused.\n> >>\n> >> Signed-off-by: Kieran Bingham \n> >> ---\n> >> src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 2 +-\n> >> src/libcamera/pipeline/raspberrypi/rpi_stream.cpp | 2 +-\n> >> src/libcamera/pipeline/simple/simple.cpp | 4 ++--\n> >> 3 files changed, 4 insertions(+), 4 deletions(-)\n> >>\n> >> diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> >> index 85e0a1f26ab6..2d70d984a276 100644\n> >> --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> >> +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> >> @@ -1008,7 +1008,7 @@ int PipelineHandlerRPi::queueAllBuffers(Camera *camera)\n> >> \t\t\t */\n> >> \t\t\tunsigned int i;\n> >> \t\t\tfor (i = 0; i < data->dropFrameCount_; i++) {\n> >> -\t\t\t\tint ret = stream->queueBuffer(nullptr);\n> >> +\t\t\t\tret = stream->queueBuffer(nullptr);\n> >> \t\t\t\tif (ret)\n> >> \t\t\t\t\treturn ret;\n> >> \t\t\t}\n> >> diff --git a/src/libcamera/pipeline/raspberrypi/rpi_stream.cpp b/src/libcamera/pipeline/raspberrypi/rpi_stream.cpp\n> >> index 1a42cc17bcba..17e38924d653 100644\n> >> --- a/src/libcamera/pipeline/raspberrypi/rpi_stream.cpp\n> >> +++ b/src/libcamera/pipeline/raspberrypi/rpi_stream.cpp\n> >> @@ -163,7 +163,7 @@ void Stream::returnBuffer(FrameBuffer *buffer)\n> >> \t * If so, do it now as availableBuffers_ will not be empty.\n> >> \t */\n> >> \twhile (!requestBuffers_.empty()) {\n> >> -\t\tFrameBuffer *buffer = requestBuffers_.front();\n> >> +\t\tbuffer = requestBuffers_.front();\n> > \n> > Same comment as for 2/10 about reusing a function argument.\n> \n> This one seems a bit less clear-cut.\n> \n> The incoming buffer is one that gets put on the availableBuffers_ queue.\n> \n> This new 'buffer' is used from two locations. Both the availableBuffers_\n> queue and the requestBuffers_ queue.\n> \n> So there's no clear 'This is a raw Buffer' case like before.\n\nIs not this 'buffer' use-case to contain a pointer to a buffer to \nsatisfy a request we could not before as we might be in a buffer \nunderrun situiation?\n\n> \n> We could say that it is distinct, that it is the 'next buffer if\n> identified' to queue to the device...\n> \n> So that could give a name of ...\n> \n> nextBuffer, or deviceBuffer ... or just 'buffer'?\n\nLooking at the context I would name it requestBuffer.\n\n> \n> I'm inclined to leave this as just re-using the buffer variable\n> currently....\n> \n> Any thoughts or better naming?\n> \n> --\n> Kieran\n> \n> \n> \n> \n> > \n> >> \n> >> \t\tif (!buffer) {\n> >> \t\t\t/*\n> >> diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\n> >> index 999c44515023..33daa2fb1b7b 100644\n> >> --- a/src/libcamera/pipeline/simple/simple.cpp\n> >> +++ b/src/libcamera/pipeline/simple/simple.cpp\n> >> @@ -612,8 +612,8 @@ int SimplePipelineHandler::configure(Camera *camera, CameraConfiguration *c)\n> >> \tuseConverter_ = config->needConversion();\n> >> \n> >> \tif (useConverter_) {\n> >> -\t\tint ret = converter_->configure(pipeConfig.pixelFormat,\n> >> -\t\t\t\t\t\tpipeConfig.captureSize, &cfg);\n> >> +\t\tret = converter_->configure(pipeConfig.pixelFormat,\n> >> +\t\t\t\t\t pipeConfig.captureSize, &cfg);\n> >> \t\tif (ret < 0) {\n> >> \t\t\tLOG(SimplePipeline, Error)\n> >> \t\t\t\t<< \"Unable to configure converter\";\n> >> -- \n> >> 2.25.1\n> >>\n> >> _______________________________________________\n> >> libcamera-devel mailing list\n> >> libcamera-devel@lists.libcamera.org\n> >> https://lists.libcamera.org/listinfo/libcamera-devel\n> > \n> \n> -- \n> Regards\n> --\n> Kieran","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E69E8BE905\n\tfor ;\n\tThu, 15 Oct 2020 11:21:28 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 639CD60E8D;\n\tThu, 15 Oct 2020 13:21:28 +0200 (CEST)","from mail-lf1-x142.google.com (mail-lf1-x142.google.com\n\t[IPv6:2a00:1450:4864:20::142])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 79BA8605BF\n\tfor ;\n\tThu, 15 Oct 2020 13:21:27 +0200 (CEST)","by mail-lf1-x142.google.com with SMTP id a9so3140506lfc.7\n\tfor ;\n\tThu, 15 Oct 2020 04:21:27 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\tj10sm1177207ljb.93.2020.10.15.04.21.23\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 15 Oct 2020 04:21:24 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"iglWJD+p\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=n3WPkY89iI5CYV/nQbEcResZ4kraUToQVbLRmZ4NO5E=;\n\tb=iglWJD+pnAWVOxT6W+eN39VDAWM2wTyOvvLH2luKJarf4UQd1xkLmFGUUDtHFJ2mhs\n\tDLhKGXooVR+afPfDenLkfarcZiKiNMWTVAOUnL8NtE6xkW9I0hUqvrzMmvqIK0PFk54P\n\tVG6dxcN5iPwCCiOfM7oyL6y2TOLT+2avatpTtbTHS1R7FogKztNWBylhgCRxs5TW/Q2a\n\tAKCuYRIjNefveKQ3f5zfGQQr/OIwcH9dGQzHefixtKtm3LyWK6bmIMb0I5hVTemZYmdk\n\tSIZaxsF/Aw2v3hG4Di+dBi7J7Wrz0sXHF1OIDOMcibqmLqXJ90YH6lOA9VASDB7ZL4D6\n\tG7tA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=n3WPkY89iI5CYV/nQbEcResZ4kraUToQVbLRmZ4NO5E=;\n\tb=G8/fp48+FpafqmqO1vFRwkogo8W7KpQCbWqqQcSP1xlhFwMyXfGjjVY8sy+/HUtJtp\n\tpc/Jg6QWFdQoIEuQ+5RGSNxsNQOZTelsNectk5YGvv5U4O3D0OqkSASo1svBDjxHmPGe\n\tL+DWVGhDYZLdv5J+9hkFEC/Ew1dgFeYCNOFeiuneVUFEQr58VtRE/tn0V/1gbPMG+Ymy\n\tv3j4LQmlDou9XJp/Lu+vpLu12srX4NIxEt1lPAh+O58L7GNbyu3/kd37a2sUEa2+I45U\n\t+IZlrR1INVNv9iZhVNwaF4CFv+rw2f0VzjrmyDTY2XBYzvtmOl0fT09RdEt/OkLt29Sa\n\tXyzw==","X-Gm-Message-State":"AOAM531nLhhCS33oaDF6QSvCZmKArcAs+QcjnADCZAJ0SX8sir5dO4Wz\n\tMFamT+J7lMw25+2iDD7Jzn9NjkSdO16/6w==","X-Google-Smtp-Source":"ABdhPJzFqD3F/EtCgIx0DZYxQzZD8iC8/AyqsCOy816zB9MUZw9G9K9QESIfS4ZGHRdeuVTTyAuHBw==","X-Received":"by 2002:a19:ae04:: with SMTP id f4mr1021653lfc.436.1602760885236;\n\tThu, 15 Oct 2020 04:21:25 -0700 (PDT)","Date":"Thu, 15 Oct 2020 13:21:23 +0200","From":"Niklas =?utf-8?q?S=C3=B6derlund?= ","To":"Kieran Bingham ","Message-ID":"<20201015112123.razh4ywstqc4qgtm@oden.dyn.berto.se>","References":"<20201013151241.3557005-1-kieran.bingham@ideasonboard.com>\n\t<20201013151241.3557005-6-kieran.bingham@ideasonboard.com>\n\t<20201014122741.rdab3253jozcb7nm@oden.dyn.berto.se>\n\t","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH 05/10] libcamera: pipeline: Use\n\texisting variable definitions","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13218,"web_url":"https://patchwork.libcamera.org/comment/13218/","msgid":"<464ba5cd-419b-3e72-08a4-648bbf33e9f5@ideasonboard.com>","date":"2020-10-15T15:59:47","subject":"Re: [libcamera-devel] [PATCH 05/10] libcamera: pipeline: Use\n\texisting variable definitions","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Niklas,\n\nOn 15/10/2020 12:21, Niklas Söderlund wrote:\n> Hi Kieran,\n> \n> On 2020-10-15 11:52:20 +0100, Kieran Bingham wrote:\n>> Hi Niklas,\n>>\n>> On 14/10/2020 13:27, Niklas Söderlund wrote:\n>>> Hi Kieran,\n>>>\n>>> On 2020-10-13 16:12:36 +0100, Kieran Bingham wrote:\n>>>> Prevent variable aliasing by removing the redeclaration of variables\n>>>> with the same name (and type) where the existing variable can be reused.\n>>>>\n>>>> Signed-off-by: Kieran Bingham \n>>>> ---\n>>>> src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 2 +-\n>>>> src/libcamera/pipeline/raspberrypi/rpi_stream.cpp | 2 +-\n>>>> src/libcamera/pipeline/simple/simple.cpp | 4 ++--\n>>>> 3 files changed, 4 insertions(+), 4 deletions(-)\n>>>>\n>>>> diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n>>>> index 85e0a1f26ab6..2d70d984a276 100644\n>>>> --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n>>>> +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n>>>> @@ -1008,7 +1008,7 @@ int PipelineHandlerRPi::queueAllBuffers(Camera *camera)\n>>>> \t\t\t */\n>>>> \t\t\tunsigned int i;\n>>>> \t\t\tfor (i = 0; i < data->dropFrameCount_; i++) {\n>>>> -\t\t\t\tint ret = stream->queueBuffer(nullptr);\n>>>> +\t\t\t\tret = stream->queueBuffer(nullptr);\n>>>> \t\t\t\tif (ret)\n>>>> \t\t\t\t\treturn ret;\n>>>> \t\t\t}\n>>>> diff --git a/src/libcamera/pipeline/raspberrypi/rpi_stream.cpp b/src/libcamera/pipeline/raspberrypi/rpi_stream.cpp\n>>>> index 1a42cc17bcba..17e38924d653 100644\n>>>> --- a/src/libcamera/pipeline/raspberrypi/rpi_stream.cpp\n>>>> +++ b/src/libcamera/pipeline/raspberrypi/rpi_stream.cpp\n>>>> @@ -163,7 +163,7 @@ void Stream::returnBuffer(FrameBuffer *buffer)\n>>>> \t * If so, do it now as availableBuffers_ will not be empty.\n>>>> \t */\n>>>> \twhile (!requestBuffers_.empty()) {\n>>>> -\t\tFrameBuffer *buffer = requestBuffers_.front();\n>>>> +\t\tbuffer = requestBuffers_.front();\n>>>\n>>> Same comment as for 2/10 about reusing a function argument.\n>>\n>> This one seems a bit less clear-cut.\n>>\n>> The incoming buffer is one that gets put on the availableBuffers_ queue.\n>>\n>> This new 'buffer' is used from two locations. Both the availableBuffers_\n>> queue and the requestBuffers_ queue.\n>>\n>> So there's no clear 'This is a raw Buffer' case like before.\n> \n> Is not this 'buffer' use-case to contain a pointer to a buffer to \n> satisfy a request we could not before as we might be in a buffer \n> underrun situiation?\n> \n>>\n>> We could say that it is distinct, that it is the 'next buffer if\n>> identified' to queue to the device...\n>>\n>> So that could give a name of ...\n>>\n>> nextBuffer, or deviceBuffer ... or just 'buffer'?\n> \n> Looking at the context I would name it requestBuffer.\n\nSold to the gentleman at the back.\nV2 shortly.\n\n--\nKieran\n\n\n> \n>>\n>> I'm inclined to leave this as just re-using the buffer variable\n>> currently....\n>>\n>> Any thoughts or better naming?\n>>\n>> --\n>> Kieran\n>>\n>>\n>>\n>>\n>>>\n>>>> \n>>>> \t\tif (!buffer) {\n>>>> \t\t\t/*\n>>>> diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\n>>>> index 999c44515023..33daa2fb1b7b 100644\n>>>> --- a/src/libcamera/pipeline/simple/simple.cpp\n>>>> +++ b/src/libcamera/pipeline/simple/simple.cpp\n>>>> @@ -612,8 +612,8 @@ int SimplePipelineHandler::configure(Camera *camera, CameraConfiguration *c)\n>>>> \tuseConverter_ = config->needConversion();\n>>>> \n>>>> \tif (useConverter_) {\n>>>> -\t\tint ret = converter_->configure(pipeConfig.pixelFormat,\n>>>> -\t\t\t\t\t\tpipeConfig.captureSize, &cfg);\n>>>> +\t\tret = converter_->configure(pipeConfig.pixelFormat,\n>>>> +\t\t\t\t\t pipeConfig.captureSize, &cfg);\n>>>> \t\tif (ret < 0) {\n>>>> \t\t\tLOG(SimplePipeline, Error)\n>>>> \t\t\t\t<< \"Unable to configure converter\";\n>>>> -- \n>>>> 2.25.1\n>>>>\n>>>> _______________________________________________\n>>>> libcamera-devel mailing list\n>>>> libcamera-devel@lists.libcamera.org\n>>>> https://lists.libcamera.org/listinfo/libcamera-devel\n>>>\n>>\n>> -- \n>> Regards\n>> --\n>> Kieran\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1EEA9BE174\n\tfor ;\n\tThu, 15 Oct 2020 15:59:53 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A4DF360E36;\n\tThu, 15 Oct 2020 17:59:52 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B65CC605BF\n\tfor ;\n\tThu, 15 Oct 2020 17:59:50 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 293B4556;\n\tThu, 15 Oct 2020 17:59:50 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Vvd0E4z+\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1602777590;\n\tbh=ybWqqa38iuOXFhk1KYWGBlyxJcaxYq5bhBMuGSm3kPI=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=Vvd0E4z+KXo8MGsJYJz3eZT+DK9sT1tGygKzfbtQYosSbV7ThYFjdmRkOf9zjpOc/\n\tA9iSsAmzCO7AONE649AJLOrKxI1OdNFhFBfbKU1lQt7OCpFaAWW+BRPgLV/TkjNCe5\n\txDxBDWEYgLWRvQpoxA6o18AeVfz5/ZKRA/5tkGPU=","To":"=?utf-8?q?Niklas_S=C3=B6derlund?= ","References":"<20201013151241.3557005-1-kieran.bingham@ideasonboard.com>\n\t<20201013151241.3557005-6-kieran.bingham@ideasonboard.com>\n\t<20201014122741.rdab3253jozcb7nm@oden.dyn.berto.se>\n\t\n\t<20201015112123.razh4ywstqc4qgtm@oden.dyn.berto.se>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<464ba5cd-419b-3e72-08a4-648bbf33e9f5@ideasonboard.com>","Date":"Thu, 15 Oct 2020 16:59:47 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20201015112123.razh4ywstqc4qgtm@oden.dyn.berto.se>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH 05/10] libcamera: pipeline: Use\n\texisting variable definitions","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]