[{"id":13187,"web_url":"https://patchwork.libcamera.org/comment/13187/","msgid":"<20201013184240.GH11939@pendragon.ideasonboard.com>","date":"2020-10-13T18:42:40","subject":"Re: [libcamera-devel] [PATCH 02/10] qcam: main_window: Re-use\n\texisting variable","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Tue, Oct 13, 2020 at 04:12:33PM +0100, Kieran Bingham wrote:\n> The queueRequest function creates FrameBuffer pointer which aliases the\n> existing and passed in buffer pointer.\n> \n> When the captureRaw_ scope is executed, the original FrameBuffer *buffer\n> is not used any more.\n> \n> Re-use it rather than creating a new variable with the same name.\n> \n> Signed-off-by: Kieran Bingham \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/qcam/main_window.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/qcam/main_window.cpp b/src/qcam/main_window.cpp\n> index 0cbdab9a6bce..0e50768aa386 100644\n> --- a/src/qcam/main_window.cpp\n> +++ b/src/qcam/main_window.cpp\n> @@ -769,7 +769,7 @@ void MainWindow::queueRequest(FrameBuffer *buffer)\n> \trequest->addBuffer(vfStream_, buffer);\n> \n> \tif (captureRaw_) {\n> -\t\tFrameBuffer *buffer = nullptr;\n> +\t\tbuffer = nullptr;\n> \n> \t\t{\n> \t\t\tQMutexLocker locker(&mutex_);","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BBD57BEEDF\n\tfor ;\n\tTue, 13 Oct 2020 18:43:27 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8B49C60E36;\n\tTue, 13 Oct 2020 20:43:27 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BC82A60589\n\tfor ;\n\tTue, 13 Oct 2020 20:43:26 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5BBDBB87;\n\tTue, 13 Oct 2020 20:43:26 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"QN4q+70K\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1602614606;\n\tbh=dvdUkhcfEyzjrSsotNU1OXB/k3wK7KHzCiHCZGc62es=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=QN4q+70KVfRJHcY113/8cySh+4B4Azaz3EQQx0UZGYWQSyO6ZqpQwv5F9/Lrckl0C\n\tJiYvjLPsDgcKU6/HO3IcIomXDmxgZDEw8njIyvpYtYkw3ED6Jd0cvwzVNW+n7VeWqR\n\tVOi3u5BZrbdPtjiO4RmNgJerqBPtmSkRmAJVxIoQ=","Date":"Tue, 13 Oct 2020 21:42:40 +0300","From":"Laurent Pinchart ","To":"Kieran Bingham ","Message-ID":"<20201013184240.GH11939@pendragon.ideasonboard.com>","References":"<20201013151241.3557005-1-kieran.bingham@ideasonboard.com>\n\t<20201013151241.3557005-3-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201013151241.3557005-3-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 02/10] qcam: main_window: Re-use\n\texisting variable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13196,"web_url":"https://patchwork.libcamera.org/comment/13196/","msgid":"<20201014122237.ey644ncd2fau5hej@oden.dyn.berto.se>","date":"2020-10-14T12:22:37","subject":"Re: [libcamera-devel] [PATCH 02/10] qcam: main_window: Re-use\n\texisting variable","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Kieran,\n\nOn 2020-10-13 16:12:33 +0100, Kieran Bingham wrote:\n> The queueRequest function creates FrameBuffer pointer which aliases the\n> existing and passed in buffer pointer.\n> \n> When the captureRaw_ scope is executed, the original FrameBuffer *buffer\n> is not used any more.\n> \n> Re-use it rather than creating a new variable with the same name.\n\nI know this is bikeshedding, but I really don't like reusing a function \nargument. Specially not for a new use-case like this where the 'buffer' \nargument passed in represents the viewfinder buffer ands the 'buffer' \nvariable used here is the raw buffer. Would it not make more sens to \nrename this buffer rawBuffer or something similar?\n\n> \n> Signed-off-by: Kieran Bingham \n> ---\n> src/qcam/main_window.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/qcam/main_window.cpp b/src/qcam/main_window.cpp\n> index 0cbdab9a6bce..0e50768aa386 100644\n> --- a/src/qcam/main_window.cpp\n> +++ b/src/qcam/main_window.cpp\n> @@ -769,7 +769,7 @@ void MainWindow::queueRequest(FrameBuffer *buffer)\n> \trequest->addBuffer(vfStream_, buffer);\n> \n> \tif (captureRaw_) {\n> -\t\tFrameBuffer *buffer = nullptr;\n> +\t\tbuffer = nullptr;\n> \n> \t\t{\n> \t\t\tQMutexLocker locker(&mutex_);\n> -- \n> 2.25.1\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 70996BEEE0\n\tfor ;\n\tWed, 14 Oct 2020 12:22:41 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 03B3F60355;\n\tWed, 14 Oct 2020 14:22:41 +0200 (CEST)","from mail-lf1-x143.google.com (mail-lf1-x143.google.com\n\t[IPv6:2a00:1450:4864:20::143])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9727D60354\n\tfor ;\n\tWed, 14 Oct 2020 14:22:39 +0200 (CEST)","by mail-lf1-x143.google.com with SMTP id l2so3493848lfk.0\n\tfor ;\n\tWed, 14 Oct 2020 05:22:39 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\ta19sm1150099ljb.97.2020.10.14.05.22.38\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 14 Oct 2020 05:22:38 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"BrjGiWU5\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=b4r49oRmV4Lvh45FupxEXjSYzN6YsHqbCiQELAthUq4=;\n\tb=BrjGiWU5fCuZQH6UYZDGeWtQRuxifdERoSSzlqEpk76FhKc4p92ttsaLSDLDcbNRYi\n\tv+c0wA3OA31gTvUFaDnRJxHQPF+uDooOUB4sgCcs5OgcFfK2NcliShxq1UXFhmiUC0C9\n\tOnOCXRdnVC9Dahkv0MjdQbVQAjoJ3iBNf5wOOiSnXzTARuTl0qwMntAs9/xsUb//4M01\n\taSr4dWa1n7ndRx5wdNB2vgUpzxIhhDeYrr275HaNar95Zv/eIfluSwaUpzLJRZc1Yo2M\n\tV4DxNuKrCZvIW2hiX721HKVCGIalLbAINIk8lYXCX69B+qCYKQjZ4w0KrEjS9BllA8Cg\n\txvcw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=b4r49oRmV4Lvh45FupxEXjSYzN6YsHqbCiQELAthUq4=;\n\tb=eXDQ52eDoojxvShYDH/HVZLJ3T3yt0zp/URfCyhMM9FyuWYTMu/U3o/75et6pr6Hao\n\t/NL/FuYdTPPL1X9YlLB8/tnnApnVpUMHBlJdMk5js7xia+TrRxapXFWKq7YJTRzHABfm\n\tFPqKN98rvuwECVwGA/nJG+ZvS52s+ulcT1Uty5TE+dOxQwau3G0ZgkUEu9YX7DEkXjLu\n\toDJEDix7HF4ucJEKKpWP9l2MErqv1RASfyaE87REujjdl2Vg9Mzek77fNF5yJ6sSopst\n\ta735RfRjHwxvwl9m4RZqF+j1BCRZzXTU+RMtSJSV7aNw1f58+ApyyxFGUusQT0l1fypg\n\tSyrg==","X-Gm-Message-State":"AOAM531TGUdG+fkFTZzviUlRHDi/P0sRSxv7cW8X1nMiAOQ+duy8Yp3o\n\tkclqtovv0seKQLEwrGpbt3KlXchXHWZEjQ==","X-Google-Smtp-Source":"ABdhPJyy+T6pZO6DlWFjgW4ezYx5LhTmihjvZy6Tn6FomlEK+fL6fj4TXVfntVm2mRvZRg3jPVhh1w==","X-Received":"by 2002:a19:407:: with SMTP id 7mr1211913lfe.291.1602678159020; \n\tWed, 14 Oct 2020 05:22:39 -0700 (PDT)","Date":"Wed, 14 Oct 2020 14:22:37 +0200","From":"Niklas =?utf-8?q?S=C3=B6derlund?= ","To":"Kieran Bingham ","Message-ID":"<20201014122237.ey644ncd2fau5hej@oden.dyn.berto.se>","References":"<20201013151241.3557005-1-kieran.bingham@ideasonboard.com>\n\t<20201013151241.3557005-3-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201013151241.3557005-3-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 02/10] qcam: main_window: Re-use\n\texisting variable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13204,"web_url":"https://patchwork.libcamera.org/comment/13204/","msgid":"<73d7e503-9ecd-2a1a-d732-9f81cb5d3a74@ideasonboard.com>","date":"2020-10-14T12:38:56","subject":"Re: [libcamera-devel] [PATCH 02/10] qcam: main_window: Re-use\n\texisting variable","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Niklas,\n\nOn 14/10/2020 13:22, Niklas Söderlund wrote:\n> Hi Kieran,\n> \n> On 2020-10-13 16:12:33 +0100, Kieran Bingham wrote:\n>> The queueRequest function creates FrameBuffer pointer which aliases the\n>> existing and passed in buffer pointer.\n>>\n>> When the captureRaw_ scope is executed, the original FrameBuffer *buffer\n>> is not used any more.\n>>\n>> Re-use it rather than creating a new variable with the same name.\n> \n> I know this is bikeshedding, but I really don't like reusing a function \n> argument. Specially not for a new use-case like this where the 'buffer' \n> argument passed in represents the viewfinder buffer ands the 'buffer' \n> variable used here is the raw buffer. Would it not make more sens to \n> rename this buffer rawBuffer or something similar?\n\nNot bikeshedding at all I don't think. That looks like a good idea to\nme. It better clarifies the use of the variable.\n\nI'll update.\n\n>> Signed-off-by: Kieran Bingham \n>> ---\n>> src/qcam/main_window.cpp | 2 +-\n>> 1 file changed, 1 insertion(+), 1 deletion(-)\n>>\n>> diff --git a/src/qcam/main_window.cpp b/src/qcam/main_window.cpp\n>> index 0cbdab9a6bce..0e50768aa386 100644\n>> --- a/src/qcam/main_window.cpp\n>> +++ b/src/qcam/main_window.cpp\n>> @@ -769,7 +769,7 @@ void MainWindow::queueRequest(FrameBuffer *buffer)\n>> \trequest->addBuffer(vfStream_, buffer);\n>> \n>> \tif (captureRaw_) {\n>> -\t\tFrameBuffer *buffer = nullptr;\n>> +\t\tbuffer = nullptr;\n>> \n>> \t\t{\n>> \t\t\tQMutexLocker locker(&mutex_);\n>> -- \n>> 2.25.1\n>>\n>> _______________________________________________\n>> libcamera-devel mailing list\n>> libcamera-devel@lists.libcamera.org\n>> https://lists.libcamera.org/listinfo/libcamera-devel\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0CBFEBEEDF\n\tfor ;\n\tWed, 14 Oct 2020 12:39:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CE8BB60F2A;\n\tWed, 14 Oct 2020 14:39:00 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9DA5D60E79\n\tfor ;\n\tWed, 14 Oct 2020 14:38:59 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 02532A42;\n\tWed, 14 Oct 2020 14:38:58 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"l6yrRwhG\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1602679139;\n\tbh=TQeIjSD4lTFPRB5+fBvTHH1+ALt7sx2SMNXhmPY7Uy8=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=l6yrRwhGjx7VP5pOMojpp2OibmAb1sO794uPq/Klo0DHk3ft9doKjCc4SObAxqieY\n\tFc2EKa+wqUVHJ7pq9XAh+4Ez4eD/DWxfvlgBI1JwIJf2HiRPHzj8PPtIpI/81H8GVh\n\tQ249J6yFPzVsQDZ1bDTzibEQiFvsytyE0vjqRzjc=","To":"=?utf-8?q?Niklas_S=C3=B6derlund?= ","References":"<20201013151241.3557005-1-kieran.bingham@ideasonboard.com>\n\t<20201013151241.3557005-3-kieran.bingham@ideasonboard.com>\n\t<20201014122237.ey644ncd2fau5hej@oden.dyn.berto.se>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<73d7e503-9ecd-2a1a-d732-9f81cb5d3a74@ideasonboard.com>","Date":"Wed, 14 Oct 2020 13:38:56 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20201014122237.ey644ncd2fau5hej@oden.dyn.berto.se>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH 02/10] qcam: main_window: Re-use\n\texisting variable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]