{"id":10048,"url":"https://patchwork.libcamera.org/api/patches/10048/?format=json","web_url":"https://patchwork.libcamera.org/patch/10048/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20201013151241.3557005-3-kieran.bingham@ideasonboard.com>","date":"2020-10-13T15:12:33","name":"[libcamera-devel,02/10] qcam: main_window: Re-use existing variable","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"8f5ac7776974252281cba70dcec05d716c48c2af","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/10048/mbox/","series":[{"id":1374,"url":"https://patchwork.libcamera.org/api/series/1374/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1374","date":"2020-10-13T15:12:31","name":"Shadowed Variables","version":1,"mbox":"https://patchwork.libcamera.org/series/1374/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/10048/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/10048/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C93F7BEEDF\n\tfor ;\n\tTue, 13 Oct 2020 15:12:50 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E45A560E91;\n\tTue, 13 Oct 2020 17:12:49 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 334B060CE6\n\tfor ;\n\tTue, 13 Oct 2020 17:12:47 +0200 (CEST)","from Q.local (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net\n\t[86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BC175145A;\n\tTue, 13 Oct 2020 17:12:46 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"tvrJi/6A\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1602601966;\n\tbh=Jyfi7wYROCyEPQP7NodcAjHolsg4ukdOQ9yCEJWSNPo=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=tvrJi/6AyrfQ9ZclzV/RsmrubKXNVyS9BQ1Myw+SgDiOJihk0iHy5sekNHDtVGttU\n\tpOo+z9QTtOv8qtIRu6GpGui2wfHSoHp2PxmPwhXemx+zNOlvqYaEgusAvHJcori8/w\n\t6k/BiU3QRkRcNK5AMLZlgRJng3arIdQ3FrdDtdok=","From":"Kieran Bingham ","To":"libcamera devel ","Date":"Tue, 13 Oct 2020 16:12:33 +0100","Message-Id":"<20201013151241.3557005-3-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20201013151241.3557005-1-kieran.bingham@ideasonboard.com>","References":"<20201013151241.3557005-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH 02/10] qcam: main_window: Re-use existing\n\tvariable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The queueRequest function creates FrameBuffer pointer which aliases the\nexisting and passed in buffer pointer.\n\nWhen the captureRaw_ scope is executed, the original FrameBuffer *buffer\nis not used any more.\n\nRe-use it rather than creating a new variable with the same name.\n\nSigned-off-by: Kieran Bingham \n---\n src/qcam/main_window.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/qcam/main_window.cpp b/src/qcam/main_window.cpp\nindex 0cbdab9a6bce..0e50768aa386 100644\n--- a/src/qcam/main_window.cpp\n+++ b/src/qcam/main_window.cpp\n@@ -769,7 +769,7 @@ void MainWindow::queueRequest(FrameBuffer *buffer)\n \trequest->addBuffer(vfStream_, buffer);\n \n \tif (captureRaw_) {\n-\t\tFrameBuffer *buffer = nullptr;\n+\t\tbuffer = nullptr;\n \n \t\t{\n \t\t\tQMutexLocker locker(&mutex_);\n","prefixes":["libcamera-devel","02/10"]}