[{"id":13177,"web_url":"https://patchwork.libcamera.org/comment/13177/","msgid":"<12a49120-0061-4a14-9dfa-2995ef92d54f@ideasonboard.com>","date":"2020-10-12T10:51:53","subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline: simple: enable\n\tqcom-camss","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Andrey,\n\nOn 12/10/2020 10:53, Andrey Konovalov wrote:\n> qcom-camss driver supports MIPI CSI2 receivers on APQ8016 and APQ8096\n> Application processors from Qualcomm, which are used on e.g. DragonBoard\n> 410c and DragonBoard 820c dev boards respectively.\n> \n> The simple pipeline handler provides basic support for these devices.\n\nExcellent, an entire platform support addition with one line :-)\n\nI'm dreaming that it could be automatic to have the simple pipeline\nhandler 'identify' targets it could support (as long as it was the last\npipeline handler to run) but I think that's possibly more headaches than\nwe want right now ;-)\n\nSo single line additions of platforms known to work is good enough for\nme ;-)\n\n\n\n> Signed-off-by: Andrey Konovalov \n\nReviewed-by: Kieran Bingham \n\n\n> ---\n> src/libcamera/pipeline/simple/simple.cpp | 1 +\n> 1 file changed, 1 insertion(+)\n> \n> diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\n> index 769fe699..15e733cd 100644\n> --- a/src/libcamera/pipeline/simple/simple.cpp\n> +++ b/src/libcamera/pipeline/simple/simple.cpp\n> @@ -50,6 +50,7 @@ namespace {\n> static const SimplePipelineInfo supportedDevices[] = {\n> \t{ \"imx7-csi\", \"pxp\" },\n> \t{ \"sun6i-csi\", nullptr },\n> +\t{ \"qcom-camss\", nullptr },\n> };\n> \n> } /* namespace */\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F1643BEEE0\n\tfor ;\n\tMon, 12 Oct 2020 10:51:57 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5970860D55;\n\tMon, 12 Oct 2020 12:51:57 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EC8EF600F2\n\tfor ;\n\tMon, 12 Oct 2020 12:51:55 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5D1733B;\n\tMon, 12 Oct 2020 12:51:55 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"bDGR7p/r\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1602499915;\n\tbh=GGaFNYe0S3FPjOO7t92JsUlP9XzurgNIbA2it9mJY0Y=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=bDGR7p/rLfz5wuj69vzLFbbGjVXfnMBIdh4a1XT0aGOadAeYsOCG2BnN9mI925Cpb\n\tV1jX8rHRWT+tl1Imd223AgOy6oYNdnxFYyNhZFkrfhqlbq043QVLevmie4yYaZzJWx\n\tV4G6bFQvreJ6me6gorXNRpL2ud/lfPOk4vY69cuc=","To":"Andrey Konovalov ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20201012095343.14283-1-andrey.konovalov@linaro.org>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<12a49120-0061-4a14-9dfa-2995ef92d54f@ideasonboard.com>","Date":"Mon, 12 Oct 2020 11:51:53 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20201012095343.14283-1-andrey.konovalov@linaro.org>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline: simple: enable\n\tqcom-camss","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13178,"web_url":"https://patchwork.libcamera.org/comment/13178/","msgid":"<20201012110032.GT3944@pendragon.ideasonboard.com>","date":"2020-10-12T11:00:32","subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline: simple: enable\n\tqcom-camss","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Andrey,\n\nThank you for the patch.\n\nOn Mon, Oct 12, 2020 at 11:51:53AM +0100, Kieran Bingham wrote:\n> On 12/10/2020 10:53, Andrey Konovalov wrote:\n> > qcom-camss driver supports MIPI CSI2 receivers on APQ8016 and APQ8096\n> > Application processors from Qualcomm, which are used on e.g. DragonBoard\n> > 410c and DragonBoard 820c dev boards respectively.\n> > \n> > The simple pipeline handler provides basic support for these devices.\n> \n> Excellent, an entire platform support addition with one line :-)\n> \n> I'm dreaming that it could be automatic to have the simple pipeline\n> handler 'identify' targets it could support (as long as it was the last\n> pipeline handler to run) but I think that's possibly more headaches than\n> we want right now ;-)\n> \n> So single line additions of platforms known to work is good enough for\n> me ;-)\n> \n> > Signed-off-by: Andrey Konovalov \n> \n> Reviewed-by: Kieran Bingham \n>\n> > ---\n> > src/libcamera/pipeline/simple/simple.cpp | 1 +\n> > 1 file changed, 1 insertion(+)\n> > \n> > diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\n> > index 769fe699..15e733cd 100644\n> > --- a/src/libcamera/pipeline/simple/simple.cpp\n> > +++ b/src/libcamera/pipeline/simple/simple.cpp\n> > @@ -50,6 +50,7 @@ namespace {\n> > static const SimplePipelineInfo supportedDevices[] = {\n> > \t{ \"imx7-csi\", \"pxp\" },\n> > \t{ \"sun6i-csi\", nullptr },\n> > +\t{ \"qcom-camss\", nullptr },\n\nLet's keep these alphabetically sorted. With that fixed,\n\nReviewed-by: Laurent Pinchart \n\nI'll apply this change when pushing.\n\n> > };\n> > \n> > } /* namespace */","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 33C4CBEEDF\n\tfor ;\n\tMon, 12 Oct 2020 11:01:20 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 923C160D55;\n\tMon, 12 Oct 2020 13:01:19 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 374E9600F2\n\tfor ;\n\tMon, 12 Oct 2020 13:01:18 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A01643B;\n\tMon, 12 Oct 2020 13:01:17 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"lV2IzkX8\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1602500477;\n\tbh=CC5/rNmf6dvoZc+PQoBiqIdgDUqWJ6KzUw8T8xaKgOk=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=lV2IzkX8CjaC99W+scAbwxjNPYAIbKdVaF9Z6FHNWjXassuOLLlB72gbNes7Q8EWh\n\t3pJ3md/cWqLYImdjJpQRoi4aTFd2RORwsNB8XE6YaS3r+YMbfZtv4WXUb7fowkv1Li\n\tsaGcBRJNBK8TlS7caLuqXPkt2xoAvdYHUqZZZlB4=","Date":"Mon, 12 Oct 2020 14:00:32 +0300","From":"Laurent Pinchart ","To":"Andrey Konovalov ","Message-ID":"<20201012110032.GT3944@pendragon.ideasonboard.com>","References":"<20201012095343.14283-1-andrey.konovalov@linaro.org>\n\t<12a49120-0061-4a14-9dfa-2995ef92d54f@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<12a49120-0061-4a14-9dfa-2995ef92d54f@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline: simple: enable\n\tqcom-camss","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]