[{"id":13164,"web_url":"https://patchwork.libcamera.org/comment/13164/","msgid":"<20201011233049.GG3944@pendragon.ideasonboard.com>","date":"2020-10-11T23:30:49","subject":"Re: [libcamera-devel] [PATCH v2 2/3] android: camera_device: Queue\n\trequest using Worker","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Sat, Oct 10, 2020 at 11:58:29AM +0200, Jacopo Mondi wrote:\n> Add a CameraWorker class member to the CameraDevice class and\n> queue capture requests to it to delegate its handling. Start and\n> stop the CameraWorker when the libcamera::Camera is started or\n> stopped.\n> \n> Tie the CaptureRequest lifetime to the Camera3RequestDescriptor's one\n> by storing it as unique_ptr<> in the descriptor to simplify handling\n> of request creation and deletion.\n> \n> Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>\n> ---\n>  src/android/camera_device.cpp | 42 ++++++++++++++++++-----------------\n>  src/android/camera_device.h   |  7 +++++-\n>  2 files changed, 28 insertions(+), 21 deletions(-)\n> \n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index c29fcb43fe2d..0036f1140560 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -168,11 +168,24 @@ MappedCamera3Buffer::MappedCamera3Buffer(const buffer_handle_t camera3buffer,\n>   */\n>  \n>  CameraDevice::Camera3RequestDescriptor::Camera3RequestDescriptor(\n\nA candidate for later, renaming CameraDevice::Camera3RequestDescriptor\nto something shorter :-) Maybe CameraDevice::RequestDescriptor, or even\nCameraDevice::Request ?\n\n> -\t\tunsigned int frameNumber, unsigned int numBuffers)\n> +\tCamera *camera, unsigned int frameNumber, unsigned int numBuffers)\n>  \t: frameNumber(frameNumber), numBuffers(numBuffers)\n>  {\n>  \tbuffers = new camera3_stream_buffer_t[numBuffers];\n> +\n> +\t/*\n> +\t * FrameBuffer instances created by wrapping a camera3 provided dmabuf\n> +\t * are emplaced in this vector of unique_ptr<> for lifetime management.\n> +\t */\n>  \tframeBuffers.reserve(numBuffers);\n> +\n> +\t/*\n> +\t * Create the libcamera::Request unique_ptr<> to tie its lifetime\n> +\t * to the descriptor's one. Set the descriptor's address as the\n> +\t * request's cookie to retrieve it at completion time.\n> +\t */\n> +\trequest = std::make_unique<CaptureRequest>(camera,\n> +\t\t\t\t\t\t   reinterpret_cast<uint64_t>(this));\n>  }\n>  \n>  CameraDevice::Camera3RequestDescriptor::~Camera3RequestDescriptor()\n> @@ -519,6 +532,7 @@ void CameraDevice::close()\n>  {\n>  \tstreams_.clear();\n>  \n> +\tworker_.stop();\n>  \tcamera_->stop();\n>  \tcamera_->release();\n>  \n> @@ -1350,6 +1364,8 @@ int CameraDevice::processCaptureRequest(camera3_capture_request_t *camera3Reques\n>  \n>  \t/* Start the camera if that's the first request we handle. */\n>  \tif (!running_) {\n> +\t\tworker_.start();\n> +\n>  \t\tint ret = camera_->start();\n>  \t\tif (ret) {\n>  \t\t\tLOG(HAL, Error) << \"Failed to start camera\";\n> @@ -1372,16 +1388,9 @@ int CameraDevice::processCaptureRequest(camera3_capture_request_t *camera3Reques\n>  \t * at request complete time.\n>  \t */\n>  \tCamera3RequestDescriptor *descriptor =\n> -\t\tnew Camera3RequestDescriptor(camera3Request->frame_number,\n> +\t\tnew Camera3RequestDescriptor(camera_.get(), camera3Request->frame_number,\n>  \t\t\t\t\t     camera3Request->num_output_buffers);\n>  \n> -\tstd::unique_ptr<Request> request =\n> -\t\tcamera_->createRequest(reinterpret_cast<uint64_t>(descriptor));\n> -\tif (!request) {\n> -\t\tLOG(HAL, Error) << \"Failed to create request\";\n> -\t\treturn -ENOMEM;\n> -\t}\n> -\n>  \tLOG(HAL, Debug) << \"Queueing Request to libcamera with \"\n>  \t\t\t<< descriptor->numBuffers << \" HAL streams\";\n>  \tfor (unsigned int i = 0; i < descriptor->numBuffers; ++i) {\n> @@ -1448,18 +1457,12 @@ int CameraDevice::processCaptureRequest(camera3_capture_request_t *camera3Reques\n>  \t\t\treturn -ENOMEM;\n>  \t\t}\n>  \n> -\t\trequest->addBuffer(cameraStream->stream(), buffer);\n> -\t}\n> -\n> -\tint ret = camera_->queueRequest(request.get());\n> -\tif (ret) {\n> -\t\tLOG(HAL, Error) << \"Failed to queue request\";\n> -\t\tdelete descriptor;\n> -\t\treturn ret;\n> +\t\tdescriptor->request->addBuffer(cameraStream->stream(), buffer,\n> +\t\t\t\t\t       camera3Buffers[i].acquire_fence);\n>  \t}\n>  \n> -\t/* The request will be deleted in the completion handler. */\n> -\trequest.release();\n> +\t/* Queue the request on the CameraWorker. */\n\ns/on the/to the/\n\n> +\tworker_.queueRequest(descriptor->request.get());\n>  \n>  \treturn 0;\n>  }\n> @@ -1564,7 +1567,6 @@ void CameraDevice::requestComplete(Request *request)\n>  \tcallbacks_->process_capture_result(callbacks_, &captureResult);\n>  \n>  \tdelete descriptor;\n> -\tdelete request;\n>  }\n>  \n>  std::string CameraDevice::logPrefix() const\n> diff --git a/src/android/camera_device.h b/src/android/camera_device.h\n> index 777d1a35e801..86f2b8974b53 100644\n> --- a/src/android/camera_device.h\n> +++ b/src/android/camera_device.h\n> @@ -25,6 +25,7 @@\n>  #include \"libcamera/internal/message.h\"\n>  \n>  #include \"camera_stream.h\"\n> +#include \"camera_worker.h\"\n>  #include \"jpeg/encoder.h\"\n>  \n>  class CameraMetadata;\n> @@ -73,7 +74,8 @@ private:\n>  \tCameraDevice(unsigned int id, const std::shared_ptr<libcamera::Camera> &camera);\n>  \n>  \tstruct Camera3RequestDescriptor {\n> -\t\tCamera3RequestDescriptor(unsigned int frameNumber,\n> +\t\tCamera3RequestDescriptor(libcamera::Camera *camera,\n> +\t\t\t\t\t unsigned int frameNumber,\n>  \t\t\t\t\t unsigned int numBuffers);\n>  \t\t~Camera3RequestDescriptor();\n>  \n> @@ -81,6 +83,7 @@ private:\n>  \t\tuint32_t numBuffers;\n>  \t\tcamera3_stream_buffer_t *buffers;\n>  \t\tstd::vector<std::unique_ptr<libcamera::FrameBuffer>> frameBuffers;\n> +\t\tstd::unique_ptr<CaptureRequest> request;\n\nYou could actually embed this. It may even make sense to merge the two\nstructures together as I don't think we need two separate structures. Up\nto you, it can also be handled later.\n\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\nI like the simplification :-)\n\n>  \t};\n>  \n>  \tstruct Camera3StreamConfiguration {\n> @@ -108,6 +111,8 @@ private:\n>  \tunsigned int id_;\n>  \tcamera3_device_t camera3Device_;\n>  \n> +\tCameraWorker worker_;\n> +\n>  \tbool running_;\n>  \tstd::shared_ptr<libcamera::Camera> camera_;\n>  \tstd::unique_ptr<libcamera::CameraConfiguration> config_;","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 46F1FBEEE0\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSun, 11 Oct 2020 23:31:37 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D9438605D1;\n\tMon, 12 Oct 2020 01:31:36 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3A15760357\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 12 Oct 2020 01:31:35 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B10CE308;\n\tMon, 12 Oct 2020 01:31:34 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"rXO2Jwmw\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1602459094;\n\tbh=RJwbgDNWC0scPu0ZRZlfCTgSzPvlXJqwYZG51/IconE=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=rXO2JwmwX7WY/up7ZKlmXcqDv9sL1WMmHSfofBf6nP0bh8XG3MKFz9OHrALV76HC9\n\tX9VQQOyHnDdRS7v/FLR+72wxLmnp0OKL+P4qxmpAAm6APGrz0FYfWzDkgj7jWfcKxi\n\tQYYXfqozaB8b1/htaIJiZOsO8jrrl8TA3VqC+SgU=","Date":"Mon, 12 Oct 2020 02:30:49 +0300","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"Jacopo Mondi <jacopo@jmondi.org>","Message-ID":"<20201011233049.GG3944@pendragon.ideasonboard.com>","References":"<20201010095830.134084-1-jacopo@jmondi.org>\n\t<20201010095830.134084-3-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201010095830.134084-3-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH v2 2/3] android: camera_device: Queue\n\trequest using Worker","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":13193,"web_url":"https://patchwork.libcamera.org/comment/13193/","msgid":"<20201014120248.i5ii2rfj7dst7cm3@oden.dyn.berto.se>","date":"2020-10-14T12:02:48","subject":"Re: [libcamera-devel] [PATCH v2 2/3] android: camera_device: Queue\n\trequest using Worker","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Jacopo,\n\nNice work.\n\nOn 2020-10-10 11:58:29 +0200, Jacopo Mondi wrote:\n> Add a CameraWorker class member to the CameraDevice class and\n> queue capture requests to it to delegate its handling. Start and\n> stop the CameraWorker when the libcamera::Camera is started or\n> stopped.\n> \n> Tie the CaptureRequest lifetime to the Camera3RequestDescriptor's one\n> by storing it as unique_ptr<> in the descriptor to simplify handling\n> of request creation and deletion.\n> \n> Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>\n\nReviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n\n> ---\n>  src/android/camera_device.cpp | 42 ++++++++++++++++++-----------------\n>  src/android/camera_device.h   |  7 +++++-\n>  2 files changed, 28 insertions(+), 21 deletions(-)\n> \n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index c29fcb43fe2d..0036f1140560 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -168,11 +168,24 @@ MappedCamera3Buffer::MappedCamera3Buffer(const buffer_handle_t camera3buffer,\n>   */\n>  \n>  CameraDevice::Camera3RequestDescriptor::Camera3RequestDescriptor(\n> -\t\tunsigned int frameNumber, unsigned int numBuffers)\n> +\tCamera *camera, unsigned int frameNumber, unsigned int numBuffers)\n>  \t: frameNumber(frameNumber), numBuffers(numBuffers)\n>  {\n>  \tbuffers = new camera3_stream_buffer_t[numBuffers];\n> +\n> +\t/*\n> +\t * FrameBuffer instances created by wrapping a camera3 provided dmabuf\n> +\t * are emplaced in this vector of unique_ptr<> for lifetime management.\n> +\t */\n>  \tframeBuffers.reserve(numBuffers);\n> +\n> +\t/*\n> +\t * Create the libcamera::Request unique_ptr<> to tie its lifetime\n> +\t * to the descriptor's one. Set the descriptor's address as the\n> +\t * request's cookie to retrieve it at completion time.\n> +\t */\n> +\trequest = std::make_unique<CaptureRequest>(camera,\n> +\t\t\t\t\t\t   reinterpret_cast<uint64_t>(this));\n>  }\n>  \n>  CameraDevice::Camera3RequestDescriptor::~Camera3RequestDescriptor()\n> @@ -519,6 +532,7 @@ void CameraDevice::close()\n>  {\n>  \tstreams_.clear();\n>  \n> +\tworker_.stop();\n>  \tcamera_->stop();\n>  \tcamera_->release();\n>  \n> @@ -1350,6 +1364,8 @@ int CameraDevice::processCaptureRequest(camera3_capture_request_t *camera3Reques\n>  \n>  \t/* Start the camera if that's the first request we handle. */\n>  \tif (!running_) {\n> +\t\tworker_.start();\n> +\n>  \t\tint ret = camera_->start();\n>  \t\tif (ret) {\n>  \t\t\tLOG(HAL, Error) << \"Failed to start camera\";\n> @@ -1372,16 +1388,9 @@ int CameraDevice::processCaptureRequest(camera3_capture_request_t *camera3Reques\n>  \t * at request complete time.\n>  \t */\n>  \tCamera3RequestDescriptor *descriptor =\n> -\t\tnew Camera3RequestDescriptor(camera3Request->frame_number,\n> +\t\tnew Camera3RequestDescriptor(camera_.get(), camera3Request->frame_number,\n>  \t\t\t\t\t     camera3Request->num_output_buffers);\n>  \n> -\tstd::unique_ptr<Request> request =\n> -\t\tcamera_->createRequest(reinterpret_cast<uint64_t>(descriptor));\n> -\tif (!request) {\n> -\t\tLOG(HAL, Error) << \"Failed to create request\";\n> -\t\treturn -ENOMEM;\n> -\t}\n> -\n>  \tLOG(HAL, Debug) << \"Queueing Request to libcamera with \"\n>  \t\t\t<< descriptor->numBuffers << \" HAL streams\";\n>  \tfor (unsigned int i = 0; i < descriptor->numBuffers; ++i) {\n> @@ -1448,18 +1457,12 @@ int CameraDevice::processCaptureRequest(camera3_capture_request_t *camera3Reques\n>  \t\t\treturn -ENOMEM;\n>  \t\t}\n>  \n> -\t\trequest->addBuffer(cameraStream->stream(), buffer);\n> -\t}\n> -\n> -\tint ret = camera_->queueRequest(request.get());\n> -\tif (ret) {\n> -\t\tLOG(HAL, Error) << \"Failed to queue request\";\n> -\t\tdelete descriptor;\n> -\t\treturn ret;\n> +\t\tdescriptor->request->addBuffer(cameraStream->stream(), buffer,\n> +\t\t\t\t\t       camera3Buffers[i].acquire_fence);\n>  \t}\n>  \n> -\t/* The request will be deleted in the completion handler. */\n> -\trequest.release();\n> +\t/* Queue the request on the CameraWorker. */\n> +\tworker_.queueRequest(descriptor->request.get());\n>  \n>  \treturn 0;\n>  }\n> @@ -1564,7 +1567,6 @@ void CameraDevice::requestComplete(Request *request)\n>  \tcallbacks_->process_capture_result(callbacks_, &captureResult);\n>  \n>  \tdelete descriptor;\n> -\tdelete request;\n>  }\n>  \n>  std::string CameraDevice::logPrefix() const\n> diff --git a/src/android/camera_device.h b/src/android/camera_device.h\n> index 777d1a35e801..86f2b8974b53 100644\n> --- a/src/android/camera_device.h\n> +++ b/src/android/camera_device.h\n> @@ -25,6 +25,7 @@\n>  #include \"libcamera/internal/message.h\"\n>  \n>  #include \"camera_stream.h\"\n> +#include \"camera_worker.h\"\n>  #include \"jpeg/encoder.h\"\n>  \n>  class CameraMetadata;\n> @@ -73,7 +74,8 @@ private:\n>  \tCameraDevice(unsigned int id, const std::shared_ptr<libcamera::Camera> &camera);\n>  \n>  \tstruct Camera3RequestDescriptor {\n> -\t\tCamera3RequestDescriptor(unsigned int frameNumber,\n> +\t\tCamera3RequestDescriptor(libcamera::Camera *camera,\n> +\t\t\t\t\t unsigned int frameNumber,\n>  \t\t\t\t\t unsigned int numBuffers);\n>  \t\t~Camera3RequestDescriptor();\n>  \n> @@ -81,6 +83,7 @@ private:\n>  \t\tuint32_t numBuffers;\n>  \t\tcamera3_stream_buffer_t *buffers;\n>  \t\tstd::vector<std::unique_ptr<libcamera::FrameBuffer>> frameBuffers;\n> +\t\tstd::unique_ptr<CaptureRequest> request;\n>  \t};\n>  \n>  \tstruct Camera3StreamConfiguration {\n> @@ -108,6 +111,8 @@ private:\n>  \tunsigned int id_;\n>  \tcamera3_device_t camera3Device_;\n>  \n> +\tCameraWorker worker_;\n> +\n>  \tbool running_;\n>  \tstd::shared_ptr<libcamera::Camera> camera_;\n>  \tstd::unique_ptr<libcamera::CameraConfiguration> config_;\n> -- \n> 2.28.0\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BCEDFBEEDF\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 14 Oct 2020 12:02:52 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 426B660E79;\n\tWed, 14 Oct 2020 14:02:52 +0200 (CEST)","from mail-lf1-x142.google.com (mail-lf1-x142.google.com\n\t[IPv6:2a00:1450:4864:20::142])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6EED660354\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 14 Oct 2020 14:02:51 +0200 (CEST)","by mail-lf1-x142.google.com with SMTP id j30so3406476lfp.4\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 14 Oct 2020 05:02:51 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\ty3sm1141367ljn.6.2020.10.14.05.02.49\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 14 Oct 2020 05:02:49 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"pDxLlMsD\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=UdbvyIE3XH2PPCLnyrRXzVDGX35kdWB0XFx7QpkWpNQ=;\n\tb=pDxLlMsDqSEtRB8oDUOKk7GJwvNRZOPpgc+4LquKwn+q95H7Rz3gymr6wtVhz5+t4P\n\t195g3diNzTZCs5YQQt/7brv+MjCF7GEoXI/8narDpBGkroJIjDIhBWwC36Q8aC6N6fRh\n\tBm6q550Bfq0hIW5nDJW8D2sLdfEWJnKV7J27ClAEY/buPZOuY2zA1/nrLOzV1f/HmJo5\n\tpXNZvvAysGlhhtp9/CAtv71eoYp6WPYDmupv+ZMkI3iuweXIxEds2Uk1ANCZtML4RSy4\n\tfYZxzfmtv8MdW/SnQR0D7/HSUmG7U48G+RaSCaVbapSPVYclWsj9ZHMsnx9ij8V0MLZT\n\tFC1w==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=UdbvyIE3XH2PPCLnyrRXzVDGX35kdWB0XFx7QpkWpNQ=;\n\tb=AZAXK5Q9WOe9cGdQLbNjRKwqYSU2j7wNxeVlJk46PXubp6zaxqqtmv1Q00kMN1rbsq\n\tJ/IxVhU6obukZ1vN0JJgqM5Y/yYOZQT0CchTFuBRUrDi0f3DAIO03dNpqwcz4iMS/Yx4\n\t6UvoQBDBNQI3HcCbCeH7itBxELGytu9vIYLNnn0k9QbmboIh1KllBVXW3GhbMddgVx2a\n\tCUKL26zIdlnVwnQhQoH5++VPUZl858j5sPerKvufAO5Fe/zVkn7eT1cp/OUSeJ2v41oP\n\tQKUBSwmCqrmQsH7lnUgMVtBGj2gH7pn/EcNmPk7NIfW0L5E7QQsbqQWWmRexOw/Bmorx\n\t+LaQ==","X-Gm-Message-State":"AOAM532CIBCmrXR9JoyOKU7YQUJNxeM9tERRcHB/lC5HG2iXr6aB55ZN\n\tjLu3Q0nCGT+s1NaHYodo2/p8Hg==","X-Google-Smtp-Source":"ABdhPJzbqs24iIeRb1ar60+MxpPi7Q3OJ1Nj6w8pBtnIrlzpZkf7ETWViAQNNmUXOOzDDyknMCk4yA==","X-Received":"by 2002:a19:4a0b:: with SMTP id\n\tx11mr1401089lfa.354.1602676970634; \n\tWed, 14 Oct 2020 05:02:50 -0700 (PDT)","Date":"Wed, 14 Oct 2020 14:02:48 +0200","From":"Niklas =?utf-8?q?S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>","To":"Jacopo Mondi <jacopo@jmondi.org>","Message-ID":"<20201014120248.i5ii2rfj7dst7cm3@oden.dyn.berto.se>","References":"<20201010095830.134084-1-jacopo@jmondi.org>\n\t<20201010095830.134084-3-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201010095830.134084-3-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH v2 2/3] android: camera_device: Queue\n\trequest using Worker","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]