[{"id":13134,"web_url":"https://patchwork.libcamera.org/comment/13134/","msgid":"<8fb63450-7e03-d064-00dc-c35da987a53e@ideasonboard.com>","date":"2020-10-09T12:46:03","subject":"Re: [libcamera-devel] [PATCH 08/10] android: camera_device: Handle\n\tNOISE_REDUCTION_MODES","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Jacopo,\n\nOn 09/10/2020 13:20, Jacopo Mondi wrote:\n> Register the ANDROID_NOISE_REDUCTION_AVAILABLE_NOISE_REDUCTION_MODES\n> static metadata property inspecting the values retuned by the pipeline\n> handler through the properties::draft::AvailableNoiseReductionModes\n> libcamera property.\n> \n> Reserve in the static metadata pack enough space to support all the 5\n> available noise reduction modes Android defines.\n> \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/android/camera_device.cpp | 17 +++++++++++++----\n> 1 file changed, 13 insertions(+), 4 deletions(-)\n> \n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index bccec358ea13..39d8218a67e5 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -538,7 +538,7 @@ std::tuple CameraDevice::calculateStaticMetadataSize()\n> \t * Currently: 51 entries, 687 bytes of static metadata\n> \t */\n> \tuint32_t numEntries = 51;\n> -\tuint32_t byteSize = 687;\n> +\tuint32_t byteSize = 691;\n> \n> \t/*\n> \t * Calculate space occupation in bytes for dynamically built metadata\n> @@ -815,9 +815,18 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n> \t\t\t\t &minFocusDistance, 1);\n> \n> \t/* Noise reduction modes. */\n> -\tuint8_t noiseReductionModes = ANDROID_NOISE_REDUCTION_MODE_OFF;\n> -\tstaticMetadata_->addEntry(ANDROID_NOISE_REDUCTION_AVAILABLE_NOISE_REDUCTION_MODES,\n> -\t\t\t\t &noiseReductionModes, 1);\n> +\tif (cameraProperties.contains(properties::draft::AvailableNoiseReductionModes)) {\n> +\t\tSpan pipelineNoiseReductionModes =\n> +\t\t\tcameraProperties.get>\n> +\t\t\t(properties::draft::AvailableNoiseReductionModes);\n> +\n> +\t\tstd::vector noiseReductionModes;\n> +\t\tfor (int32_t mode : pipelineNoiseReductionModes)\n> +\t\t\tnoiseReductionModes.push_back(mode);\n> +\t\tstaticMetadata_->addEntry(ANDROID_NOISE_REDUCTION_AVAILABLE_NOISE_REDUCTION_MODES,\n> +\t\t\t\t\t noiseReductionModes.data(),\n> +\t\t\t\t\t noiseReductionModes.size());\n> +\t}\n> \n> \t/* Scaler static metadata. */\n> \tfloat maxDigitalZoom = 1;\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9A806BEEE0\n\tfor ;\n\tFri, 9 Oct 2020 12:46:08 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 380AD60359;\n\tFri, 9 Oct 2020 14:46:08 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7E6A760358\n\tfor ;\n\tFri, 9 Oct 2020 14:46:06 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 057E7539;\n\tFri, 9 Oct 2020 14:46:05 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"WrDtR5ni\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1602247566;\n\tbh=nSrkgGEP+Zlf6godRPdpOAt4Gpi0FcqQxn0IJtFOmYY=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=WrDtR5ni2z4HXozS5IET5Q5sdM0XqIF3UKeMUUCn3eKfONvbK9fPDvmV7v/yQwFhK\n\tI4wIMX9lhnfxG5euGGhIIKJYHBZIAJbnVteoa4N49xzdS5o79bMg/MC1GYa1di3WqI\n\tT1MYjU2KacWBdlXzP/xjCRBuz7mFZK3ptBbrpr9o=","To":"Jacopo Mondi , libcamera-devel@lists.libcamera.org","References":"<20201009122101.73858-1-jacopo@jmondi.org>\n\t<20201009122101.73858-9-jacopo@jmondi.org>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<8fb63450-7e03-d064-00dc-c35da987a53e@ideasonboard.com>","Date":"Fri, 9 Oct 2020 13:46:03 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20201009122101.73858-9-jacopo@jmondi.org>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH 08/10] android: camera_device: Handle\n\tNOISE_REDUCTION_MODES","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13136,"web_url":"https://patchwork.libcamera.org/comment/13136/","msgid":"<8c305a97-16d9-97f5-dddb-974396cda2fc@ideasonboard.com>","date":"2020-10-09T12:48:02","subject":"Re: [libcamera-devel] [PATCH 08/10] android: camera_device: Handle\n\tNOISE_REDUCTION_MODES","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Jacopo,\n\nOn 09/10/2020 13:20, Jacopo Mondi wrote:\n> Register the ANDROID_NOISE_REDUCTION_AVAILABLE_NOISE_REDUCTION_MODES\n> static metadata property inspecting the values retuned by the pipeline\n> handler through the properties::draft::AvailableNoiseReductionModes\n> libcamera property.\n> \n> Reserve in the static metadata pack enough space to support all the 5\n> available noise reduction modes Android defines.\n> \n> Signed-off-by: Jacopo Mondi \n> ---\n> src/android/camera_device.cpp | 17 +++++++++++++----\n> 1 file changed, 13 insertions(+), 4 deletions(-)\n> \n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index bccec358ea13..39d8218a67e5 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -538,7 +538,7 @@ std::tuple CameraDevice::calculateStaticMetadataSize()\n> \t * Currently: 51 entries, 687 bytes of static metadata\n> \t */\n> \tuint32_t numEntries = 51;\n> -\tuint32_t byteSize = 687;\n> +\tuint32_t byteSize = 691;\n\n'5 available noise modes' ... 687 + 5 = 692?\n\n> \n> \t/*\n> \t * Calculate space occupation in bytes for dynamically built metadata\n> @@ -815,9 +815,18 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n> \t\t\t\t &minFocusDistance, 1);\n> \n> \t/* Noise reduction modes. */\n> -\tuint8_t noiseReductionModes = ANDROID_NOISE_REDUCTION_MODE_OFF;\n> -\tstaticMetadata_->addEntry(ANDROID_NOISE_REDUCTION_AVAILABLE_NOISE_REDUCTION_MODES,\n> -\t\t\t\t &noiseReductionModes, 1);\n> +\tif (cameraProperties.contains(properties::draft::AvailableNoiseReductionModes)) {\n> +\t\tSpan pipelineNoiseReductionModes =\n> +\t\t\tcameraProperties.get>\n> +\t\t\t(properties::draft::AvailableNoiseReductionModes);\n> +\n> +\t\tstd::vector noiseReductionModes;\n> +\t\tfor (int32_t mode : pipelineNoiseReductionModes)\n> +\t\t\tnoiseReductionModes.push_back(mode);\n> +\t\tstaticMetadata_->addEntry(ANDROID_NOISE_REDUCTION_AVAILABLE_NOISE_REDUCTION_MODES,\n> +\t\t\t\t\t noiseReductionModes.data(),\n> +\t\t\t\t\t noiseReductionModes.size());\n> +\t}\n> \n> \t/* Scaler static metadata. */\n> \tfloat maxDigitalZoom = 1;\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 09F7EBEEDF\n\tfor ;\n\tFri, 9 Oct 2020 12:48:08 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CBAFD60359;\n\tFri, 9 Oct 2020 14:48:07 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id ED66760358\n\tfor ;\n\tFri, 9 Oct 2020 14:48:05 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 813B9539;\n\tFri, 9 Oct 2020 14:48:05 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"BBFzKkbD\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1602247685;\n\tbh=zIme04JgxkV4CdxPX3aNXh6OCclq8PQPBvxFYucGyko=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=BBFzKkbDaIt9NtW1uT4J3b0xEec4loOTGikSbWTfwSuHU34TJ94+iVPckm6aGsVde\n\tOiXIxJEvRjGthkamH2gjk9iebgsbe8eUNExBUph81qHpgxyDcSc4kYWddp8Y7tKCuU\n\tzWZgFpNVI7AqmOiGBlf/Gi15rvjUGk9zu+v6Tfl8=","To":"Jacopo Mondi , libcamera-devel@lists.libcamera.org","References":"<20201009122101.73858-1-jacopo@jmondi.org>\n\t<20201009122101.73858-9-jacopo@jmondi.org>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<8c305a97-16d9-97f5-dddb-974396cda2fc@ideasonboard.com>","Date":"Fri, 9 Oct 2020 13:48:02 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20201009122101.73858-9-jacopo@jmondi.org>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH 08/10] android: camera_device: Handle\n\tNOISE_REDUCTION_MODES","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13138,"web_url":"https://patchwork.libcamera.org/comment/13138/","msgid":"<20201009125546.vuk3nhovfntu2lqv@uno.localdomain>","date":"2020-10-09T12:55:46","subject":"Re: [libcamera-devel] [PATCH 08/10] android: camera_device: Handle\n\tNOISE_REDUCTION_MODES","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Kieran,\n\nOn Fri, Oct 09, 2020 at 01:48:02PM +0100, Kieran Bingham wrote:\n> Hi Jacopo,\n>\n> On 09/10/2020 13:20, Jacopo Mondi wrote:\n> > Register the ANDROID_NOISE_REDUCTION_AVAILABLE_NOISE_REDUCTION_MODES\n> > static metadata property inspecting the values retuned by the pipeline\n> > handler through the properties::draft::AvailableNoiseReductionModes\n> > libcamera property.\n> >\n> > Reserve in the static metadata pack enough space to support all the 5\n> > available noise reduction modes Android defines.\n> >\n> > Signed-off-by: Jacopo Mondi \n> > ---\n> > src/android/camera_device.cpp | 17 +++++++++++++----\n> > 1 file changed, 13 insertions(+), 4 deletions(-)\n> >\n> > diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> > index bccec358ea13..39d8218a67e5 100644\n> > --- a/src/android/camera_device.cpp\n> > +++ b/src/android/camera_device.cpp\n> > @@ -538,7 +538,7 @@ std::tuple CameraDevice::calculateStaticMetadataSize()\n> > \t * Currently: 51 entries, 687 bytes of static metadata\n> > \t */\n> > \tuint32_t numEntries = 51;\n> > -\tuint32_t byteSize = 687;\n> > +\tuint32_t byteSize = 691;\n>\n> '5 available noise modes' ... 687 + 5 = 692?\n>\n\nOne was already reported :)\n\n> >\n> > \t/*\n> > \t * Calculate space occupation in bytes for dynamically built metadata\n> > @@ -815,9 +815,18 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n> > \t\t\t\t &minFocusDistance, 1);\n> >\n> > \t/* Noise reduction modes. */\n> > -\tuint8_t noiseReductionModes = ANDROID_NOISE_REDUCTION_MODE_OFF;\n> > -\tstaticMetadata_->addEntry(ANDROID_NOISE_REDUCTION_AVAILABLE_NOISE_REDUCTION_MODES,\n> > -\t\t\t\t &noiseReductionModes, 1);\n> > +\tif (cameraProperties.contains(properties::draft::AvailableNoiseReductionModes)) {\n> > +\t\tSpan pipelineNoiseReductionModes =\n> > +\t\t\tcameraProperties.get>\n> > +\t\t\t(properties::draft::AvailableNoiseReductionModes);\n> > +\n> > +\t\tstd::vector noiseReductionModes;\n> > +\t\tfor (int32_t mode : pipelineNoiseReductionModes)\n> > +\t\t\tnoiseReductionModes.push_back(mode);\n> > +\t\tstaticMetadata_->addEntry(ANDROID_NOISE_REDUCTION_AVAILABLE_NOISE_REDUCTION_MODES,\n> > +\t\t\t\t\t noiseReductionModes.data(),\n> > +\t\t\t\t\t noiseReductionModes.size());\n> > +\t}\n> >\n> > \t/* Scaler static metadata. */\n> > \tfloat maxDigitalZoom = 1;\n> >\n>\n> --\n> Regards\n> --\n> Kieran","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0EE56BEEDF\n\tfor ;\n\tFri, 9 Oct 2020 12:51:49 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E101A60359;\n\tFri, 9 Oct 2020 14:51:48 +0200 (CEST)","from relay12.mail.gandi.net (relay12.mail.gandi.net\n\t[217.70.178.232])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 575C060358\n\tfor ;\n\tFri, 9 Oct 2020 14:51:47 +0200 (CEST)","from uno.localdomain (93-34-118-233.ip49.fastwebnet.it\n\t[93.34.118.233]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay12.mail.gandi.net (Postfix) with ESMTPSA id DF15120000E;\n\tFri, 9 Oct 2020 12:51:46 +0000 (UTC)"],"Date":"Fri, 9 Oct 2020 14:55:46 +0200","From":"Jacopo Mondi ","To":"Kieran Bingham ","Message-ID":"<20201009125546.vuk3nhovfntu2lqv@uno.localdomain>","References":"<20201009122101.73858-1-jacopo@jmondi.org>\n\t<20201009122101.73858-9-jacopo@jmondi.org>\n\t<8c305a97-16d9-97f5-dddb-974396cda2fc@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<8c305a97-16d9-97f5-dddb-974396cda2fc@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 08/10] android: camera_device: Handle\n\tNOISE_REDUCTION_MODES","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13140,"web_url":"https://patchwork.libcamera.org/comment/13140/","msgid":"<77c0d75d-3aa2-aba8-088f-41bafdffb5ea@ideasonboard.com>","date":"2020-10-09T12:54:21","subject":"Re: [libcamera-devel] [PATCH 08/10] android: camera_device: Handle\n\tNOISE_REDUCTION_MODES","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"On 09/10/2020 13:55, Jacopo Mondi wrote:\n> Hi Kieran,\n> \n> On Fri, Oct 09, 2020 at 01:48:02PM +0100, Kieran Bingham wrote:\n>> Hi Jacopo,\n>>\n>> On 09/10/2020 13:20, Jacopo Mondi wrote:\n>>> Register the ANDROID_NOISE_REDUCTION_AVAILABLE_NOISE_REDUCTION_MODES\n>>> static metadata property inspecting the values retuned by the pipeline\n>>> handler through the properties::draft::AvailableNoiseReductionModes\n>>> libcamera property.\n>>>\n>>> Reserve in the static metadata pack enough space to support all the 5\n>>> available noise reduction modes Android defines.\n>>>\n>>> Signed-off-by: Jacopo Mondi \n>>> ---\n>>> src/android/camera_device.cpp | 17 +++++++++++++----\n>>> 1 file changed, 13 insertions(+), 4 deletions(-)\n>>>\n>>> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n>>> index bccec358ea13..39d8218a67e5 100644\n>>> --- a/src/android/camera_device.cpp\n>>> +++ b/src/android/camera_device.cpp\n>>> @@ -538,7 +538,7 @@ std::tuple CameraDevice::calculateStaticMetadataSize()\n>>> \t * Currently: 51 entries, 687 bytes of static metadata\n>>> \t */\n>>> \tuint32_t numEntries = 51;\n>>> -\tuint32_t byteSize = 687;\n>>> +\tuint32_t byteSize = 691;\n>>\n>> '5 available noise modes' ... 687 + 5 = 692?\n>>\n> \n> One was already reported :)\n\nAha ok - that's fine then.\n\nI really wish this wasn't manual ;-)\n\n--\nThanks\n\nKieran\n\n\n> \n>>>\n>>> \t/*\n>>> \t * Calculate space occupation in bytes for dynamically built metadata\n>>> @@ -815,9 +815,18 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n>>> \t\t\t\t &minFocusDistance, 1);\n>>>\n>>> \t/* Noise reduction modes. */\n>>> -\tuint8_t noiseReductionModes = ANDROID_NOISE_REDUCTION_MODE_OFF;\n>>> -\tstaticMetadata_->addEntry(ANDROID_NOISE_REDUCTION_AVAILABLE_NOISE_REDUCTION_MODES,\n>>> -\t\t\t\t &noiseReductionModes, 1);\n>>> +\tif (cameraProperties.contains(properties::draft::AvailableNoiseReductionModes)) {\n>>> +\t\tSpan pipelineNoiseReductionModes =\n>>> +\t\t\tcameraProperties.get>\n>>> +\t\t\t(properties::draft::AvailableNoiseReductionModes);\n>>> +\n>>> +\t\tstd::vector noiseReductionModes;\n>>> +\t\tfor (int32_t mode : pipelineNoiseReductionModes)\n>>> +\t\t\tnoiseReductionModes.push_back(mode);\n>>> +\t\tstaticMetadata_->addEntry(ANDROID_NOISE_REDUCTION_AVAILABLE_NOISE_REDUCTION_MODES,\n>>> +\t\t\t\t\t noiseReductionModes.data(),\n>>> +\t\t\t\t\t noiseReductionModes.size());\n>>> +\t}\n>>>\n>>> \t/* Scaler static metadata. */\n>>> \tfloat maxDigitalZoom = 1;\n>>>\n>>\n>> --\n>> Regards\n>> --\n>> Kieran","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CC649BEEE0\n\tfor ;\n\tFri, 9 Oct 2020 12:54:25 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9A1CC60725;\n\tFri, 9 Oct 2020 14:54:25 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 444FA60358\n\tfor ;\n\tFri, 9 Oct 2020 14:54:24 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C259E539;\n\tFri, 9 Oct 2020 14:54:23 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"VOTEpB3m\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1602248064;\n\tbh=5g4QYWgGCIu2oZjGWaTcvJGWAuPjtmmvpWjAQ/prBDc=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=VOTEpB3mG7QZUvnhUsUp4MsTlWD7EkAv9rOB1F6cxaLyefgVUs9ptVcG181Yfq2hl\n\t+B5vWvZ8dlZSzsMP4V6rJOaPxaDcke2lNvP+uu/VNhnZ6fSDfpqDE6Pgm8/O/4whuh\n\tumHClNejIE0CgW74E5NQICMtroPG7ECJcMpvC/Os=","To":"Jacopo Mondi ","References":"<20201009122101.73858-1-jacopo@jmondi.org>\n\t<20201009122101.73858-9-jacopo@jmondi.org>\n\t<8c305a97-16d9-97f5-dddb-974396cda2fc@ideasonboard.com>\n\t<20201009125546.vuk3nhovfntu2lqv@uno.localdomain>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<77c0d75d-3aa2-aba8-088f-41bafdffb5ea@ideasonboard.com>","Date":"Fri, 9 Oct 2020 13:54:21 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20201009125546.vuk3nhovfntu2lqv@uno.localdomain>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH 08/10] android: camera_device: Handle\n\tNOISE_REDUCTION_MODES","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13143,"web_url":"https://patchwork.libcamera.org/comment/13143/","msgid":"<20201009132226.vgq4flbx2emhgxij@uno.localdomain>","date":"2020-10-09T13:22:26","subject":"Re: [libcamera-devel] [PATCH 08/10] android: camera_device: Handle\n\tNOISE_REDUCTION_MODES","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Kieran,\n\nOn Fri, Oct 09, 2020 at 01:54:21PM +0100, Kieran Bingham wrote:\n>\n>\n> On 09/10/2020 13:55, Jacopo Mondi wrote:\n> > Hi Kieran,\n> >\n> > On Fri, Oct 09, 2020 at 01:48:02PM +0100, Kieran Bingham wrote:\n> >> Hi Jacopo,\n> >>\n> >> On 09/10/2020 13:20, Jacopo Mondi wrote:\n> >>> Register the ANDROID_NOISE_REDUCTION_AVAILABLE_NOISE_REDUCTION_MODES\n> >>> static metadata property inspecting the values retuned by the pipeline\n> >>> handler through the properties::draft::AvailableNoiseReductionModes\n> >>> libcamera property.\n> >>>\n> >>> Reserve in the static metadata pack enough space to support all the 5\n> >>> available noise reduction modes Android defines.\n> >>>\n> >>> Signed-off-by: Jacopo Mondi \n> >>> ---\n> >>> src/android/camera_device.cpp | 17 +++++++++++++----\n> >>> 1 file changed, 13 insertions(+), 4 deletions(-)\n> >>>\n> >>> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> >>> index bccec358ea13..39d8218a67e5 100644\n> >>> --- a/src/android/camera_device.cpp\n> >>> +++ b/src/android/camera_device.cpp\n> >>> @@ -538,7 +538,7 @@ std::tuple CameraDevice::calculateStaticMetadataSize()\n> >>> \t * Currently: 51 entries, 687 bytes of static metadata\n> >>> \t */\n> >>> \tuint32_t numEntries = 51;\n> >>> -\tuint32_t byteSize = 687;\n> >>> +\tuint32_t byteSize = 691;\n> >>\n> >> '5 available noise modes' ... 687 + 5 = 692?\n> >>\n> >\n> > One was already reported :)\n>\n> Aha ok - that's fine then.\n>\n> I really wish this wasn't manual ;-)\n\nIt's awful I agree.\n\nConsidering this clarification, I think the values in\nPIPELINE_MAX_DEPTH, COLOR_CORRECTION_ABERRATION_MODE, NOISE_REDUCTION_MODES\nare correct. LENS_SHADING_MAP_MODES is not, as it's brand new, so\nspace should be reserved not for 1, but for the 2 possible values it\nsupports.\n\n>\n> --\n> Thanks\n>\n> Kieran\n>\n>\n> >\n> >>>\n> >>> \t/*\n> >>> \t * Calculate space occupation in bytes for dynamically built metadata\n> >>> @@ -815,9 +815,18 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n> >>> \t\t\t\t &minFocusDistance, 1);\n> >>>\n> >>> \t/* Noise reduction modes. */\n> >>> -\tuint8_t noiseReductionModes = ANDROID_NOISE_REDUCTION_MODE_OFF;\n> >>> -\tstaticMetadata_->addEntry(ANDROID_NOISE_REDUCTION_AVAILABLE_NOISE_REDUCTION_MODES,\n> >>> -\t\t\t\t &noiseReductionModes, 1);\n> >>> +\tif (cameraProperties.contains(properties::draft::AvailableNoiseReductionModes)) {\n> >>> +\t\tSpan pipelineNoiseReductionModes =\n> >>> +\t\t\tcameraProperties.get>\n> >>> +\t\t\t(properties::draft::AvailableNoiseReductionModes);\n> >>> +\n> >>> +\t\tstd::vector noiseReductionModes;\n> >>> +\t\tfor (int32_t mode : pipelineNoiseReductionModes)\n> >>> +\t\t\tnoiseReductionModes.push_back(mode);\n> >>> +\t\tstaticMetadata_->addEntry(ANDROID_NOISE_REDUCTION_AVAILABLE_NOISE_REDUCTION_MODES,\n> >>> +\t\t\t\t\t noiseReductionModes.data(),\n> >>> +\t\t\t\t\t noiseReductionModes.size());\n> >>> +\t}\n> >>>\n> >>> \t/* Scaler static metadata. */\n> >>> \tfloat maxDigitalZoom = 1;\n> >>>\n> >>\n> >> --\n> >> Regards\n> >> --\n> >> Kieran\n>\n> --\n> Regards\n> --\n> Kieran","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7D37CBEEE0\n\tfor ;\n\tFri, 9 Oct 2020 13:18:28 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5822460725;\n\tFri, 9 Oct 2020 15:18:28 +0200 (CEST)","from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net\n\t[217.70.183.194])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B782060358\n\tfor ;\n\tFri, 9 Oct 2020 15:18:27 +0200 (CEST)","from uno.localdomain (93-34-118-233.ip49.fastwebnet.it\n\t[93.34.118.233]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 526EE40007;\n\tFri, 9 Oct 2020 13:18:27 +0000 (UTC)"],"X-Originating-IP":"93.34.118.233","Date":"Fri, 9 Oct 2020 15:22:26 +0200","From":"Jacopo Mondi ","To":"Kieran Bingham ","Message-ID":"<20201009132226.vgq4flbx2emhgxij@uno.localdomain>","References":"<20201009122101.73858-1-jacopo@jmondi.org>\n\t<20201009122101.73858-9-jacopo@jmondi.org>\n\t<8c305a97-16d9-97f5-dddb-974396cda2fc@ideasonboard.com>\n\t<20201009125546.vuk3nhovfntu2lqv@uno.localdomain>\n\t<77c0d75d-3aa2-aba8-088f-41bafdffb5ea@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<77c0d75d-3aa2-aba8-088f-41bafdffb5ea@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 08/10] android: camera_device: Handle\n\tNOISE_REDUCTION_MODES","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]