{"id":10035,"url":"https://patchwork.libcamera.org/api/patches/10035/?format=json","web_url":"https://patchwork.libcamera.org/patch/10035/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20201009122101.73858-9-jacopo@jmondi.org>","date":"2020-10-09T12:20:59","name":"[libcamera-devel,08/10] android: camera_device: Handle NOISE_REDUCTION_MODES","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"49a1528fa5270361a5b0b0c6d5d2573d184f9a19","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/10035/mbox/","series":[{"id":1370,"url":"https://patchwork.libcamera.org/api/series/1370/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1370","date":"2020-10-09T12:20:51","name":"android: Introduce draft controls","version":1,"mbox":"https://patchwork.libcamera.org/series/1370/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/10035/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/10035/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 361B0BEEE1\n\tfor ;\n\tFri, 9 Oct 2020 12:17:17 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AAE9C60BD2;\n\tFri, 9 Oct 2020 14:17:15 +0200 (CEST)","from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net\n\t[217.70.183.198])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9518F60725\n\tfor ;\n\tFri, 9 Oct 2020 14:17:13 +0200 (CEST)","from uno.lan (93-34-118-233.ip49.fastwebnet.it [93.34.118.233])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 2CF1BC0007;\n\tFri, 9 Oct 2020 12:17:13 +0000 (UTC)"],"X-Originating-IP":"93.34.118.233","From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 9 Oct 2020 14:20:59 +0200","Message-Id":"<20201009122101.73858-9-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.28.0","In-Reply-To":"<20201009122101.73858-1-jacopo@jmondi.org>","References":"<20201009122101.73858-1-jacopo@jmondi.org>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH 08/10] android: camera_device: Handle\n\tNOISE_REDUCTION_MODES","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Register the ANDROID_NOISE_REDUCTION_AVAILABLE_NOISE_REDUCTION_MODES\nstatic metadata property inspecting the values retuned by the pipeline\nhandler through the properties::draft::AvailableNoiseReductionModes\nlibcamera property.\n\nReserve in the static metadata pack enough space to support all the 5\navailable noise reduction modes Android defines.\n\nSigned-off-by: Jacopo Mondi \n---\n src/android/camera_device.cpp | 17 +++++++++++++----\n 1 file changed, 13 insertions(+), 4 deletions(-)","diff":"diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex bccec358ea13..39d8218a67e5 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -538,7 +538,7 @@ std::tuple CameraDevice::calculateStaticMetadataSize()\n \t * Currently: 51 entries, 687 bytes of static metadata\n \t */\n \tuint32_t numEntries = 51;\n-\tuint32_t byteSize = 687;\n+\tuint32_t byteSize = 691;\n \n \t/*\n \t * Calculate space occupation in bytes for dynamically built metadata\n@@ -815,9 +815,18 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n \t\t\t\t &minFocusDistance, 1);\n \n \t/* Noise reduction modes. */\n-\tuint8_t noiseReductionModes = ANDROID_NOISE_REDUCTION_MODE_OFF;\n-\tstaticMetadata_->addEntry(ANDROID_NOISE_REDUCTION_AVAILABLE_NOISE_REDUCTION_MODES,\n-\t\t\t\t &noiseReductionModes, 1);\n+\tif (cameraProperties.contains(properties::draft::AvailableNoiseReductionModes)) {\n+\t\tSpan pipelineNoiseReductionModes =\n+\t\t\tcameraProperties.get>\n+\t\t\t(properties::draft::AvailableNoiseReductionModes);\n+\n+\t\tstd::vector noiseReductionModes;\n+\t\tfor (int32_t mode : pipelineNoiseReductionModes)\n+\t\t\tnoiseReductionModes.push_back(mode);\n+\t\tstaticMetadata_->addEntry(ANDROID_NOISE_REDUCTION_AVAILABLE_NOISE_REDUCTION_MODES,\n+\t\t\t\t\t noiseReductionModes.data(),\n+\t\t\t\t\t noiseReductionModes.size());\n+\t}\n \n \t/* Scaler static metadata. */\n \tfloat maxDigitalZoom = 1;\n","prefixes":["libcamera-devel","08/10"]}