[{"id":13128,"web_url":"https://patchwork.libcamera.org/comment/13128/","msgid":"<9a1962fc-2b1e-3fac-d48b-2091dc0c00b3@ideasonboard.com>","date":"2020-10-09T12:31:53","subject":"Re: [libcamera-devel] [PATCH 05/10] libcamera: ipu3: Register\n\tpipeline properties","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Jacopo,\n\nOn 09/10/2020 13:20, Jacopo Mondi wrote:\n> Register three pipeline properties in the IPU3 pipeline handler:\n> - properties::draft::PipelineMaxDepth\n> - properties::draft::AvailableNoiseReductionModes\n> - properties::draft::AvailableColorCorrectionAberrationModes\n> - properties::draft::AvailableLensShadingMapModes\n> \n> IPU3 reports a maximum of 3 processing stages: exposure, capture and\n> ISP processing. It does not support noise reduction, color\n> aberration and lens shading map modes.\n> \n> Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>\n> ---\n>  src/libcamera/pipeline/ipu3/ipu3.cpp | 8 ++++++++\n>  1 file changed, 8 insertions(+)\n> \n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index f5a20d30fd03..f7ade2a6d5f3 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -13,6 +13,7 @@\n>  \n>  #include <libcamera/camera.h>\n>  #include <libcamera/formats.h>\n> +#include <libcamera/property_ids.h>\n>  #include <libcamera/request.h>\n>  #include <libcamera/stream.h>\n>  \n> @@ -770,6 +771,13 @@ int PipelineHandlerIPU3::registerCameras()\n>  \n>  \t\t/* Initialize the camera properties. */\n>  \t\tdata->properties_ = cio2->sensor()->properties();\n> +\t\tdata->properties_.set(properties::draft::PipelineMaxDepth, 3);\n\nYou've detailed in the commit message that the 3 stages are Exposure\nCapture and ISP processing.\n\nIt might be nice to add a comment above the PipelineMaxDepth entry here,\nto state that (to explain why 3 is set here), and to make it clear\nwhy/when/what is updated in the future.\n\nBut otherwise, or anyway,\n\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\n> +\t\tdata->properties_.set(properties::draft::AvailableNoiseReductionModes,\n> +\t\t\t\t      { static_cast<int32_t>(properties::draft::NoiseReductionModeOff) });\n> +\t\tdata->properties_.set(properties::draft::AvailableColorCorrectionAberrationModes,\n> +\t\t\t\t      { static_cast<int32_t>(properties::draft::ColorCorrectionAberrationOff) });\n> +\t\tdata->properties_.set(properties::draft::AvailableLensShadingMapModes,\n> +\t\t\t\t      { static_cast<int32_t>(properties::draft::LensShadingMapModeOff) });\n>  \n>  \t\t/**\n>  \t\t * \\todo Dynamically assign ImgU and output devices to each\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 937D4BEEDF\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri,  9 Oct 2020 12:31:58 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2CF8560359;\n\tFri,  9 Oct 2020 14:31:58 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 93CE260358\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri,  9 Oct 2020 14:31:56 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EF984539;\n\tFri,  9 Oct 2020 14:31:55 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"SpSX5z31\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1602246716;\n\tbh=WQe1D9S8aZ6+0OX14G04lJXdvxzfqM+xEBNToXOGBGs=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=SpSX5z31ZtWiVluShwkcOeoKJd/BPmZJ9OC0I0fAT16fBMTAIzJOXkUO97BlFcZpB\n\tur6K4tF7blJPfH1jc5sNKBVBXpOEVCn0ZbhazW66WssSuipbwrX7nweNxTIGdXyun6\n\tz4W2X3hnnvdMT4vM43qEZyWgFxopPGN3Ow6AWhLw=","To":"Jacopo Mondi <jacopo@jmondi.org>, libcamera-devel@lists.libcamera.org","References":"<20201009122101.73858-1-jacopo@jmondi.org>\n\t<20201009122101.73858-6-jacopo@jmondi.org>","From":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<9a1962fc-2b1e-3fac-d48b-2091dc0c00b3@ideasonboard.com>","Date":"Fri, 9 Oct 2020 13:31:53 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20201009122101.73858-6-jacopo@jmondi.org>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH 05/10] libcamera: ipu3: Register\n\tpipeline properties","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":13172,"web_url":"https://patchwork.libcamera.org/comment/13172/","msgid":"<20201012010510.GO3944@pendragon.ideasonboard.com>","date":"2020-10-12T01:05:10","subject":"Re: [libcamera-devel] [PATCH 05/10] libcamera: ipu3: Register\n\tpipeline properties","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Fri, Oct 09, 2020 at 02:20:56PM +0200, Jacopo Mondi wrote:\n> Register three pipeline properties in the IPU3 pipeline handler:\n> - properties::draft::PipelineMaxDepth\n> - properties::draft::AvailableNoiseReductionModes\n> - properties::draft::AvailableColorCorrectionAberrationModes\n> - properties::draft::AvailableLensShadingMapModes\n> \n> IPU3 reports a maximum of 3 processing stages: exposure, capture and\n> ISP processing. It does not support noise reduction, color\n> aberration and lens shading map modes.\n> \n> Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>\n> ---\n>  src/libcamera/pipeline/ipu3/ipu3.cpp | 8 ++++++++\n>  1 file changed, 8 insertions(+)\n> \n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index f5a20d30fd03..f7ade2a6d5f3 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -13,6 +13,7 @@\n>  \n>  #include <libcamera/camera.h>\n>  #include <libcamera/formats.h>\n> +#include <libcamera/property_ids.h>\n>  #include <libcamera/request.h>\n>  #include <libcamera/stream.h>\n>  \n> @@ -770,6 +771,13 @@ int PipelineHandlerIPU3::registerCameras()\n>  \n>  \t\t/* Initialize the camera properties. */\n>  \t\tdata->properties_ = cio2->sensor()->properties();\n> +\t\tdata->properties_.set(properties::draft::PipelineMaxDepth, 3);\n> +\t\tdata->properties_.set(properties::draft::AvailableNoiseReductionModes,\n> +\t\t\t\t      { static_cast<int32_t>(properties::draft::NoiseReductionModeOff) });\n> +\t\tdata->properties_.set(properties::draft::AvailableColorCorrectionAberrationModes,\n> +\t\t\t\t      { static_cast<int32_t>(properties::draft::ColorCorrectionAberrationOff) });\n> +\t\tdata->properties_.set(properties::draft::AvailableLensShadingMapModes,\n> +\t\t\t\t      { static_cast<int32_t>(properties::draft::LensShadingMapModeOff) });\n\nWhen the only supported mode is off, how about not declaring the\nproperty in the pipeline handler ? Otherwise that will be lots of\nboilerplate code in pipeline handlers.\n\n>  \n>  \t\t/**\n>  \t\t * \\todo Dynamically assign ImgU and output devices to each","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1BC61BEEDF\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 12 Oct 2020 01:05:57 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DE92160CE0;\n\tMon, 12 Oct 2020 03:05:56 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9D3FF60CE0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 12 Oct 2020 03:05:55 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 380EB308;\n\tMon, 12 Oct 2020 03:05:55 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"cTB1cYuu\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1602464755;\n\tbh=Zv0Y/4jumUnVTdanbW2Ba8CvDWkhwbgBeY0xzwSczgU=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=cTB1cYuuGk58SvmGduF9SWhRydd6J8igg+6bARaEdYsRn6hrp2s9ZK/V12qiEeoJP\n\tp78ru8W5TCi4iuMSE8sPZ+dm0e9xaVLxssmTap2tJb2m6/GyewTCumP12KjXft67KC\n\t9Ks3q6k5xQFFqXU62D1wv3i8Xh1qjKF7pYrvHc7s=","Date":"Mon, 12 Oct 2020 04:05:10 +0300","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"Jacopo Mondi <jacopo@jmondi.org>","Message-ID":"<20201012010510.GO3944@pendragon.ideasonboard.com>","References":"<20201009122101.73858-1-jacopo@jmondi.org>\n\t<20201009122101.73858-6-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201009122101.73858-6-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH 05/10] libcamera: ipu3: Register\n\tpipeline properties","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":13190,"web_url":"https://patchwork.libcamera.org/comment/13190/","msgid":"<20201013205810.zdhcdjoo42y6dhvo@uno.localdomain>","date":"2020-10-13T20:58:10","subject":"Re: [libcamera-devel] [PATCH 05/10] libcamera: ipu3: Register\n\tpipeline properties","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent,\n\nOn Mon, Oct 12, 2020 at 04:05:10AM +0300, Laurent Pinchart wrote:\n> Hi Jacopo,\n>\n> Thank you for the patch.\n>\n> On Fri, Oct 09, 2020 at 02:20:56PM +0200, Jacopo Mondi wrote:\n> > Register three pipeline properties in the IPU3 pipeline handler:\n> > - properties::draft::PipelineMaxDepth\n> > - properties::draft::AvailableNoiseReductionModes\n> > - properties::draft::AvailableColorCorrectionAberrationModes\n> > - properties::draft::AvailableLensShadingMapModes\n> >\n> > IPU3 reports a maximum of 3 processing stages: exposure, capture and\n> > ISP processing. It does not support noise reduction, color\n> > aberration and lens shading map modes.\n> >\n> > Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>\n> > ---\n> >  src/libcamera/pipeline/ipu3/ipu3.cpp | 8 ++++++++\n> >  1 file changed, 8 insertions(+)\n> >\n> > diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> > index f5a20d30fd03..f7ade2a6d5f3 100644\n> > --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> > +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> > @@ -13,6 +13,7 @@\n> >\n> >  #include <libcamera/camera.h>\n> >  #include <libcamera/formats.h>\n> > +#include <libcamera/property_ids.h>\n> >  #include <libcamera/request.h>\n> >  #include <libcamera/stream.h>\n> >\n> > @@ -770,6 +771,13 @@ int PipelineHandlerIPU3::registerCameras()\n> >\n> >  \t\t/* Initialize the camera properties. */\n> >  \t\tdata->properties_ = cio2->sensor()->properties();\n> > +\t\tdata->properties_.set(properties::draft::PipelineMaxDepth, 3);\n> > +\t\tdata->properties_.set(properties::draft::AvailableNoiseReductionModes,\n> > +\t\t\t\t      { static_cast<int32_t>(properties::draft::NoiseReductionModeOff) });\n> > +\t\tdata->properties_.set(properties::draft::AvailableColorCorrectionAberrationModes,\n> > +\t\t\t\t      { static_cast<int32_t>(properties::draft::ColorCorrectionAberrationOff) });\n> > +\t\tdata->properties_.set(properties::draft::AvailableLensShadingMapModes,\n> > +\t\t\t\t      { static_cast<int32_t>(properties::draft::LensShadingMapModeOff) });\n>\n> When the only supported mode is off, how about not declaring the\n> property in the pipeline handler ? Otherwise that will be lots of\n> boilerplate code in pipeline handlers.\n>\n\nYes, I think for now it's a good idea and will save quite some\nboilerplate code in pipeline handlers.\n\n> >\n> >  \t\t/**\n> >  \t\t * \\todo Dynamically assign ImgU and output devices to each\n>\n> --\n> Regards,\n>\n> Laurent Pinchart","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 94C33BEEE0\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 13 Oct 2020 20:54:11 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 71E9260DFD;\n\tTue, 13 Oct 2020 22:54:11 +0200 (CEST)","from relay10.mail.gandi.net (relay10.mail.gandi.net\n\t[217.70.178.230])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A056B60589\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 13 Oct 2020 22:54:10 +0200 (CEST)","from uno.localdomain (2-224-242-101.ip172.fastwebnet.it\n\t[2.224.242.101]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay10.mail.gandi.net (Postfix) with ESMTPSA id 24915240005;\n\tTue, 13 Oct 2020 20:54:09 +0000 (UTC)"],"Date":"Tue, 13 Oct 2020 22:58:10 +0200","From":"Jacopo Mondi <jacopo@jmondi.org>","To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","Message-ID":"<20201013205810.zdhcdjoo42y6dhvo@uno.localdomain>","References":"<20201009122101.73858-1-jacopo@jmondi.org>\n\t<20201009122101.73858-6-jacopo@jmondi.org>\n\t<20201012010510.GO3944@pendragon.ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201012010510.GO3944@pendragon.ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 05/10] libcamera: ipu3: Register\n\tpipeline properties","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]