[{"id":13127,"web_url":"https://patchwork.libcamera.org/comment/13127/","msgid":"<1f731606-aca8-a812-f283-4b4c29ec0999@ideasonboard.com>","date":"2020-10-09T12:29:51","subject":"Re: [libcamera-devel] [PATCH 04/10] libcamera: control_ids: Define\n\tdraft controls","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Jacopo,\n\nOn 09/10/2020 13:20, Jacopo Mondi wrote:\n> Libcamera is in the process of defining its own set of controls\n> to enable applications to control the image capture process and\n> return information on the captured frames.\n> \n> To temporary close the gap in the Android camera HAL and support all\n\ns/temporary/temporarily/\n\n> controls required in the LIMITED hw level, define a set of Draft\n> controls whose values are taken from their Android definition, in order\n> to allow pipeline handlers to support Android.\n> \n> Signed-off-by: Jacopo Mondi \n> ---\n> src/libcamera/control_ids.yaml | 266 +++++++++++++++++++++++++++++++++\n> 1 file changed, 266 insertions(+)\n> \n> diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml\n> index 4c415545dcae..62724b218380 100644\n> --- a/src/libcamera/control_ids.yaml\n> +++ b/src/libcamera/control_ids.yaml\n> @@ -284,4 +284,270 @@ controls:\n> order in an array of 9 floating point values.\n> \n> size: [3x3]\n> +\n> + - AePrecaptureTrigger:\n> + type: int32_t\n> + draft: true\n> + description: |\n> + Draft control for AE metering trigger. Currently identical to\n> + ANDROID_CONTROL_AE_PRECAPTURE_TRIGGER.\n> +\n> + Whether the camera device will trigger a precapture metering sequence\n> + when it processes this request.\n> + enum:\n> + - name: AePrecaptureTriggerIdle\n> + value: 0\n> + description: The trigger is idle.\n> + - name: AePrecaptureTriggerStart\n> + value: 1\n> + description: The pre-capture AE metering is started by the camera.\n> + - name: AePrecaptureTriggerCancel\n> + value: 2\n> + description: |\n> + The camera will cancel any active or completed metering sequence.\n> + The AE algorithm is reset to its initial state.\n> +\n> + - AfTrigger:\n> + type: int32_t\n> + draft: true\n> + description: |\n> + Draft control for AF trigger. Currently identical to\n> + ANDROID_CONTROL_AF_TRIGGER.\n> +\n> + Whether the camera device will trigger autofocus for this request.\n> + enum:\n> + - name: AfTriggerIdle\n> + value: 0\n> + description: The trigger is idle.\n> + - name: AfTriggerStart\n> + value: 1\n> + description: The AF routine is started by the camera.\n> + - name: AfTriggerCancel\n> + value: 2\n> + description: |\n> + The camera will cancel any active trigger and the AF routine is\n> + reset to its initial state.\n> +\n> + - NoiseReductionMode:\n> + type: int32_t\n> + draft: true\n> + description: |\n> + Draft control to select the noise reduction algorithm mode. Currently\n> + identical to ANDROID_NOISE_REDUCTION_MODE.\n> +\n> + Mode of operation for the noise reduction algorithm.\n> +\n> + \\sa properties::draft::AvailableNoiseReductionModes.\n\nOnly out of interest, does the \\sa need to be fully qualified like that\nfor things which are in the same scope?\n\nReviewed-by: Kieran Bingham \n\n> + enum:\n> + - name: NoiseReductionModeOff\n> + value: 0\n> + description: No noise reduction is applied\n> + - name: NoiseReductionModeFast\n> + value: 1\n> + description: |\n> + Noise reduction is applied without reducing the frame rate.\n> + - name: NoiseReductionModeHighQuality\n> + value: 2\n> + description: |\n> + High quality noise reduction at the expense of frame rate.\n> + - name: NoiseReductionModeMinimal\n> + value: 3\n> + description: |\n> + Minimal noise reduction is applied without reducing the frame rate.\n> + - name: NoiseReductionModeZSL\n> + value: 4\n> + description: |\n> + Noise reduction is applied at different levels to different streams.\n> +\n> + - ColorCorrectionAberrationMode:\n> + type: int32_t\n> + draft: true\n> + description: |\n> + Draft control to select the color correction aberration mode. Currently\n> + identical to ANDROID_COLOR_CORRECTION_ABERRATION_MODE.\n> +\n> + Mode of operation for the chromatic aberration correction algorithm.\n> +\n> + \\sa properties::draft::AvailableColorCorrectionAberrationModes.\n> + enum:\n> + - name: ColorCorrectionAberrationOff\n> + value: 0\n> + description: No aberration correction is applied.\n> + - name: ColorCorrectionAberrationFast\n> + value: 1\n> + description: Aberration correction will not slow down the frame rate.\n> + - name: ColorCorrectionAberrationHighQuality\n> + value: 2\n> + description: |\n> + High quality aberration correction which might reduce the frame\n> + rate.\n> +\n> + - AeState:\n> + type: int32_t\n> + draft: true\n> + description: |\n> + Draft control to report the current AE algorithm state. Currently\n> + identical to ANDROID_CONTROL_AE_STATE.\n> +\n> + Current state of the AE algorithm.\n> + enum:\n> + - name: AeStateInactive\n> + value: 0\n> + description: The AE algorithm is inactive.\n> + - name: AeStateSearching\n> + value: 1\n> + description: The AE algorithm has not converged yet.\n> + - name: AeStateConverged\n> + value: 2\n> + description: The AE algorithm has converged.\n> + - name: AeStateLocked\n> + value: 3\n> + description: The AE algorithm is locked.\n> + - name: AeStateFlashRequired\n> + value: 4\n> + description: The AE algorithm would need a flash for good results\n> + - name: AeStatePrecapture\n> + value: 5\n> + description: |\n> + The AE algorithm has started a pre-capture metering session.\n> + \\sa AePrecaptureTrigger\n> +\n> + - AfState:\n> + type: int32_t\n> + draft: true\n> + description: |\n> + Draft control to report the current AF algorithm state. Currently\n> + identical to ANDROID_CONTROL_AF_STATE.\n> +\n> + Current state of the AF algorithm.\n> + enum:\n> + - name: AfStateInactive\n> + value: 0\n> + description: The AF algorithm is inactive.\n> + - name: AfStatePassiveScan\n> + value: 1\n> + description: |\n> + AF is performing a passive scan of the scene in continuous\n> + auto-focus mode.\n> + - name: AfStatePassiveFocused\n> + value: 2\n> + description: |\n> + AF believes the scene is in focus, but might restart scanning.\n> + - name: AfStateActiveScan\n> + value: 3\n> + description: |\n> + AF is performing a scan triggered by an AF trigger request.\n> + \\sa AfTrigger\n> + - name: AfStateFocusedLock\n> + value: 4\n> + description: |\n> + AF believes has focused correctly and has locked focus.\n> + - name: AfStateNotFocusedLock\n> + value: 5\n> + description: |\n> + AF has not been able to focus and has locked.\n> + - name: AfStatePassiveUnfocused\n> + value: 6\n> + description: |\n> + AF has completed a passive scan without finding focus.\n> +\n> + - AwbState:\n> + type: int32_t\n> + draft: true\n> + description: |\n> + Draft control to report the current AWB algorithm state. Currently\n> + identical to ANDROID_CONTROL_AWB_STATE.\n> +\n> + Current state of the AWB algorithm.\n> + enum:\n> + - name: AwbStateInactive\n> + value: 0\n> + description: The AWB algorithm is inactive.\n> + - name: AwbStateSearching\n> + value: 1\n> + description: The AWB algorithm has not converged yet.\n> + - name: AwbConverged\n> + value: 2\n> + description: The AWB algorithm has converged.\n> + - name: AwbLocked\n> + value: 3\n> + description: The AWB algorithm is locked.\n> +\n> + - ScalerCropRegion:\n> + type: Rectangle\n> + draft: true\n> + description: |\n> + Draft control to report the region of the sensor that has been read-out.\n> + Currently identical to ANDROID_SCALER_CROP_REGION.\n> +\n> + The area of the sensor that has been read out, defined relatively to\n> + the active pixel array size.\n> +\n> + \\sa properties::PixelArrayActiveAreas\n> +\n> + - SensorTimestamp:\n> + type: int64_t\n> + draft: true\n> + description: |\n> + Draft control to report the start of exposure of the first row of the\n> + captured image. Currently identical to ANDROID_SENSOR_TIMESTAMP.\n> +\n> + - SensorRollingShutterSkew:\n> + type: int64_t\n> + draft: true\n> + description: |\n> + Draft control to report the time between the start of exposure of the\n> + first row and the start of exposure of the last row. Currently\n> + identical to ANDROID_SENSOR_ROLLING_SHUTTER_SKEW\n> +\n> + - LensShadingMapMode:\n> + type: int32_t\n> + draft: true\n> + description: |\n> + Draft control to report if the lens shading map is available. Currently\n> + identical to ANDROID_STATISTICS_LENS_SHADING_MAP_MODE.\n> +\n> + \\sa properties::draft::AvailableLensShadingMapModes.\n> + enum:\n> + - name: LensShadingMapModeOff\n> + value: 0\n> + description: No lens shading map mode is available.\n> + - name: LensShadingMapModeOn\n> + value: 1\n> + description: The lens shading map mode is available.\n> +\n> + - SceneFlicker:\n> + type: int32_t\n> + draft: true\n> + description: |\n> + Draft control to report the detected scene light frequency. Currently\n> + identical to ANDROID_STATISTICS_SCENE_FLICKER.\n> + enum:\n> + - name: SceneFickerOff\n> + value: 0\n> + description: No flickering detected.\n> + - name: SceneFicker50Hz\n> + value: 1\n> + description: 50Hz flickering detected.\n> + - name: SceneFicker60Hz\n> + value: 2\n> + description: 60Hz flickering detected.\n> +\n> + - PipelineDepth:\n> + type: int32_t\n> + draft: true\n> + description: |\n> + Specifies the number of pipeline stages the frame went through from when\n> + it was exposed to when the final completed result was available to the\n> + framework. Always less than or equal to PipelineMaxDepth. Currently\n> + identical to ANDROID_REQUEST_PIPELINE_DEPTH.\n> +\n> + The typical value for this control is 3 as a frame is first exposed,\n> + captured and then processed in a single pass through the ISP. Any\n> + additional processing step performed after the ISP pass (in example face\n> + detection, additional format conversions etc) count as an additional\n> + pipeline stage.\n> +\n> + \\sa properties::draft:PipelineMaxDepth\n> +\n> ...\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F3379BEEDF\n\tfor ;\n\tFri, 9 Oct 2020 12:29:55 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 813606073B;\n\tFri, 9 Oct 2020 14:29:55 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C168660358\n\tfor ;\n\tFri, 9 Oct 2020 14:29:54 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 11D30539;\n\tFri, 9 Oct 2020 14:29:54 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Mza8FALc\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1602246594;\n\tbh=1Qup9nlYNg3+8bufDMcmarnlPkGA/fHvSfjpOr48jqA=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=Mza8FALc5W03eS1SX2NROdw5PWUsp/BJRXQX7sffbL6S7RmZ6nTPGHpwZow4tkOhq\n\tG0xXvdFCFwyvT5Aj5Er7w71obMGMBTjnw/WT8pJOFW1frIiLpzEEtZRbDMDwxIzw/g\n\tf6ogeMyLVxiiZUg4BEy3MirUVV8DnAAzshe+3OQc=","To":"Jacopo Mondi , libcamera-devel@lists.libcamera.org","References":"<20201009122101.73858-1-jacopo@jmondi.org>\n\t<20201009122101.73858-5-jacopo@jmondi.org>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<1f731606-aca8-a812-f283-4b4c29ec0999@ideasonboard.com>","Date":"Fri, 9 Oct 2020 13:29:51 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20201009122101.73858-5-jacopo@jmondi.org>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH 04/10] libcamera: control_ids: Define\n\tdraft controls","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13170,"web_url":"https://patchwork.libcamera.org/comment/13170/","msgid":"<20201012010342.GN3944@pendragon.ideasonboard.com>","date":"2020-10-12T01:03:42","subject":"Re: [libcamera-devel] [PATCH 04/10] libcamera: control_ids: Define\n\tdraft controls","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Fri, Oct 09, 2020 at 01:29:51PM +0100, Kieran Bingham wrote:\n> On 09/10/2020 13:20, Jacopo Mondi wrote:\n> > Libcamera is in the process of defining its own set of controls\n\ns/Libcamera/libcamera/\n\n> > to enable applications to control the image capture process and\n> > return information on the captured frames.\n> > \n> > To temporary close the gap in the Android camera HAL and support all\n> \n> s/temporary/temporarily/\n> \n> > controls required in the LIMITED hw level, define a set of Draft\n\ns/hw/hardware/ ?\n\n> > controls whose values are taken from their Android definition, in order\n> > to allow pipeline handlers to support Android.\n> > \n> > Signed-off-by: Jacopo Mondi \n> > ---\n> > src/libcamera/control_ids.yaml | 266 +++++++++++++++++++++++++++++++++\n> > 1 file changed, 266 insertions(+)\n> > \n> > diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml\n> > index 4c415545dcae..62724b218380 100644\n> > --- a/src/libcamera/control_ids.yaml\n> > +++ b/src/libcamera/control_ids.yaml\n> > @@ -284,4 +284,270 @@ controls:\n> > order in an array of 9 floating point values.\n> > \n> > size: [3x3]\n> > +\n> > + - AePrecaptureTrigger:\n> > + type: int32_t\n> > + draft: true\n> > + description: |\n> > + Draft control for AE metering trigger. Currently identical to\n> > + ANDROID_CONTROL_AE_PRECAPTURE_TRIGGER.\n> > +\n> > + Whether the camera device will trigger a precapture metering sequence\n> > + when it processes this request.\n> > + enum:\n> > + - name: AePrecaptureTriggerIdle\n> > + value: 0\n> > + description: The trigger is idle.\n> > + - name: AePrecaptureTriggerStart\n> > + value: 1\n> > + description: The pre-capture AE metering is started by the camera.\n> > + - name: AePrecaptureTriggerCancel\n> > + value: 2\n> > + description: |\n> > + The camera will cancel any active or completed metering sequence.\n> > + The AE algorithm is reset to its initial state.\n> > +\n> > + - AfTrigger:\n> > + type: int32_t\n> > + draft: true\n> > + description: |\n> > + Draft control for AF trigger. Currently identical to\n> > + ANDROID_CONTROL_AF_TRIGGER.\n> > +\n> > + Whether the camera device will trigger autofocus for this request.\n> > + enum:\n> > + - name: AfTriggerIdle\n> > + value: 0\n> > + description: The trigger is idle.\n> > + - name: AfTriggerStart\n> > + value: 1\n> > + description: The AF routine is started by the camera.\n> > + - name: AfTriggerCancel\n> > + value: 2\n> > + description: |\n> > + The camera will cancel any active trigger and the AF routine is\n> > + reset to its initial state.\n> > +\n> > + - NoiseReductionMode:\n> > + type: int32_t\n> > + draft: true\n> > + description: |\n> > + Draft control to select the noise reduction algorithm mode. Currently\n> > + identical to ANDROID_NOISE_REDUCTION_MODE.\n> > +\n> > + Mode of operation for the noise reduction algorithm.\n> > +\n> > + \\sa properties::draft::AvailableNoiseReductionModes.\n\nI think you can drop the period at the end, for this and all other \\sa.\n\n> \n> Only out of interest, does the \\sa need to be fully qualified like that\n> for things which are in the same scope?\n\nNote that this is src/libcamera/control_ids.yaml, the namespace is\ncontrols::draft, not properties::draft.\n\n> Reviewed-by: Kieran Bingham \n> \n> > + enum:\n> > + - name: NoiseReductionModeOff\n> > + value: 0\n> > + description: No noise reduction is applied\n> > + - name: NoiseReductionModeFast\n> > + value: 1\n> > + description: |\n> > + Noise reduction is applied without reducing the frame rate.\n> > + - name: NoiseReductionModeHighQuality\n> > + value: 2\n> > + description: |\n> > + High quality noise reduction at the expense of frame rate.\n> > + - name: NoiseReductionModeMinimal\n> > + value: 3\n> > + description: |\n> > + Minimal noise reduction is applied without reducing the frame rate.\n> > + - name: NoiseReductionModeZSL\n> > + value: 4\n> > + description: |\n> > + Noise reduction is applied at different levels to different streams.\n> > +\n> > + - ColorCorrectionAberrationMode:\n> > + type: int32_t\n> > + draft: true\n> > + description: |\n> > + Draft control to select the color correction aberration mode. Currently\n> > + identical to ANDROID_COLOR_CORRECTION_ABERRATION_MODE.\n> > +\n> > + Mode of operation for the chromatic aberration correction algorithm.\n> > +\n> > + \\sa properties::draft::AvailableColorCorrectionAberrationModes.\n> > + enum:\n> > + - name: ColorCorrectionAberrationOff\n> > + value: 0\n> > + description: No aberration correction is applied.\n> > + - name: ColorCorrectionAberrationFast\n> > + value: 1\n> > + description: Aberration correction will not slow down the frame rate.\n> > + - name: ColorCorrectionAberrationHighQuality\n> > + value: 2\n> > + description: |\n> > + High quality aberration correction which might reduce the frame\n> > + rate.\n> > +\n> > + - AeState:\n> > + type: int32_t\n> > + draft: true\n> > + description: |\n> > + Draft control to report the current AE algorithm state. Currently\n> > + identical to ANDROID_CONTROL_AE_STATE.\n> > +\n> > + Current state of the AE algorithm.\n> > + enum:\n> > + - name: AeStateInactive\n> > + value: 0\n> > + description: The AE algorithm is inactive.\n> > + - name: AeStateSearching\n> > + value: 1\n> > + description: The AE algorithm has not converged yet.\n> > + - name: AeStateConverged\n> > + value: 2\n> > + description: The AE algorithm has converged.\n> > + - name: AeStateLocked\n> > + value: 3\n> > + description: The AE algorithm is locked.\n> > + - name: AeStateFlashRequired\n> > + value: 4\n> > + description: The AE algorithm would need a flash for good results\n> > + - name: AeStatePrecapture\n> > + value: 5\n> > + description: |\n> > + The AE algorithm has started a pre-capture metering session.\n> > + \\sa AePrecaptureTrigger\n> > +\n> > + - AfState:\n> > + type: int32_t\n> > + draft: true\n> > + description: |\n> > + Draft control to report the current AF algorithm state. Currently\n> > + identical to ANDROID_CONTROL_AF_STATE.\n> > +\n> > + Current state of the AF algorithm.\n> > + enum:\n> > + - name: AfStateInactive\n> > + value: 0\n> > + description: The AF algorithm is inactive.\n> > + - name: AfStatePassiveScan\n> > + value: 1\n> > + description: |\n> > + AF is performing a passive scan of the scene in continuous\n> > + auto-focus mode.\n> > + - name: AfStatePassiveFocused\n> > + value: 2\n> > + description: |\n> > + AF believes the scene is in focus, but might restart scanning.\n> > + - name: AfStateActiveScan\n> > + value: 3\n> > + description: |\n> > + AF is performing a scan triggered by an AF trigger request.\n> > + \\sa AfTrigger\n> > + - name: AfStateFocusedLock\n> > + value: 4\n> > + description: |\n> > + AF believes has focused correctly and has locked focus.\n> > + - name: AfStateNotFocusedLock\n> > + value: 5\n> > + description: |\n> > + AF has not been able to focus and has locked.\n> > + - name: AfStatePassiveUnfocused\n> > + value: 6\n> > + description: |\n> > + AF has completed a passive scan without finding focus.\n> > +\n> > + - AwbState:\n> > + type: int32_t\n> > + draft: true\n> > + description: |\n> > + Draft control to report the current AWB algorithm state. Currently\n> > + identical to ANDROID_CONTROL_AWB_STATE.\n> > +\n> > + Current state of the AWB algorithm.\n> > + enum:\n> > + - name: AwbStateInactive\n> > + value: 0\n> > + description: The AWB algorithm is inactive.\n> > + - name: AwbStateSearching\n> > + value: 1\n> > + description: The AWB algorithm has not converged yet.\n> > + - name: AwbConverged\n> > + value: 2\n> > + description: The AWB algorithm has converged.\n> > + - name: AwbLocked\n> > + value: 3\n> > + description: The AWB algorithm is locked.\n> > +\n> > + - ScalerCropRegion:\n> > + type: Rectangle\n> > + draft: true\n> > + description: |\n> > + Draft control to report the region of the sensor that has been read-out.\n> > + Currently identical to ANDROID_SCALER_CROP_REGION.\n> > +\n> > + The area of the sensor that has been read out, defined relatively to\n> > + the active pixel array size.\n> > +\n> > + \\sa properties::PixelArrayActiveAreas\n\nThis one will soon be replaced :-)\n\n> > +\n> > + - SensorTimestamp:\n> > + type: int64_t\n> > + draft: true\n> > + description: |\n> > + Draft control to report the start of exposure of the first row of the\n> > + captured image. Currently identical to ANDROID_SENSOR_TIMESTAMP.\n> > +\n> > + - SensorRollingShutterSkew:\n> > + type: int64_t\n> > + draft: true\n> > + description: |\n> > + Draft control to report the time between the start of exposure of the\n> > + first row and the start of exposure of the last row. Currently\n> > + identical to ANDROID_SENSOR_ROLLING_SHUTTER_SKEW\n> > +\n> > + - LensShadingMapMode:\n> > + type: int32_t\n> > + draft: true\n> > + description: |\n> > + Draft control to report if the lens shading map is available. Currently\n> > + identical to ANDROID_STATISTICS_LENS_SHADING_MAP_MODE.\n> > +\n> > + \\sa properties::draft::AvailableLensShadingMapModes.\n> > + enum:\n> > + - name: LensShadingMapModeOff\n> > + value: 0\n> > + description: No lens shading map mode is available.\n> > + - name: LensShadingMapModeOn\n> > + value: 1\n> > + description: The lens shading map mode is available.\n> > +\n> > + - SceneFlicker:\n> > + type: int32_t\n> > + draft: true\n> > + description: |\n> > + Draft control to report the detected scene light frequency. Currently\n> > + identical to ANDROID_STATISTICS_SCENE_FLICKER.\n> > + enum:\n> > + - name: SceneFickerOff\n> > + value: 0\n> > + description: No flickering detected.\n> > + - name: SceneFicker50Hz\n> > + value: 1\n> > + description: 50Hz flickering detected.\n> > + - name: SceneFicker60Hz\n> > + value: 2\n> > + description: 60Hz flickering detected.\n> > +\n> > + - PipelineDepth:\n> > + type: int32_t\n> > + draft: true\n> > + description: |\n> > + Specifies the number of pipeline stages the frame went through from when\n\nIf you want to keep the \"Draft control to ...\" elsewhere I would add it\nhere too.\n\n> > + it was exposed to when the final completed result was available to the\n> > + framework. Always less than or equal to PipelineMaxDepth. Currently\n> > + identical to ANDROID_REQUEST_PIPELINE_DEPTH.\n> > +\n> > + The typical value for this control is 3 as a frame is first exposed,\n> > + captured and then processed in a single pass through the ISP. Any\n> > + additional processing step performed after the ISP pass (in example face\n> > + detection, additional format conversions etc) count as an additional\n> > + pipeline stage.\n> > +\n> > + \\sa properties::draft:PipelineMaxDepth\n\ns/draft:/draft::/\n\nAcked-by: Laurent Pinchart \n\n> > +\n> > ...\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 988D7BEEDF\n\tfor ;\n\tMon, 12 Oct 2020 01:04:30 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2C04960CE0;\n\tMon, 12 Oct 2020 03:04:30 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0E79360CE0\n\tfor ;\n\tMon, 12 Oct 2020 03:04:28 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6993C308;\n\tMon, 12 Oct 2020 03:04:27 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"GGutWoVE\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1602464667;\n\tbh=CmCePoceTkNlmoq0VFoS6yNRYdEGioXZ6ZL/fwPNF34=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=GGutWoVEtUDy3M6wi3VLGFDCBVkUzlyXY5rmBZNM6Td99aNNdR2Msh9ZhJgVmJmgr\n\tINIZM6vI9e+da7I+kOChbpRLWwQYFNXpixC1kjv1/LxIHqbcYnwq4BEdHAJ+5cKP0s\n\tZxoiJHgNDeWm4Tz2rNK/OHdr0+FUY5G6Tsx7Q9Og=","Date":"Mon, 12 Oct 2020 04:03:42 +0300","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Message-ID":"<20201012010342.GN3944@pendragon.ideasonboard.com>","References":"<20201009122101.73858-1-jacopo@jmondi.org>\n\t<20201009122101.73858-5-jacopo@jmondi.org>\n\t<1f731606-aca8-a812-f283-4b4c29ec0999@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<1f731606-aca8-a812-f283-4b4c29ec0999@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 04/10] libcamera: control_ids: Define\n\tdraft controls","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]